From nobody Fri May 17 10:13:26 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmx.de ARC-Seal: i=1; a=rsa-sha256; t=1621973699; cv=none; d=zohomail.com; s=zohoarc; b=BtqQlUaxXgpWrYDM9aUD0aa6bA2Qap3bccmx6it49+E9cP1HlHkyKK6KbsuiYY4YtYoE0c9jVtXI2cJv8RCSqKKJdFRkI3ywir4U7YMQXa1SXQPvQx0eW8rULIOzb0gV2VwIJYIbFaoSCjjEVHTkZxTPEMUu91PqnH6uBIXbme0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1621973699; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=eSWX7Hz+pvtii7/m3VTN4XmQA6pjayuHDtYFQkgMxPQ=; b=YCoGh+8irwdMRQ2l4CtBmAxAOlzILjhcsjaUbfx6omdfatkt025HCFvMqSrOOBCfbdNTRiViuCAdXqXh0quDsslPD32TBe/raa5RvTomjw/9Y6IpyMgjMs9dvP9o+qaiHfEiqcLR+nsuS2cCXZCV12ZRnPl/ActcLVsA//igSxA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 162197369969836.159495857398156; Tue, 25 May 2021 13:14:59 -0700 (PDT) Received: from localhost ([::1]:59198 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lldS6-0004my-EA for importer@patchew.org; Tue, 25 May 2021 16:14:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44962) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lldQy-00045X-7P; Tue, 25 May 2021 16:13:48 -0400 Received: from mout.gmx.net ([212.227.17.21]:53621) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lldQw-0006u1-9s; Tue, 25 May 2021 16:13:48 -0400 Received: from ls3530 ([92.116.159.17]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1Mq2nK-1l8jxp2LQY-00n7nW; Tue, 25 May 2021 22:13:39 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1621973619; bh=X0olC0WIpdXqsDDFYUYxQTKfLLoGDFlIOCie2+d7qzY=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject; b=ZTV90boq2FyBjRBwiF6v/Y6xp2n9fZDAjRZaXzEv1CyGPNebPHy2/ipaqE4h99lRU /gfQ6060aifmaC1IHCHjjYE73oxiDKP9tRVqymMxEpltCXKw8+JZ0YBvmywKAUBjCw 12srJBdivvRl6f7bnaifOSDkSFwpJv7TH342SkbQ= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Date: Tue, 25 May 2021 22:12:45 +0200 From: Helge Deller To: Riku Voipio , Laurent Vivier , qemu-devel@nongnu.org Subject: [PATCH v2] hw/display/artist: Fix bug in coordinate extraction in artist_vram_read() and artist_vram_write() Message-ID: MIME-Version: 1.0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:kacsbEpZQOtrpvEN38OhG3pgvuer9y6jNg2NYxlPRirx7RQ8XjA tN0Rlxphze1U2vZookTmzKbnhH9N5vFngfkk4+48CJbDGyKmCTAzpmK8UNE4Mk+L6BJ9AaM S59+olXV5Sq1Eua8AUX3A+dsZ5Z+gNZGsoZcsAB4T46bw19tj7rVViqPn3EPGXF6nEBLmNu /U1oe+/qc06Q1b6/Y934A== X-UI-Out-Filterresults: notjunk:1;V03:K0:clu+oriFaD0=:XsS+fgK7PtxhaxHMyZF7SU ts3jKORWRHV4RzQdxxXSVBHM8cktX+mXd5nd8DvcjU7Me+Sm9wsTffT223tubdOkRvW4JTWN5 hXXMDt/vyMWjgQuR1CoysN+cEUVeXagEpMusvYxtu8Y2BJIIPfTJChnoQAtfjoArOCALYzMao Rj9i6IL+ZlRnl4RYfNcXeEIW4dmfWzv8TFGPWq97MWGpTEGGKYHpEZSLvo3xcfL6EhL/7xFlL m7MF6alAtVYw61Aa6lFwVJ3pfkwTpAwPJ/5eNmGp2nyH2/eOXnAHKy4jLj7cckeSPDIA6LRlc 7qz57lOS7ArtbLQrNZXWZRc9LH2b2gBxAgGrXU3UuHTMy1Ew0RsvGuWbzG0uwn664x9QA6KCF e+SMnYvvUC2WIOCCbp/xuWlxQALSfAghupVnTMgk370J8z1jMweGTwfq1/cAKXbWBP1ONnPH+ lbU+K2mbWVzO4dzcmQWlijjleea/4m+CezChvv8LZVkyNhSw+G71mVdlaUAhyaimbz3Wp/zE/ 4x0S1dVI3OUecO+N8CVwBE7QdF3EnUoub7w2DDJQHEKcAOsnVAxt6EF/5ecirCkOX1qWUU5lR JpClThoIm0p/Ebm8T/wSO4RA/k/t4XGcL4QafZda39ppaRFcZQdlm7JRMaPB2/lDjCdosSB4D JO76cMlm1Kxtvo3mYgzaAg03xmGLNwlzBmOsq7R+px329ZPlHd+vveKHjF5JmsauUmOLwuQ1v D+1P7Al1pzvDPSk1xGD+eClshKUTWyYG19gI0i9quOZec2CEpOuJ1LHWAWiswL/SgqzonELri EDUUu2pyDi/cy8pjfzinvnPc88Bz8++a+OgFKNMhAOc4HjqiObBqQVNtXONBtPKTXRl1TAEW0 xS3OCrLHq6WBi8pvqrA1mVbPWJo39dR9KsQA9nhNQpQEogqCQJO8mfj7jAwSKMq8a//MUK558 vrg4Y+bygbW1+Du/0HNhHpIh95SVp3JFVTaTIaEKGhBQ336YFnh5hSBAWbPtfnaS66+46efYY GOHVCAqrWop7bKTec3oaYvDKkcc6u8Sl7TXVXG4BWjwuxd7a3I7gnxUb0PNjsbJY9VsN2U2Qe HLY0CW4O4IVFrt1RE7FBXh4hN+otUl+/I8tgHnITvZ78ZDKbjv6JQxKAbJvqivBT/1OQgCegI Yjm9cf1VHrh049r9kRhNOCLvuS8BxeDBkexRTabRrm+PdhjqP2gY/nLPIgzjdpyuAqWXI= Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=212.227.17.21; envelope-from=deller@gmx.de; helo=mout.gmx.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sven Schnelle , Richard Henderson , Philippe =?iso-8859-15?Q?Mathieu-Daud=E9?= , qemu-stable@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" The CDE desktop on HP-UX 10 shows wrongly rendered pixels when the local sc= reen menu is closed. This bug was introduced by commit c7050f3f167b ("hw/display/artist: Refactor x/y coordination extraction") which converted= the coordinate extraction in artist_vram_read() and artist_vram_write() to use = the ADDR_TO_X and ADDR_TO_Y macros, but forgot to right-shift the address by 2 = as it was done before. Signed-off-by: Helge Deller Fixes: c7050f3f167b ("hw/display/artist: Refactor x/y coordination extracti= on") Cc: Philippe Mathieu-Daud=C3=A9 Cc: Richard Henderson Cc: Sven Schnelle Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- v2: Fix artist_vram_write() too, noticed by Philippe Mathieu-Daud=C3=A9 diff --git a/hw/display/artist.c b/hw/display/artist.c index ed0e637f25..8758c77bbf 100644 --- a/hw/display/artist.c +++ b/hw/display/artist.c @@ -1171,8 +1171,8 @@ static void artist_vram_write(void *opaque, hwaddr ad= dr, uint64_t val, } buf =3D vram_write_buffer(s); - posy =3D ADDR_TO_Y(addr); - posx =3D ADDR_TO_X(addr); + posy =3D ADDR_TO_Y(addr >> 2); + posx =3D ADDR_TO_X(addr >> 2); if (!buf->size) { return; @@ -1233,8 +1233,8 @@ static uint64_t artist_vram_read(void *opaque, hwaddr= addr, unsigned size) return 0; } - posy =3D ADDR_TO_Y(addr); - posx =3D ADDR_TO_X(addr); + posy =3D ADDR_TO_Y(addr >> 2); + posx =3D ADDR_TO_X(addr >> 2); if (posy > buf->height || posx > buf->width) { return 0;