From nobody Thu May 2 02:24:42 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1dmarc=pass fromdomain=outlook.com); dmarc=pass(p=none dis=none) header.from=outlook.com ARC-Seal: i=2; a=rsa-sha256; t=1599737621; cv=pass; d=zohomail.com; s=zohoarc; b=YdL776R7oxnNAW6ZzT/+dOKE5sDhAd9riKUBMsdAQSpCGrtxlB1kIIE9IqzCxud5a86lADDyBkWMJqMG1oMcu+wv6TlYAhACaG2P5gH6uIJ0I733RerwV0MegMEl3UQNtamV68C2bpLL1NhtcyJI9YGezM23OY5C7LN/0N6GGyM= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1599737621; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=VlKf6BG7Qzx4AT7bOHmMIV+IK0OOBh+ESj2ZF+qgnzw=; b=O9XVOT9baRU9Yq9Cd6V+8De79TwXNkrLqz2w4U15AMR3x9RwmM4h2eRDb8EedWRubAqJnq9VYCxZ9nDWYvCugMOgQVrWgOdxt/evr2q3xR03ZZG2u0RjmI83RFAx3rPeV/GAiExPGuPqQT7OmaPBMrPNcj9wEBd4P6g2MoIhm5Q= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1dmarc=pass fromdomain=outlook.com); dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1599737621453635.2584088204716; Thu, 10 Sep 2020 04:33:41 -0700 (PDT) Received: from localhost ([::1]:41402 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kGKpf-0007MC-UW for importer@patchew.org; Thu, 10 Sep 2020 07:33:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36330) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kGKov-0006Sb-Ip for qemu-devel@nongnu.org; Thu, 10 Sep 2020 07:32:53 -0400 Received: from mail-pu1apc01olkn0818.outbound.protection.outlook.com ([2a01:111:f400:febe::818]:11472 helo=APC01-PU1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kGKoo-0002TV-OJ for qemu-devel@nongnu.org; Thu, 10 Sep 2020 07:32:50 -0400 Received: from HK2APC01FT046.eop-APC01.prod.protection.outlook.com (2a01:111:e400:7ebc::48) by HK2APC01HT004.eop-APC01.prod.protection.outlook.com (2a01:111:e400:7ebc::104) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3370.16; Thu, 10 Sep 2020 11:17:13 +0000 Received: from SYBP282MB0012.AUSP282.PROD.OUTLOOK.COM (2a01:111:e400:7ebc::44) by HK2APC01FT046.mail.protection.outlook.com (2a01:111:e400:7ebc::436) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3370.16 via Frontend Transport; Thu, 10 Sep 2020 11:17:13 +0000 Received: from SYBP282MB0012.AUSP282.PROD.OUTLOOK.COM ([fe80::69c8:4a0a:9647:972f]) by SYBP282MB0012.AUSP282.PROD.OUTLOOK.COM ([fe80::69c8:4a0a:9647:972f%6]) with mapi id 15.20.3370.016; Thu, 10 Sep 2020 11:17:13 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e/jLdJzBK0nYJdDSKyIPFfxAPUSTHRBUAncR7aX9HJwbzoAwMpnM/Pax5BeXLdykx2be5taNqZbCK93o09J2qqPtxaWDliRSNINO6PWNb92U1inYZuyvXgOAjsPuObm12p+EHG2GR8E8+Ii+1PQVNwMShTdERa+ew1H5zrXmO90QCnH9ko3F9r7592cT/WxLslyGiOPWDLv1rNBw32VZGxL567x3dFdaoc48G7DUi4RcsNL9HKci/Ir3D5Iaipheh0YchkKCFoo/b566l//VxuN3tSNeAw/rWpiWGRdNGbdNGMxzRKOZWKXE8oKBN50siv1EhQS7Ixi6jCeuUDgKDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VlKf6BG7Qzx4AT7bOHmMIV+IK0OOBh+ESj2ZF+qgnzw=; b=X6pcOs+Iy2eC0EuNFG6HkPtsz1iQqYGlswBbvGWSBiU9j1cA0e9kZd5XFk1p9YBeNCT4A7qFz8SrnQ4m3PXUs/7OvPhxjOkZE/uN90+RxA2z8n8/QtHoq6QyRzeoksBpMFuzbQimOw0V9Q/WGXCzvvrhxgA/7PJkWrATqtYrR80cWiS5ioiD8oG5lg+9AfvEdx6FQIYSzuDUGBiDC39RdwsI9j4NryZW+ngLfGVkKrh+WBsuIcvU6o92HC1+uQ8+eiNicArVC159WN4LHhYSMBbG47jpX8HrgXQpEi6rJbCETxwEwANABaxq31vZGKrR6hEPEDxJQWPQ1J9IYgeFRw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VlKf6BG7Qzx4AT7bOHmMIV+IK0OOBh+ESj2ZF+qgnzw=; b=Ig/hEC1FAELObJFtzx4N6iKbQcDQhDzOsI8iDih6t4k6V3vCP+eihqv8kEq+P38TbKm8FQ0wKY+O8qd/dQxZIPB1qYadK9yYaDyPRYH1EG5NKG+qh/YIu+oNQ1B4JUiWDyHWvW0rbwIdT4xAfU6GGz2iR4m7NlQmCWaVGwlExJhzMdlMcIZS5VUCyVtNuzKzT0VYQHY4Tk/w6EBRgwGs3RjJjhtcsCsDDXRmwAY+4f2eo3ah8xha3TH+gsFYWcsPejoILMZoJpH9q0pEZl/sboKTHRZFhz6dDBzafAEV/ghjxLG/7nfnJsmT79xSIuyY69yBfour/5V5CB82z4JHDA== From: zhou qi To: "qemu-devel@nongnu.org" Subject: [PATCH] Fix video playback slowdown when spice client no audio enabled Thread-Topic: [PATCH] Fix video playback slowdown when spice client no audio enabled Thread-Index: AQHWh2Nf15JHbfwDZk+Tob2Rs7FGzg== Date: Thu, 10 Sep 2020 11:17:13 +0000 Message-ID: Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-incomingtopheadermarker: OriginalChecksum:F78DDCB0A3110535127208E5DD5097CA3D3A16BF170C09260D7EAC1117AC52AA; UpperCasedChecksum:3BD75A9721F56501F5AF8B6D820E5FDA41DCD47036F74B732CE9A992986A5E8B; SizeAsReceived:2664; Count:41 x-ms-exchange-messagesentrepresentingtype: 1 x-tmn: [i2it4URTABpDE3Uf86g11Wds7+QWJE5rs1sw0GEEss4=] x-ms-publictraffictype: Email x-incomingheadercount: 41 x-eopattributedmessage: 0 x-ms-office365-filtering-correlation-id: 050c830c-9800-4e94-411e-08d8557b1193 x-ms-traffictypediagnostic: HK2APC01HT004: x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: j72pMZB9j4FjN8h/MjeIHJzCp7cVDh9hScs53WpOCJtFKJxjqOS3csf7NwWIPqESGhw6i6gVR0Q/FVzHxB7uY71xNhgwnFlA+qi3ZYoS1VUAtbz2k2G1cc8SHoRjk6Q/HFGwdijiyAnwUOKR8We36NGuCZDZyHRYz2qd1sgmq9FhGhOnn705DaHBY1bPi7ZAgy7skfwmszEtkanEp+fJOGGso/W4bSPi+MwXKzTkzvY= x-ms-exchange-antispam-messagedata: 8cetmqkl5+CPg//1WOPDbzh7eKhuuTncDZ9Efs1fnc//kDVsWP1W3FitmgWgKSSlmP0OKDvC9R0UZ980WXRQLglEuaTBH2HYOunolSd4h19th+++LcEqskn+vqp5Mq3LJwmJ2v+GoiOIx7kCKe2CfA== x-ms-exchange-transport-forked: True Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-AuthSource: HK2APC01FT046.eop-APC01.prod.protection.outlook.com X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 050c830c-9800-4e94-411e-08d8557b1193 X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Sep 2020 11:17:13.4288 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Internet X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK2APC01HT004 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a01:111:f400:febe::818; envelope-from=atmgnd@outlook.com; helo=APC01-PU1-obe.outbound.protection.outlook.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HK_RANDOM_ENVFROM=0.001, HK_RANDOM_FROM=0.768, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @outlook.com) Content-Type: text/plain; charset="utf-8" From e8c2e283f0954de255a32ea70d577d5e61992399 Mon Sep 17 00:00:00 2001 From: Qi Zhou Date: Thu, 10 Sep 2020 19:09:29 +0800 Subject: [PATCH] Fix video playback slowdown when spice client no audio ena= bled You will get video playback slowdown on the following cases 1. use official spice client with audio channel disabled, use --spice-disab= le-audio option 2. thirtpart client doesn't implement audio channel ref: https://github.com/qemu/qemu/commit/fb35c2cec58985f0b8d2733f1b91927542= eeb3fd Signed-off-by: Qi Zhou --- audio/audio.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/audio/audio.c b/audio/audio.c index ce8c6dec5f..50febe190f 100644 --- a/audio/audio.c +++ b/audio/audio.c @@ -1091,7 +1091,11 @@ static size_t audio_pcm_hw_run_out(HWVoiceOut *hw, s= ize_t live) while (live) { size_t size, decr, proc; void *buf =3D hw->pcm_ops->get_buffer_out(hw, &size); - if (!buf || size =3D=3D 0) { + + if (!buf) { + hw->mix_buf->pos =3D (hw->mix_buf->pos + live) % hw->mix_buf->= size; + return clipped + live; + } else if ( size =3D=3D 0) { break; } =20 --=20 2.17.1