From nobody Thu Apr 18 23:33:52 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=hotmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1543943653066655.7413935393231; Tue, 4 Dec 2018 09:14:13 -0800 (PST) Received: from localhost ([::1]:58156 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gUEGx-0005b3-SK for importer@patchew.org; Tue, 04 Dec 2018 12:14:11 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47217) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gUEFA-0002Ct-Vi for qemu-devel@nongnu.org; Tue, 04 Dec 2018 12:12:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gUDz1-0004Hu-Rr for qemu-devel@nongnu.org; Tue, 04 Dec 2018 11:55:44 -0500 Received: from mail-oln040092072060.outbound.protection.outlook.com ([40.92.72.60]:39712 helo=EUR03-VE1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gUDz1-0004GB-Gt for qemu-devel@nongnu.org; Tue, 04 Dec 2018 11:55:39 -0500 Received: from VE1EUR03FT059.eop-EUR03.prod.protection.outlook.com (10.152.18.57) by VE1EUR03HT184.eop-EUR03.prod.protection.outlook.com (10.152.18.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1382.18; Tue, 4 Dec 2018 16:55:34 +0000 Received: from HE1P190MB0073.EURP190.PROD.OUTLOOK.COM (10.152.18.55) by VE1EUR03FT059.mail.protection.outlook.com (10.152.19.60) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1382.18 via Frontend Transport; Tue, 4 Dec 2018 16:55:34 +0000 Received: from HE1P190MB0073.EURP190.PROD.OUTLOOK.COM ([fe80::d06f:e391:b828:5003]) by HE1P190MB0073.EURP190.PROD.OUTLOOK.COM ([fe80::d06f:e391:b828:5003%7]) with mapi id 15.20.1382.020; Tue, 4 Dec 2018 16:55:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YA9wqjMRGWMg2xlqjvMTt700MnQGpZnjRYfVzjwGx9s=; b=C4pnAAfBmYflLBXSig+Of7V7Z9e2QkK/YhgXQD/ddSi1e+hFjkfWRvcCjAnT4ewXKbggrC0k45OuyG8WfwbMqU0P8Cw1GTGKnkkr3erTu+UC0P6nuI4IqUR+c9KTe26T7VXBHPWS5B34MEIySElBb74qZ9BMlPSnN/kzO/V3KAzGWLddcFpPoObxp0/Yp8AgSlFE04UEngpHPpNYdgwuMgNX3nOmwZcBkagZwrRN2IfeuGKGc9imr7T/+h0bK9en0Hus6vkXlf5QLLkE80gkY6kXfRMu/TSX+egF9VqzitcfnWogUf8M4lKUgpfjb6fKJhb6LC0YMyhnBrIzSho8oA== From: Gonzo FWS To: Thomas Huth , "qemu-devel@nongnu.org" Thread-Topic: [Qemu-devel] i386: don't require elf64 for multiboot kernel Thread-Index: AQHUi/CF/MxzwfEktkSKlgSd7tGjqA== Date: Tue, 4 Dec 2018 16:55:34 +0000 Message-ID: Accept-Language: en-US, en-GB Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-incomingtopheadermarker: OriginalChecksum:29C27C4E26D952BE0AA691FB25A6A0E0BBE1A343361120F193F3504FC05201F3; UpperCasedChecksum:403377ED3A12CA939C5ED75356DD4F2A98230FCB137C5FBA37CE88EDDE1490E0; SizeAsReceived:6885; Count:43 x-tmn: [NaWYkr37SkITu50HZsGl+0+uNreBqih7] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VE1EUR03HT184; 6:e11vSxxbCmucUUN6pobvcMwwaToN+e4lW2nk3KpB//1YahPnDbWZFx3CKknioupyF3hiyMiF+qT7LUwRYXOi5JHrQ2oM8tStPivpeSLoSfony64BE6jt1GB5CrHUFtAj3A/ZKln/AIS+47jpfBb+mzTdg9XnME0xMR5uB+oWdIERgeBKGJRD8U5gbncSCAadCskaHnt/0ZfBv09zzHM+649y83BIBPDWuwfKIjTDPW7licNUn0nWhSX5aCc4smkDzRbPqgzWL1/LJ52NETGeyF6ThX4zN2AJeN04Yw/lHlCXSAa8zO7WJtVgbkMnuUvZ9CVXwQN9RN0G/qeCqIteOHipIXxiWqdbjadSjcl7IkDhUQfArDhDQFSyBWqtKk2cbUORFI5uKfiGxbDfymdmUPoE62BnlxMQ7hv3yglNnCu1fCghm5VoWzGm1aLdlqN/KqtYCpQo9N8g8/XRFmVXXg==; 5:BfNtSepb31PQLdyTLEtbKMyEdnbXZT4QICZAkCdN++Ikt5hlt9Q8SHkYUattkmcfwBD3AoU51eIfQ2EV1op6Ep3+3ADVCsCDC+fwv4CLlIlYWFoa/xHpNqaZsOuYjOOKfGXocH+F1XpLgE+nKjE+2z9EQepUzGhAE62C2AhTdmE=; 7:qSx6tnTfoDFrFKdLaTNUbBpbojqpiKuzDeeo5vSso5s+s8s8cF5xbMk0TOywx16pZ+0LfDCdgw8d8LYqj2Z2tYhgME6jKE+1MexaEgA55+YNDdtnu1T/kLDJ/vAnOO/eqrI1NgZJSSu4+tHxT5jQYw== x-incomingheadercount: 43 x-eopattributedmessage: 0 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390098)(7020095)(201702061078)(5061506573)(5061507331)(1603103135)(2017031320274)(2017031324274)(2017031323274)(2017031322404)(1603101475)(1601125500)(1701031045); SRVR:VE1EUR03HT184; x-ms-traffictypediagnostic: VE1EUR03HT184: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(4566010)(82015058); SRVR:VE1EUR03HT184; BCL:0; PCL:0; RULEID:; SRVR:VE1EUR03HT184; x-microsoft-antispam-message-info: MllEBRdwTetXNhCRDJ3rzJGTRhv+qZ/It3IltSQ0J9Zn0v+2EV26GyqTaf14RkxM MIME-Version: 1.0 X-OriginatorOrg: hotmail.com X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: f12efbb0-867f-4c93-8261-502eceebfafa X-MS-Exchange-CrossTenant-Network-Message-Id: a63bc0eb-e25f-4c1f-1aa6-08d65a094ee5 X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: f12efbb0-867f-4c93-8261-502eceebfafa X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Dec 2018 16:55:34.3878 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Internet X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1EUR03HT184 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 40.92.72.60 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.21 Subject: [Qemu-devel] i386: don't require elf64 for multiboot kernel X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Right now IncludeOS on x86_64 must use a chainloader for multiboot support.= The chainloader is an ELF32 kernel that loads the real ELF64 kernel and ju= mps to it. As long as the ELF has the .multiboot section and conforms to th= e spec, meaning _start is be a 32-bit entry, it should be fine. By removing the extra check in multiboot.c, we can also boot ELF64 files. A= s can be seen here: https://cloud.fwsnet.net/index.php/s/XrkBkC8zy7MLa9p Signed-off-by: Alf-Andr=C3=A9 Walla --- hw/i386/multiboot.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/hw/i386/multiboot.c b/hw/i386/multiboot.c index 1a4344f5fc..d07ebf3361 100644 --- a/hw/i386/multiboot.c +++ b/hw/i386/multiboot.c @@ -194,11 +194,6 @@ int load_multiboot(FWCfgState *fw_cfg, int kernel_size; fclose(f); - if (((struct elf64_hdr*)header)->e_machine =3D=3D EM_X86_64) { - error_report("Cannot load x86-64 image, give a 32bit one."); - exit(1); - } - kernel_size =3D load_elf(kernel_filename, NULL, NULL, &elf_entry, &elf_low, &elf_high, 0, I386_ELF_MACHINE, 0, 0); -- 2.17.1