From nobody Tue Nov 18 07:47:48 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1609316794; cv=none; d=zohomail.com; s=zohoarc; b=eO9BUI2dzZPXDDdvQjjOSxSuSNJyA09xuNxToCknMghGiM8YjwNUBDuBlxEqlfqLGwgtQC4b5vhwe3ltzOm4szS6/EZT2pbr7hzpQbrARtnYeAE+ho+krbQz+PicSFTKZAyu+Lb/4AM67Ww34z86rGaRCpi+SFG+p9lRZIv3PL0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1609316794; h=Content-Type:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=WQ8bLW7cr5KTrvIry59MV6MtdzFLx/Pgowc2nu7UzM4=; b=BzN5v6OmGCrJrB7t/6T4l8q7YwdQJYPcuf8L1JZ2+CN8agMDL30oigw37dr4j/GV6+Hlo9lb6QAG7mkp3aD0p7WQZAYjbfFM3xvuVkhH7f8NGYDPhLSC9g8A3xHKPwxRGXJQip+sR2QMIYH4crhYCNJNYDZE58Ap2ojYesdnthI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1609316794882875.8027492260128; Wed, 30 Dec 2020 00:26:34 -0800 (PST) Received: from localhost ([::1]:42194 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kuWoT-0006Xw-Dh for importer@patchew.org; Wed, 30 Dec 2020 03:26:33 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44744) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kuWnG-0005xj-8e; Wed, 30 Dec 2020 03:25:18 -0500 Received: from mail-ej1-x632.google.com ([2a00:1450:4864:20::632]:42014) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kuWnD-00043w-Ek; Wed, 30 Dec 2020 03:25:18 -0500 Received: by mail-ej1-x632.google.com with SMTP id d17so20979689ejy.9; Wed, 30 Dec 2020 00:25:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=WQ8bLW7cr5KTrvIry59MV6MtdzFLx/Pgowc2nu7UzM4=; b=kokY6ff3xzKJDWci1kOn2PelBp6wnrJ9woVzkywGvTNJiaS+VT4ja8z22Qv9m1NbBG zsiiKV37MLfMlD0QOZ3RmSj1uwrpkgcvN0BOwSrBiVv3jws7qYm0Y6JSqNUyaWRBDHrP 3YJBjKUE9xEHeaCOIXouI3obpCatre+zpLot2Lqjm+p2e+YmzCs6eD00oQAg/y/vSRxY aBZNyE0mBvjpcJXnmvLgISWsikKSjwZGwoZnqzx/I4RATAv4dgxJkCbsas3sMXQMEvm7 ChLNvd8+Ak3aY8T+DBDwgMegAXvr+Wn38lkvbFvWaEOze1aVw3PWNKtb4C5UZOBQtUDO fqqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=WQ8bLW7cr5KTrvIry59MV6MtdzFLx/Pgowc2nu7UzM4=; b=Kt6VoAZKlpNJkUhY9pCSvccdii5BO5F3T+pxnMN+JY8IgXvc4Sd4MzT8rp/WlzuPd6 tMezTrTgjRQzDaKhrWyHYI9Feo8dJSjYkKVHA/mhzvj5LQPKfUNK41w8gquXtbTBpmar 8TPHuokHg/bcPBWNh0zxbrK9yuy5Qxi1KJUvpWdjq42GdlPubD3ezuwuIAwGxFqvsEav 1HQOlRDkP+cOoU+KuDzJeZANJdKV0NknnYbZe8jVkPcKlHgZcqhGGQE/PQ/SK8xGJGOA Wbqt5mq33+E+oT+VpRyEgTMVeK71+UXYYQLD35ecLg7V32yVgsvGYM1AEr+FD/OKpFQz sa5Q== X-Gm-Message-State: AOAM530XQZie8sz4pTg0W5+cIAEL9WpHJsxq5OsDwMlU+t93MNl8nxJf 0RrKUGcI+ef2iMkB3PAccBj3pTzGhhHOHnG0IT91wVsv64+6sg== X-Google-Smtp-Source: ABdhPJwVKRgw2pm0mrB0cBbzIwnTjzrimfu8dvWCP7Ucz95SuS0FhPMcCxIBCTpIO6MnAwRZWjKv4tfyyaD0A2ZwYSc= X-Received: by 2002:a17:906:518a:: with SMTP id y10mr49740268ejk.323.1609316713219; Wed, 30 Dec 2020 00:25:13 -0800 (PST) MIME-Version: 1.0 From: Sylvain Pelissier Date: Wed, 30 Dec 2020 09:25:02 +0100 Message-ID: Subject: [PATCH v2] gdb: riscv: Add target description To: "qemu-devel@nongnu.org Developers" , Palmer Dabbelt , Alistair Francis , "open list:RISC-V" , Sagar Karandikar , Bastian Koppelmann , Bin Meng Content-Type: multipart/alternative; boundary="00000000000005c81105b7aa3fbd" Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::632; envelope-from=sylvain.pelissier@gmail.com; helo=mail-ej1-x632.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @gmail.com) Content-Transfer-Encoding: quoted-printable --00000000000005c81105b7aa3fbd MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 VGFyZ2V0IGRlc2NyaXB0aW9uIGlzIG5vdCBjdXJyZW50bHkgaW1wbGVtZW50ZWQgaW4gUklTQy1W IGFyY2hpdGVjdHVyZS4KVGh1cyBHREIgd29uJ3Qgc2V0IGl0IHByb3Blcmx5IHdoZW4gYXR0YWNo ZWQuIFRoZSBwYXRjaCBpbXBsZW1lbnRzIHRoZQp0YXJnZXQgZGVzY3JpcHRpb24gcmVzcG9uc2Uu CgpTaWduZWQtb2ZmLWJ5OiBTeWx2YWluIFBlbGlzc2llciA8c3lsdmFpbi5wZWxpc3NpZXJAZ21h aWwuY29tPgpSZXZpZXdlZC1ieTogQWxpc3RhaXIgRnJhbmNpcyA8YWxpc3RhaXIuZnJhbmNpc0B3 ZGMuY29tPgpSZXZpZXdlZC1ieTogQmluIE1lbmcgPGJpbi5tZW5nQHdpbmRyaXZlci5jb20+Ci0t LQogdGFyZ2V0L3Jpc2N2L2NwdS5jIHwgMTMgKysrKysrKysrKysrKwogMSBmaWxlIGNoYW5nZWQs IDEzIGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS90YXJnZXQvcmlzY3YvY3B1LmMgYi90YXJn ZXQvcmlzY3YvY3B1LmMKaW5kZXggMjU0Y2Q4M2Y4Yi4uZWQ0OTcxOTc4YiAxMDA2NDQKLS0tIGEv dGFyZ2V0L3Jpc2N2L2NwdS5jCisrKyBiL3RhcmdldC9yaXNjdi9jcHUuYwpAQCAtNTU2LDYgKzU1 NiwxOCBAQCBzdGF0aWMgUHJvcGVydHkgcmlzY3ZfY3B1X3Byb3BlcnRpZXNbXSA9M0QgewogICAg IERFRklORV9QUk9QX0VORF9PRl9MSVNUKCksCiB9OwoKK3N0YXRpYyBnY2hhciAqcmlzY3ZfZ2Ri X2FyY2hfbmFtZShDUFVTdGF0ZSAqY3MpCit7CisgICAgUklTQ1ZDUFUgKmNwdSA9M0QgUklTQ1Zf Q1BVKGNzKTsKKyAgICBDUFVSSVNDVlN0YXRlICplbnYgPTNEICZjcHUtPmVudjsKKworICAgIGlm IChyaXNjdl9jcHVfaXNfMzJiaXQoZW52KSkgeworICAgICAgICByZXR1cm4gZ19zdHJkdXAoInJp c2N2OnJ2MzIiKTsKKyAgICB9IGVsc2UgeworICAgICAgICByZXR1cm4gZ19zdHJkdXAoInJpc2N2 OnJ2NjQiKTsKKyAgICB9Cit9CisKIHN0YXRpYyB2b2lkIHJpc2N2X2NwdV9jbGFzc19pbml0KE9i amVjdENsYXNzICpjLCB2b2lkICpkYXRhKQogewogICAgIFJJU0NWQ1BVQ2xhc3MgKm1jYyA9M0Qg UklTQ1ZfQ1BVX0NMQVNTKGMpOwpAQCAtNTkxLDYgKzYwMyw3IEBAIHN0YXRpYyB2b2lkIHJpc2N2 X2NwdV9jbGFzc19pbml0KE9iamVjdENsYXNzICpjLCB2b2lkCipkYXRhKQogICAgIC8qIEZvciBu b3csIG1hcmsgdW5taWdyYXRhYmxlOiAqLwogICAgIGNjLT52bXNkID0zRCAmdm1zdGF0ZV9yaXNj dl9jcHU7CiAjZW5kaWYKKyAgICBjYy0+Z2RiX2FyY2hfbmFtZSA9M0QgcmlzY3ZfZ2RiX2FyY2hf bmFtZTsKICNpZmRlZiBDT05GSUdfVENHCiAgICAgY2MtPnRjZ19pbml0aWFsaXplID0zRCByaXNj dl90cmFuc2xhdGVfaW5pdDsKICAgICBjYy0+dGxiX2ZpbGwgPTNEIHJpc2N2X2NwdV90bGJfZmls bDsKLS09MjAKMi4yNS4x --00000000000005c81105b7aa3fbd Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Target description is not currently implemented in RISC-V = architecture. Thus GDB won't set it properly when attached. The patch i= mplements the target description response.

Signed-off-by: Sylvain Pe= lissier <sylvain.pelissie= r@gmail.com>
---
=C2=A0target/riscv/cpu.c | 13 +++++++++++++=C2=A01 file changed, 13 insertions(+)

diff --git a/target/riscv/c= pu.c b/target/riscv/cpu.c
index 254cd83f8b..ed4971978b 100644
--- a/t= arget/riscv/cpu.c
+++ b/target/riscv/cpu.c
@@ -556,6 +556,18 @@ stati= c Property riscv_cpu_properties[] =3D {
=C2=A0 =C2=A0 =C2=A0DEFINE_PROP_= END_OF_LIST(),
=C2=A0};
=C2=A0
+static gchar *riscv_gdb_arch_name(= CPUState *cs)
+{
+ =C2=A0 =C2=A0RISCVCPU *cpu =3D RISCV_CPU(cs);
+= =C2=A0 =C2=A0CPURISCVState *env =3D &cpu->env;
+
+ =C2=A0 =C2= =A0if (riscv_cpu_is_32bit(env)) {
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0return g_= strdup("riscv:rv32");
+ =C2=A0 =C2=A0} else {
+ =C2=A0 =C2= =A0 =C2=A0 =C2=A0return g_strdup("riscv:rv64");
+ =C2=A0 =C2= =A0}
+}
+
=C2=A0static void riscv_cpu_class_init(ObjectClass *c, v= oid *data)
=C2=A0{
=C2=A0 =C2=A0 =C2=A0RISCVCPUClass *mcc =3D RISCV_C= PU_CLASS(c);
@@ -591,6 +603,7 @@ static void riscv_cpu_class_init(Object= Class *c, void *data)
=C2=A0 =C2=A0 =C2=A0/* For now, mark unmigratable:= */
=C2=A0 =C2=A0 =C2=A0cc->vmsd =3D &vmstate_riscv_cpu;
=C2= =A0#endif
+ =C2=A0 =C2=A0cc->gdb_arch_name =3D riscv_gdb_arch_name;=C2=A0#ifdef CONFIG_TCG
=C2=A0 =C2=A0 =C2=A0cc->tcg_initialize =3D = riscv_translate_init;
=C2=A0 =C2=A0 =C2=A0cc->tlb_fill =3D riscv_cpu_= tlb_fill;
--
2.25.1
--00000000000005c81105b7aa3fbd--