From nobody Fri Nov 14 23:29:38 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1759226376; cv=none; d=zohomail.com; s=zohoarc; b=CAuBWbhy0C46jet/1L1TDAcgfuQlNiaL4RH+DYPB0TZ5kSPMEtdBnnleDl2VhB9dBu4Acs2RAaoTER3o3wTZbDd+DBNig4SGTuvTY0EIHvY/9bq0a8QUS3C094Oyx5gleuGlcjgu+C6hF6gV/vYDLIWp7yhbfgjcuryhq68pnZI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1759226376; h=Content-Type:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=nNQOhBWxAwN+tCfdXUvKDVjrEEM+0houM9LjCgxD5jA=; b=ilVATCLMgFayHQ33r1qehSJwcoAnmkbHYst4Lut4uaxlozN9ZjKUk3uHSD8P9RmKm32zl86BXfvtmhJvW5s4+eKJFRX/zt1hD2CnWyn9fTR5qXcfNc2n6DkWCL+dJkDdwKU8drif+TC6GIoa+2nf63gEb0tWyiZnx2t6cchBYng= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1759226376089627.4015370134041; Tue, 30 Sep 2025 02:59:36 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v3X6u-000378-Cu; Tue, 30 Sep 2025 05:57:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v3Wlf-0003oF-VI for qemu-devel@nongnu.org; Tue, 30 Sep 2025 05:35:31 -0400 Received: from mail-ej1-x62e.google.com ([2a00:1450:4864:20::62e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1v3WlU-0001Qf-Gu for qemu-devel@nongnu.org; Tue, 30 Sep 2025 05:35:29 -0400 Received: by mail-ej1-x62e.google.com with SMTP id a640c23a62f3a-b3d50882cc2so458765166b.2 for ; Tue, 30 Sep 2025 02:35:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cylo-net.20230601.gappssmtp.com; s=20230601; t=1759224913; x=1759829713; darn=nongnu.org; h=cc:to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=nNQOhBWxAwN+tCfdXUvKDVjrEEM+0houM9LjCgxD5jA=; b=0r92mJtCCNVWbPP/1IdmaxiYJn2k6lRAzMfLJwEbn3//XVXbew+E+SrmDfK1XuWqe7 X5LItx9+34KMVXZSjOafeDXiTaZvFP1LIiLVePPwJAPNTZGrNXvD95MGaygjvuNhXFEm yUtltNnzRNkleoKS18DrUaMHqrQBYuAjWz2/DAC7I0qwNMmYRhnl7E9HIIVHBRxBFWI7 1cImLRCId1IKsT9am4A7d7iUaJNFElNvwinps5AsyeP9+j72NO+F6GjHi2Zs4fi6w+uQ bmEiOPwIJKnGiEziSMS8gfh5jXPtLppP75mViUMNBwJHzMetTcIXCYhwTjRGU9NSlnQk 70Wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759224913; x=1759829713; h=cc:to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=nNQOhBWxAwN+tCfdXUvKDVjrEEM+0houM9LjCgxD5jA=; b=WgM7wDfZ9hJ8EDjJUnNAV9L3mYNCINLbgxVNJBUAlJJeQDhQ5MHEVxjBeVOri8kyjw M9ulZu5qjDfePboTaqy1Ua0A7OMBPZvj4Xox7L1lpfaxwjmwRwlTNAy5kgdNjTT0qLyo bJpTkz3CQ5Qb5FWaFEA+fshgDmKMvQWM8XGURgZ7tWVDS7/WduDY2KfVTwQoGCVLVnKT mxpBW7wHRdVpPMYQYKUL22eGMdfsoJK8ddijoevOqtN0MQlAiJxZ4YBzVgueszTMI223 D6Z81sgyUvPJ0Kyz/z0cKgVvh3LljLrpROmn8B7o4FqXxDmoiSe+izoIy6cBSgExKvch k4kg== X-Gm-Message-State: AOJu0YxrFS+FEMCMd9xUzPSE8BZo/7u5fmY7dr7D6GATL7eRxHngdLvO 0NYxD1N9R/xCwPdIujvKx9R/c0XTc7Okbr/jFIGzKXhQJIOF551KOkAZ0yU5QxPYcmvEgqZoZRm xGr53Xtxm9J4KCRK03CkKEhf1YQlhrytMrpqpioNdUU2fmHjlMb0f7XK5Qa4= X-Gm-Gg: ASbGnctHL/7/NRCatwXiCKWsEMJwN+fh1xRDjQCONFy20fJ0dir2iYkfICBCVFtqUpu Jt2W27m1TlhbmIc1lnPQLN3y6tqDeouL5zkXEzSv6/GN2P3iBqVtiBYGLjck9XzaMVNU2Rc5nEb 2h3WBAGOSjoSOvDLB4ea64VpSnyhSx7f96wM+rTI6EMq/HtO0IRY5wAo+ET0E0Y6aiapNEM4e74 DSCaKwVJXL5PE2PZcvTX0FKQOoKEP6N8yShn20dRSiFHpOr X-Google-Smtp-Source: AGHT+IETbiKODhQQ4PSeYM+Ri5cDLzACI+nQZRsKqqkghSvx6fnazRlqnNHd1cQDZ5eACu+a/O4VsaQuH7++vMgnOj0= X-Received: by 2002:a17:906:c113:b0:b2a:5fe5:87c7 with SMTP id a640c23a62f3a-b34b69423famr2413535666b.12.1759224912627; Tue, 30 Sep 2025 02:35:12 -0700 (PDT) MIME-Version: 1.0 From: "Grant Millar | Cylo" Date: Tue, 30 Sep 2025 10:35:01 +0100 X-Gm-Features: AS18NWArTSOpfpl9orxCYcoR8gqYDVtoKsv0iifeRLOVtXtYXY3czY2nK8WIj_s Message-ID: Subject: [PATCH] ui/vnc: Fix NULL pointer dereference in vnc_disconnect_start To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::62e; envelope-from=grant@cylo.net; helo=mail-ej1-x62e.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Tue, 30 Sep 2025 05:57:16 -0400 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @cylo-net.20230601.gappssmtp.com) X-ZM-MESSAGEID: 1759226377963116600 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From 0d1c4ac000a66ef22b4a0cd0c4bedd840192096a Mon Sep 17 00:00:00 2001 From: Rid Date: Tue, 30 Sep 2025 10:23:58 +0100 Subject: [PATCH] ui/vnc: Fix NULL pointer dereference in vnc_disconnect_sta= rt When a WebSocket connection fails during the handshake, vs->ioc can be NULL when vnc_disconnect_start() is called, leading to a segmentation fault when qio_channel_close() tries to dereference it. This can be reproduced by sending incomplete HTTP requests to the WebSocket port: for i in {1..100}; do (echo -n "GET / HTTP/1.1" && sleep 0.05) | nc -w 1 & done Add a NULL check before calling qio_channel_close() to prevent the crash. Signed-off-by: Rid --- ui/vnc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ui/vnc.c b/ui/vnc.c index 77c823bf2e..1669ed1b80 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -1301,7 +1301,9 @@ static void vnc_disconnect_start(VncState *vs) g_source_remove(vs->ioc_tag); vs->ioc_tag =3D 0; } - qio_channel_close(vs->ioc, NULL); + if (vs->ioc) { + qio_channel_close(vs->ioc, NULL); + } vs->disconnecting =3D TRUE; } --=20 2.39.5