From nobody Tue Feb 10 20:54:53 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1687588884; cv=none; d=zohomail.com; s=zohoarc; b=dmQ1z4yTn76rUnJx2U5BPIbty8lJ+EBaRLkrWQuIzvca4c1J5TSL2ULsfJa3qXkLurOyluA09y1knphq0VtZ7seji2ua9vB83Ct0iegXFGQ1+Y8SoIWDT+imwm2djrVzzpMLBsM8hr6XAKD/n8FPS3ry4t0TY+tV0iNb7vg0fco= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1687588884; h=Content-Type:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=4B+21lKxKTxXjdKxGSG9Kq9GEu7ynJBkhDjDeipxVqg=; b=fTFAk24G4+3DiFsB4GUsIjR00QXhmNztSqp3oSvXYr4u+quE/+MhnSKNcmGMB/Gre+MakZquR5C2ZRDceRHskRmOT1M+eEiHuUmCx3W7mY9pzbQzfrTPRFo3eq3shnCXzYY58ac58vpaxia3llNkpo1X7AZ8EycH+c94YpkfU0s= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1687588884012432.9838506719269; Fri, 23 Jun 2023 23:41:24 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qCwwX-0004xH-96; Sat, 24 Jun 2023 02:40:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qCwwU-0004wp-Ir for qemu-devel@nongnu.org; Sat, 24 Jun 2023 02:40:18 -0400 Received: from mail-ej1-x62a.google.com ([2a00:1450:4864:20::62a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qCwwN-0000Jy-7W for qemu-devel@nongnu.org; Sat, 24 Jun 2023 02:40:18 -0400 Received: by mail-ej1-x62a.google.com with SMTP id a640c23a62f3a-98746d7f35dso181669166b.2 for ; Fri, 23 Jun 2023 23:40:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20221208.gappssmtp.com; s=20221208; t=1687588807; x=1690180807; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=4B+21lKxKTxXjdKxGSG9Kq9GEu7ynJBkhDjDeipxVqg=; b=oIuawj9IvCA1nYRzevGfiYYmqpUcR8ku0sEgxciw3ntSoMcTI5MfGMhMBwHPSV4Vys /x63kzPZq5GMQywYTUVeZWHo1MOdzixI1pY5ZQaMgmylM0S8uEJ2VqkUobp0J8pIQ5KM KR0EATvC+yV8ZBkCUPrBq9c79+/36xK/6zeixEIFNmJUd+nF3NHbPUTwDefaYxSvWBrr rNEmKcO3i0HyMwZPjk2X+En3NSDHtNwmcug9vyCdm1wr24s9le+d2+7MgsrGB495qhJw AY0Hm8YKyP0LkA/dpiCn8SDM7sNJFbWDVyq+e7c5J/MdTnKJybzkxJNN4K3ANSdNy1XE u70A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687588807; x=1690180807; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=4B+21lKxKTxXjdKxGSG9Kq9GEu7ynJBkhDjDeipxVqg=; b=EWw4VX/Nqx55VFIbugBIkO9mUSq/AZDmVfZQ/Tj0pOIOsot7jLd8AWUB39ylELdmYK Lfch/slEWCQ3e7V6+e5CRSXn+Z0Wqys+eXvzjQUn6O4b/gkaSuIkVVi0yQIHrsMlFeg5 WJqadPI39N5jQay+Rai8Xk6a99NntW1m3tmp3w35ZaitD1Ji16lTbr3zCMbNfGksBv54 YPHEXklwApYeipQmsvjsj13hJbvF9d5KYge9heunr5kOern7BXVXqVtOvP3drzmhebcE 2sDXSvW+Tts042OgNb1ZnVWfLwdUZMKsu1x9uz8KdQgTC1ejb7n4VJJupuPyGPqdlncQ 29Zw== X-Gm-Message-State: AC+VfDzrirKkRrgp+iobi50fWvZbqXs7+wrJ56ib5iAKtcN6h87EXc9N wbxXOyPQdrREvmX2w5AtHIVLxm6MuvpMOWM2f4QyZZdaNvASRmx030c= X-Google-Smtp-Source: ACHHUZ45TS9j7Sev4U8zft1IDVH4MczaXJUxkqDUBArrIKJpQfZxs2g3Kmm8J59KlEpDUYLC1wPdWZFNc47izYuEmw4= X-Received: by 2002:a17:907:2d2c:b0:98d:bc7c:c962 with SMTP id gs44-20020a1709072d2c00b0098dbc7cc962mr1686943ejc.45.1687588806666; Fri, 23 Jun 2023 23:40:06 -0700 (PDT) MIME-Version: 1.0 From: Warner Losh Date: Sat, 24 Jun 2023 00:40:33 -0600 Message-ID: Subject: RFC: bsd-user broken a while ago, is this the right fix? To: QEMU Developers Content-Type: multipart/alternative; boundary="00000000000059435d05feda6384" Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=2a00:1450:4864:20::62a; envelope-from=wlosh@bsdimp.com; helo=mail-ej1-x62a.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @bsdimp-com.20221208.gappssmtp.com) X-ZM-MESSAGEID: 1687588886049100001 Content-Transfer-Encoding: quoted-printable --00000000000059435d05feda6384 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 VGhpcyBjaGFuZ2U6Cgpjb21taXQgZjAwNTA2YWVjYTJmNmQ5MjMxODk2NzY5M2Y4ZGE4YzcxM2Mx NjNmMwpNZXJnZTogZDM3MTU4YmIyNDIgODdlMzAzZGU3MGYKQXV0aG9yOiBQZXRlciBNYXlkZWxs IDxwZXRlci5tYXlkZWxsQGxpbmFyby5vcmc+CkRhdGU6ICAgV2VkIE1hciAyOSAxMToxOToxOSAy MDIzICswMTAwCgogICAgTWVyZ2UgdGFnICdwdWxsLXRjZy0yMDIzMDMyOCcgb2YgaHR0cHM6Ly9n aXRsYWIuY29tL3J0aDc2ODAvcWVtdSBpbnRvCnN0YWdpbmcKCiAgICBVc2UgYSBsb2NhbCB2ZXJz aW9uIG9mIEdUcmVlIFsjMjg1XQogICAgRml4IHBhZ2Vfc2V0X2ZsYWdzIHZzIHRoZSBsYXN0IHBh Z2Ugb2YgdGhlIGFkZHJlc3Mgc3BhY2UgWyMxNTI4XQogICAgUmUtZW5hYmxlIGdkYnN0dWIgYnJl YWtwb2ludHMgdW5kZXIgS1ZNCgogICAgIyAtLS0tLUJFR0lOIFBHUCBTSUdOQVRVUkUtLS0tLQog ICAgIwogICAgIyBpUUZSQkFBQkNnQTdGaUVFZWtnZWVJYUxUYmFvV2dYQVpOODQ2SzkrSVY4RkFt UWpjTElkSEhKcFkyaGhjbVF1CiAgICAjIGFHVnVaR1Z5YzI5dVFHeHBibUZ5Ynk1dmNtY0FDZ2tR Wk44NDZLOStJVjhya2dmL1phem9kb3ZSS3hmYU82MjIKICAgICMgbUdXN3l3SW0raElaWW1LQzdP YmlNS0ZyQm9DeWVYSDl5T0xTeDQyVDcwUXN0V3ZCTXVram92TE16MStUdGJvMQogICAgIyBWT3Zw R0gyQjVXNzZsM2krbXVBbEt4RlJiQkgya01MVGFMK0JYdGtta0w0Rko5YlM4V2lQQXBzTDNsRVgv cTJFCiAgICAjIDNrcWFUM04zQzA5c1dPNW9WQVBHVFVITDBFdXRLaE9hcjJWWkwwK1BWUEZ6TDNC TlBoblFIOVFjYk52REJWM24KICAgICMgY3gzR1NYWnlMN1BseWkrcXdzS2YvM0pvK0Yyd3IyTlZm M0Rxc2N1OVQxTjFrSTVoU2pScHdxVUVKekpaNXJlaQogICAgIyBseS9nQlhDL0o3K1dOK3grdzJK bE4wa1dYV3FDMFFiRGZabmo5NlBkM293V1o3ajRzVDl6UjVmY05lbmVjeGxSCiAgICAjIDM4Qm8w dz0zRD0zRAogICAgIyA9M0R5c0Y3CiAgICAjIC0tLS0tRU5EIFBHUCBTSUdOQVRVUkUtLS0tLQog ICAgIyBncGc6IFNpZ25hdHVyZSBtYWRlIFR1ZSAyOCBNYXIgMjAyMyAyMzo1Njo1MCBCU1QKICAg ICMgZ3BnOiAgICAgICAgICAgICAgICB1c2luZyBSU0Ega2V5CjdBNDgxRTc4ODY4QjREQjZBODVB MDVDMDY0REYzOEU4QUY3RTIxNUYKICAgICMgZ3BnOiAgICAgICAgICAgICAgICBpc3N1ZXIgInJp Y2hhcmQuaGVuZGVyc29uQGxpbmFyby5vcmciCiAgICAjIGdwZzogR29vZCBzaWduYXR1cmUgZnJv bSAiUmljaGFyZCBIZW5kZXJzb24gPApyaWNoYXJkLmhlbmRlcnNvbkBsaW5hcm8ub3JnPiIgW2Z1 bGxdCiAgICAjIFByaW1hcnkga2V5IGZpbmdlcnByaW50OiA3QTQ4IDFFNzggODY4QiA0REI2IEE4 NUEgIDA1QzAgNjRERiAzOEU4CkFGN0UgMjE1RgoKICAgICogdGFnICdwdWxsLXRjZy0yMDIzMDMy OCcgb2YgaHR0cHM6Ly9naXRsYWIuY29tL3J0aDc2ODAvcWVtdToKICAgICAgc29mdG1tdTogUmVz dG9yZSB1c2Ugb2YgQ1BVIHdhdGNocG9pbnQgZm9yIGFsbCBhY2NlbGVyYXRvcnMKICAgICAgc29m dG1tdS93YXRjaHBvaW50OiBBZGQgbWlzc2luZyAncWVtdS9lcnJvci1yZXBvcnQuaCcgaW5jbHVk ZQogICAgICBzb2Z0bW11OiBSZXN0cmljdCBjcHVfY2hlY2tfd2F0Y2hwb2ludCAvIGFkZHJlc3Nf bWF0Y2hlcyB0byBUQ0cgYWNjZWwKICAgICAgbGludXgtdXNlci9hcm06IFRha2UgbW9yZSBjYXJl IGFsbG9jYXRpbmcgY29tbXBhZ2UKICAgICAgaW5jbHVkZS9leGVjOiBDaGFuZ2UgcmVzZXJ2ZWRf dmEgc2VtYW50aWNzIHRvIGxhc3QgYnl0ZQogICAgICBsaW51eC11c2VyOiBQYXNzIGxhc3Qgbm90 IGVuZCB0byBwcm9iZV9ndWVzdF9iYXNlCiAgICAgIGFjY2VsL3RjZzogUGFzcyBsYXN0IG5vdCBl bmQgdG8gdGJfaW52YWxpZGF0ZV9waHlzX3JhbmdlCiAgICAgIGFjY2VsL3RjZzogUGFzcyBsYXN0 IG5vdCBlbmQgdG8gdGJfaW52YWxpZGF0ZV9waHlzX3BhZ2VfcmFuZ2VfX2xvY2tlZAogICAgICBh Y2NlbC90Y2c6IFBhc3MgbGFzdCBub3QgZW5kIHRvIHBhZ2VfY29sbGVjdGlvbl9sb2NrCiAgICAg IGFjY2VsL3RjZzogUGFzcyBsYXN0IG5vdCBlbmQgdG8gUEFHRV9GT1JfRUFDSF9UQgogICAgICBh Y2NlbC90Y2c6IFBhc3MgbGFzdCBub3QgZW5kIHRvIHBhZ2VfcmVzZXRfdGFyZ2V0X2RhdGEKICAg ICAgYWNjZWwvdGNnOiBQYXNzIGxhc3Qgbm90IGVuZCB0byBwYWdlX3NldF9mbGFncwogICAgICBs aW51eC11c2VyOiBEaWFnbm9zZSBtaXNhbGlnbmVkIC1SIHNpemUKICAgICAgdGNnOiB1c2UgUVRy ZWUgaW5zdGVhZCBvZiBHVHJlZQogICAgICB1dGlsOiBpbXBvcnQgR1RyZWUgYXMgUVRyZWUKCiAg ICBTaWduZWQtb2ZmLWJ5OiBQZXRlciBNYXlkZWxsIDxwZXRlci5tYXlkZWxsQGxpbmFyby5vcmc+ CgpicmVha3MgYnNkLXVzZXIuIHdoZW4gSSBtZXJnZSBpdCB0byB0aGUgYnNkLXVzZXIgdXBzdHJl YW0gYmxpdHogYnJhbmNoIEkKZ2V0IG1lbW9yeSBhbGxvY2F0aW9uIGVycm9ycyBvbiBzdGFydHVw LiBBdCBsZWFzdCBmb3IgYXJtdjcuCgpzcGVjaWZpY2FsbHksIGlmIEkgYmFjayBvdXQgdGhlIGJz ZC11c2VyIHBhcnQgb2YgYm90aApjb21taXQgOTUwNTlmOWMzMTNhN2ZiZDdmMjJlNGNkYzE5Nzdj MDM5M2FkZGM3YgpBdXRob3I6IFJpY2hhcmQgSGVuZGVyc29uIDxyaWNoYXJkLmhlbmRlcnNvbkBs aW5hcm8ub3JnPgpEYXRlOiAgIE1vbiBNYXIgNiAwMToyNjoyOSAyMDIzICswMzAwCgogICAgaW5j bHVkZS9leGVjOiBDaGFuZ2UgcmVzZXJ2ZWRfdmEgc2VtYW50aWNzIHRvIGxhc3QgYnl0ZQoKICAg IENoYW5nZSB0aGUgc2VtYW50aWNzIHRvIGJlIHRoZSBsYXN0IGJ5dGUgb2YgdGhlIGd1ZXN0IHZh LCByYXRoZXIKICAgIHRoYW4gdGhlIGZvbGxvd2luZyBieXRlLiAgVGhpcyBhdm9pZHMgc29tZSBv dmVyZmxvdyBjb25kaXRpb25zLgoKICAgIFJldmlld2VkLWJ5OiBQaGlsaXBwZSBNYXRoaWV1LURh dWQ8QzM+PEE5PiA8cGhpbG1kQGxpbmFyby5vcmc+CiAgICBTaWduZWQtb2ZmLWJ5OiBSaWNoYXJk IEhlbmRlcnNvbiA8cmljaGFyZC5oZW5kZXJzb25AbGluYXJvLm9yZz4KCmFuZAoKY29tbWl0IDQ5 ODQwYTRhMDk4MTQ5MDY3Nzg5MjU1YmNhNjg5NDY0NWY0MTEwMzYKQXV0aG9yOiBSaWNoYXJkIEhl bmRlcnNvbiA8cmljaGFyZC5oZW5kZXJzb25AbGluYXJvLm9yZz4KRGF0ZTogICBNb24gTWFyIDYg MDE6NTE6MDkgMjAyMyArMDMwMAoKICAgIGFjY2VsL3RjZzogUGFzcyBsYXN0IG5vdCBlbmQgdG8g cGFnZV9zZXRfZmxhZ3MKCiAgICBQYXNzIHRoZSBhZGRyZXNzIG9mIHRoZSBsYXN0IGJ5dGUgdG8g YmUgY2hhbmdlZCwgcmF0aGVyIHRoYW4KICAgIHRoZSBmaXJzdCBhZGRyZXNzIHBhc3QgdGhlIGxh c3QgYnl0ZS4gIFRoaXMgYXZvaWRzIG92ZXJmbG93CiAgICB3aGVuIHRoZSBsYXN0IHBhZ2Ugb2Yg dGhlIGFkZHJlc3Mgc3BhY2UgaXMgaW52b2x2ZWQuCgogICAgUmVzb2x2ZXM6IGh0dHBzOi8vZ2l0 bGFiLmNvbS9xZW11LXByb2plY3QvcWVtdS8tL2lzc3Vlcy8xNTI4CiAgICBSZXZpZXdlZC1ieTog UGhpbGlwcGUgTWF0aGlldS1EYXVkPEMzPjxBOT4gPHBoaWxtZEBsaW5hcm8ub3JnPgogICAgU2ln bmVkLW9mZi1ieTogUmljaGFyZCBIZW5kZXJzb24gPHJpY2hhcmQuaGVuZGVyc29uQGxpbmFyby5v cmc+Cgp0aGluZ3Mgd29yayBhZ2Fpbi4gSWYgSSBiYWNrb3V0IHBhcnRzLCBpdCBmYWlscyBzdGls bC4gSWYgSSBiYWNrIG91dCBvbmx5Cm9uZSBvZgp0aGUgdHdvLCBidXQgbm90IGJvdGgsIHRoZW4g aXQgZmFpbHMuCgpXaGF0J3MgaGFwcGVuaW5nIGlzIHRoYXQgd2UncmUgcGlja2luZyBhIHJlc2Vy dmVkX3ZhIHRoYXQncyBvdmVyZmxvd2luZyB3aGVuCndlIGFkZCAxIHRvIGl0LiB0aGlzIG92ZXJm bG93IGdvZXMgYXdheSBpZiBJIG1ha2UgdGhlIG92ZXJmbG93cyBub3QKcG9zc2libGU6CmRpZmYg LS1naXQgYS9ic2QtdXNlci9tbWFwLmMgYi9ic2QtdXNlci9tbWFwLmMKaW5kZXggYTg4MjUxZjg3 MDUuLmJkODZjMGE4Njg5IDEwMDY0NAotLS0gYS9ic2QtdXNlci9tbWFwLmMKKysrIGIvYnNkLXVz ZXIvbW1hcC5jCkBAIC0yMzcsOCArMjM3LDggQEAgdW5zaWduZWQgbG9uZyBsYXN0X2JyazsKIHN0 YXRpYyBhYmlfdWxvbmcgbW1hcF9maW5kX3ZtYV9yZXNlcnZlZChhYmlfdWxvbmcgc3RhcnQsIGFi aV91bG9uZyBzaXplLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGFi aV91bG9uZyBhbGlnbm1lbnQpCiB7Ci0gICAgYWJpX3Vsb25nIGFkZHI7Ci0gICAgYWJpX3Vsb25n IGVuZF9hZGRyOworICAgIHVpbnQ2NF90IGFkZHI7CisgICAgdWludDY0X3QgZW5kX2FkZHI7CiAg ICAgaW50IHByb3Q7CiAgICAgaW50IGxvb3BlZCA9M0QgMDsKCk15IHF1ZXN0aW9uIGlzLCBpcyB0 aGlzIHRoZSByaWdodCBmaXg/IFRoZSBvbGQgY29kZSBhdm9pZGVkIHRoZSBvdmVyZmxvdyBpbgp0 d28gd2F5cy4gMSBpdCBzZXQgcmVzZXJ2ZV92YSB0byBhIHBhZ2Ugc2hvcnQgKHdoaWNoIGlmIEkg Zml4IHRoYXQsIGl0CndvcmtzIGJldHRlciwgYnV0IG5vdCBxdWl0ZSByaWdodCkuIGFuZCBpdCBu ZXZlciBjb21wdXRlcyBhbiBhZGRyZXNzIHRoYXQKbWF5IG92ZXJmbG93ICh3aGljaCB0aGUgbmV3 IGNvZGUgZG9lcyB3aXRob3V0IHRoZSBhYm92ZSBwYXRjaCkuCgpJdCBzZWVtcyB0byB3b3JrLCBi dXQgaXQgbG9va3Mgc3VwZXIgd2VpcmQuCgpDb21tZW50cz8KCldhcnJuZXI= --00000000000059435d05feda6384 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
This change:

commit f00506ae= ca2f6d92318967693f8da8c713c163f3
Merge: d37158bb242 87e303de70f
Autho= r: Peter Maydell <peter.mayd= ell@linaro.org>
Date: =C2=A0 Wed Mar 29 11:19:19 2023 +0100
=C2=A0 =C2=A0 Merge tag 'pull-tcg-20230328' of https://gitlab.com/rth7680/qemu into staging<= br>=C2=A0 =C2=A0
=C2=A0 =C2=A0 Use a local version of GTree [#285]
= =C2=A0 =C2=A0 Fix page_set_flags vs the last page of the address space [#15= 28]
=C2=A0 =C2=A0 Re-enable gdbstub breakpoints under KVM
=C2=A0 =C2= =A0
=C2=A0 =C2=A0 # -----BEGIN PGP SIGNATURE-----
=C2=A0 =C2=A0 #=C2=A0 =C2=A0 # iQFRBAABCgA7FiEEekgeeIaLTbaoWgXAZN846K9+IV8FAmQjcLIdHHJpY2= hhcmQu
=C2=A0 =C2=A0 # aGVuZGVyc29uQGxpbmFyby5vcmcACgkQZN846K9+IV8rkgf/Z= azodovRKxfaO622
=C2=A0 =C2=A0 # mGW7ywIm+hIZYmKC7ObiMKFrBoCyeXH9yOLSx42T= 70QstWvBMukjovLMz1+Ttbo1
=C2=A0 =C2=A0 # VOvpGH2B5W76l3i+muAlKxFRbBH2kML= TaL+BXtkmkL4FJ9bS8WiPApsL3lEX/q2E
=C2=A0 =C2=A0 # 3kqaT3N3C09sWO5oVAPGTU= HL0EutKhOar2VZL0+PVPFzL3BNPhnQH9QcbNvDBV3n
=C2=A0 =C2=A0 # cx3GSXZyL7Ply= i+qwsKf/3Jo+F2wr2NVf3Dqscu9T1N1kI5hSjRpwqUEJzJZ5rei
=C2=A0 =C2=A0 # ly/g= BXC/J7+WN+x+w2JlN0kWXWqC0QbDfZnj96Pd3owWZ7j4sT9zR5fcNenecxlR
=C2=A0 =C2= =A0 # 38Bo0w=3D=3D
=C2=A0 =C2=A0 # =3DysF7
=C2=A0 =C2=A0 # -----END P= GP SIGNATURE-----
=C2=A0 =C2=A0 # gpg: Signature made Tue 28 Mar 2023 23= :56:50 BST
=C2=A0 =C2=A0 # gpg: =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0using RSA key 7A481E78868B4DB6A85A05C064DF38E8AF7E215F
= =C2=A0 =C2=A0 # gpg: =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0issuer "richard.hen= derson@linaro.org"
=C2=A0 =C2=A0 # gpg: Good signature from &qu= ot;Richard Henderson <ri= chard.henderson@linaro.org>" [full]
=C2=A0 =C2=A0 # Primary = key fingerprint: 7A48 1E78 868B 4DB6 A85A =C2=A005C0 64DF 38E8 AF7E 215F=C2=A0 =C2=A0
=C2=A0 =C2=A0 * tag 'pull-tcg-20230328' of https://gitlab.com/rth7680/qemu:=
=C2=A0 =C2=A0 =C2=A0 softmmu: Restore use of CPU watchpoint for all acc= elerators
=C2=A0 =C2=A0 =C2=A0 softmmu/watchpoint: Add missing 'qemu= /error-report.h' include
=C2=A0 =C2=A0 =C2=A0 softmmu: Restrict cpu_= check_watchpoint / address_matches to TCG accel
=C2=A0 =C2=A0 =C2=A0 lin= ux-user/arm: Take more care allocating commpage
=C2=A0 =C2=A0 =C2=A0 inc= lude/exec: Change reserved_va semantics to last byte
=C2=A0 =C2=A0 =C2= =A0 linux-user: Pass last not end to probe_guest_base
=C2=A0 =C2=A0 =C2= =A0 accel/tcg: Pass last not end to tb_invalidate_phys_range
=C2=A0 =C2= =A0 =C2=A0 accel/tcg: Pass last not end to tb_invalidate_phys_page_range__l= ocked
=C2=A0 =C2=A0 =C2=A0 accel/tcg: Pass last not end to page_collecti= on_lock
=C2=A0 =C2=A0 =C2=A0 accel/tcg: Pass last not end to PAGE_FOR_EA= CH_TB
=C2=A0 =C2=A0 =C2=A0 accel/tcg: Pass last not end to page_reset_ta= rget_data
=C2=A0 =C2=A0 =C2=A0 accel/tcg: Pass last not end to page_set_= flags
=C2=A0 =C2=A0 =C2=A0 linux-user: Diagnose misaligned -R size
= =C2=A0 =C2=A0 =C2=A0 tcg: use QTree instead of GTree
=C2=A0 =C2=A0 =C2= =A0 util: import GTree as QTree
=C2=A0 =C2=A0
=C2=A0 =C2=A0 Signed-o= ff-by: Peter Maydell <peter.= maydell@linaro.org>

breaks bsd-user. when I merge = it to the bsd-user upstream blitz branch I get memory allocation errors on = startup. At least for armv7.

specifically, if = I back out the bsd-user part of both
commit 95059f9c313a7fbd7f22e= 4cdc1977c0393addc7b
Author: Richard Henderson <richard.henderson@linaro.org>
Date: =C2= =A0 Mon Mar 6 01:26:29 2023 +0300

=C2=A0 =C2=A0 include/exec: Change= reserved_va semantics to last byte
=C2=A0 =C2=A0
=C2=A0 =C2=A0 Chan= ge the semantics to be the last byte of the guest va, rather
=C2=A0 =C2= =A0 than the following byte.=C2=A0 This avoids some overflow conditions.=C2=A0 =C2=A0
=C2=A0 =C2=A0 Reviewed-by: Philippe Mathieu-Daud<C3&g= t;<A9> <philmd@linaro.org= >
=C2=A0 =C2=A0 Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
and

commit 49840a4a098149067789255bca6= 894645f411036
Author: Richard Henderson <richard.henderson@linaro.org>
Date: =C2=A0 Mo= n Mar 6 01:51:09 2023 +0300

=C2=A0 =C2=A0 accel/tcg: Pass last not e= nd to page_set_flags
=C2=A0 =C2=A0
=C2=A0 =C2=A0 Pass the address of= the last byte to be changed, rather than
=C2=A0 =C2=A0 the first addres= s past the last byte.=C2=A0 This avoids overflow
=C2=A0 =C2=A0 when the = last page of the address space is involved.
=C2=A0 =C2=A0
=C2=A0 =C2= =A0 Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1528
=C2=A0 =C2=A0 R= eviewed-by: Philippe Mathieu-Daud<C3><A9> <philmd@linaro.org>
=C2=A0 =C2=A0 Signed-off-b= y: Richard Henderson <ri= chard.henderson@linaro.org>

things work again. If = I backout parts, it fails still. If I back out only one of
the tw= o, but not both, then it fails.

What's happeni= ng is that we're picking a reserved_va that's overflowing when
we add 1 to it. this overflow goes away if I make the overflows not p= ossible:
diff --git a/bsd-user/mmap.c b/bsd-user/mmap.c
index = a88251f8705..bd86c0a8689 100644
--- a/bsd-user/mmap.c
+++ b/bsd-user/= mmap.c
@@ -237,8 +237,8 @@ unsigned long last_brk;
=C2=A0static abi_u= long mmap_find_vma_reserved(abi_ulong start, abi_ulong size,
=C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0abi_ulong ali= gnment)
=C2=A0{
- =C2=A0 =C2=A0abi_ulong addr;
- =C2=A0 =C2=A0abi_= ulong end_addr;
+ =C2=A0 =C2=A0uint64_t addr;
+ =C2=A0 =C2=A0uint64_t= end_addr;
=C2=A0 =C2=A0 =C2=A0int prot;
=C2=A0 =C2=A0 =C2=A0int loop= ed =3D 0;
=C2=A0
My question is, is this the right fix? The ol= d code avoided the overflow in two ways. 1 it set reserve_va to a page shor= t (which if I fix that, it works better, but not quite right). and it never= computes an address that may overflow (which the new code does without the= above patch).

It seems to work, but it looks supe= r weird.

Comments?

Warrne= r
--00000000000059435d05feda6384--