From nobody Thu May 2 22:38:32 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1638463985; cv=none; d=zohomail.com; s=zohoarc; b=YjCKZQnHCngPuu0WrDA9Ir7ZaVtnA0LicpT5pHjbGu7AGwIHTo3bbXdqe7aUzH5oYi1N7IpuE1i9K7UneEzJYNi117IrhXVO3H0GBywXYmJ+FRGr6Tk7+oaJNeCKNvUHJWbUn+9GHummGqOgxbYKbe1DcvoIKJyoQs/g+2Y7n7g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1638463985; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=/+pYBHWwoVbB7dUwLy+g2yXoaXy5z2uXR7Do0ZlzUbk=; b=dFG0RxzCVD7KVN13Zgtvinz1gTGsl636v1fAKH9npFhrQVlFnbOFmwBuOU5Y/JzAwQstFpgKRYGCiWWAFtt/JTwqKeyQISyJcqou6SA8oTDxVeaT6wy5Lnzze+R7eXyvScvz504Bmtr0b8rgqG9QCJOFawq90oSQ9thRbkn5Sos= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 163846398578127.572941915835145; Thu, 2 Dec 2021 08:53:05 -0800 (PST) Received: from localhost ([::1]:33836 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mspKS-00078G-Be for importer@patchew.org; Thu, 02 Dec 2021 11:53:04 -0500 Received: from eggs.gnu.org ([209.51.188.92]:56686) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mspFM-0000ZJ-Vn; Thu, 02 Dec 2021 11:47:49 -0500 Received: from [2a00:1450:4864:20::52d] (port=42801 helo=mail-ed1-x52d.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mspFI-0005UC-CA; Thu, 02 Dec 2021 11:47:46 -0500 Received: by mail-ed1-x52d.google.com with SMTP id r11so434922edd.9; Thu, 02 Dec 2021 08:47:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/+pYBHWwoVbB7dUwLy+g2yXoaXy5z2uXR7Do0ZlzUbk=; b=e2gg/V3ULVDWGzQiEpuPnOwsg98rKtfLrjoyZnvW0D4MSvARs614YyyQ8rlWGC82Os z0PSHUZIhZScVWjdXSdewXR9FevpI9tpZCj7WRBNUnjn8n/M5Kurp3WmDdPhJ6MMqPAv 5f1xbIvA8GxAL94FSHFgAK0+rftI684r6mak9whrsV9NbePe2AP7W5oxkMHCyeMnMBp1 kUtns+/Pbpk43BKnY9hJQAUa52s87e8Eplxd6RTIyIec4RrKfDI9njd3Vc0WxptT/wmv Rcv1sOntwNXfeoTJRBVA6Pe3QGs2Wh8RFzEIVKEC1KT/Dcu/Om4HWbe8BNpHu7ThI6oq 0V9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/+pYBHWwoVbB7dUwLy+g2yXoaXy5z2uXR7Do0ZlzUbk=; b=33yjFhoMJHqo0iVIaip1m4n/WH9bSCHX+avHXFHGbC5FugmXKzmvTpasQ8WVGw84+j wAIJ8BkHrCsjRw4BW5bfI7TGuKwKlnG86McYcP78GdbBV9PoZV5a2lqsX9Z9iGY/8xiD leCm4LRvaV2blVGU+xXdvRXNKVdgYGkXJwHR9srARz7EFeQZlTce+FTzNCkgEkjtYUKm 4XiZkN9aOjsTpIfZOqU1URZF4Bu19mmj3keiruaF/+TPC35PReebJayeXgBVvvrUm6tF VMBUKJ829jOOKpwcUNbhWAejG0DkqdnL7yaGD5nuLbDUZskMGaC9wXKu4rOdJeq9ML8K ZyRg== X-Gm-Message-State: AOAM532w94T7u2FEXdk68zWvYSJHnj6XMGiN5+calLCu61d986wUdb7p MPYA8iCAfv8yqbn2skOjp7zA+7lE8E9aFhh7L5F/tu9wj4Y= X-Google-Smtp-Source: ABdhPJy1agj58JrKBURoJDugkYptifiAT6Vo80u5cTMPuruDpfdWO4nbNYedSI4MuPCilzzwGERFjnQbPv5XX6CRmw4= X-Received: by 2002:aa7:c714:: with SMTP id i20mr18856455edq.180.1638463660464; Thu, 02 Dec 2021 08:47:40 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Mark Mielke Date: Thu, 2 Dec 2021 11:47:29 -0500 Message-ID: Subject: Fwd: [PATCH] virtio-blk: Fix clean up of host notifiers for single MR transaction. To: qemu-stable@nongnu.org, Stefan Hajnoczi , Kevin Wolf , Hanna Reitz , qemu-block@nongnu.org, qemu-devel@nongnu.org X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::52d (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::52d; envelope-from=mark.mielke@gmail.com; helo=mail-ed1-x52d.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Greg Kurz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1638463986364100001 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Sorry... I missed copy maintainers and qemu-stable. This should be considered a regression. Reviewed-by: Ani Sinha ---------- Forwarded message --------- From: Mark Mielke Date: Thu, Dec 2, 2021 at 11:26 AM Subject: [PATCH] virtio-blk: Fix clean up of host notifiers for single MR transaction. To: The code that introduced "virtio-blk: Configure all host notifiers in a single MR transaction" introduced a second loop variable to perform cleanup in second loop, but mistakenly still refers to the first loop variable within the second loop body. Fixes: d0267da61489 ("virtio-blk: Configure all host notifiers in a single MR transaction") Signed-off-by: Mark Mielke --- hw/block/dataplane/virtio-blk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/block/dataplane/virtio-blk.c b/hw/block/dataplane/virtio-bl= k.c index 252c3a7a23..ee5a5352dc 100644 --- a/hw/block/dataplane/virtio-blk.c +++ b/hw/block/dataplane/virtio-blk.c @@ -222,7 +222,7 @@ int virtio_blk_data_plane_start(VirtIODevice *vdev) memory_region_transaction_commit(); while (j--) { - virtio_bus_cleanup_host_notifier(VIRTIO_BUS(qbus), i); + virtio_bus_cleanup_host_notifier(VIRTIO_BUS(qbus), j); } goto fail_host_notifiers; } -- 2.33.1 --=20 Mark Mielke