From nobody Wed Nov 5 02:58:20 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1532434986363506.52056710600414; Tue, 24 Jul 2018 05:23:06 -0700 (PDT) Received: from localhost ([::1]:40168 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fhwLJ-0007bt-Dm for importer@patchew.org; Tue, 24 Jul 2018 08:23:05 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37725) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fhwKB-0007AR-44 for qemu-devel@nongnu.org; Tue, 24 Jul 2018 08:21:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fhwKA-0008Ia-6u for qemu-devel@nongnu.org; Tue, 24 Jul 2018 08:21:55 -0400 Received: from mail-lj1-x230.google.com ([2a00:1450:4864:20::230]:33317) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fhwK7-0008Hi-Fg; Tue, 24 Jul 2018 08:21:51 -0400 Received: by mail-lj1-x230.google.com with SMTP id s12-v6so3398490ljj.0; Tue, 24 Jul 2018 05:21:51 -0700 (PDT) Received: by 2002:a2e:309:0:0:0:0:0 with HTTP; Tue, 24 Jul 2018 05:21:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to:cc :content-transfer-encoding; bh=r96ClO0nJ8cLFDfP22K9iIosr0rFND5mgnkBBI/8LoU=; b=DS8s0rgk1BN5ofLgOHLRHnSz5PwWz2JVMP8fvo2Sgmc/eN4Z+dSD7NQgwZVhde5jee 6lzfsZGliHZ0OVj19nqfv7XWFFs65r7QHUz0lwyIJY2TfGZ/A9NiXwioERssthEMaPaP AJv3gVmf8h95dw26KefJPtOKJKXWkb5axE6uqvsuJzDMzbp1eveL3whwwmseSCHAkOS+ fq82lXATAyI2FFVtDA7eMV2n1S4QgYNVvUmxO6zVVNNEqzW7eTpUlOoEKQ4fdavNq5ge Pte16xupBrZ0+9g2DObnxbah2lLCtYsF4NlrmPCfnF+FdqkLg9dfu/v8J1xDeUFSUJs1 ua9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc :content-transfer-encoding; bh=r96ClO0nJ8cLFDfP22K9iIosr0rFND5mgnkBBI/8LoU=; b=bJR7q9AECXfFJwUzOBv3p8QanjmVaReGPOGPA0VSLwU81jRCl8IUmizygNIVz5L1dE IE711v33692EisraSiYSHny8ZpLvRChZxM8CvSeUwy91s7YXG7aMdaoXQNXb7yxWmNSf tf0/Bky5Yz93L8mj7y2eUrOOwsQaxBXAfAVLcFEe7ggIw6/l3D4n5MwNm6aSb2q35mHh SK06PWiGMwCCaL8BwY81x6K8+8YqcE+GwnzBr0zolSRUl9Yp6sBG/Dy0aRNd38GIQB5o FlffN7Ndt2cUmHOd0wm8jOPD3k5H/p7tGcnXS9WHgAVU6gzVG7lHNarpqCVa9kCmIdPU 9uHw== X-Gm-Message-State: AOUpUlEwWAkqtzpQVh+xmQOtDzxoHtcCNPgb43np9MupaTJAM0Xj0CPc Yzf8QT9PgBG1dVThaQrSKDx2F593XpMbbx7VMg7UdUTx X-Google-Smtp-Source: AAOMgpds+9oXTzVd/VBOr0tDLEcyWbL47dm+sldoq349WnEezxpmA5cF/gOj93TMhf947O+/RJOPytIZvuLJIUW1W/M= X-Received: by 2002:a2e:7014:: with SMTP id l20-v6mr12552273ljc.141.1532434909559; Tue, 24 Jul 2018 05:21:49 -0700 (PDT) MIME-Version: 1.0 From: Jason Andryuk Date: Tue, 24 Jul 2018 08:21:49 -0400 Message-ID: To: qemu-stable@nongnu.org, qemu-devel@nongnu.org Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::230 Subject: [Qemu-devel] Stable 2.12.1 Request: "ccid-card-passthru: fix regression in realize()" X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: marcandre.lureau@redhat.com, Gerd Hoffmann , mdroth@linux.vnet.ibm.com, f4bug@amsat.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" I'd like to request this commit for QEMU 2.12.1 stable backport: commit e58d64a16abc "ccid-card-passthru: fix regression in realize()" The patch fixes a VM start failure which I experience on 2.12.0. Patch inlined below Thanks, Jason From e58d64a16abc2304c4dcb644411eb9580bf63b1e Mon Sep 17 00:00:00 2001 From: =3D?UTF-8?q?Marc-Andr=3DC3=3DA9=3D20Lureau?=3D Date: Tue, 15 May 2018 17:30:39 +0200 Subject: [PATCH] ccid-card-passthru: fix regression in realize() MIME-Version: 1.0 Content-Type: text/plain; charset=3DUTF-8 Content-Transfer-Encoding: 8bit Since cc847bfd16d894fd8c1a2ce25f31772f6cdbbc74, CCID card-passthru fails to intialize, because it changed a debug line to an error, probably by mistake. Change it back to a DPRINTF debug. (solves Boxes creating VM with smartcard passthru failing to start) Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-id: 20180515153039.27514-1-marcandre.lureau@redhat.com Signed-off-by: Gerd Hoffmann --- hw/usb/ccid-card-passthru.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/usb/ccid-card-passthru.c b/hw/usb/ccid-card-passthru.c index 7684db0cb3..25fb19b0d7 100644 --- a/hw/usb/ccid-card-passthru.c +++ b/hw/usb/ccid-card-passthru.c @@ -345,7 +345,7 @@ static void passthru_realize(CCIDCardState *base, Error **errp) card->vscard_in_pos =3D 0; card->vscard_in_hdr =3D 0; if (qemu_chr_fe_backend_connected(&card->cs)) { - error_setg(errp, "ccid-card-passthru: initing chardev"); + DPRINTF(card, D_INFO, "ccid-card-passthru: initing chardev"); qemu_chr_fe_set_handlers(&card->cs, ccid_card_vscard_can_read, ccid_card_vscard_read,