From nobody Tue Feb 10 10:18:09 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=umich.edu ARC-Seal: i=1; a=rsa-sha256; t=1665613394; cv=none; d=zohomail.com; s=zohoarc; b=QbPWMXC20Lqojas+GYb1NYpGUoaEFerCkULrr+/G5sr3zKceOZxGVVbJ3a305nKJ1gfa9my37T3qAhx5mlA8WnJ/RfIsQoe3eSbCzHL/XcyGBgQ9j85m0PHFjU26KuyXihnprpR2NRN4Esf5e1bM1vhnuXuhZBAHDW69LZeHXHM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1665613394; h=Content-Type:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=KkHguknvAFk7BEm9X9Q7YbQ0YifkJ0YknRfDZIpP6m0=; b=BY8gvuyuCPLX9nxHMH71H7mImhCWOvCSIxDGPWQ2rAhBa+IWkREJqmfOIiKa3F+9tfWYj+hbZv8c7v3B7uN8ZRP1Qn8TCty6uF1EfXWNS2Bipw6IVZrnfcvE384PFUX9vKiLYAH3fF6lrHUYZd6F8QPw514kSY098eirFf9wyfM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1665613393947137.50939654120157; Wed, 12 Oct 2022 15:23:13 -0700 (PDT) Received: from localhost ([::1]:35360 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oik87-0000br-Ff for importer@patchew.org; Wed, 12 Oct 2022 18:23:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48140) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oijtl-0006JI-DG for qemu-devel@nongnu.org; Wed, 12 Oct 2022 18:08:21 -0400 Received: from mail-yb1-xb36.google.com ([2607:f8b0:4864:20::b36]:36748) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oijti-000227-7L for qemu-devel@nongnu.org; Wed, 12 Oct 2022 18:08:19 -0400 Received: by mail-yb1-xb36.google.com with SMTP id 126so62528ybw.3 for ; Wed, 12 Oct 2022 15:08:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=umich.edu; s=google-2016-06-03; h=cc:to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=KkHguknvAFk7BEm9X9Q7YbQ0YifkJ0YknRfDZIpP6m0=; b=dmOyThPaD4Sg/qN5e9vGIj0g2ntJJzxIDs0rw0pISOuQ8t9ejgslWEV08skLiDtKAM Oh8Z28PEG2sVjBow64sxY9T3vDcR9ZULkI9tb+ceMWXpGrRtvUH5Lqsl5nJLHzqxre/T Op0b8ct7lzABhJcUAPAkKNt0VR87LyCieMN1j+U57QTgtF6z8j3PbYEgWVF7GcQRJO22 lysWn4MHovwWUAZXlguYgPOXLJYDT0EZ1YVClmBB1n7jLJXZ9VcFr6DJFyGni600Ic7h Oxz1+YOqGcgbtXiVQfNfD6yxw3XJNgey2g5178PL7HevBU2RL3unQRW4+Q4CDiDT9iE4 6/ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=KkHguknvAFk7BEm9X9Q7YbQ0YifkJ0YknRfDZIpP6m0=; b=DNUXquqGZYeZwvu04gBUnVz85BAbLIHW/pB0P5SAsbs0jT7rTnFVGHLx/uMio0SQIg GWgKeGOgaxShbMrmgat4L8LzcXOf4VvYJ4UWcx3coz93q5atreAjX7q7Gd2ItTzekEXB FQeqiVcKo5NvcF5nYllI9f7GGXLy+hzlvhh//PMs6CngJipWL0FCpMbVnATR1EzT9mfG +QjbVReZZrI1A2Sg9KFekJTqPMs9bxFi+ygF+vRD3Pjt3o2gKWLwb+Bjwqx0kP/iNyK8 Jbp7xWHQ0GbCttQshoGbI96gXRbjDiepZZNmHLNPedchZ+WTdLw7rvjCrE8etOLudzus RKJA== X-Gm-Message-State: ACrzQf1xixX3W3CW3oN+Nqe7zJi6QVZkjfvmc8GzDZHU+6ATvrUTMh3j 8ez9EFH6xakmgrXi1OvwSPE1Us943Bj//ndARiAdokCU3KgRaw== X-Google-Smtp-Source: AMsMyM4y2jlRpqz7QkGFqjWPV/aL2mPv5SarBXlUlMyBieAIgI0zQgUQu/w0lMbSrAJE5S8vky3Ue7qF+wz5T4+1Vx8= X-Received: by 2002:a5b:a0f:0:b0:691:6fea:deda with SMTP id k15-20020a5b0a0f000000b006916feadedamr30106867ybq.377.1665612493341; Wed, 12 Oct 2022 15:08:13 -0700 (PDT) MIME-Version: 1.0 From: Christopher Wrogg Date: Wed, 12 Oct 2022 18:08:02 -0400 Message-ID: Subject: [PATCH v2] Properly sign extend BBIT branch offset during calculation To: qemu-devel@nongnu.org Cc: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , Aurelien Jarno , Jiaxun Yang , qemu-trivial@nongnu.org, Aleksandar Rikalo Content-Type: multipart/alternative; boundary="000000000000ffd8dd05eadda0bc" Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::b36; envelope-from=cwrogg@umich.edu; helo=mail-yb1-xb36.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Wed, 12 Oct 2022 18:21:53 -0400 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @umich.edu) X-ZM-MESSAGEID: 1665613395997100001 Content-Transfer-Encoding: quoted-printable --000000000000ffd8dd05eadda0bc MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 VGhlIE9jdGVvbiBzcGVjaWZpYyBCQklUIGluc3RydWN0aW9uIGluY29ycmVjdGx5IGNvbXB1dGVz CnRoZSBicmFuY2ggb2Zmc2V0LiBUaGUgMTYgYml0IHZhbHVlIGlzIG5vdCBzaWduIGV4dGVuZGVk LgoKU2lnbmVkLW9mZi1ieTogQ2hyaXN0b3BoZXIgV3JvZ2cgPGN3cm9nZ0B1bWljaC5lZHU+ClJl c29sdmVzOiBodHRwczovL2dpdGxhYi5jb20vcWVtdS1wcm9qZWN0L3FlbXUvLS9pc3N1ZXMvMTI1 MQotLS0KIHRhcmdldC9taXBzL3RjZy9vY3Rlb25fdHJhbnNsYXRlLmMgfCA1ICsrKystCiAxIGZp bGUgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEv dGFyZ2V0L21pcHMvdGNnL29jdGVvbl90cmFuc2xhdGUuYwpiL3RhcmdldC9taXBzL3RjZy9vY3Rl b25fdHJhbnNsYXRlLmMKaW5kZXggNmEyMDdkMmU3ZS4uOTBmN2IxMDVjYiAxMDA2NDQKLS0tIGEv dGFyZ2V0L21pcHMvdGNnL29jdGVvbl90cmFuc2xhdGUuYworKysgYi90YXJnZXQvbWlwcy90Y2cv b2N0ZW9uX3RyYW5zbGF0ZS5jCkBAIC0zOCw3ICszOCwxMCBAQCBzdGF0aWMgYm9vbCB0cmFuc19C QklUKERpc2FzQ29udGV4dCAqY3R4LCBhcmdfQkJJVCAqYSkKICAgICB9CgogICAgIGN0eC0+aGZs YWdzIHw9M0QgTUlQU19IRkxBR19CQzsKLSAgICBjdHgtPmJ0YXJnZXQgPTNEIGN0eC0+YmFzZS5w Y19uZXh0ICsgNCArIGEtPm9mZnNldCAqIDQ7CisgICAgYS0+b2Zmc2V0ICo9M0QgNDsKKyAgICBh LT5vZmZzZXQgPTNEICh0YXJnZXRfbG9uZykoaW50MTZfdClhLT5vZmZzZXQ7CisgICAgY3R4LT5i dGFyZ2V0ID0zRCBjdHgtPmJhc2UucGNfbmV4dCArIDQgKyBhLT5vZmZzZXQ7CisKICAgICBjdHgt PmhmbGFncyB8PTNEIE1JUFNfSEZMQUdfQkRTMzI7CgogICAgIHRjZ190ZW1wX2ZyZWUodDApOwot LT0yMAoyLjMwLjI= --000000000000ffd8dd05eadda0bc Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
The Octeon specific BBIT instruction incorrectly computes<= br>the branch offset. The 16 bit value is not sign extended.

Signed-= off-by: Christopher Wrogg <cwrogg@um= ich.edu>
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1251
= ---
=C2=A0target/mips/tcg/octeon_translate.c | 5 ++++-
=C2=A01 file c= hanged, 4 insertions(+), 1 deletion(-)

diff --git a/target/mips/tcg/= octeon_translate.c b/target/mips/tcg/octeon_translate.c
index 6a207d2e7e= ..90f7b105cb 100644
--- a/target/mips/tcg/octeon_translate.c
+++ b/ta= rget/mips/tcg/octeon_translate.c
@@ -38,7 +38,10 @@ static bool trans_BB= IT(DisasContext *ctx, arg_BBIT *a)
=C2=A0 =C2=A0 =C2=A0}
=C2=A0
= =C2=A0 =C2=A0 =C2=A0ctx->hflags |=3D MIPS_HFLAG_BC;
- =C2=A0 =C2=A0ct= x->btarget =3D ctx->base.pc_next + 4 + a->offset * 4;
+ =C2=A0 = =C2=A0a->offset *=3D 4;
+ =C2=A0 =C2=A0a->offset =3D (target_long)= (int16_t)a->offset;
+ =C2=A0 =C2=A0ctx->btarget =3D ctx->base.p= c_next + 4 + a->offset;
+
=C2=A0 =C2=A0 =C2=A0ctx->hflags |=3D = MIPS_HFLAG_BDS32;
=C2=A0
=C2=A0 =C2=A0 =C2=A0tcg_temp_free(t0);
--=
2.30.2
--000000000000ffd8dd05eadda0bc--