From nobody Mon May 6 19:47:26 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=google.com ARC-Seal: i=1; a=rsa-sha256; t=1616811155; cv=none; d=zohomail.com; s=zohoarc; b=G0AR5FmSJhfHBsvcxdMLtrCJ7Yw0im0yUPx2qNsJxGZpmDqkymO4oV49JR0WUE1VwIJySflhwVl/JJx1mmE3UGkG4VdjkJgOFkIEKwZmakefZfZYgklyjXKAP6Dq8kkvi6Uc4YSPbb7FTkSr5R+4de+eCS7sUTe1fbJBuzFQzug= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1616811155; h=Content-Type:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=OYrqYVdzc32IvKcljuu1ZRbBtOX9g/8hiUl5rwHloFs=; b=EoH+1/cg8aJpq9FpcPhmevWnUxCIaayaIt0F15faKkFQ6ANYRDC6Z4U6hHsXtrXhukXs3wNV8BFo3h28gHOmmVo6agmAxtcJRk6GGsUitk9rOF/4SHzC9spXFuRz2MBjSnC5Jwm49ODeIeh+s7GzlNPaOOsB+CGfI443ViTmqm0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1616811155737207.7353611169558; Fri, 26 Mar 2021 19:12:35 -0700 (PDT) Received: from localhost ([::1]:54566 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lPyRF-0006oo-Eo for importer@patchew.org; Fri, 26 Mar 2021 22:12:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60822) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lPyQK-0006Pk-Cy for qemu-devel@nongnu.org; Fri, 26 Mar 2021 22:11:36 -0400 Received: from mail-il1-x134.google.com ([2607:f8b0:4864:20::134]:45014) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lPyQI-0005Rj-TM for qemu-devel@nongnu.org; Fri, 26 Mar 2021 22:11:36 -0400 Received: by mail-il1-x134.google.com with SMTP id t6so6580604ilp.11 for ; Fri, 26 Mar 2021 19:11:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:from:date:message-id:subject:to:cc; bh=OYrqYVdzc32IvKcljuu1ZRbBtOX9g/8hiUl5rwHloFs=; b=nEM01qKTTeQ6KwMOwDJQmV4dWRS/rIEchD9+vVgXhSTe8u7Ajx8McG11gn8aUBmtyc PY11loMVQgnwUYbBEb6jwm1qNNxR69aXcuBL7KTYS0hdb3T9Xmsf1t80+0M1e7lF9bfK mgX+5obbhEq4DaxatmaZy2pUDTfYVTKqaVfcKkyMlZSufvNQvRE0I6hAgotvBqHljwhp gZQCD+jazkBi9Gv1xCmqVF/6SfnQODDz1ORmC8Jk2mA/W7Ruu0ZH/QdPQtiWF6FyOzS0 jsPwwoCxdrTHud4EwPa+g+dXqLy3jID3SOEVMFYdadstQkx/9iLqx7PgBm6/743cY2yK JxIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=OYrqYVdzc32IvKcljuu1ZRbBtOX9g/8hiUl5rwHloFs=; b=NNZ57p9Tjl/Cp3BAe1fF35N7MTcj6lsFS8Kfj6lrQRsuEJkmIuqw7jmp4wG77Ei0dX tZ1uSOgADa+K+A6zVSV6ip6HyxawTeyRY1BBw0laF6kXBgWzfHaCQH5lBitwMppXVYi8 geqxYTzeaxXAUI9qX88VhaQ08vzQmK3xQXm5BGYz/Kf+mefQoiBoJG/mPUM4Ty203VN1 OuSxx985GSzBKWMNqIG8Zz2AlCyeCe6A6q7nPCErNuYXHLCYNnskzYyri/EjGSV22/87 pS/fKQO5/k4cZ1dq1GcGOrAphZkwWU+NBTU7jr1D5z4Gp71my7CARFM0deOR1T8voUhW GL2g== X-Gm-Message-State: AOAM530oSdgWXR3VHdqhS90+MglYcryBGz9pfKpD+9mdw/wX+WgLlxRp CmsTDTAz34CCVkugdiTGQjh/YQKcqVap90PQMguSlwhUccYk1w== X-Google-Smtp-Source: ABdhPJx997yxSIl3E/LzB/8mCKIh2fN6RdVEgUUV/IhtOXpbd1XJFmwIgkHnajk8pGNDTpt0wMdTO28QR6z0ifkyeSQ= X-Received: by 2002:a05:6e02:1348:: with SMTP id k8mr13639117ilr.277.1616811093498; Fri, 26 Mar 2021 19:11:33 -0700 (PDT) MIME-Version: 1.0 From: Zach Reizner Date: Fri, 26 Mar 2021 22:11:16 -0400 Message-ID: Subject: [PATCH v2] linux-user: allow NULL msg in recvfrom To: qemu-devel@nongnu.org Cc: Laurent Vivier , peter.maydell@linaro.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::134; envelope-from=zachr@google.com; helo=mail-il1-x134.google.com X-Spam_score_int: -175 X-Spam_score: -17.6 X-Spam_bar: ----------------- X-Spam_report: (-17.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5, USER_IN_DEF_SPF_WL=-7.5 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @google.com) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The kernel allows a NULL msg in recvfrom so that he size of the next message may be queried before allocating a correctly sized buffer. This change allows the syscall translator to pass along the NULL msg pointer instead of returning early with EFAULT. Signed-off-by: Zach Reizner Reviewed-by: Laurent Vivier --- v2: - return -TARGET_EFAULT on non-null invalid msg pointer linux-user/syscall.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 1e508576c7..294779c86f 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -3679,9 +3679,14 @@ static abi_long do_recvfrom(int fd, abi_ulong msg, size_t len, int flags, void *host_msg; abi_long ret; - host_msg =3D lock_user(VERIFY_WRITE, msg, len, 0); - if (!host_msg) - return -TARGET_EFAULT; + if (!msg) { + host_msg =3D NULL; + } else { + host_msg =3D lock_user(VERIFY_WRITE, msg, len, 0); + if (!host_msg) { + return -TARGET_EFAULT; + } + } if (target_addr) { if (get_user_u32(addrlen, target_addrlen)) { ret =3D -TARGET_EFAULT; --=20 2.31.0.291.g576ba9dcdaf-goog