From nobody Fri May 3 12:18:44 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1490974171324435.6582682496356; Fri, 31 Mar 2017 08:29:31 -0700 (PDT) Received: from localhost ([::1]:41582 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ctyUT-0000ND-VM for importer@patchew.org; Fri, 31 Mar 2017 11:29:29 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54607) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ctyTa-0008HU-9E for qemu-devel@nongnu.org; Fri, 31 Mar 2017 11:28:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ctyTZ-0004D6-8J for qemu-devel@nongnu.org; Fri, 31 Mar 2017 11:28:34 -0400 Received: from mail-vk0-x244.google.com ([2607:f8b0:400c:c05::244]:33900) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ctyTY-0004CP-Uw for qemu-devel@nongnu.org; Fri, 31 Mar 2017 11:28:33 -0400 Received: by mail-vk0-x244.google.com with SMTP id y16so11904207vky.1 for ; Fri, 31 Mar 2017 08:28:32 -0700 (PDT) Received: by 10.103.86.88 with HTTP; Fri, 31 Mar 2017 08:28:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dgtlrift-com.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=okmGTL47Q0FPkD5AHsb7hGEL0QK95oQmXP/XqhPfORM=; b=QW3f+EoVZGxPVC74rHQp/VIVO77lFmX5vWOvzPHfTeITKYYloBZF4WWNWIu3xuJ404 rWBzEz8brFcH6snf7ZCBFf7DZM2sdigwE5VcVjM35IcuMj+eDaTAw0IRxFF0MeIXXYIY +CV14yTOyxa8UcvuUEUlouneJahpeQxlS0vYOcYmu/5lPHqz0vgUDHi8+DJEllN5PW/W EEXidC3Pn9VcBV/IUFICckphI4Et+LXMeRerQ43DJN7mq1vf43ZSktoIUaqzS1kpWp53 LLLC15Ty64/kSfaiID3tROSFBKzNLiuo4Mt+Q9WPVk+/HIe33On8hEfJu+6IfQDDh66t gzMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=okmGTL47Q0FPkD5AHsb7hGEL0QK95oQmXP/XqhPfORM=; b=T1HSPn2RkiTdbwqte4nc6ae82tQUYoXEmixYrAodK1hYWWHl+Id5cwo+ejgd7c4hN1 RFbchIBzBj3RgdCJijMG5AtWKgrOLd8fxF5xaJ9JqjaIE98s9S75LES2A+x3uCJA+v7f AcexeY6P5bLMUHwBpTUWrkoj45ouaA0n8Y2bOY41I4tUcsfNs8yiH3MdtHI8jKUDk65X lmzx+F5FohYO8zUT6TBcCuQQPPjSDvJqYLgVcT3sg/niG5l8DSeWjwTbBEEtrgGgYFgb WIhKp+nDyC5DlQa8LZvERqoIrgg2DgcIZ54WgpkuGUoHTrzDyJWJahol+XDk8jbVdEif bP4g== X-Gm-Message-State: AFeK/H0+SM7gdKiwrL6lJPhldRcK0ajh1DhrAANemO71Q7FwMATOuLqaBsaDDhcKOXKinKKpk+WxHbln5ZEF9A== X-Received: by 10.159.37.34 with SMTP id 31mr1544619uaz.50.1490974112230; Fri, 31 Mar 2017 08:28:32 -0700 (PDT) MIME-Version: 1.0 From: James Hanley Date: Fri, 31 Mar 2017 11:28:31 -0400 Message-ID: To: Alistair Francis , Peter Crosthwaite , qemu-devel X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400c:c05::244 X-Content-Filtered-By: Mailman/MimeDel 2.1.21 Subject: [Qemu-devel] MTD timeout on bootup X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When trying to bootup a pristine zync image from the zc702 tarball, it would always fail with the MTD detection of the serial flash device type command over the SPI. I believe this section of code may have the logic flipped. Once I changed it to the following, I was able to detect the flash type when booting the pristine image from Xilinx. -Jim From baaaacca370c13526fd2b8c7b33c7d9e8a6d7b8d Mon Sep 17 00:00:00 2001 From: Jim Hanley Date: Thu, 23 Mar 2017 10:29:34 -0400 Subject: [PATCH] MTD writes from the SPI were never being dequeue... Signed-off-by: --- hw/ssi/xilinx_spips.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/ssi/xilinx_spips.c b/hw/ssi/xilinx_spips.c index da8adfa..a3af1f7 100644 --- a/hw/ssi/xilinx_spips.c +++ b/hw/ssi/xilinx_spips.c @@ -482,8 +482,8 @@ static void xilinx_spips_write(void *opaque, hwaddr addr, s->regs[addr] =3D (s->regs[addr] & ~mask) | (value & mask); no_reg_update: xilinx_spips_update_cs_lines(s); - if ((man_start_com && s->regs[R_CONFIG] & MAN_START_EN) || - (fifo8_is_empty(&s->tx_fifo) && s->regs[R_CONFIG] & MAN_START_EN)) { + if (!((man_start_com && s->regs[R_CONFIG] & MAN_START_EN) || + (fifo8_is_empty(&s->tx_fifo) && s->regs[R_CONFIG] & MAN_START_EN))) { xilinx_spips_flush_txfifo(s); } xilinx_spips_update_cs_lines(s); --=20 2.7.4