From nobody Thu Nov 6 12:16:23 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1542180367395853.6568775421931; Tue, 13 Nov 2018 23:26:07 -0800 (PST) Received: from localhost ([::1]:58643 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gMpYs-0004ss-3B for importer@patchew.org; Wed, 14 Nov 2018 02:26:06 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45920) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gMmyh-0005u1-PW for qemu-devel@nongnu.org; Tue, 13 Nov 2018 23:40:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gMmyg-0007Iy-Ef for qemu-devel@nongnu.org; Tue, 13 Nov 2018 23:40:35 -0500 Received: from mail-oi1-x242.google.com ([2607:f8b0:4864:20::242]:37781) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gMmyg-00079T-6w for qemu-devel@nongnu.org; Tue, 13 Nov 2018 23:40:34 -0500 Received: by mail-oi1-x242.google.com with SMTP id y23so3381458oia.4 for ; Tue, 13 Nov 2018 20:40:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to:cc; bh=j2KRHg4wJv/KnfVuhrTdjmJ4nROHalfMgQOtcUlJJoY=; b=C6g6wJdBWePELWHomyCMv6h8ciaW4kCF8yQj//ZGPwW+sg89tO5VW/W5cFja8e2i75 jMHoaCKAFH4nNMiSzYBF32iK3oQjbri/gNhtJun0A/SiR6Wli2u6GUMuhHkkbaHpanAZ Mt9bEQu5TglfBNoQHg4qfTjZYR3iIEDEpbD/F4SkGozllc++NFkMOUVYgYGg5PaIvfOa LtOZ0uFbQAE9S82D0KWoIsQaqw5VdBuS40T6HfBEgFPe2YBFlCUZXpXNF425BZXa2i9t DBogt9M+UmTy91PBbBjJJA8imNUQRCaahWucKBLWLPe/CxYc0tZdqY2xUIjeNVBDg4qH qmsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=j2KRHg4wJv/KnfVuhrTdjmJ4nROHalfMgQOtcUlJJoY=; b=iqqELfEa568mFgUe8hZ9rBupdlbKG9aKF/+6wdiHnRZWqcxXEvvpaa0uo3jJpB2QkA 2xwMiZDMTFIrdSzKOPX2UuSSTOmU86lXkekNc9/DeItV24C5CVbF7bhBEbALZA+DFa2B g5WfKpJ9w0q63pC4lWxSMfeQmo9dbAqLh3U/2K0eghbidH7NrzAuO5gv3etIIkAwF4ld X4CVw/bweJiK7JPkb9xaLuoKZv5WcFLxfroTGGPuup4UDYfFIvU7VUt3r4J32KTwNoZk brMvZNaZR3XiMQ1H45eKKEhtxsNekCK2lnwrca8qIMbg1q7iXFdb9T5n3TRSHtwshUq1 4RBg== X-Gm-Message-State: AGRZ1gKBL+h2E73pMFEJ6GTJWemobR2zlt32SCGOuKFQTFR4senSKYP+ 4xSuFcASqGmeTuYzrfG67+mxY1amL8JazCZbSRU= X-Google-Smtp-Source: AJdET5edT+4vrVWvjoy87KL9OxslLTomQ6j8lNjMmKrhEdBk6/qTIfapvbVhYjBMecbs2bOYXksiyBBH1BP7XehezM4= X-Received: by 2002:aca:b183:: with SMTP id a125-v6mr231148oif.44.1542170417773; Tue, 13 Nov 2018 20:40:17 -0800 (PST) MIME-Version: 1.0 From: Seth K Date: Sun, 4 Nov 2018 02:42:38 -0500 Message-ID: To: Alistair Francis , =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= , Paolo Bonzini X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::242 X-Mailman-Approved-At: Wed, 14 Nov 2018 02:24:36 -0500 X-Content-Filtered-By: Mailman/MimeDel 2.1.21 Subject: [Qemu-devel] [PATCH] Corrected memory regions X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "qemu-devel@nongnu.org Developers" Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" I corrected these 2 memory regions based on specifications from the chip manufacturer. The existing ranges seem to overlap and and cause odd behavior and/or crashes when trying to set up multiple UARTs, I also played with changing MAX_SERIAL_PORTS to 8 to match the hardware, but I did not include that in this patch as I never fully tested its effects. This is my first patch, I hope I did it correctly, Seth Kintigh --- hw/char/stm32f2xx_usart.c | 2 +- hw/timer/stm32f2xx_timer.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/char/stm32f2xx_usart.c b/hw/char/stm32f2xx_usart.c index 032b5fda13..f3363a2952 100644 --- a/hw/char/stm32f2xx_usart.c +++ b/hw/char/stm32f2xx_usart.c @@ -202,7 +202,7 @@ static void stm32f2xx_usart_init(Object *obj) sysbus_init_irq(SYS_BUS_DEVICE(obj), &s->irq); memory_region_init_io(&s->mmio, obj, &stm32f2xx_usart_ops, s, - TYPE_STM32F2XX_USART, 0x2000); + TYPE_STM32F2XX_USART, 0x400); sysbus_init_mmio(SYS_BUS_DEVICE(obj), &s->mmio); } diff --git a/hw/timer/stm32f2xx_timer.c b/hw/timer/stm32f2xx_timer.c index 58fc7b1188..ae744d1642 100644 --- a/hw/timer/stm32f2xx_timer.c +++ b/hw/timer/stm32f2xx_timer.c @@ -308,7 +308,7 @@ static void stm32f2xx_timer_init(Object *obj) sysbus_init_irq(SYS_BUS_DEVICE(obj), &s->irq); memory_region_init_io(&s->iomem, obj, &stm32f2xx_timer_ops, s, - "stm32f2xx_timer", 0x4000); + "stm32f2xx_timer", 0x400); sysbus_init_mmio(SYS_BUS_DEVICE(obj), &s->iomem); s->timer =3D timer_new_ns(QEMU_CLOCK_VIRTUAL, stm32f2xx_timer_interrup= t, s); --=20 2.11.0