From nobody Mon May 20 04:48:30 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1622299017; cv=none; d=zohomail.com; s=zohoarc; b=ngyp42RQTaKwpjCF2cWwic34rrJqPYtn1cdpGV/ngreu585UWPKC0M5IH2AmLhG65M8xSnt1pFOQPlT5taHrPFCXTnU+2/DZsa5DxBCNUg+6uK60MTbfNBoeL4tKNM5HM5eZFqQidrFiSxWAfYKjqbTNWQBumfXPJGYyrioV7mY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1622299017; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=ngTHq4uZ/3YhGRj3d1E2PZpFyjb2xsjU5E6Qfyp3oPA=; b=aelyNOhsoggYgPtpu2GabsyUljLbqdae/XypE+xjyXOUvGnfzY57u1E0/biTsJ3sqwfh8Mv8t24Q5+62ixwKjMylFfkcQBuoy/V/4MNwIKaDv4GUQ56/5GN15hMK6U9e/3jx2hpX1G1uGCGYPWzUvFivysLx/O63NsTnX6y226E= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1622299017035209.86327853544594; Sat, 29 May 2021 07:36:57 -0700 (PDT) Received: from localhost ([::1]:53710 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ln057-0001jz-UU for importer@patchew.org; Sat, 29 May 2021 10:36:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52992) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ln04T-000131-9b for qemu-devel@nongnu.org; Sat, 29 May 2021 10:36:13 -0400 Received: from mail-qt1-x82c.google.com ([2607:f8b0:4864:20::82c]:33527) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ln04Q-0000bK-CX for qemu-devel@nongnu.org; Sat, 29 May 2021 10:36:13 -0400 Received: by mail-qt1-x82c.google.com with SMTP id a15so4896753qta.0 for ; Sat, 29 May 2021 07:36:10 -0700 (PDT) Received: from [192.168.0.6] (d149-67-175-105.try.wideopenwest.com. [67.149.105.175]) by smtp.gmail.com with ESMTPSA id t12sm5288440qti.22.2021.05.29.07.36.08 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 29 May 2021 07:36:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:content-transfer-encoding:mime-version:subject:message-id:date :cc:to; bh=ngTHq4uZ/3YhGRj3d1E2PZpFyjb2xsjU5E6Qfyp3oPA=; b=qVHCW/Z1j30y6zsiPLLrW19RBZO6EDenptDoED4AYMBHeTM0Dz+/suD7cqvyKqus0D 19D0B++bIj7+mJKu1fPw6Q8+7lU9+BRBnEzp/9K/Od9moOH9RHPI/MuN6B9VkiccmDx2 hOj+9WMydL0vOYpm2o3C9WSI9HWEOLkXqeR2QD9kILnxiOqYoFfQgHOvaauhO5pp+Lnl 9XCR6DB1Qd7GOGTDJ1lDjF1TcJVpEPsMrrfQyUsfBa2JSokEeC23ZPAr96BwsRClSkHJ f7tfahyZmIB1+YH3MP498KmxuyXEzIb2Zmh5LZnjDfA3m4sfWYDjv/i3UWiw3u587h9o v19Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:content-transfer-encoding:mime-version :subject:message-id:date:cc:to; bh=ngTHq4uZ/3YhGRj3d1E2PZpFyjb2xsjU5E6Qfyp3oPA=; b=XLpD9hROZLFOFS2e/AKLu1sQTkyiUxaPRcCqtRUzwkrgX1Ip/nD2zqAWcz5yU1hhsl oovu6K7PHJ+XMkIyHz4/DWZFfjwqXUrUtfDEnDgTWX8NK6HES7/dKgkeBwTwcoH7mYS1 06UI8JbTouf8TKdHfyRqCx5dCuqSFOKMak81P9ADmSoEqJFxWdAv/SMWgWkWMeWHh5pX QqsVtdFqB4AtlSwGWkKW0Xi6W3rJHsS6/k/NKtTuosdVsJRNLuAGmyP+h08tBGys90NQ fM8kg/RW/L/LK2n9GcftqXjb8/n+UdpGMKgM5o0XpjeWusvSEo78MkEMQNdxEsjuay48 55Hg== X-Gm-Message-State: AOAM532fCzLNfUfgJeKqRovZaIPFeK/i7jR4QpIUI/oVQ7wYQiUoGb7U upfzWf2wXnjgeDT/9itmWKE= X-Google-Smtp-Source: ABdhPJyC6USeQIkmbnvHLKvCEMuMxGj1f722qoFDKMlgdqtjRd2qa3iZPNWvtpdO1a4Pn8qbJ98bSw== X-Received: by 2002:ac8:5bd5:: with SMTP id b21mr7780196qtb.317.1622298969403; Sat, 29 May 2021 07:36:09 -0700 (PDT) From: Programmingkid Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.40.0.2.32\)) Subject: ping: [PATCH] Set icon for QEMU binary on Mac OS Message-Id: Date: Sat, 29 May 2021 10:36:08 -0400 To: Peter Maydell , QEMU devel list X-Mailer: Apple Mail (2.3654.40.0.2.32) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::82c; envelope-from=programmingkidx@gmail.com; helo=mail-qt1-x82c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @gmail.com) Content-Type: text/plain; charset="utf-8" Ping,=20 please implement this patch. The default icon on Mac OS 11 is not very good= looking. https://lore.kernel.org/qemu-devel/20210202134410.9274-1-programmingkidx@gm= ail.com/ Before switching the build system over to Meson, an icon was added to the QEMU binary on Mac OS. This patch adds back that feature. Signed-off-by: John Arbuckle --- meson.build | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/meson.build b/meson.build index f00b7754fd..7f534f4e75 100644 --- a/meson.build +++ b/meson.build @@ -2183,6 +2183,26 @@ foreach target : target_dirs link_args: link_args, gui_app: exe['gui']) +# set QEMU's icon on Mac OS +if targetos =3D=3D 'darwin' + newiconpart1 =3D custom_target('Icon for ' + exe_name + ' - part 1', + depends : emulator, + input : emulator, + output : 'new icon for ' + exe_name + ' - 1', + command : ['Rez', '-append', + meson.source_root() + '/pc-bios/qemu.rsrc', '-o', + meson.current_build_dir() / exe['name']], + build_by_default : true) + + custom_target('Icon for ' + exe_name + ' - part 2', + depends : newiconpart1, + input : emulator, + output : 'new icon for ' + exe_name + ' - 2', + command : ['SetFile', '-a', 'C', + meson.current_build_dir() / exe['name']], + build_by_default : true) +endif + if exe_sign emulators +=3D {exe['name'] : custom_target(exe['name'], install: true, --=20 2.24.3 (Apple Git-128)