From nobody Mon Feb 9 07:43:26 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1591471433; cv=none; d=zohomail.com; s=zohoarc; b=FwKOadTwy1o54bkIf6pP1QHh3rJoYLpBxhyheph+IN5UwcbKchcIvPkn3zT5goVIIeEjcb8O1JiDZhU2fNT6zUXj1A3GyOSEjpWAVOUFFINGG8FSbj9K2L0fPURb3NbWzUxEyCNWS5CLW5KiBA5WHNvU37IB0jfZX6nh66LiY0o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1591471433; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=tNdqgjuv5p4EkwFpvwgiE8d9svILRtZ0dHCK6++Enog=; b=L8GQh9KmrOmPHTT/siZkvxoAWdVO107oGckivcaxqYSjGgX2qECoMTmX5IdjST7BD/Ikt8m02ad1SGcD1MlCB0Yb9ZeG6M/2IWMjMOdoYJhnwIUWNv50/MJK0r63pC9L1JddAQhSgmBGAf6+27I7NBqRvYcXRLdwN52AqH5/3M4= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1591471432612875.9807286984475; Sat, 6 Jun 2020 12:23:52 -0700 (PDT) Received: from localhost ([::1]:40910 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jheQ3-0008AT-Ao for importer@patchew.org; Sat, 06 Jun 2020 15:23:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41282) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jheP8-0007QN-Nk for qemu-devel@nongnu.org; Sat, 06 Jun 2020 15:22:54 -0400 Received: from zero.eik.bme.hu ([2001:738:2001:2001::2001]:30170) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jheP7-0006H4-B9 for qemu-devel@nongnu.org; Sat, 06 Jun 2020 15:22:54 -0400 Received: from zero.eik.bme.hu (blah.eik.bme.hu [152.66.115.182]) by localhost (Postfix) with SMTP id C773C748DCC; Sat, 6 Jun 2020 21:22:42 +0200 (CEST) Received: by zero.eik.bme.hu (Postfix, from userid 432) id 8721A7482CE; Sat, 6 Jun 2020 21:22:42 +0200 (CEST) Message-Id: <9fab4fe6513fe8b921ce86a57f4ff7e0d5a3c3f9.1591471056.git.balaton@eik.bme.hu> In-Reply-To: References: From: BALATON Zoltan Subject: [PATCH 4/4] sm501: Optimise 1 pixel 2d ops Date: Sat, 06 Jun 2020 21:17:36 +0200 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable To: qemu-devel@nongnu.org X-Spam-Probability: 8% Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2001:738:2001:2001::2001; envelope-from=balaton@eik.bme.hu; helo=zero.eik.bme.hu X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Sebastian Bauer , Magnus Damm , Gerd Hoffmann , Aurelien Jarno Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Some guests do 1x1 blits which is faster to do directly than calling a function for it so avoid overhead in this case. Signed-off-by: BALATON Zoltan --- hw/display/sm501.c | 40 +++++++++++++++++++++++++++++++++++++--- 1 file changed, 37 insertions(+), 3 deletions(-) diff --git a/hw/display/sm501.c b/hw/display/sm501.c index 3397ca9fbf..59693fbb5c 100644 --- a/hw/display/sm501.c +++ b/hw/display/sm501.c @@ -793,6 +793,25 @@ static void sm501_2d_operation(SM501State *s) src_x =3D=3D dst_x && src_y =3D=3D dst_y) { break; } + /* Some clients also do 1 pixel blits, avoid overhead for thes= e */ + if (width =3D=3D 1 && height =3D=3D 1) { + unsigned int si =3D (src_x + src_y * src_pitch) * (1 << fo= rmat); + unsigned int di =3D (dst_x + dst_y * dst_pitch) * (1 << fo= rmat); + switch (format) { + case 0: + s->local_mem[dst_base + di] =3D s->local_mem[src_base = + si]; + break; + case 1: + *(uint16_t *)&s->local_mem[dst_base + di] =3D + *(uint16_t *)&s->local_mem[src_base + = si]; + break; + case 2: + *(uint32_t *)&s->local_mem[dst_base + di] =3D + *(uint32_t *)&s->local_mem[src_base + = si]; + break; + } + break; + } /* Check for overlaps, this could be made more exact */ uint32_t sb, se, db, de; sb =3D src_base + src_x + src_y * (width + src_pitch); @@ -841,9 +860,24 @@ static void sm501_2d_operation(SM501State *s) color =3D cpu_to_le16(color); } =20 - pixman_fill((uint32_t *)&s->local_mem[dst_base], - dst_pitch * (1 << format) / sizeof(uint32_t), - 8 * (1 << format), dst_x, dst_y, width, height, color); + if (width =3D=3D 1 && height =3D=3D 1) { + unsigned int i =3D (dst_x + dst_y * dst_pitch) * (1 << format); + switch (format) { + case 0: + s->local_mem[dst_base + i] =3D color & 0xff; + break; + case 1: + *(uint16_t *)&s->local_mem[dst_base + i] =3D color & 0xfff= f; + break; + case 2: + *(uint32_t *)&s->local_mem[dst_base + i] =3D color; + break; + } + } else { + pixman_fill((uint32_t *)&s->local_mem[dst_base], + dst_pitch * (1 << format) / sizeof(uint32_t), + 8 * (1 << format), dst_x, dst_y, width, height, co= lor); + } break; } default: --=20 2.21.3