From nobody Mon Feb 9 11:07:59 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1554986084; cv=none; d=zoho.com; s=zohoarc; b=N94i8FCUtSPWY487aFYZ3HPTGjsm8V9/Q5U+/8E2/lV+g7IHeeneL8K9DykMu9eIUQKeIw7+KmqXMzcyjUujLqb9+OkZnwb9ConKIYLrAi/Z4friU78tIwFs7y5WbR9IXQ5H2OJEVzQhKUzCq5Ndywglq0OhopEcVqBxsBwQGII= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1554986084; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=NiiZmZYoiKLqKCOmTx7ABlStDDvDLIoMY/T9jpTUQNI=; b=gOhPMW8/P8Ox/kXju5X8elW8pP96pJGvrItvOODKnAtlEk8iJGrjuuHL9zeScRkZlxxT4vmVTuu9dPAbiXn21CwjweNgtxR49Ww0NYeiSYHBZXhwd6OgWEBOTFA+wCxJNhmwVTz5iSYaxik0Nt1/PFlgxoXvHTXkIes4GMQOt1s= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=null header.from= header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 15549860829431.340732555399427; Thu, 11 Apr 2019 05:34:42 -0700 (PDT) Received: from localhost ([127.0.0.1]:48181 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hEYud-0004RO-1Q for importer@patchew.org; Thu, 11 Apr 2019 08:34:39 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59582) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hEYsu-0003aT-H9 for qemu-devel@nongnu.org; Thu, 11 Apr 2019 08:32:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hEYst-0001T5-2t for qemu-devel@nongnu.org; Thu, 11 Apr 2019 08:32:52 -0400 Received: from fanzine.igalia.com ([91.117.99.155]:54617) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hEYsr-0001Q2-Dk; Thu, 11 Apr 2019 08:32:50 -0400 Received: from 178-55-128-240.bb.dnainternet.fi ([178.55.128.240] helo=perseus.local) by fanzine.igalia.com with esmtpsa (Cipher TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim) id 1hEYso-000273-MA; Thu, 11 Apr 2019 14:32:47 +0200 Received: from berto by perseus.local with local (Exim 4.89) (envelope-from ) id 1hEYsZ-0007fH-Je; Thu, 11 Apr 2019 15:32:31 +0300 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=References:In-Reply-To:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=NiiZmZYoiKLqKCOmTx7ABlStDDvDLIoMY/T9jpTUQNI=; b=ZaK4qfmpodYI3IfthkyyUXboXN+p1dSFJHYtN88YIFmAEFpDOY+9wTlfCNbbDP95pXAT/dc/v3XLQwQN/0lPnp7Vdzm3DharfMu3pWfyhHfSA/WJ7BOVeduSVEl/zbsdMIHo9oPcyKW8IhLkOKhI5WwLdiAcIr+PKF4nVgo0UMDdrlZ4o2QMRnQFqcimAFECnvQX6L1oqvFAhxl+AXfkXPJZBmesX/u0ovzrbcWNFomKPNEscxnJ0MYCrKouEHwvsQjG1A+plgnCy+ijbDQL4Bl0uBzfyg4YmZk85mAmaIDz9Sds4A6XnNJ/FUFvdQVXBXXl/PHJKhVIan8oAoETkg==; From: Alberto Garcia To: qemu-devel@nongnu.org Date: Thu, 11 Apr 2019 15:32:27 +0300 Message-Id: <9dc45741ca93573c3c782f2333129ee6ed1e9274.1554985749.git.berto@igalia.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: References: In-Reply-To: References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] [fuzzy] X-Received-From: 91.117.99.155 Subject: [Qemu-devel] [PATCH for-4.1 v2 1/2] commit: Make base read-only if there is an early failure X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Alberto Garcia , qemu-block@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" You can reproduce this by passing an invalid filter-node-name (like "1234") to block-commit. In this case the base image is put in read-write mode but is never reset back to read-only. Signed-off-by: Alberto Garcia Reviewed-by: Max Reitz --- block/commit.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/block/commit.c b/block/commit.c index ba60fef58a..698eda1dfe 100644 --- a/block/commit.c +++ b/block/commit.c @@ -384,6 +384,9 @@ fail: if (s->top) { blk_unref(s->top); } + if (s->base_read_only) { + bdrv_reopen_set_read_only(base, true, NULL); + } job_early_fail(&s->common.job); /* commit_top_bs has to be replaced after deleting the block job, * otherwise this would fail because of lack of permissions. */ --=20 2.11.0