From nobody Sun Feb 8 23:58:59 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=eik.bme.hu Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1635452207401753.9562407408663; Thu, 28 Oct 2021 13:16:47 -0700 (PDT) Received: from localhost ([::1]:51404 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mgBpO-0006fh-AC for importer@patchew.org; Thu, 28 Oct 2021 16:16:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49298) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mgBWk-0003mz-Kz for qemu-devel@nongnu.org; Thu, 28 Oct 2021 15:57:30 -0400 Received: from zero.eik.bme.hu ([2001:738:2001:2001::2001]:64533) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mgBWh-0000P8-KJ for qemu-devel@nongnu.org; Thu, 28 Oct 2021 15:57:29 -0400 Received: from zero.eik.bme.hu (blah.eik.bme.hu [152.66.115.182]) by localhost (Postfix) with SMTP id 5C1B07561FE; Thu, 28 Oct 2021 21:57:06 +0200 (CEST) Received: by zero.eik.bme.hu (Postfix, from userid 432) id 9BA727561BC; Thu, 28 Oct 2021 21:57:05 +0200 (CEST) Message-Id: <9cf323be3617162431e7cd830b463c4e70375daa.1635449225.git.balaton@eik.bme.hu> In-Reply-To: References: From: BALATON Zoltan Subject: [PATCH v4 19/23] hw/intc/sh_intc: Remove unneeded local variable initialisers Date: Thu, 28 Oct 2021 21:27:05 +0200 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable To: qemu-devel@nongnu.org X-Spam-Probability: 8% Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2001:738:2001:2001::2001; envelope-from=balaton@eik.bme.hu; helo=zero.eik.bme.hu X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Richard Henderson , Magnus Damm , Yoshinori Sato Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZM-MESSAGEID: 1635452208133100002 Content-Type: text/plain; charset="utf-8" The sh_intc_locate function will either init these or not return so no need to initialise them. Signed-off-by: BALATON Zoltan --- hw/intc/sh_intc.c | 21 ++++++++++----------- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/hw/intc/sh_intc.c b/hw/intc/sh_intc.c index ed0a5f87cc..1f4e1b9370 100644 --- a/hw/intc/sh_intc.c +++ b/hw/intc/sh_intc.c @@ -196,14 +196,13 @@ static void sh_intc_toggle_mask(struct intc_desc *des= c, intc_enum id, } } =20 -static uint64_t sh_intc_read(void *opaque, hwaddr offset, - unsigned size) +static uint64_t sh_intc_read(void *opaque, hwaddr offset, unsigned size) { struct intc_desc *desc =3D opaque; - intc_enum *enum_ids =3D NULL; - unsigned int first =3D 0; - unsigned int width =3D 0; - unsigned int mode =3D 0; + intc_enum *enum_ids; + unsigned int first; + unsigned int width; + unsigned int mode; unsigned long *valuep; =20 sh_intc_locate(desc, (unsigned long)offset, &valuep, @@ -216,12 +215,12 @@ static void sh_intc_write(void *opaque, hwaddr offset, uint64_t value, unsigned size) { struct intc_desc *desc =3D opaque; - intc_enum *enum_ids =3D NULL; - unsigned int first =3D 0; - unsigned int width =3D 0; - unsigned int mode =3D 0; - unsigned int k; + intc_enum *enum_ids; + unsigned int first; + unsigned int width; + unsigned int mode; unsigned long *valuep; + unsigned int k; unsigned long mask; =20 trace_sh_intc_write(size, offset, value); --=20 2.21.4