From nobody Mon Feb 9 19:10:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1505160032340267.2602409203856; Mon, 11 Sep 2017 13:00:32 -0700 (PDT) Received: from localhost ([::1]:60232 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1drUsg-0000o8-QG for importer@patchew.org; Mon, 11 Sep 2017 16:00:30 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39946) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1drUp3-0006A6-F7 for qemu-devel@nongnu.org; Mon, 11 Sep 2017 15:56:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1drUoz-0002EI-H0 for qemu-devel@nongnu.org; Mon, 11 Sep 2017 15:56:45 -0400 Received: from mail-sn1nam01on0040.outbound.protection.outlook.com ([104.47.32.40]:13620 helo=NAM01-SN1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1drUoz-0002D8-8P for qemu-devel@nongnu.org; Mon, 11 Sep 2017 15:56:41 -0400 Received: from SN4PR0201CA0041.namprd02.prod.outlook.com (10.162.76.27) by BY2PR0201MB1927.namprd02.prod.outlook.com (10.163.75.157) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.35.12; Mon, 11 Sep 2017 19:56:38 +0000 Received: from SN1NAM02FT062.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e44::207) by SN4PR0201CA0041.outlook.office365.com (2603:10b6:803:2e::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.35.12 via Frontend Transport; Mon, 11 Sep 2017 19:56:38 +0000 Received: from xsj-pvapsmtpgw02 (149.199.60.100) by SN1NAM02FT062.mail.protection.outlook.com (10.152.72.208) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.13.11 via Frontend Transport; Mon, 11 Sep 2017 19:56:37 +0000 Received: from unknown-38-66.xilinx.com ([149.199.38.66]:45319 helo=xsj-pvapsmtp01) by xsj-pvapsmtpgw02 with esmtp (Exim 4.63) (envelope-from ) id 1drUov-0001Pt-9E; Mon, 11 Sep 2017 12:56:37 -0700 Received: from [127.0.0.1] (helo=localhost) by xsj-pvapsmtp01 with smtp (Exim 4.63) (envelope-from ) id 1drUov-00004r-5A; Mon, 11 Sep 2017 12:56:37 -0700 Received: from xsj-pvapsmtp01 (maildrop.xilinx.com [149.199.38.66]) by xsj-smtp-dlp1.xlnx.xilinx.com (8.13.8/8.13.1) with ESMTP id v8BJuV9m029762; Mon, 11 Sep 2017 12:56:31 -0700 Received: from [172.19.2.220] (helo=localhost.localdomain) by xsj-pvapsmtp01 with esmtp (Exim 4.63) (envelope-from ) id 1drUop-0008Vx-5Q; Mon, 11 Sep 2017 12:56:31 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector1-xilinx-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=6sGoNP9kfUPooKobFkK1ztWlyGFavUdZhXvgYtMwX3k=; b=MrxruzNCfk86pUJ8I/3oi6PyMgtv1YCKvzfFraZoOKs/dWMb3JeAGM8+YsobfSAUqJ8avRXH/rgj7OBmf4xtBkq5o1sXWmI0t7/fbZ3B4VIlaMvSwbWJ460VikcqYZvpE74CiZCoyz9wfdpJ2kF3cDLddLTz6zHUF3/Fepm5sSA= Authentication-Results: spf=pass (sender IP is 149.199.60.100) smtp.mailfrom=xilinx.com; redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=bestguesspass action=none header.from=xilinx.com; Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.60.100 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.60.100; helo=xsj-pvapsmtpgw02; From: Alistair Francis To: Date: Mon, 11 Sep 2017 12:52:56 -0700 Message-ID: <9cb1d23551898c9c9a5f84da6773e99871285120.1505158760.git.alistair.francis@xilinx.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: References: X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.1.0.1062-23322.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.100; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(2980300002)(438002)(199003)(189002)(63266004)(2906002)(33646002)(2351001)(77096006)(106466001)(9786002)(118296001)(5003940100001)(189998001)(50986999)(50466002)(76176999)(8676002)(575784001)(48376002)(81156014)(50226002)(81166006)(47776003)(8936002)(36756003)(6666003)(36386004)(478600001)(2950100002)(6916009)(356003)(54906002)(305945005)(110136004)(5660300001)(4326008)(39060400002)(107986001)(5001870100001); DIR:OUT; SFP:1101; SCL:1; SRVR:BY2PR0201MB1927; H:xsj-pvapsmtpgw02; FPR:; SPF:Pass; PTR:unknown-60-100.xilinx.com,xapps1.xilinx.com; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; SN1NAM02FT062; 1:Lqr9H3j8fRQul4b2WSjepA7XzjqT8RmlcjcF2jmYiC41hYkiKgN8IQlj3vbOOh14O9wmWiUJEdrx1DGMfgQdaAco4zDkoV1xocTOm2aZyK8FsyTBLf4eQ+Xae5D8Anhu MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 54d3b679-a8f4-4eac-def4-08d4f94f36a9 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(8251501002)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:BY2PR0201MB1927; X-Microsoft-Exchange-Diagnostics: 1; BY2PR0201MB1927; 3:294qImXSyEVelpbR6AsyaN0neeGhop3QsmtkPRq/R39H26qFi3hEWkSOCGkjyMwUDeuIoMYxaAOERhW5P0k1z5SGqv9Dg8IpXfT6quEXOszR+Uuus8PcIxl/wIuK1bjdhViGnkW7IkOqoEm4E1fzvBXf7if0o4c12VLNsDY+LlXrj+ipm7EMpS6t0AHSnBR2wmLv251oVJz+iBYJaH+wBw9AudRGscOUwhf1jvKgKNF/e+TzO4vJ/nPrq9tWY8ZAsdeiWNxIHDyodBiOgjv5PoiBfueR/6dUFts67HMlWiJs8SM+mu/MN83ZY4xD/aAh92OP5HL+7/2SmjvjnB4xb4mEIj9sg401r7KJgVex+JA=; 25:3yqBvWeRF92uk4tiOXbqfGYuLQt0m/JNY9R2cdoQXVRbOSJdkspywJaFWyf5zxMcdDFbTph3BUtpeY6MYZ4VeF3K1gzFnCHbag+JP/cldn+bFXv2A4JurTWVgmbXbR4STixWsDFg5XJffNYZguWVxZCSyf+CfUTKNV2wCBDOc5YKx1At0J6REOtvaBgfHVIbIlvcasUKUAxVDm321QWBbUbYMQFDWBbazU6TDtyvUqY8s/FH2fsm9uZTsoCkElOYjqviIxTyZkuI7rFpGPlLF8k4nFK8pzrtdxmYskEEWDoODrd13L1VtRa9qmifL0d899DRDtf5AKWXeggucI41XA== X-MS-TrafficTypeDiagnostic: BY2PR0201MB1927: X-Microsoft-Exchange-Diagnostics: 1; BY2PR0201MB1927; 31:rrqHWbeGgVK50o8gdlkes7mCOK7gNJ+wCMLZzINiyfAbJt/4mtzLjv+42gzE3iDb5X8Mwe2fKGrMbWpOhzk7eCWlHLwzcvCLZaxorvb/Hqhg6IH+wsm1OFBwv1pLulMKyeltplmWyz2XXgdVVERNn1TNNOR8FGCBeccrcLqa2Z5+XiEswnI8gUGJCQ4glJKSpcLWRYOxB3hQ8xIP7ovc8rJwCeVwiYGPEnIKAc76mvo=; 20:CbITyVd9eEz0QxoDEOuUXyxO+Q3RXCQ0ZURJUQNB6CcNSim4GvbZmjeV9HsbtesPgXDlag2B9znLiTu0xOTDIdlCVtdrtYxU90m8F0cws9MNnv3yEsc1/6oGzwKHFImBSwpNp+wONJ669HuZBL2mIaD3pohZTTxoSx88aB+jcDbKyv2EdWk9gvE8d01oClBRcqtIS+LsYd77z9e2N+vCM3wEWxDWUehZdFbXOaMXjI089Gig1DepdI2f/6sskOaGd4r7mZRzaEpuJJmh647KeuS7p8RfJPTxUOZWhn+X3sPoouqTC5hdojhurddlg7TnB6vURV08PM8l4k0m1/U0T0RWoF4nw80b3rTiwgujZ84Jo8rryGkbdX66Ir9Gw12VoWfp63IbCBsqLyKOZDsNhD9gVq3dj5FXqOBlG6K2azWGpU4r7VyNw2zqpehaVNRgulczSc+nmeGy8zqFwLsS7hEf1sWS1Z6WI702lon65gi1LBOQB52/bso3f8bxL0ys X-Exchange-Antispam-Report-Test: UriScan:(192813158149592); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(3002001)(10201501046)(93006095)(93004095)(100000703101)(100105400095)(6055026)(6041248)(20161123555025)(20161123564025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:BY2PR0201MB1927; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:BY2PR0201MB1927; X-Microsoft-Exchange-Diagnostics: 1; BY2PR0201MB1927; 4:mP9DR/m1jvMOG+uxz1h0+9CjhJME6lajSoU8M7ImfUj92qidjIiOZFCmOg0jQMxTGGV+1EHwwEZv1pOs3qqaQTo2uzLM2psVKqnpNR8tXzIhh+WbVv86kcKJVSsNQ4a51APoUAoYk0dwWpLnuHYmOfC5V4KGPUI6HkxPZ+5KV1hpy3tYBmbwNoDTtdOpQVg8c5cnHbMCbo+QgDKGzexuTIidn31NwVQdOA0q9Vrkr5og+9HoIvhHBoJy7HWMl4+hTP14FHZYgoGqG82lFGxkl9mrnyhPP5jbB9dRRHcZG2Q= X-Forefront-PRVS: 04270EF89C X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BY2PR0201MB1927; 23:Xyn34CSJeRODrRLRyf0iScDYuzCS3Z2Gh1xp/Nv?= =?us-ascii?Q?ryHrAlPinlyue3X30fDCmzwNpxu3RbzX8nDEzPoPsIup7yKN1GrRHlkSUXOw?= =?us-ascii?Q?G5Rdr3d0HtlspQ6ridyCTXSkamgvBY0MFzP31/DBt2aB3oG+LIO5/MUaUE93?= =?us-ascii?Q?mAv8K0XelwvE6YSZ+R0DpCNE3MjsZedjhTFX7s4HZ9rnZVBmLH5PZdOU5HCJ?= =?us-ascii?Q?KrL8q9uMSsrrxdCioMoQ5fOvgsnPHlRSsXNb3Vy22xvYMOzstmQEznvPJe3o?= =?us-ascii?Q?ki8I5sX5iN97Ux2+pb4rYOC6elfjemRDUTKj1BZYsPXWJf55PNWnwWADincD?= =?us-ascii?Q?8gmYbHjbAMO2jbztEmwwPSuJqWiB0eVMxZ5OV657HrrSIyNHZGK47FQZQ52/?= =?us-ascii?Q?sKZmrgZJt2hCHsafFsYtzPC4UI/W8lEoLy8sipLf6RkRxtrWypYkfGu0OCPM?= =?us-ascii?Q?JTJkTpP/VlD7353zv+AwhhQI75OmC+/vuj2zaAs5svy9k9n+f3dvPboLf5jW?= =?us-ascii?Q?c/yFtOsUH9qoARhpp24nRYymLK19z99nh76HOqMqxJ5bn8SVZuXkb4DMvHh6?= =?us-ascii?Q?JzG/LgcxNhEKXIzCl+9Giw+MWUyzylQLMVzUZn9VY98KTamBJ8dBA5AE5LIr?= =?us-ascii?Q?ZlN60QCf197wfGVO7vbEeRm35Fs1EvLIR+44CmSbT9+mugFvvESCFICBMX8c?= =?us-ascii?Q?Yt9Q7xHmy60qwwuvs9UdFfy2e2/hzx10KChF1y4GzxM1lVHzD4k96uvGsQC2?= =?us-ascii?Q?MEqcp563mcNZazIHoBuXp0WHVdJABqPwpN4X4HAT8Pt+AGHUCwy8nCYkqC7c?= =?us-ascii?Q?m0CUJwyPacHlHu/V5IKsjpHT7tlBWnvo0TglDR9446cZV1e8EGbSenUD9x61?= =?us-ascii?Q?hI/jkw1xz/K0OviJCQotkU18lcV+RTTZaczy1FY3nCtMthYHCWSXrdKCYrA9?= =?us-ascii?Q?NYOJrUgDcUpMf0h2HNLKC/f3fgiJ/tWM7GPevUlzD6ph7eeh/q1rQ29oTASt?= =?us-ascii?Q?EMmkyne8jCWfIJ2EiIq969Bcc?= X-Microsoft-Exchange-Diagnostics: 1; BY2PR0201MB1927; 6:ttR/wlQ9QprGeDOK4LdRkf5Yk8xe83W6+nErX4c3CvKUEwUPS5lxqcr0L1ENZKNa5eQ7KWuzfXgzffjGMDqmS9HPVOH6u8DhE8pUSf9q1jxSy8fHvX54aZfzAbqbU0zSr1ePNxMBWWfekCNU64n/lw3AK7wKyjyiX5DJGCByu2HvnIELDwqVH0uJnbr4yWBGdC2TgOew5bUom3ZM+EgUPvfyA2ni5PkR9Q7wPJIIqKAIWNlZmtyxGU2Rb7jYFIDCThcz+MZ7/iqF32DgzWgg6D23HJPrQpKtEsUkGVtgrYLu+nxObn7BPKfPkSEXqcu0kKsgAMf0rU1XIsBpDsRvFQ==; 5:JKfYgxn6kvHiZq2FQI3rHtPQHvLGgJazeA2hj+db8IoQUIc8KUZwpvXg06e59XSn4bvQlDSki4XOBJUYapQAiSKaaiTdgfvIiyfqPfGbdzMvAT3IJvwyKeIN/GB6qLm9GPXoQA8yVLXDYMffhx/d5w==; 24:VAr1xRLLL7ztH/x8UNtroKZwG/h7ziaTci/bL4Eia6I4SVelOYjg0gOfims5kTxZxBGGaO49Vvp3YG0ftRvXg/FQsb2DAGXo4FQfCzlTtg8=; 7:aL2S3sZQPrPUC9YqglAv48Wubik4VKIq1sUooOSDvOW8IOWbJGjRJbukowv6l62NgvKklIpS2x6X3T7eFZM25Q5EkZ78DTbzDY8rMpFWutdpfULoaQfv8hicRIRzFKgipwnWcG5/qSB0HXydj/AcNVNs5JRV1BIBGpHKHQWR1mJD2eWr18EtP7tG3SnW5EDQCel0t7HibYv0TH2AOI0T83WzukA56yXg59w2dAVAlcc= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Sep 2017 19:56:37.7792 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.60.100]; Helo=[xsj-pvapsmtpgw02] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR0201MB1927 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 104.47.32.40 Subject: [Qemu-devel] [PATCH v4 5/8] General warn report fixups X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alistair23@gmail.com, pbonzini@redhat.com, armbru@redhat.com, alistair.francis@xilinx.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Tidy up some of the warn_report() messages after having converted them to use warn_report(). Signed-off-by: Alistair Francis Reviewed-by: Markus Armbruster --- V4: - Small fixes block/vvfat.c | 3 +-- hw/arm/vexpress.c | 2 +- hw/i386/xen/xen-mapcache.c | 2 +- hw/mips/mips_malta.c | 4 ++-- hw/mips/mips_r4k.c | 3 +-- hw/s390x/s390-virtio.c | 14 ++++++++------ net/hub.c | 6 ++---- net/net.c | 5 +++-- target/i386/hax-mem.c | 6 +++--- target/ppc/translate_init.c | 3 +-- ui/keymaps.c | 3 +-- 11 files changed, 24 insertions(+), 27 deletions(-) diff --git a/block/vvfat.c b/block/vvfat.c index 6659a4a96a..cbabb36f62 100644 --- a/block/vvfat.c +++ b/block/vvfat.c @@ -1227,8 +1227,7 @@ static int vvfat_open(BlockDriverState *bs, QDict *op= tions, int flags, =20 switch (s->fat_type) { case 32: - warn_report("FAT32 has not been tested. " - "You are welcome to do so!"); + warn_report("FAT32 has not been tested. You are welcome to do so!"= ); break; case 16: case 12: diff --git a/hw/arm/vexpress.c b/hw/arm/vexpress.c index f72ee6658b..96c5eebeaf 100644 --- a/hw/arm/vexpress.c +++ b/hw/arm/vexpress.c @@ -494,7 +494,7 @@ static void vexpress_modify_dtb(const struct arm_boot_i= nfo *info, void *fdt) * happen with older device tree blobs. */ warn_report("couldn't find interrupt controller in " - "dtb; will not include virtio-mmio devices in the dtb.= "); + "dtb; will not include virtio-mmio devices in the dtb"= ); } else { int i; const hwaddr *map =3D daughterboard->motherboard_map; diff --git a/hw/i386/xen/xen-mapcache.c b/hw/i386/xen/xen-mapcache.c index 91a4fd6984..baab93b614 100644 --- a/hw/i386/xen/xen-mapcache.c +++ b/hw/i386/xen/xen-mapcache.c @@ -127,7 +127,7 @@ void xen_map_cache_init(phys_offset_to_gaddr_t f, void = *opaque) =20 if (rlimit_as.rlim_max !=3D RLIM_INFINITY) { warn_report("QEMU's maximum size of virtual" - " memory is not infinity."); + " memory is not infinity"); } if (rlimit_as.rlim_max < MCACHE_MAX_SIZE + NON_MCACHE_MEMORY_SIZE)= { mapcache->max_mcache_size =3D rlimit_as.rlim_max - diff --git a/hw/mips/mips_malta.c b/hw/mips/mips_malta.c index 233e2ee802..7d6e58348e 100644 --- a/hw/mips/mips_malta.c +++ b/hw/mips/mips_malta.c @@ -216,8 +216,8 @@ static void generate_eeprom_spd(uint8_t *eeprom, ram_ad= dr_t ram_size) } =20 if (ram_size) { - warn_report("SPD cannot represent final %dMB" - " of SDRAM", (int)ram_size); + warn_report("SPD cannot represent final " RAM_ADDR_FMT "MB" + " of SDRAM", ram_size); } =20 /* fill in SPD memory information */ diff --git a/hw/mips/mips_r4k.c b/hw/mips/mips_r4k.c index 6ffb88fd70..b48a4d72ac 100644 --- a/hw/mips/mips_r4k.c +++ b/hw/mips/mips_r4k.c @@ -254,8 +254,7 @@ void mips_r4k_init(MachineState *machine) } } else if (!qtest_enabled()) { /* not fatal */ - warn_report("could not load MIPS bios '%s'", - bios_name); + warn_report("could not load MIPS bios '%s'", bios_name); } g_free(filename); =20 diff --git a/hw/s390x/s390-virtio.c b/hw/s390x/s390-virtio.c index 25781f04d8..0e91c465f2 100644 --- a/hw/s390x/s390-virtio.c +++ b/hw/s390x/s390-virtio.c @@ -141,9 +141,10 @@ void gtod_save(QEMUFile *f, void *opaque) =20 r =3D s390_get_clock(&tod_high, &tod_low); if (r) { - warn_report("Unable to get guest clock for migration. " - "Error code %d. Guest clock will not be migrated " - "which could cause the guest to hang.", r); + warn_report("Unable to get guest clock for migration: %s", + strerror(-r)); + error_printf("Guest clock will not be migrated " + "which could cause the guest to hang."); qemu_put_byte(f, S390_TOD_CLOCK_VALUE_MISSING); return; } @@ -170,9 +171,10 @@ int gtod_load(QEMUFile *f, void *opaque, int version_i= d) =20 r =3D s390_set_clock(&tod_high, &tod_low); if (r) { - warn_report("Unable to set guest clock value. " - "s390_get_clock returned error %d. This could cause " - "the guest to hang.", r); + warn_report("Unable to set guest clock for migration: %s", + strerror(-r)); + error_printf("Guest clock will not be restored " + "which could cause the guest to hang."); } =20 return 0; diff --git a/net/hub.c b/net/hub.c index 745a2168a1..14b4eec68f 100644 --- a/net/hub.c +++ b/net/hub.c @@ -310,8 +310,7 @@ void net_hub_check_clients(void) QLIST_FOREACH(port, &hub->ports, next) { peer =3D port->nc.peer; if (!peer) { - warn_report("hub port %s has no peer", - port->nc.name); + warn_report("hub port %s has no peer", port->nc.name); continue; } =20 @@ -334,8 +333,7 @@ void net_hub_check_clients(void) warn_report("vlan %d with no nics", hub->id); } if (has_nic && !has_host_dev) { - warn_report("vlan %d is not connected to host network", - hub->id); + warn_report("vlan %d is not connected to host network", hub->i= d); } } } diff --git a/net/net.c b/net/net.c index 1301cdbd88..39ef546708 100644 --- a/net/net.c +++ b/net/net.c @@ -1494,8 +1494,9 @@ void net_check_clients(void) QTAILQ_FOREACH(nc, &net_clients, next) { if (!nc->peer) { warn_report("%s %s has no peer", - nc->info->type =3D=3D NET_CLIENT_DRIVER_NIC ? - "nic" : "netdev", nc->name); + nc->info->type =3D=3D NET_CLIENT_DRIVER_NIC + ? "nic" : "netdev", + nc->name); } } =20 diff --git a/target/i386/hax-mem.c b/target/i386/hax-mem.c index 756f2dd268..27a0d214f2 100644 --- a/target/i386/hax-mem.c +++ b/target/i386/hax-mem.c @@ -12,6 +12,7 @@ #include "cpu.h" #include "exec/address-spaces.h" #include "exec/exec-all.h" +#include "qemu/error-report.h" =20 #include "target/i386/hax-i386.h" #include "qemu/queue.h" @@ -178,9 +179,8 @@ static void hax_process_section(MemoryRegionSection *se= ction, uint8_t flags) if (!memory_region_is_ram(mr)) { if (memory_region_is_romd(mr)) { /* HAXM kernel module does not support ROMD yet */ - warn_report("Ignoring ROMD region 0x%016" PRIx64 - "->0x%016" PRIx64 "", __func__, start_pa, - start_pa + size); + warn_report("Ignoring ROMD region 0x%016" PRIx64 "->0x%016" PR= Ix64, + start_pa, start_pa + size); } return; } diff --git a/target/ppc/translate_init.c b/target/ppc/translate_init.c index 49190ec95a..466bf97347 100644 --- a/target/ppc/translate_init.c +++ b/target/ppc/translate_init.c @@ -9321,8 +9321,7 @@ static void init_ppc_proc(PowerPCCPU *cpu) } #endif if (env->check_pow =3D=3D NULL) { - warn_report("no power management check handler " - "registered." + warn_report("no power management check handler registered." " Attempt QEMU to crash very soon !"); } } diff --git a/ui/keymaps.c b/ui/keymaps.c index a6cefdaff9..f9762d1497 100644 --- a/ui/keymaps.c +++ b/ui/keymaps.c @@ -198,8 +198,7 @@ int keysym2scancode(void *kbd_layout, int keysym) if (keysym < MAX_NORMAL_KEYCODE) { if (k->keysym2keycode[keysym] =3D=3D 0) { trace_keymap_unmapped(keysym); - warn_report("no scancode found for keysym %d", - keysym); + warn_report("no scancode found for keysym %d", keysym); } return k->keysym2keycode[keysym]; } else { --=20 2.11.0