From nobody Tue Feb 10 15:46:02 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=temperror (zoho.com: Error in retrieving data from DNS) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1507853610173748.8127195685914; Thu, 12 Oct 2017 17:13:30 -0700 (PDT) Received: from localhost ([::1]:47838 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e2nbL-0002u1-CI for importer@patchew.org; Thu, 12 Oct 2017 20:13:19 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57791) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e2nZo-0001t4-Vt for qemu-devel@nongnu.org; Thu, 12 Oct 2017 20:11:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e2nZk-0006tj-Hf for qemu-devel@nongnu.org; Thu, 12 Oct 2017 20:11:44 -0400 Received: from mail-by2nam01on0079.outbound.protection.outlook.com ([104.47.34.79]:21981 helo=NAM01-BY2-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e2nZk-0006qz-7x for qemu-devel@nongnu.org; Thu, 12 Oct 2017 20:11:40 -0400 Received: from MWHPR0201CA0008.namprd02.prod.outlook.com (10.167.160.149) by CY1PR02MB1334.namprd02.prod.outlook.com (10.161.170.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Fri, 13 Oct 2017 00:11:36 +0000 Received: from SN1NAM02FT002.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e44::206) by MWHPR0201CA0008.outlook.office365.com (2603:10b6:301:74::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.77.21 via Frontend Transport; Fri, 13 Oct 2017 00:11:35 +0000 Received: from xsj-pvapsmtpgw01 (149.199.60.83) by SN1NAM02FT002.mail.protection.outlook.com (10.152.72.94) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.77.10 via Frontend Transport; Fri, 13 Oct 2017 00:11:34 +0000 Received: from unknown-38-66.xilinx.com ([149.199.38.66] helo=xsj-pvapsmtp01) by xsj-pvapsmtpgw01 with esmtp (Exim 4.63) (envelope-from ) id 1e2nZe-0004Cr-9G; Thu, 12 Oct 2017 17:11:34 -0700 Received: from [127.0.0.1] (helo=localhost) by xsj-pvapsmtp01 with smtp (Exim 4.63) (envelope-from ) id 1e2nZe-0002Nc-5t; Thu, 12 Oct 2017 17:11:34 -0700 Received: from xsj-pvapsmtp01 (smtp.xilinx.com [149.199.38.66]) by xsj-smtp-dlp1.xlnx.xilinx.com (8.13.8/8.13.1) with ESMTP id v9D0BOJp022909; Thu, 12 Oct 2017 17:11:25 -0700 Received: from [172.19.2.220] (helo=localhost.localdomain) by xsj-pvapsmtp01 with esmtp (Exim 4.63) (envelope-from ) id 1e2nZU-0002M5-OV; Thu, 12 Oct 2017 17:11:24 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector1-xilinx-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=JvN71wuNTtLJ0+POurzAgHBeutt7x9ZuZDOadozohXE=; b=yIbWJ7Dje0gqDWQpIwNxzIlVuqk7UlJW7GdWx0ucLc4dzaG+CmiRgUOZZZDK0PtoTSAj3UHH1oNKJyl0jKIYwjDsQKvkpdzRgFvdswCfI7vspfEu5w28urx1HPSt9JdMaH6BCO9TbFa3GHK4mZMtGRXWYfM5SohLD3vKTV1vERI= Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=xilinx.com; amsat.org; dkim=none (message not signed) header.d=none;amsat.org; dmarc=bestguesspass action=none header.from=xilinx.com; Received-SPF: temperror (zoho.com: Error in retrieving data from DNS) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.60.83 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.60.83; helo=xsj-pvapsmtpgw01; From: Alistair Francis To: Date: Thu, 12 Oct 2017 17:07:34 -0700 Message-ID: <9b45c06f0e445bcdb2f8169c96ad392c9db19fbe.1507852977.git.alistair.francis@xilinx.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: References: X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.1.0.1062-23390.004 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.83; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(376002)(39860400002)(346002)(2980300002)(438002)(189002)(199003)(77096006)(36756003)(106466001)(63266004)(356003)(305945005)(50986999)(76176999)(47776003)(8936002)(81156014)(478600001)(8676002)(81166006)(5003940100001)(50466002)(2906002)(2351001)(48376002)(118296001)(551934003)(33646002)(6666003)(5660300001)(9786002)(316002)(39060400002)(16586007)(50226002)(4326008)(54906003)(36386004)(106002)(2950100002)(6916009)(189998001)(107986001)(21314002); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR02MB1334; H:xsj-pvapsmtpgw01; FPR:; SPF:Pass; PTR:unknown-60-83.xilinx.com; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; SN1NAM02FT002; 1:JbhI6ntYCjAsbCTUAscFOPcrY8y7ab+N1G+htg52lXxztj1NHXcdPg8hlY2y5oi31bdNzR9PHfSSSPkTgn7XNjUBPeu9PgUt2vcVhD5fAxvqLP2oFNaYDIE0NXgMX1GN MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 25a77be3-980c-48e6-cea1-08d511cef74c X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254152)(8251501002)(2017052603199)(201703131423075)(201703031133081)(201702281549075); SRVR:CY1PR02MB1334; X-Microsoft-Exchange-Diagnostics: 1; CY1PR02MB1334; 3:U5ZYJhjXBCPJPa8lMmvf+FT34EKwXQ60aFbOvgcHEvdNuJJCPB+vUWNTDbBU6mWxqNNka2rPtjWf5Bxb7QQTiB/G/FAHPyBgO6S/grIMWOcurNEYqiaRANGqAHGzcne0f5bdwYOv3GA/BEnGrAKTZGDM1FIRrlHloI63qCfzbMWQrXSuPxgs+nPZbjztTY2K/H0TOb2PfZfVni4KuIGoJk+X2bjVfqZNzqb5PDc89eQKsOKeN4TLUFuWuqUGHXA7xmc0rNo01whwqojM9rud0Udxj34xBqq3pQw6XCFnm5YiQlef1m20bqdAsZ8BW37gW6/n1Bv2qL1d8uV+Dd5yFSXIlhgZqSfJlvlDhTd9mQI=; 25:uzChG4GOjJJr5o7sno8dlADzpK22u8PWrgOFdjpHSl4Dcn3TBjpg7nNb25Z/8HErt7rbMSWGBUJSlIh1Po82xo2p9eGcwvPPNNvtCB2isH2DDQZV0syUdj7IlD7ewwJ523/X+vhRRAqawl2B4QHllqMlm6CjRS/twC1zaKM4gQsd/VNsNLn6Tvjy1AylDDp3Q3JZDDWW+Op06lJQ6kHijqqX8RvYTxamHJOdDEa5BL6qGqyPUyWa6f3yOiQyndVkh9pKIVgLWkYpufObvHVTX5JhKn9i1K6WyGwe4HxEUdO08gaL2uLiQm9tDATFIPbgzXxX/zhrRd/kewnIH1sKu5vSEkqh/QscJpA0d1eU8ns= X-MS-TrafficTypeDiagnostic: CY1PR02MB1334: X-Microsoft-Exchange-Diagnostics: 1; CY1PR02MB1334; 31:ZFtbcKcs1N3zeIjiRz4dVum7HDWO4BB3LRsx/fLOkgZNWd1MtK09bburCNsSn/YaSRrUxj6RsE3e/BguA/F7p5gBChmCTGkCiwsmb3aOlL/M0FzdhFtB0Ip+WGqZU76epdAGsyluoc4Vq4BXVTZOEDHDC/jKMKu3ORKRKSfTAlUVLDkoCgxbpFByn59D84F+QyqvpKL7zFDo3rRDDf3J/CQV47Q8zYKI+NzLDQU4OgI=; 20:oyqPaYjQET7U9c0YmKZFn8FcwrXDRqVKGDo+fhQdy8yGOsuzwleUX1drYhEp+owKmuwiU2CIYNZPHkweC+zD4FuHrxwGFQ/J7wzrjW2HBVzDeZmSht0X/sxjFXDsgOJKw4+009DIFa3j/McUWS4kOmCbx/91A1MXDYLLfP2AHXE/MctymmtEexeQqzFnqCdAh+2TPwg9OP7Yd4k+AMNcebOkPgb0ChdSP1ZSNQvlSwdnPFi3Ydcq9PpcbJjsbFXhjBQL3dM1QTsZE/DvPK1VK9D2USX3E78FpszmRXII/y0Ny4HQ2qm9hevOd5sGCO5iSkZk+DSLRI8bGF5/B4esuxhu/AYO4iUo2K/QaSvLTNVHPHy8l6jcaYei1+wgoYyd/z/CXUIuHk7scJOJVfuaSldQef8cloI7Pv2LdL8Corp8ZUYz7UAGmuQ2AOpWFApkCl1wY7rJYKl1cuST78wYTMXerYu4t4eVEMFMHi9QPiW67v16E4ZFI2iFmMnZgTEw X-Exchange-Antispam-Report-Test: UriScan:(192813158149592); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(93006095)(93004095)(100000703101)(100105400095)(3002001)(10201501046)(6055026)(6041248)(20161123558100)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123562025)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:CY1PR02MB1334; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:CY1PR02MB1334; X-Microsoft-Exchange-Diagnostics: 1; CY1PR02MB1334; 4:ydPKxCqIQzjrwu7qLnTlJuhQUmoqgO7fqLpLpiBRa//bCyT0dqXLLLndib5ilkYT4brXh5T4MYSGMMWzfz8Es4XFBklBEk3NeAGNAqKNnTNoXZBEweEntGkX6kyAkOeL0wcKftj+pKfwf8GVcQwoK2SmJM3duLA461jai6PQ8dEHmS9fmp/ZJ6uFbG4oAJdtPGsdWtHCnlNpRMAxfqQDMQU/wLYHi0H7BT5nBknl/c11Gn/MJeLr3XSsy+JaXCMFJfu5REgJj2srvTgPDG8TgBdssVevZbHu704/NING8hc= X-Forefront-PRVS: 04599F3534 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR02MB1334; 23:tb/EiJh2hwrfg834qOabOOWybnOz33LxQkbOHassQ?= =?us-ascii?Q?AjOz4r9tRTdGqRIrmlE67MIrxEGFuhLORc2i1adpWQTSmmZHytF1zTMcvIJ4?= =?us-ascii?Q?uHQ6mlxrx8/Jetext+hItrmwjmeu/51QXTjCE7xhZfxzKZa23rSqQRXbeTSj?= =?us-ascii?Q?gquXgrIuYPKnz41AfWRLEXZycUJi0gOY4OH/cghjmDS5Ky5A/TsHgR6FNW5N?= =?us-ascii?Q?5KX6XhvpDBF96WegibuqUU2o/DmrErflxmJJBFTJUwOQbbh0/e0qeNX9BhgQ?= =?us-ascii?Q?Wrw7hwsSgHa+E0P/kODN+/gz+gtTX9tDh0TwrN/GXVy13CJC17E2ew4sMJsU?= =?us-ascii?Q?65We+UJS3BVo//Ly5XWPuvN4rnu7VOfg/A8kYxCjAxRRDnoQkOtYvi8TCCf1?= =?us-ascii?Q?y5G42tPOj65aqe6Mj0i4vdOxwGpT+njb4CVcDJYRSlTZiWVfp6xfyl+g90wv?= =?us-ascii?Q?qFkWijkB88gaYz6dXBeYI+msyn2f1OYW5EUGcAwvmkSBqcljMyD/AYhAtXA3?= =?us-ascii?Q?t8q2Nzuu8NpuNe4MGrJbS282K83wFb1d1uim1Wg0NgwVy9nu0B1yK5G/Mkcl?= =?us-ascii?Q?8VkrBoxY6o4xMa8rfI1yFw++MTM0dTfQjL1YYJf2xgvjn5akJPIMry6/IHvg?= =?us-ascii?Q?Fvqd3VDtEPbE6REesXPY9++qqtRM03czphzriM+AtBdPWP2yAywU9767fyBP?= =?us-ascii?Q?XdDbC3zWhQ+IacTKOTV828MgCK6ZlFrJlThxBTPXeJvoZ2oEJBtudRlm/Kc7?= =?us-ascii?Q?ZsFNPxHkszhYvPp/sobRUeGdIM4aFn5Qk7D2ow+DHrU/yAkjfxJePmlJxCYN?= =?us-ascii?Q?w9K5Rv0xXAB/fH/V1Yz+fRRpOKgP/pJubzkBJgoqwHRhO9WyCt5UAKl+Drk1?= =?us-ascii?Q?CKgrDrqbeov/4zZHIn8AbO513JU+pfDh2LvjD8pJO0A0dhenr/MC5DMt/3DH?= =?us-ascii?Q?OPHj0Q1YGhfb/x31hRJlNd7A5p2DB2XmcDPxFZk8zYhp80bzIhFZI6n2ydrg?= =?us-ascii?Q?UWptPb+msWm6587uvtdBcy07/gK1pVQuBbjHa1Tt2jQsgitCib1jyj3cqUPC?= =?us-ascii?Q?peAK+fmRvTdLo1atwSv7liqMuHqbv1WOZkC+uiaZ1mzGgx8xg=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR02MB1334; 6:mlxKR1rDmZLrrQw1Py35XYGw0t8UAaw9OOi2F9VvoYSWv81YXaHwDXYU485QQNaptgua4lvmj0FGSke4c/HAUrLlCrx7FgP5G/XydK0ysXLTmv65EkT0CFStDiBVQLbw5Xz7AMKYQIu/buYCBBupKgauoAiekeylc1Trj24rocCrg47MivHMwwBcHhW2hTl8Fr7RE9gIS84Goj3BmwejXYyfdPvCCH9U6Cr2VLJ4ZkZ6p0YbmdtxVceiMtL/6qWOcbR+eVFfZb0fGk4PNs8nELlRnDIcWzLytz4m1TmeavBFM+KRwFEzC48RuiEowsF3xFxZ+O/yG0AoMG3+q6d6mg==; 5:+8qsdol6hOvNyooG/7kbgK3p/0g2owMEJhEFBgHzrSyqqf2hrPjjAn9bIP6IHt9Vo3CjQF3B5jy353gNJ8J1cVS6/LG/s1Ipj9kZrgxr7e7k5HbjrSG12mijXc/K77Hjxvh5wP5HjedRsuBLUZV2iq29e3GnTAZqRvGo+ueBkWg=; 24:Jighj1UTxK8KxLgIX+RTmWwtV2o6MQNL8K2KQabegvbHN6RX9nKXbQoOAv28vUBW+F2GBCOJ9j18gUO1A+HnOZKB6WzMAAD1mEXpicw2qJ8=; 7:fbEbljAXoh9eDIYkXzQNxN4rTL4qc7OnTYggtKuQTC060lw11fUdHyiLNOBBlTQNC4FnO/3lHdYeO0ApoTyw2IUo138yW9yZsyAqP4x1KZesEFR1CSF1SUYGPTrZc/XyGAFfyMdhyw3ynSzi0RQ+G+8MLw2ilWkwGK38klwp71JuLNJrLX0szsWnNZ5NAdNc4tWlyOu2ov9ZNV9pBmzWfZymoNbIFpiRUxZu9zc6Wys= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2017 00:11:34.5546 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.60.83]; Helo=[xsj-pvapsmtpgw01] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR02MB1334 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 104.47.34.79 Subject: [Qemu-devel] [PATCH v2 4/5] xlnx-zcu102: Specify the valid CPUs X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ehabkost@redhat.com, f4bug@amsat.org, alistair.francis@xilinx.com, imammedo@redhat.com, marcel@redhat.com, alistair23@gmail.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_6 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" List all possible valid CPU options. Signed-off-by: Alistair Francis --- An implementation for single CPU machines is still being discussed. A solution proposed by Eduardo is this: 1) Change the default on TYPE_MACHINE to: mc->valid_cpu_types =3D { TYPE_CPU, NULL }; This will keep the existing behavior for all boards. 2) mc->valid_cpu_types=3DNULL be interpreted as "no CPU model except the default is accepted" or "-cpu is not accepted" in machine_run_board_init() (I prefer the former, but both options would be correct) 3) Boards like xlnx_zynqmp could then just do this: static void xxx_class_init(...) { mc->default_cpu_type =3D MY_CPU_TYPE; /* Reason: XXX_init() is hardcoded to MY_CPU_TYPE */ mc->valid_cpu_types =3D NULL; } V2: - Don't use the users -cpu - Fixup allignment hw/arm/xlnx-zcu102.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/hw/arm/xlnx-zcu102.c b/hw/arm/xlnx-zcu102.c index 519a16ed98..c6df776d89 100644 --- a/hw/arm/xlnx-zcu102.c +++ b/hw/arm/xlnx-zcu102.c @@ -160,6 +160,11 @@ static void xlnx_zynqmp_init(XlnxZCU102 *s, MachineSta= te *machine) arm_load_kernel(s->soc.boot_cpu_ptr, &xlnx_zcu102_binfo); } =20 +const char *xlnx_zynqmp_valid_cpus[] =3D { + ARM_CPU_TYPE_NAME("cortex-a53"), + NULL + }; + static void xlnx_ep108_init(MachineState *machine) { XlnxZCU102 *s =3D EP108_MACHINE(machine); @@ -185,6 +190,12 @@ static void xlnx_ep108_machine_class_init(ObjectClass = *oc, void *data) mc->block_default_type =3D IF_IDE; mc->units_per_default_bus =3D 1; mc->ignore_memory_transaction_failures =3D true; + mc->default_cpu_type =3D ARM_CPU_TYPE_NAME("cortex-a53"); + /* The ZynqMP SoC is always a Cortex-A53. We add this here to give + * users a sane error if they specify a different CPU, but we never + * use their CPU choice. + */ + mc->valid_cpu_types =3D xlnx_zynqmp_valid_cpus; } =20 static const TypeInfo xlnx_ep108_machine_init_typeinfo =3D { @@ -240,6 +251,12 @@ static void xlnx_zcu102_machine_class_init(ObjectClass= *oc, void *data) mc->block_default_type =3D IF_IDE; mc->units_per_default_bus =3D 1; mc->ignore_memory_transaction_failures =3D true; + mc->default_cpu_type =3D ARM_CPU_TYPE_NAME("cortex-a53"); + /* The ZynqMP SoC is always a Cortex-A53. We add this here to give + * users a sane error if they specify a different CPU, but we never + * use their CPU choice. + */ + mc->valid_cpu_types =3D xlnx_zynqmp_valid_cpus; } =20 static const TypeInfo xlnx_zcu102_machine_init_typeinfo =3D { --=20 2.11.0