From nobody Mon Feb 9 10:38:28 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=crudebyte.com ARC-Seal: i=1; a=rsa-sha256; t=1644493501; cv=none; d=zohomail.com; s=zohoarc; b=SOdvH9lYoa+p7kV7vx1unhhWDHYkpoQhNGc3Ju6GHqY9ye/R77PQfjQoY95furAk/Epxa+srYZsWG9PBrXZXMvUsCxESIwbNnc/evGly2SHE0G7b43ktmOkp8msuhjiN9s8QtS2RWGZBUdrbC13UKlxDcHL4uBIP0ptWQCiIcgQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1644493501; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=nol1mgUdNPIinW3AvolOp2b+vCDqiMhIC5upX6MUJlg=; b=ZqHYABM5F79b2JRs/wPEyFAO8oy8FLxf6i4TDR4seUPIPSzajaYl5wrDs/NfU+gVkkvolo4lQi/G4BXI2kjqA2wvLr2E58u+8f+gHmJdQRxZ4JshFlBS38+BJHN2NbnWMzB7zjkpuDzLbUQXNOYl6sT5IMPNZhp1HiiWXr/8Hg4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1644493501242241.1427723698015; Thu, 10 Feb 2022 03:45:01 -0800 (PST) Received: from localhost ([::1]:52020 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nI7si-0002HJ-0F for importer@patchew.org; Thu, 10 Feb 2022 06:45:00 -0500 Received: from eggs.gnu.org ([209.51.188.92]:43324) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <98c520acce46f855d29f5f7c857103975926939e@lizzy.crudebyte.com>) id 1nI7kB-0007eg-Ou for qemu-devel@nongnu.org; Thu, 10 Feb 2022 06:36:14 -0500 Received: from lizzy.crudebyte.com ([91.194.90.13]:44097) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <98c520acce46f855d29f5f7c857103975926939e@lizzy.crudebyte.com>) id 1nI7jp-0003T7-GD for qemu-devel@nongnu.org; Thu, 10 Feb 2022 06:36:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=crudebyte.com; s=lizzy; h=Cc:To:Subject:Date:From:References:In-Reply-To: Message-Id:Content-Type:Content-Transfer-Encoding:MIME-Version:Content-ID: Content-Description; bh=nol1mgUdNPIinW3AvolOp2b+vCDqiMhIC5upX6MUJlg=; b=mABlf eVcgmghIK3MNl5+XXgsZrMAAtnGV/u/yXOH/PxU9EWDORqeXUMLmX8ubt6MzcvUV8o2DneUsZ4dSb 0Z10Xpv2T5QUYwZc3VSVrrpRpLsLsVRhoqU7eRPxZueGeoxqDk56uGReX1IvZm56lYmARTrIJHgxC 676Tbg1pm0CROGB7rT4tTTKY3ztSchkPPmnNsHezwAxq2T6GLo5iH0K45b5wlas+qds0niup/vTPc jiQK7SlGwEiX0dsYqsVqIdh4wNCyvIvv8xVHFld7SlSgdTVtxKxRwekxw/ksXnIqgPAHeyBp7Sghd Zr5zXJoGPzqJ5NrWMN/1R6f0YB6yw==; Message-Id: <98c520acce46f855d29f5f7c857103975926939e.1644492115.git.qemu_oss@crudebyte.com> In-Reply-To: References: From: Christian Schoenebeck Date: Thu, 10 Feb 2022 12:21:55 +0100 Subject: [PULL 3/5] tests/9pfs: Fix leak of local_test_path To: qemu-devel@nongnu.org, Peter Maydell Cc: Greg Kurz Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=91.194.90.13; envelope-from=98c520acce46f855d29f5f7c857103975926939e@lizzy.crudebyte.com; helo=lizzy.crudebyte.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @crudebyte.com) X-ZM-MESSAGEID: 1644493502364100003 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Greg Kurz local_test_path is allocated in virtio_9p_create_local_test_dir() to hold t= he path of the temporary directory. It should be freed in virtio_9p_remove_local_te= st_dir() when the temporary directory is removed. Clarify the lifecycle of local_tes= t_path while here. Based-on: Signed-off-by: Greg Kurz Message-Id: <20220201151508.190035-2-groug@kaod.org> Reviewed-by: Christian Schoenebeck Signed-off-by: Christian Schoenebeck --- tests/qtest/libqos/virtio-9p.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/tests/qtest/libqos/virtio-9p.c b/tests/qtest/libqos/virtio-9p.c index ef96ef006a..5d18e5eae5 100644 --- a/tests/qtest/libqos/virtio-9p.c +++ b/tests/qtest/libqos/virtio-9p.c @@ -39,8 +39,13 @@ static char *concat_path(const char* a, const char* b) =20 void virtio_9p_create_local_test_dir(void) { + g_assert(local_test_path =3D=3D NULL); struct stat st; char *pwd =3D g_get_current_dir(); + /* + * template gets cached into local_test_path and freed in + * virtio_9p_remove_local_test_dir(). + */ char *template =3D concat_path(pwd, "qtest-9p-local-XXXXXX"); =20 local_test_path =3D mkdtemp(template); @@ -66,6 +71,8 @@ void virtio_9p_remove_local_test_dir(void) /* ignore error, dummy check to prevent compiler error */ } g_free(cmd); + g_free(local_test_path); + local_test_path =3D NULL; } =20 char *virtio_9p_test_path(const char *path) --=20 2.20.1