From nobody Wed Aug 26 12:57:33 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1785947011; cv=none; d=zohomail.com; s=zohoarc; b=KtwQdSDDRKdAA4aREjD/zopKLrp5flU5nyWM1vURyb0sb47xRP5juUWsLGJt3fhlOqW46F82yy/q1gfvPkjpDHCWrYWzohEgFO8ILnCUDrQsvD3Ps2EhtFhn8lx0Pr7ZeMP4FLXXB2pFGQJnRwwg7yYff5lqLxojGrnLDx6f1Jw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1785947011; h=Content-Type:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=UV1a1GUQzrfupq7bpNH7AnYHi9xGtwR/UiQyeOUpwiM=; b=j8ELO2JRAR0SUtOoHN+8G2P0MLjfYQAGg0uRQpm2EEST12ukMve1o+Yzt2dsWQjGnUEHzAtNUyQlDv/ykoRzM7+UE9oyxIYQNEvkQSwoZVXK5z2H3hx47TvyskmjpfVDXWBp7GTlSf8AdoqLY7Dvxy+6Gq0JT7jMMzwn7ATsofQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1785947011827148.48021134378484; Wed, 5 Aug 2026 09:23:31 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wreOn-0004GS-AX; Wed, 05 Aug 2026 12:23:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wreOk-0004CN-D8 for qemu-devel@nongnu.org; Wed, 05 Aug 2026 12:23:18 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wreOg-0007S8-CY for qemu-devel@nongnu.org; Wed, 05 Aug 2026 12:23:17 -0400 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-681-nmfqkuB7NhSUJxkEEyqItw-1; Wed, 05 Aug 2026 12:23:09 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1B1A51955BD0; Wed, 5 Aug 2026 16:23:08 +0000 (UTC) Received: from [10.44.32.79] (unknown [10.44.32.79]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9905219560AB; Wed, 5 Aug 2026 16:23:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1785946992; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type; bh=UV1a1GUQzrfupq7bpNH7AnYHi9xGtwR/UiQyeOUpwiM=; b=cNuiEwVKBHv667j/HX2NvBSuBJNs++sEzFT2O8ew2U1EHLXzi3AuV8M2cakmG8wBUTuFMs gIT1qUl4xWyLWwla3xfk4e+VfgF4MWvyF6sB3iV+u35cES/kQ8Q7o8CknT89vUfi9CHT0o /9s9Q+3VzPAxpyGpklSojUJ9IibB4wU= X-MC-Unique: nmfqkuB7NhSUJxkEEyqItw-1 X-Mimecast-MFC-AGG-ID: nmfqkuB7NhSUJxkEEyqItw_1785946988 Date: Wed, 5 Aug 2026 18:23:04 +0200 (CEST) From: Mikulas Patocka To: Yoshinori Sato , Richard Henderson cc: qemu-devel@nongnu.org Subject: [PATCH v2] linux-user/sh4: Deliver SIGILL on invalid instruction Message-ID: <9691a731-5d0c-15b7-e773-60bac1f54fc8@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=mpatocka@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 4 X-Spam_score: 0.4 X-Spam_bar: / X-Spam_report: (0.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.852, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1785947012924158501 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" On invalid instruction, deliver SIGILL rather than crashing the whole process unconditionally. Cc: qemu-stable@nongnu.org Signed-off-by: Mikulas Patocka Reviewed-by: Richard Henderson Reviewed-by: Yoshinori Sato --- linux-user/sh4/cpu_loop.c | 7 +++++++ 1 file changed, 7 insertions(+) Index: qemu/linux-user/sh4/cpu_loop.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- qemu.orig/linux-user/sh4/cpu_loop.c 2026-08-05 18:05:44.000000000 +0200 +++ qemu/linux-user/sh4/cpu_loop.c 2026-08-05 18:12:12.000000000 +0200 @@ -64,6 +64,13 @@ void cpu_loop(CPUSH4State *env) cpu_exec_step_atomic(cs); arch_interrupt =3D false; break; + case 0x180: + /* Illegal instruction */ + /* fallthrough */ + case 0x1a0: + /* Illegal instruction in delay slot */ + force_sig_fault(TARGET_SIGILL, TARGET_ILL_ILLOPC, env->pc); + break; default: fprintf(stderr, "Unhandled trap: 0x%x\n", trapnr); cpu_dump_state(cs, stderr, 0);