From nobody Sat Apr 11 23:08:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=eik.bme.hu Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773010214177757.6181783929916; Sun, 8 Mar 2026 15:50:14 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vzMw8-0003oQ-CX; Sun, 08 Mar 2026 18:49:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vzMw6-0003no-MO for qemu-devel@nongnu.org; Sun, 08 Mar 2026 18:49:22 -0400 Received: from zero.eik.bme.hu ([152.66.115.2]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vzMw4-0005TO-O0 for qemu-devel@nongnu.org; Sun, 08 Mar 2026 18:49:22 -0400 Received: from localhost (localhost [127.0.0.1]) by zero.eik.bme.hu (Postfix) with ESMTP id 9CF15596D97; Sun, 08 Mar 2026 23:49:18 +0100 (CET) Received: from zero.eik.bme.hu ([127.0.0.1]) by localhost (zero.eik.bme.hu [127.0.0.1]) (amavis, port 10028) with ESMTP id Z3v3a1X3OU56; Sun, 8 Mar 2026 23:49:16 +0100 (CET) Received: by zero.eik.bme.hu (Postfix, from userid 432) id 9C15F5969FD; Sun, 08 Mar 2026 23:49:16 +0100 (CET) X-Virus-Scanned: amavis at eik.bme.hu Message-ID: <90b49357b6bf80bcf8962331575ffd16a96b706a.1773009887.git.balaton@eik.bme.hu> In-Reply-To: References: From: BALATON Zoltan Subject: [PATCH 1/2] ati-vga: Simplify hw cursor drawing To: qemu-devel@nongnu.org Cc: Gerd Hoffmann , marcandre.lureau@redhat.com, Chad Jablonski Date: Sun, 08 Mar 2026 23:49:16 +0100 (CET) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=152.66.115.2; envelope-from=balaton@eik.bme.hu; helo=zero.eik.bme.hu X-Spam_score_int: -1 X-Spam_score: -0.2 X-Spam_bar: / X-Spam_report: (-0.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.819, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.903, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZM-MESSAGEID: 1773010217761154100 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Avoid calculating index at every step when we can just count the position. Signed-off-by: BALATON Zoltan Reviewed-by: Chad Jablonski --- hw/display/ati.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/display/ati.c b/hw/display/ati.c index be41f2e0e2..7543065456 100644 --- a/hw/display/ati.c +++ b/hw/display/ati.c @@ -200,7 +200,7 @@ static void ati_cursor_draw_line(VGACommonState *vga, u= int8_t *d, int scr_y) ATIVGAState *s =3D container_of(vga, ATIVGAState, vga); uint32_t srcoff; uint32_t *dp =3D (uint32_t *)d; - int i, j, h; + int i, j, h, idx =3D 0; =20 if (!(s->regs.crtc_gen_cntl & CRTC2_CUR_EN) || scr_y < vga->hw_cursor_y || scr_y >=3D vga->hw_cursor_y + 64 || @@ -215,10 +215,10 @@ static void ati_cursor_draw_line(VGACommonState *vga,= uint8_t *d, int scr_y) uint32_t color; uint8_t abits =3D vga_read_byte(vga, srcoff + i); uint8_t xbits =3D vga_read_byte(vga, srcoff + i + 8); - for (j =3D 0; j < 8; j++, abits <<=3D 1, xbits <<=3D 1) { + for (j =3D 0; j < 8; j++, abits <<=3D 1, xbits <<=3D 1, idx++) { if (abits & BIT(7)) { if (xbits & BIT(7)) { - color =3D dp[i * 8 + j] ^ 0xffffffff; /* complement */ + color =3D dp[idx] ^ 0xffffffff; /* complement */ } else { continue; /* transparent, no change */ } @@ -226,10 +226,10 @@ static void ati_cursor_draw_line(VGACommonState *vga,= uint8_t *d, int scr_y) color =3D (xbits & BIT(7) ? s->regs.cur_color1 : s->regs.cur_color0) | 0xff000000; } - if (vga->hw_cursor_x + i * 8 + j >=3D h) { + if (vga->hw_cursor_x + idx >=3D h) { return; /* end of screen, don't span to next line */ } - dp[i * 8 + j] =3D color; + dp[idx] =3D color; } } } --=20 2.41.3