From nobody Sat May 18 06:31:27 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=protonmail.com ARC-Seal: i=1; a=rsa-sha256; t=1619820749; cv=none; d=zohomail.com; s=zohoarc; b=A6w2Y2adYi0UO+YmyAz/xkOQ6Wk1mcYkCmgL0/YAsT330ECLpTPN4DWiGAZ94bhOazCiFp4bdADGy18bqAXnC22OLxDECwi27D+kvwI8zHaeW/eNtS22JNXV53Tglf3U0z2ww2DW74EMrym4Em3JJHO+q0RUS5QqLDfQCvWRklA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1619820749; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=/UTzgRglq2koKH0w/UaBTvK78WfrbfeSRziifYBYPzY=; b=Uge/3OZlEFYe3EzWN/pqC6SQMV4HcrfoodtJ0XCvvyu6a5bHPqJ4ndohk7ZRM3OFBdjrxMZDy0AJGM8Zgqt7ZcvsC0OX+pZ0FSXykaQBPx5pibAecME0pe5SWpYFQGjGFci6SB6PEv1YHC1ugKlJICE7/454obynJSF3rqS3xL0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 161982074916896.84891127726632; Fri, 30 Apr 2021 15:12:29 -0700 (PDT) Received: from localhost ([::1]:46324 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lcbN3-0007CH-R2 for importer@patchew.org; Fri, 30 Apr 2021 18:12:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36364) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lcamt-0007jj-OH; Fri, 30 Apr 2021 17:35:03 -0400 Received: from mail-40137.protonmail.ch ([185.70.40.137]:58355) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lcamq-0000m2-LE; Fri, 30 Apr 2021 17:35:03 -0400 Date: Fri, 30 Apr 2021 21:34:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1619818490; bh=/UTzgRglq2koKH0w/UaBTvK78WfrbfeSRziifYBYPzY=; h=Date:To:From:Cc:Reply-To:Subject:From; b=RvgEKSMg5kmpomKF9knhF0kId3h4w5waPyAPY+RHcBN5CIWHml75u2Npms+ACZLN7 QgTsViL4AO5sqt2dEAomx0A00Y6cAc8UlbJgMVdpRfPW2zKAmWW3QfDQE6S/wi64Ct vJluYIyyrzWfshv6jWz7WprNPRnJa4rH0EYmqLXg= To: "qemu-devel@nongnu.org" From: cennedee Cc: Paolo Bonzini , Fam Zheng , Juan Quintela , "qemu-block@nongnu.org" , "mreitz@redhat.com" , "Dr. David Alan Gilbert" , Kevin Wolf , John Snow , Stefan Hajnoczi , "qemu-trivial@nongnu.org" Subject: [PATCH] Add missing coroutine_fn function signature to functions Message-ID: <8y2vfZuyQoZPUsO-9E_Vl_x5LG4S3-ewrNqvmbgOTUHPglYpU2A0-jjdIh78JySlGCqhHgfXXezC_HGTIbSdlsqcT9YzUKr0b_FKp1OLk00=@protonmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=185.70.40.137; envelope-from=cennedee@protonmail.com; helo=mail-40137.protonmail.ch X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Fri, 30 Apr 2021 18:11:42 -0400 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: cennedee Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @protonmail.com) Content-Type: text/plain; charset="utf-8" From 447601c28d5ed0b1208a0560390f760e75ce5613 Mon Sep 17 00:00:00 2001 From: Cenne Dee Date: Fri, 30 Apr 2021 15:52:28 -0400 Subject: [PATCH] Add missing coroutine_fn function signature to functions Patch adds the signature for all relevant functions ending with _co or those that use them. Signed-off-by: Cenne Dee --- block/block-gen.h | 2 +- migration/migration.c | 2 +- monitor/hmp.c | 2 +- scsi/qemu-pr-helper.c | 2 +- tests/unit/test-thread-pool.c | 4 ++-- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a/block/block-gen.h b/block/block-gen.h index f80cf48..4963372 100644 --- a/block/block-gen.h +++ b/block/block-gen.h @@ -36,7 +36,7 @@ typedef struct BdrvPollCo { Coroutine *co; /* Keep pointer here for debugging */ } BdrvPollCo; -static inline int bdrv_poll_co(BdrvPollCo *s) +static inline int coroutine_fn bdrv_poll_co(BdrvPollCo *s) { assert(!qemu_in_coroutine()); diff --git a/migration/migration.c b/migration/migration.c index 8ca0341..1acade8 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -539,7 +539,7 @@ static void process_incoming_migration_bh(void *opaque) migration_incoming_state_destroy(); } -static void process_incoming_migration_co(void *opaque) +static void coroutine_fn process_incoming_migration_co(void *opaque) { MigrationIncomingState *mis =3D migration_incoming_get_current(); PostcopyState ps; diff --git a/monitor/hmp.c b/monitor/hmp.c index 6c0b33a..0a16d61 100644 --- a/monitor/hmp.c +++ b/monitor/hmp.c @@ -1068,7 +1068,7 @@ typedef struct HandleHmpCommandCo { bool done; } HandleHmpCommandCo; -static void handle_hmp_command_co(void *opaque) +static void coroutine_fn handle_hmp_command_co(void *opaque) { HandleHmpCommandCo *data =3D opaque; data->cmd->cmd(data->mon, data->qdict); diff --git a/scsi/qemu-pr-helper.c b/scsi/qemu-pr-helper.c index 7b9389b..7c1ed2a 100644 --- a/scsi/qemu-pr-helper.c +++ b/scsi/qemu-pr-helper.c @@ -175,7 +175,7 @@ static int do_sgio_worker(void *opaque) return status; } -static int do_sgio(int fd, const uint8_t *cdb, uint8_t *sense, +static int coroutine_fn do_sgio(int fd, const uint8_t *cdb, uint8_t *sense, uint8_t *buf, int *sz, int dir) { ThreadPool *pool =3D aio_get_thread_pool(qemu_get_aio_context()); diff --git a/tests/unit/test-thread-pool.c b/tests/unit/test-thread-pool.c index 70dc631..21fc118 100644 --- a/tests/unit/test-thread-pool.c +++ b/tests/unit/test-thread-pool.c @@ -72,7 +72,7 @@ static void test_submit_aio(void) g_assert_cmpint(data.ret, =3D=3D, 0); } -static void co_test_cb(void *opaque) +static void coroutine_fn co_test_cb(void *opaque) { WorkerTestData *data =3D opaque; @@ -90,7 +90,7 @@ static void co_test_cb(void *opaque) /* The test continues in test_submit_co, after aio_poll... */ } -static void test_submit_co(void) +static void coroutine_fn test_submit_co(void) { WorkerTestData data; Coroutine *co =3D qemu_coroutine_create(co_test_cb, &data); -- 2.31.1