From nobody Wed Nov 5 02:58:19 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail header.i=@wdc.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1531859443598968.9586728804113; Tue, 17 Jul 2018 13:30:43 -0700 (PDT) Received: from localhost ([::1]:33148 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ffWcE-0001dK-7z for importer@patchew.org; Tue, 17 Jul 2018 16:30:34 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49421) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ffWaH-0008VR-6g for qemu-devel@nongnu.org; Tue, 17 Jul 2018 16:28:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ffWaE-0005h3-1i for qemu-devel@nongnu.org; Tue, 17 Jul 2018 16:28:33 -0400 Received: from esa3.hgst.iphmx.com ([216.71.153.141]:20646) by eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71) (envelope-from ) id 1ffWaD-0005gc-KD for qemu-devel@nongnu.org; Tue, 17 Jul 2018 16:28:29 -0400 Received: from mail-cys01nam02lp0052.outbound.protection.outlook.com (HELO NAM02-CY1-obe.outbound.protection.outlook.com) ([207.46.163.52]) by ob1.hgst.iphmx.com with ESMTP; 18 Jul 2018 04:28:29 +0800 Received: from risc6-mainframe.int.fusionio.com (199.255.44.250) by BN6PR04MB0389.namprd04.prod.outlook.com (2603:10b6:404:91::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.952.17; Tue, 17 Jul 2018 20:28:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1531859310; x=1563395310; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=Z/sogBiN0ay1POHuPGblX40zyyO2mF0oW+LCGZoiE+I=; b=mmTdXXfRBzD7VZduu8b6hXuFJiyl4MRQwkYx58+dE3WYZ31b+sw3bL3D V1qEcebKqNOrC9TqtW44MvKRGvlixQ8QFnHDvywqPahN0YJOnAgocopXm EKvEQ8VHiyKtF1W7P66YvA4fVTqNqZRos22zRO2PaqfTlRY2vozyX2MT5 NvYbmwtk9o8Ns4BJRMDxpjuovR6bBvmFznlizTxGxxdCkhtnGy6yXizIN brBzYUefQx4qK4+0/0mfmiLB0vALp94jRERCIESXlBqhZFm54zmbg8UZn HJuASaz53BxcMI0LEBQK69RbL+abdfc38CuZ5NzNtxLz1j1NtEaWsdGy4 A==; X-IronPort-AV: E=Sophos;i="5.51,366,1526313600"; d="scan'208";a="87467638" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector1-wdc-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qQ7P+oU+jXRgyif9+EFsk5+IU5pxNWhdwoP3eCbwOTw=; b=QcCk+guxfRy54ydma7QUfUB80OZuXkyTmHovNty6xBuqaV4cPMJcWSYB5GSg6qgqaeQh71Qy2RbwItjz+MC7hHuHnx8Dm0/2611q6Soj2czMa0IBFPTlUUkKg9qoWxGBJMzOB3nrVhfMZnWLRreTXdWDmH378OcswQBWfU6y8lU= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Alistair.Francis@wdc.com; From: Alistair Francis To: qemu-devel@nongnu.org Date: Tue, 17 Jul 2018 13:28:15 -0700 Message-Id: <8a6a1a1a1056023dc79179399c11e059fbdcde1a.1531859179.git.alistair.francis@wdc.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: MIME-Version: 1.0 X-Originating-IP: [199.255.44.250] X-ClientProxiedBy: BYAPR04CA0023.namprd04.prod.outlook.com (2603:10b6:a03:40::36) To BN6PR04MB0389.namprd04.prod.outlook.com (2603:10b6:404:91::18) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7f5591b2-d749-494b-45b2-08d5ec23d933 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600053)(711020)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(48565401081)(2017052603328)(7153060)(7193020); SRVR:BN6PR04MB0389; X-Microsoft-Exchange-Diagnostics: 1; BN6PR04MB0389; 3:cO+TAApIrbaCShjBdwCXGzNQ3ANvatawi1z6nlE41c9vfLAxNurjbhYT/45dl5LLaHQM83pOxO2mhIT5cWXseQk8+vehCUkGrSB+XSaZ/j5lpJSyaYCXjhthgw+K4Tkr58luIrbW1/31kPBYgiKYC4bqc3cEnX3gdZzNlw8TU3irt1MkmplFOXKwNfSXUHbPT6pphHafi8wdBVrIHGaeq7I5zKM6T8aYkTaUe/5GQrI0aPeBgMneKDLeeTntVDhZ; 25:dO2i5aHP5URVNQ0eH4GAWIPsFrTqPnnznLcb1BlUYwpRkDAOpWYRK4/ZgLzNX940Sg3vOU3dKk/aH9kGobKHuknca9+3wcKtumT7/Y8ZbqoKbS9/zB5OV7AbTnB7l3pFzEUJ1mUKu3iklg3F5z8OR7xTmzOE1oHboGaAmbKC/JSWRp3qCIxgTa+UXKOdB3itM/IxniIQbrwHyso12ofWuhyzF2qrZxvLdejSRjSt/nrVIb+A8WP2ZbRzvUL1KQ+29zUj6V3Zrjk6SIkzv3GUR4hdWajXf1aT9On6Zm8q4+X2L9IPS3cQQ02goDgCy6v3w/KxYXusE5k9XJzl94al8w==; 31:cYOqTYhPndwxh4FBje/RBWQMDEDuKXgYdRi7S5RqLaWMaem6Ia1qifQhW/CpADBQgjUaCn3tLzN+kVK7cL+iS3Jv2mWlALN7zSfmoOzai3u/LaIH/WJOGM0S2qS7FyAhXrG6Y1xxz7bojz1Dvv5+1e8N//wpRO7GPFfeRQkCJt6aUVDCBz+YRTmCO5hyUAPVjs2nUNoTUzN0t42q5EqEIuS+1s70hz9UZteCAQki9p4= X-MS-TrafficTypeDiagnostic: BN6PR04MB0389: WDCIPOUTBOUND: EOP-TRUE X-Microsoft-Exchange-Diagnostics: 1; BN6PR04MB0389; 20:jMNbNWtVU3Krfd5okYT03uwcMtJeME7wUWBpqBX9x+Xflf7Yg0zqr/c1DDtaiDrjsqQo7ROQsqrVtp2Vqdy0vVD0NibI5XG675jQyyGo63bbwG02qWQn6boZ2UmKlwaYZt+ulTWqx6GcbAK2D0CYyI6rB1Agmt3b716cCAa/LuTpdD7v3rFnSml0HiGwjP4ir+NZW/d8M5YW4r2W0NGxWaM8iGBXVaAcZupIw3vCUbT+Uq7vmh9fWoJcSLTzQ3bGFPXZTslqFuaSY/Ef7Lw9gGvKHhhqsp6VVSzhMt7mI4x5JywD/dCdOce5pUebPaSDG56KDC7JxSVcP0/AdzofFv10Whf6Q2IfwMA/H1pxxBA9/QB8zsK9pvy9pa7NLVTCPU6iolTjk6Mr6v7bX47/1KjGh59OHGAxapn9GHbkKlokaXzYqTVNv926/I9x6NGaI+STi087FMCQejBTMfoz8f5aJMbrAYBtmIu97hLmiQP5SiiugZHTQzA6HuHnQmcB; 4:jLZt/WQocvCrjEhuKne7sLJZr2/YznLz4+yxJlaeYAOeYCW4topcJ4RLBzz3cq04+HmFW+SlRMmJcq/N4A77p6s2PPBk7o+R2JasDJoYv+WERdS7gP2bGYt6x47SH1SSh9J8XMl0XVnqw5VkTMZL27niTRXDeOxvE3sFMZTc0VnuNPf/1zj1UqRIN9ed6otJ+Aje5PeA9UBqEhsn5YTld8Uy/JNpu0BM01LpQvx2nGV1UrSszYd0YpPaMMlmubltCBykwwszj86AkhdpEhcIiA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040522)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93001095)(3231311)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123558120)(20161123564045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(6072148)(201708071742011)(7699016); SRVR:BN6PR04MB0389; BCL:0; PCL:0; RULEID:; SRVR:BN6PR04MB0389; X-Forefront-PRVS: 073631BD3D X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(346002)(376002)(136003)(366004)(396003)(39860400002)(199004)(189003)(106356001)(8936002)(6916009)(47776003)(66066001)(16586007)(105586002)(305945005)(2351001)(316002)(97736004)(7736002)(53936002)(86362001)(6666003)(2906002)(6116002)(3846002)(25786009)(36756003)(72206003)(4326008)(478600001)(44832011)(486006)(2616005)(68736007)(118296001)(956004)(11346002)(52116002)(51416003)(16526019)(26005)(476003)(76176011)(6512007)(186003)(386003)(6506007)(81166006)(8676002)(446003)(81156014)(2361001)(5660300001)(50226002)(6486002)(48376002)(50466002); DIR:OUT; SFP:1102; SCL:1; SRVR:BN6PR04MB0389; H:risc6-mainframe.int.fusionio.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN6PR04MB0389; 23:cnSLkBET/Kcmum9o+StOiN7gYt3HwfVKB0vQ/+z8r?= =?us-ascii?Q?9+J+2VP/3CfoHNjC/6Z9BBCmuwrwk3hRG0t0+7e3GZgUECWpEtmo5/NsIb88?= =?us-ascii?Q?s+PdmMzQqGuCJrnUCcfAvS7qK+xemxu0+/MTdY99lj4JkPtaoRyAtojoHsHF?= =?us-ascii?Q?ljUt3ABmgINt51zHOecpXeyOeA51s2tClJh8ArSQ8z+HyZgdpCwkzyKcnh4L?= =?us-ascii?Q?54Np6GfZqdXK0Wv/1pBQxVwtbI/+3efoOgUJPSlMNSzVwspvoWfxYRMORZS3?= =?us-ascii?Q?KUHP6BA3Lzeq7MSg8E3iOKOO7dBdwnjfCpLRKoj26xtRS61VTDQvOYrVzoEl?= =?us-ascii?Q?2cwrLZrXs99anNpbajWqdgq9d1OT189ltj56LxGt/9pvVedNSRVqnQqVIQ6f?= =?us-ascii?Q?NJCuzsdBS/tsdKIqZ3I5jiWTZL90hPRJFi6TQpZZsGmAeNkualA+msV932mr?= =?us-ascii?Q?3QZuw9IcK69NQCxHPPbpBeAkJtsB7MvqgUQJRFuGS3sNsFpVvLP4N0HzZoso?= =?us-ascii?Q?7ONVQ0w6EPPJNltYR0bEB9yqTl9WulujDsHQrL75N6xgZZRq9RjhDu+5cS+B?= =?us-ascii?Q?Mv4CPFtUqilSmvDTBdB75e+3+oF2Amleo9VTChz/flC+J3VuK4Hw//O5nCrs?= =?us-ascii?Q?bhInq6xv3PZ4go/sjj67xLghYt69EXksch0iv47fFSXP3A0Zcu07NheYSTXX?= =?us-ascii?Q?2iAnrQsGH+6hqy3/TjA2SjGw/gbKTX1Q4Qq3HMo0TCYJS9XRvdd+YeswcfY6?= =?us-ascii?Q?EUXqcx+dFgHDHhtpF+LrCTCKvueHBBMOKjlathTqFI4bHvQondenTlWiLXzY?= =?us-ascii?Q?PPXbRzHZVx983F38SoOSUEIljkMAMyqq6LZmPnniNh1+Kk+LhvR/+3Lhu3zI?= =?us-ascii?Q?KHcoogOY/TsBVqjf7odzT6vOW8OTYC3FuY9klT13mTSe3OlwwmXnWmC3NKfN?= =?us-ascii?Q?0VMrO9nYnHgNBHFG0oMsSpEThtpMPSWzuZlpvSfpbvhSAn8ijvWobWypoUzR?= =?us-ascii?Q?46TBbZlZV9iAMQiIH2Xy1rhE3uj69onRLqoC0sH6zv8llO1HglxV0NnuXZ91?= =?us-ascii?Q?63sDRCl7NkZk9Pl5/aiRU/LVVv7u7s9Ujrj76jG6lcqHlhR3LDYeI0j88xvW?= =?us-ascii?Q?Yg62jjATdG8nXT4cw+4MKtIuSLryszQUMhiZ0aVcI8O5eAHAecPIKxnpsu0O?= =?us-ascii?Q?dQj5SLYOMtp+EPeASvKBinVJBOj4C3TDURyHD7UFwBpj1nsfm1wq0FuVSAxm?= =?us-ascii?Q?Xhf9VEgsbvqYWoHl75LDPtYVNg2eIjg03AmPHnd?= X-Microsoft-Antispam-Message-Info: TIOKUQXtDX3GO3/F28pVsJklzlZTj6YkIB2FhsTaX+M4ui1r13q4D/d5wY5KM2y8yFMBWfxyQzdR46rzzIKVQBhDFpLHNBn+3Xd2VGvaofpRUBnIGS5eWUJr+X1KFIUq+rJWxx15bSi8ySJt4MyP43xrdIVFFdtwPRy5jLl7f4ccuyZ9dHF4fUGO47L8OudnV/yHB9JyJ7ELkmtlcqhuQwQhwQeOrnQ8rfZa5vMdFHI14KdXwO/lpTANOlIAd0XZaEqQqgdQj6wc+fr8MHIUVf1e16DN7OmltgsOCu6WSagt5YCN5sgagtIyxIUgrJqhVADD5mrisW0g+GFq6WVe0hSKZLsL40VyQbcFohtXmLw= X-Microsoft-Exchange-Diagnostics: 1; BN6PR04MB0389; 6:Vrgc+71+STMpEKEV7icDO7Nh8ABNTysJlpdCHz2bROxpsahylizkhbYP1+5bYi+I/mW7dgAkmR03B2b/lmDv3bDEv4Iig/5G/JEHb6c3GhBD3r8Ya3Betw7xLAQzl6hqss0jgDGxw1xrqq4M05ikSfc6AymzjZ2B3dpH+R4pmHjf45ibZggmFAGJlcUxmvScsNvZq7SramaZLCVPLDMK4yQMERn8TCfnVzSHL2UVOxn3OXytEjK1UkDglHeVJ+xYPxC3S5AG1+9wK7aKMHGntLR0Huz7JTAL+XucU7NNKX5FsQAW2JQQyoVzAFCtM0Xp72/6BBOKJvdOwKaMhRF9a2hSYuhP235AFIbzZnYpjBYa8jgu4torLFtV91OCW8MiCusZiYxTItuvjFHTYRfL3wpqcm3IKWMB0WVJXBXY3PuQ8BtXXQ7VnLG/U4ES4U/r/nXJhtDaZzq2EqreUm9Ndg==; 5:ngpej60sNfJWtvyV0HcxQCzwoT6c7bLVhCE7qmIsLZ7Upb0xEmEgfvavxKP7Ze+GpkIT/3uSTzIj8V+sNbu+E7dGL4fuBul13TVCUcqoS33Kk9/FtEN3UOt8iT0L1I1i69x41zJxhs//tnXgvvCSmcWVmljb7+Pgb0dHdmNsdwg=; 24:is5urysm33xPdJtFWDwzRur2ZONnKFTPkLVc1TXnht/POJkiAZPw71xqrx4Wg60Bu+NekVebHkTCygOMX27DPr/V+t4C4bX3W+uk3DBO55I= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BN6PR04MB0389; 7:ruGHscmKevYCOn2f8RaRZkx0LJU3cpYPgKLEBFuSprEupIC9ZohdrIlWAFBMiXzfHug+kaT2heDAnofhegzlF804hUmQuuQQ3blr/7/LhiFttiAozo9m9C/N1BDstqvHIvG2O9W967jqgRmS2HB2cwgaVOPNEyA9syzDMV83aCH7masxryFrihBH4b04FVYC0+Qar5rPyny5iB2AceThoE11CgKK4zjLlxZ78lK4ScQTBC4jHJ+DZ54DqUTa1ZkT; 20:tlV7T2pHTKbD/osWYnum+Tpjn5TIeKWJ7a4Lo3lehwISNhHjxVdQpO9lm7iY9Vw+PalznSlFYMyzGYVP3ldFFN1txdub5K3OnVl0bZE1P1yA7bcKSL/doXnQTZclJJpvF0yg2CWBknX/SJ1sR9oFpn0Nlstgr5Ur8Am/0CcB/GA= X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2018 20:28:25.0936 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7f5591b2-d749-494b-45b2-08d5ec23d933 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR04MB0389 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 216.71.153.141 Subject: [Qemu-devel] [PATCH v1 3/5] virt: Fix crash when introspecting the device X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: thuth@redhat.com, mjc@sifive.com, alistair.francis@wdc.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (found 2 invalid signatures) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use the new object_initialize_child() and sysbus_init_child_obj() to fix the issue. Signed-off-by: Alistair Francis Reviewed-by: Michael Clark --- hw/riscv/virt.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c index aeada2498d..248bbdffd3 100644 --- a/hw/riscv/virt.c +++ b/hw/riscv/virt.c @@ -274,9 +274,8 @@ static void riscv_virt_board_init(MachineState *machine) void *fdt; =20 /* Initialize SOC */ - object_initialize(&s->soc, sizeof(s->soc), TYPE_RISCV_HART_ARRAY); - object_property_add_child(OBJECT(machine), "soc", OBJECT(&s->soc), - &error_abort); + object_initialize_child(OBJECT(machine), "soc", &s->soc, sizeof(s->soc= ), + TYPE_RISCV_HART_ARRAY, &error_abort, NULL); object_property_set_str(OBJECT(&s->soc), VIRT_CPU, "cpu-type", &error_abort); object_property_set_int(OBJECT(&s->soc), smp_cpus, "num-harts", --=20 2.17.1