From nobody Sun Feb 8 18:39:33 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1590130303; cv=none; d=zohomail.com; s=zohoarc; b=Ogl5hMRhjOEd7mJfGb1SBuWNsgx2DKieoc/BtsAqFMSVMi1fS1JLa5yjhsbnBSPHLqfxmP2oaDhONHx5DFNPsMmf9/9cvcd6Pk+YR3oW/NtVf8snlcIPHXF1oGNcAFE52KC0S7DYtM3X271YetPS481zOdVjd+YJrpH0hR9y5aM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1590130303; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=3ugV/slSWVx2cTOAU3Bi0GGVK0xzZgIgXRxXmcFBiok=; b=Okj2HXx8sJ/qAJFYFz64WcUcu8j+KpPRpneJNk5NuA7ClW/+r9vZZG1C+uEU3AlxV8RZdoSRP2kw8TA+aeMSfqeud0awbfmJ/hi/BjCbXla45Bf4heeqwVgX/Nf4Kzz3/Skp8T99Ko2T6kKuNBNQ5sAwREumD38LeEUqBuMexns= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1590130303545475.02355798456017; Thu, 21 May 2020 23:51:43 -0700 (PDT) Received: from localhost ([::1]:56930 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jc1Ww-0002Sh-67 for importer@patchew.org; Fri, 22 May 2020 02:51:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38262) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jc1TJ-0007TD-TS for qemu-devel@nongnu.org; Fri, 22 May 2020 02:47:57 -0400 Received: from mout.web.de ([212.227.15.4]:38849) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jc1TI-000167-PS for qemu-devel@nongnu.org; Fri, 22 May 2020 02:47:57 -0400 Received: from luklap ([89.247.255.67]) by smtp.web.de (mrweb005 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MHEXc-1jpAdD2DT6-00DKkS; Fri, 22 May 2020 08:47:43 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1590130063; bh=ccn6+rX95KPnZc453AzARCcdDXrnJE3FRVs3VRcf8r8=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:In-Reply-To:References; b=H+VKf/AdfUmmR5GSJpzr3xM6laegk3q1EgUm3PepEXVnHvCEwkhp+TVg+1RyheJy/ 9vYp02NA/2Duee8UaQpB+dRC933Daa8EYLQlV9elSxcy6eUo9IjeLsEvyr8Ei2sC/k GPX1VipTGAknv4LBmHKXHAfQIzBZ6co0vYIFJt1Y= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Date: Fri, 22 May 2020 08:47:42 +0200 From: Lukas Straub To: qemu-devel Subject: [PATCH v6 4/6] net/colo-compare.c: Only hexdump packets if tracing is enabled Message-ID: <8a4db9598051334ae3fa97b73556cdbaac5bbe43.1590129793.git.lukasstraub2@web.de> In-Reply-To: References: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/90druBuHZiQR/w=D3dOHZYB"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Provags-ID: V03:K1:kRqQK+J+UXSe/5J61Czr8joRBqKJwVkRhvNs85XNF3cQQMCew0M wJllyPnCDe9qsnbvdry1Q/yLkkQJ30V8aqRxPxOPnKFIEjljhaZE/Bflv3HAmZFluFxbxpp MPpc51in6IJ0Y2Eg0Bz75n4YUWmqruAzATww30i7WbQN/Sz75xa381GPYlXLZFKjdLFRTaU Lu/RR39FhDiPShC+Cm0qw== X-UI-Out-Filterresults: notjunk:1;V03:K0:tJW2wBz5+UU=:nGtIWeJ/W8oQ0qwWnyDl08 gzNY/rqiS/VwAUMDYygXbf0qcXG1eLf0Nmn4xw2+b37ctjGj3ZVi5kSfeQr0HFWHfwzj/8xof byTrydJJKtlZLsKAWzWvx8FX2cmef+U1/nKE4YHKZ9YPsXnVAV0CBqN/gurGkAPfSLjJaFH1t H0/M3cP5aOTRp5MPlbve8qJWLT0ceBLlt6cQk41KMj/FWf6M4qmNjuv3HFC/gWUMkaTUptyPw 5EIDp65/5Hc0Vr2zovzK1ItKiIQjVQqICG0gvr5iH5JsH4PymnNaZTw1ZVzX/o0SuMgI9QOVb jujkwwBVVYZrTT2bRij+YbBjWAq0EApldbvuN1T3detnJecPYq+VJlAyzloDrfsQnvQjpHIm7 8p0W8YYfWwhzvlwB9G8qYhb5TyJTm14Ni/YspSD5wFXc/Ea1/OKnYbvxSjocLn2b8+/fLQLOS mUAUJe9e/ly3BLFenxjFbhq23ofvaE7Jz2i0SIJUgzFadID9bmVSwTBRjZrp24ZvxbAtHhNd7 JMyu45pPqC52rcj0etllG0eKvX/EXZ2qIw5/tNUHsR2xONRI4Hrqu3BkZ4TAk4XX2BIDxl0QS qiW699rHXG8kuSAfB5N4ghjaaBCbmtv+WX6yz10lniaPmZINte8HmbdKS6sS0mgJyS1fI2HBW e9jluAY5OLAZ05Q21GqF7PTP6mhLl1FIYRmWz8PSl8U6OIx/W0OSGMfjCb4wXqLL4loQAe2EE ZGhqk86xrcxdqgzazJ1IQyGi+gP45Xs1Pn/iP8+IFX2WDOsi46AZfxg9xb/pizDBvUQMmF+aY dXd5Ur9b3/vmlSrugahL2nM0tz8Khz9ROkUiFiBQYwoY6UrDkQh8P9ID09MO3mf5dzojLIqdY AX2maJrIyIelBeYs/RC/DuCKYaDo+bwjz1BzgRIjkhJUSRhNJhUBy0W2M8Nm3fRt4JfiJ4j4l OhJG74YTqrEzY9bntrn4PTRk/BOVwbiwhxD/OHC2eWMw14fx6Sgi96oXGAubaE0RKSmGxSz9t knoDNldmebGeyscp4NqDnCvu43qv45AQHqATp+N5ia3sgsQo6rryt4N2gTSbOTBGalQoKkJu4 x2xRZol98ZJmC8qz5NvgoQYlFBGLlf4emXZrAOt5KxpaklJXrVedqHFsOwtO1i+1XW9FBZFGj KatYUCs5a8s5OQCW9yQYVoxGoS7AVi+EZ8zWTNyI3EUs5EGAB4KEFAitvyffEXTx1UTwLk5SS MEmiX/b2domU85OOz Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=212.227.15.4; envelope-from=lukasstraub2@web.de; helo=mout.web.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/22 02:47:49 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Zhang Chen , Jason Wang , Li Zhijian , =?UTF-8?B?TWFyYy1BbmRyw6k=?= Lureau Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-Zoho-Virus-Status: 1 X-ZohoMail-DKIM: fail (Header signature does not verify) --Sig_/90druBuHZiQR/w=D3dOHZYB Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Else the log will be flooded if there is a lot of network traffic. Signed-off-by: Lukas Straub Reviewed-by: Zhang Chen Reviewed-by: Philippe Mathieu-Daud=C3=A9 Tested-by: Philippe Mathieu-Daud=C3=A9 --- net/colo-compare.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/net/colo-compare.c b/net/colo-compare.c index e47c8c6049..7886444cdf 100644 --- a/net/colo-compare.c +++ b/net/colo-compare.c @@ -483,10 +483,12 @@ sec: g_queue_push_head(&conn->primary_list, ppkt); g_queue_push_head(&conn->secondary_list, spkt); - qemu_hexdump((char *)ppkt->data, stderr, - "colo-compare ppkt", ppkt->size); - qemu_hexdump((char *)spkt->data, stderr, - "colo-compare spkt", spkt->size); + if (trace_event_get_state_backends(TRACE_COLO_COMPARE_MISCOMPARE))= { + qemu_hexdump((char *)ppkt->data, stderr, + "colo-compare ppkt", ppkt->size); + qemu_hexdump((char *)spkt->data, stderr, + "colo-compare spkt", spkt->size); + } colo_compare_inconsistency_notify(s); } -- 2.20.1 --Sig_/90druBuHZiQR/w=D3dOHZYB Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEg/qxWKDZuPtyYo+kNasLKJxdslgFAl7HdY4ACgkQNasLKJxd slhwhw//TU+wzem+FrVD4Tpxz7kbWEYTiflLdPgWo0u7hGRERQN9SwyELU3bosNc HYsraOvdjvrA4bfhn5fSU/L+Mc0iRgHD/yXpjGL+PmRCCY3N9SbSLE/EAD2X78aB vWlgkr3uDXgXctt7VFyhjpcJ6IL7pzH6jUHJk75ZyTsnqdDv/ALKPwEEJ+6W8P/Y zmC5kwgFiyo/VmUzwZGEsDBfy53xZ9Lfvr0C31QyFyel12WkSDr/QVqyYuOhFpET HF/tMfWfpEFpiJVC8WbB0tAyghTVahFZOk47ULKlqq7MbLPkK356MvC2ArD7HLlo zd8czGIxIJi+DP3K5hgsNK6A2IJTToIBe0EdCofXmXxugPtq17zUQmbjv+IpaVSJ /fJ4x8lAVWxNeS3opgmVA4LfoydPtzcu1oL/MQAsWa7fj8p4mhI+QqXtXJhUuUY2 D8zeGgc2DkGCt1ukXkazowuqE/84bVAwVah+V+M2HVx4PvlbvorRHwwU3JZLloOB fnfgzUG6N7bBugqQOSaGHVe/S3IpaiEcZEj2g+84FyjGgy48SejvbC9vmnz1gs0C EugNfRIDbE/5/OQFxdfcn7YHWfI9F9sIs1i97q9hb1eqwfON0xCoNgVBGvQuwx4b SnhbiUrBMeoponp7nLRXQIPgxliF3OSnrDKVABM+Dg8UP3um2Wo= =XpCR -----END PGP SIGNATURE----- --Sig_/90druBuHZiQR/w=D3dOHZYB--