From nobody Sun Apr 12 06:10:29 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=eik.bme.hu Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1772926105750413.3239733154044; Sat, 7 Mar 2026 15:28:25 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vz13a-0005Pb-PN; Sat, 07 Mar 2026 18:27:38 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vz13Z-0005Oy-49 for qemu-devel@nongnu.org; Sat, 07 Mar 2026 18:27:37 -0500 Received: from zero.eik.bme.hu ([2001:738:2001:2001::2001]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vz13W-0004vL-4s for qemu-devel@nongnu.org; Sat, 07 Mar 2026 18:27:36 -0500 Received: from localhost (localhost [127.0.0.1]) by zero.eik.bme.hu (Postfix) with ESMTP id 0E6D0596DA1; Sun, 08 Mar 2026 00:27:33 +0100 (CET) Received: from zero.eik.bme.hu ([127.0.0.1]) by localhost (zero.eik.bme.hu [127.0.0.1]) (amavis, port 10028) with ESMTP id QevSxnqIAYVk; Sun, 8 Mar 2026 00:27:30 +0100 (CET) Received: by zero.eik.bme.hu (Postfix, from userid 432) id E7F61596A3F; Sun, 08 Mar 2026 00:27:30 +0100 (CET) X-Virus-Scanned: amavis at eik.bme.hu Message-ID: <89fd648ce41452d5e69f4f74856f45be0fd91071.1772924827.git.balaton@eik.bme.hu> In-Reply-To: References: From: BALATON Zoltan Subject: [PATCH v4 1/6] memory: Add memory_region_new* functions MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable To: qemu-devel@nongnu.org Cc: Peter Xu , Akihiko Odaki , Paolo Bonzini , Mark Cave-Ayland , Max Filippov , Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Date: Sun, 08 Mar 2026 00:27:30 +0100 (CET) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2001:738:2001:2001::2001; envelope-from=balaton@eik.bme.hu; helo=zero.eik.bme.hu X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZM-MESSAGEID: 1772926109304154100 Content-Type: text/plain; charset="utf-8" These are counterparts of similar memory_region_init* functions but differ in that these allocate the memory region with object_new so the memory region will be managed by QOM and freed with the owner. This behaviour was already documented and the reference tracking is implemented but it could not be used without these functions because memory_region_init* functions call object_initialize that clears the free function of the object so it would not be freed. Signed-off-by: BALATON Zoltan --- include/system/memory.h | 81 +++++++++++++++++++ system/memory.c | 172 ++++++++++++++++++++++++++++++++++++++++ 2 files changed, 253 insertions(+) diff --git a/include/system/memory.h b/include/system/memory.h index d4793a08a7..ab76433c54 100644 --- a/include/system/memory.h +++ b/include/system/memory.h @@ -1324,6 +1324,10 @@ void memory_region_init(MemoryRegion *mr, const char *name, uint64_t size); =20 +MemoryRegion *memory_region_new(Object *owner, + const char *name, + uint64_t size); + /** * memory_region_ref: Add 1 to a memory region's reference count * @@ -1374,6 +1378,12 @@ void memory_region_init_io(MemoryRegion *mr, const char *name, uint64_t size); =20 +MemoryRegion *memory_region_new_io(Object *owner, + const MemoryRegionOps *ops, + void *opaque, + const char *name, + uint64_t size); + /** * memory_region_init_ram_flags_nomigrate: Initialize RAM memory region. * Accesses into the region will @@ -1400,6 +1410,12 @@ bool memory_region_init_ram_flags_nomigrate(MemoryRe= gion *mr, uint32_t ram_flags, Error **errp); =20 +MemoryRegion *memory_region_new_ram_flags_nomigrate(Object *owner, + const char *name, + uint64_t size, + uint32_t ram_flags, + Error **errp); + /** * memory_region_init_resizeable_ram: Initialize memory region with resiz= able * RAM. Accesses into the region will @@ -1432,6 +1448,16 @@ bool memory_region_init_resizeable_ram(MemoryRegion = *mr, uint64_t length, void *host), Error **errp); + +MemoryRegion *memory_region_new_resizeable_ram(Object *owner, + const char *name, + uint64_t size, + uint64_t max_size, + void (*resized)(const char*, + uint64_t le= ngth, + void *host), + Error **errp); + #ifdef CONFIG_POSIX =20 /** @@ -1467,6 +1493,15 @@ bool memory_region_init_ram_from_file(MemoryRegion *= mr, ram_addr_t offset, Error **errp); =20 +MemoryRegion *memory_region_new_ram_from_file(Object *owner, + const char *name, + uint64_t size, + uint64_t align, + uint32_t ram_flags, + const char *path, + ram_addr_t offset, + Error **errp); + /** * memory_region_init_ram_from_fd: Initialize RAM memory region with a * mmap-ed backend. @@ -1495,6 +1530,15 @@ bool memory_region_init_ram_from_fd(MemoryRegion *mr, int fd, ram_addr_t offset, Error **errp); + +MemoryRegion *memory_region_new_ram_from_fd(Object *owner, + const char *name, + uint64_t size, + uint32_t ram_flags, + int fd, + ram_addr_t offset, + Error **errp); + #endif =20 /** @@ -1518,6 +1562,11 @@ void memory_region_init_ram_ptr(MemoryRegion *mr, uint64_t size, void *ptr); =20 +MemoryRegion *memory_region_new_ram_ptr(Object *owner, + const char *name, + uint64_t size, + void *ptr); + /** * memory_region_init_ram_device_ptr: Initialize RAM device memory region= from * a user-provided pointer. @@ -1546,6 +1595,11 @@ void memory_region_init_ram_device_ptr(MemoryRegion = *mr, uint64_t size, void *ptr); =20 +MemoryRegion *memory_region_new_ram_device_ptr(Object *owner, + const char *name, + uint64_t size, + void *ptr); + /** * memory_region_init_alias: Initialize a memory region that aliases all o= r a * part of another memory region. @@ -1565,6 +1619,12 @@ void memory_region_init_alias(MemoryRegion *mr, hwaddr offset, uint64_t size); =20 +MemoryRegion *memory_region_new_alias(Object *owner, + const char *name, + MemoryRegion *orig, + hwaddr offset, + uint64_t size); + /** * memory_region_init_iommu: Initialize a memory region of a custom type * that translates addresses @@ -1630,6 +1690,16 @@ bool memory_region_init_ram_guest_memfd(MemoryRegion= *mr, uint64_t size, Error **errp); =20 +MemoryRegion *memory_region_new_ram(Object *owner, + const char *name, + uint64_t size, + Error **errp); + +MemoryRegion *memory_region_new_ram_guest_memfd(Object *owner, + const char *name, + uint64_t size, + Error **errp); + /** * memory_region_init_rom: Initialize a ROM memory region. * @@ -1659,6 +1729,11 @@ bool memory_region_init_rom(MemoryRegion *mr, uint64_t size, Error **errp); =20 +MemoryRegion *memory_region_new_rom(Object *owner, + const char *name, + uint64_t size, + Error **errp); + /** * memory_region_init_rom_device: Initialize a ROM memory region. * Writes are handled via callbacks. @@ -1694,6 +1769,12 @@ bool memory_region_init_rom_device(MemoryRegion *mr, uint64_t size, Error **errp); =20 +MemoryRegion *memory_region_new_rom_device(Object *owner, + const MemoryRegionOps *ops, + void *opaque, + const char *name, + uint64_t size, + Error **errp); =20 /** * memory_region_owner: get a memory region's owner. diff --git a/system/memory.c b/system/memory.c index f1db72eb42..4fee87e041 100644 --- a/system/memory.c +++ b/system/memory.c @@ -1251,6 +1251,15 @@ void memory_region_init(MemoryRegion *mr, memory_region_do_init(mr, owner, name, size); } =20 +MemoryRegion *memory_region_new(Object *owner, const char *name, uint64_t = size) +{ + MemoryRegion *mr =3D MEMORY_REGION(object_new(TYPE_MEMORY_REGION)); + + assert(name); /* mr is attached to owner by name */ + memory_region_do_init(mr, owner, name, size); + return mr; +} + static void memory_region_get_container(Object *obj, Visitor *v, const char *name, void *opaque, Error **errp) @@ -1576,6 +1585,16 @@ void memory_region_init_io(MemoryRegion *mr, Object = *owner, memory_region_set_ops(mr, ops, opaque); } =20 +MemoryRegion *memory_region_new_io(Object *owner, + const MemoryRegionOps *ops, void *opaqu= e, + const char *name, uint64_t size) +{ + MemoryRegion *mr =3D memory_region_new(owner, name, size); + + memory_region_set_ops(mr, ops, opaque); + return mr; +} + static bool memory_region_set_ram_block(MemoryRegion *mr, RAMBlock *rb) { mr->ram =3D true; @@ -1601,6 +1620,18 @@ bool memory_region_init_ram_flags_nomigrate(MemoryRe= gion *mr, Object *owner, return memory_region_set_ram_block(mr, rb); } =20 +MemoryRegion *memory_region_new_ram_flags_nomigrate(Object *owner, + const char *name, + uint64_t size, + uint32_t ram_flags, + Error **errp) +{ + MemoryRegion *mr =3D memory_region_new(owner, name, size); + RAMBlock *rb =3D qemu_ram_alloc(size, ram_flags, mr, errp); + + return memory_region_set_ram_block(mr, rb) ? mr : NULL; +} + bool memory_region_init_resizeable_ram(MemoryRegion *mr, Object *owner, const char *name, @@ -1618,6 +1649,21 @@ bool memory_region_init_resizeable_ram(MemoryRegion = *mr, return memory_region_set_ram_block(mr, rb); } =20 +MemoryRegion *memory_region_new_resizeable_ram(Object *owner, + const char *name, + uint64_t size, + uint64_t max_size, + void (*resized)(const char*, + uint64_t le= ngth, + void *host), + Error **errp) +{ + MemoryRegion *mr =3D memory_region_new(owner, name, size); + RAMBlock *rb =3D qemu_ram_alloc_resizeable(size, max_size, resized, mr= , errp); + + return memory_region_set_ram_block(mr, rb) ? mr : NULL; +} + #if defined(CONFIG_POSIX) && !defined(EMSCRIPTEN) bool memory_region_init_ram_from_file(MemoryRegion *mr, Object *owner, const char *name, uint64_t size, @@ -1634,6 +1680,24 @@ bool memory_region_init_ram_from_file(MemoryRegion *= mr, Object *owner, return memory_region_set_ram_block(mr, rb); } =20 +MemoryRegion *memory_region_new_ram_from_file(Object *owner, + const char *name, + uint64_t size, + uint64_t align, + uint32_t ram_flags, + const char *path, + ram_addr_t offset, + Error **errp) +{ + MemoryRegion *mr =3D memory_region_new(owner, name, size); + RAMBlock *rb; + + mr->readonly =3D !!(ram_flags & RAM_READONLY); + mr->align =3D align; + rb =3D qemu_ram_alloc_from_file(size, mr, ram_flags, path, offset, err= p); + return memory_region_set_ram_block(mr, rb) ? mr : NULL; +} + bool memory_region_init_ram_from_fd(MemoryRegion *mr, Object *owner, const char *name, uint64_t size, uint32_t ram_flags, int fd, @@ -1647,6 +1711,20 @@ bool memory_region_init_ram_from_fd(MemoryRegion *mr= , Object *owner, false, errp); return memory_region_set_ram_block(mr, rb); } + +MemoryRegion *memory_region_new_ram_from_fd(Object *owner, + const char *name, uint64_t siz= e, + uint32_t ram_flags, int fd, + ram_addr_t offset, Error **err= p) +{ + MemoryRegion *mr =3D memory_region_new(owner, name, size); + RAMBlock *rb; + + mr->readonly =3D !!(ram_flags & RAM_READONLY); + rb =3D qemu_ram_alloc_from_fd(size, size, NULL, mr, ram_flags, fd, off= set, + false, errp); + return memory_region_set_ram_block(mr, rb) ? mr : NULL; +} #endif =20 static void memory_region_set_ram_ptr(MemoryRegion *mr, uint64_t size, @@ -1666,6 +1744,15 @@ void memory_region_init_ram_ptr(MemoryRegion *mr, Ob= ject *owner, memory_region_set_ram_ptr(mr, size, ptr); } =20 +MemoryRegion *memory_region_new_ram_ptr(Object *owner, const char *name, + uint64_t size, void *ptr) +{ + MemoryRegion *mr =3D memory_region_new(owner, name, size); + + memory_region_set_ram_ptr(mr, size, ptr); + return mr; +} + void memory_region_init_ram_device_ptr(MemoryRegion *mr, Object *owner, const char *name, uint64_t size, void *ptr) @@ -1675,6 +1762,17 @@ void memory_region_init_ram_device_ptr(MemoryRegion = *mr, Object *owner, memory_region_set_ram_ptr(mr, size, ptr); } =20 +MemoryRegion *memory_region_new_ram_device_ptr(Object *owner, const char *= name, + uint64_t size, void *ptr) +{ + MemoryRegion *mr =3D memory_region_new(owner, name, size); + + memory_region_set_ops(mr, &ram_device_mem_ops, mr); + mr->ram_device =3D true; + memory_region_set_ram_ptr(mr, size, ptr); + return mr; +} + void memory_region_init_alias(MemoryRegion *mr, Object *owner, const char *name, MemoryRegion *orig, hwaddr offset, uint64_t size) @@ -1684,6 +1782,17 @@ void memory_region_init_alias(MemoryRegion *mr, Obje= ct *owner, mr->alias_offset =3D offset; } =20 +MemoryRegion *memory_region_new_alias(Object *owner, + const char *name, MemoryRegion *orig, + hwaddr offset, uint64_t size) +{ + MemoryRegion *mr =3D memory_region_new(owner, name, size); + + mr->alias =3D orig; + mr->alias_offset =3D offset; + return mr; +} + void memory_region_init_iommu(void *_iommu_mr, size_t instance_size, const char *mrtypename, @@ -3659,6 +3768,19 @@ bool memory_region_init_ram(MemoryRegion *mr, Object= *owner, return true; } =20 +MemoryRegion *memory_region_new_ram(Object *owner, + const char *name, uint64_t size, + Error **errp) +{ + MemoryRegion *mr; + + mr =3D memory_region_new_ram_flags_nomigrate(owner, name, size, 0, err= p); + if (mr) { + memory_region_register_ram(mr, owner); + } + return mr; +} + bool memory_region_init_ram_guest_memfd(MemoryRegion *mr, Object *owner, const char *name, uint64_t size, Error **errp) @@ -3671,6 +3793,21 @@ bool memory_region_init_ram_guest_memfd(MemoryRegion= *mr, Object *owner, return true; } =20 +MemoryRegion *memory_region_new_ram_guest_memfd(Object *owner, + const char *name, + uint64_t size, + Error **errp) +{ + MemoryRegion *mr; + + mr =3D memory_region_new_ram_flags_nomigrate(owner, name, size, + RAM_GUEST_MEMFD, errp); + if (mr) { + memory_region_register_ram(mr, owner); + } + return mr; +} + bool memory_region_init_rom(MemoryRegion *mr, Object *owner, const char *name, uint64_t size, Error **errp) @@ -3684,6 +3821,20 @@ bool memory_region_init_rom(MemoryRegion *mr, Object= *owner, return true; } =20 +MemoryRegion *memory_region_new_rom(Object *owner, + const char *name, uint64_t size, + Error **errp) +{ + MemoryRegion *mr; + + mr =3D memory_region_new_ram_flags_nomigrate(owner, name, size, 0, err= p); + if (mr) { + mr->readonly =3D true; + memory_region_register_ram(mr, owner); + } + return mr; +} + bool memory_region_init_rom_device(MemoryRegion *mr, Object *owner, const MemoryRegionOps *ops, void *opaqu= e, const char *name, uint64_t size, @@ -3703,6 +3854,27 @@ bool memory_region_init_rom_device(MemoryRegion *mr,= Object *owner, return false; } =20 +MemoryRegion *memory_region_new_rom_device(Object *owner, + const MemoryRegionOps *ops, + void *opaque, + const char *name, uint64_t size, + Error **errp) +{ + MemoryRegion *mr; + RAMBlock *rb; + + assert(ops); + mr =3D memory_region_new_io(owner, ops, opaque, name, size); + rb =3D qemu_ram_alloc(size, 0, mr, errp); + if (memory_region_set_ram_block(mr, rb)) { + mr->ram =3D false; + mr->rom_device =3D true; + memory_region_register_ram(mr, owner); + return mr; + } + return NULL; +} + /* * Support system builds with CONFIG_FUZZ using a weak symbol and a stub f= or * the fuzz_dma_read_cb callback --=20 2.41.3