From nobody Mon Feb 9 17:07:24 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1770232138; cv=none; d=zohomail.com; s=zohoarc; b=MSMc0CNtEPREHkbKkOSOeaRKacywq3lEgenE9/7O9xXrk2vl6d2poAfJOUnoXrvmyAUCvr1T3KMp5hMho3iGBdsM0TC37UfpBuhqYDzzphF9M+NEFXRAl9PK4J+5BGP9VIIQCFbO74e3Jaig2/Iwa01FJnU7tgmawSrux9+M8AA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770232138; h=Content-Type:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=+939riydvwDd27jqC2atSYgpM2eosXh2uo/JqY9/3xU=; b=k5Rv6/yRkmFrZivIBqQGgm7bXbR6DbRLoMNFwi98BHTodDdWQEY9ti1xq24BCla+0GpRwym3ctp614dQQNlZMZ67/zZsZQrYxl/l77TwIIW77TkurY4yjOBcHV0s5TIthSBDxw3D5S6+Xa+3G3WhGd0EYnmk/6U6Guh1VyJSsaU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770232138623614.349270069577; Wed, 4 Feb 2026 11:08:58 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vniA4-00070l-7p; Wed, 04 Feb 2026 14:03:36 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vniA1-0006qm-VR for qemu-devel@nongnu.org; Wed, 04 Feb 2026 14:03:33 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vniA0-0007mk-C4 for qemu-devel@nongnu.org; Wed, 04 Feb 2026 14:03:33 -0500 Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-376-yhLOvfY0Pc2jld7g4joNVw-1; Wed, 04 Feb 2026 14:03:30 -0500 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-4358f90fe8dso118238f8f.0 for ; Wed, 04 Feb 2026 11:03:30 -0800 (PST) Received: from redhat.com (IGLD-80-230-34-155.inter.net.il. [80.230.34.155]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43617e25d47sm7489588f8f.5.2026.02.04.11.03.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Feb 2026 11:03:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770231811; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+939riydvwDd27jqC2atSYgpM2eosXh2uo/JqY9/3xU=; b=HyecGc8Hs1fN/wpGI7XhtzgU2pnzZUq4YfNyfzv3e2LnjeCotTnC7Uuyrfr2RPEBCyfQ3O pKqzHJ9gqvqnh3peDlC8vmDHKsV/ytojx1bKX2QxswlPhUHrz7Zg+ahSmpVouWjibmDyfZ CdaQePwSfGarPEtrZXYeg0OSmaZ6KbI= X-MC-Unique: yhLOvfY0Pc2jld7g4joNVw-1 X-Mimecast-MFC-AGG-ID: yhLOvfY0Pc2jld7g4joNVw_1770231809 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1770231809; x=1770836609; darn=nongnu.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=+939riydvwDd27jqC2atSYgpM2eosXh2uo/JqY9/3xU=; b=OJB8UaUyFl2O2t/5fqdE/OPMVOS6YoIoW9FV/e2TN6vPZhg8i6Vehg/FFs12sqAPfc V/j737omikb3+SnB2OGBhgTXYPnfUXgnBloxO210tPQPX94kH1G2AtIISaYuEGy7F4vK gdR/00oqzbIa4oF+bsbB2zMb69gp34HRpANnXMk51yBnjBqi71CVDbsAsJk+aeZATLHC sSA7Q19c7BjsjC67XXn0DSJIY0D4556inTcVw2q8fUlCWTI3pgae23tJZR+sNulRtFcT N0vS7BPmQ5dSlCeCiwBMcYjbmXVCHsM+zIozW523KoiNmGJzSyUtWNAcHxzh0NS9Drrp 00/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770231809; x=1770836609; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+939riydvwDd27jqC2atSYgpM2eosXh2uo/JqY9/3xU=; b=IUoQNSQzMU5MQk7FPXPxZ13x7x2my75ESbKWoHRveLcfpzMLFLbMwRbaWBeEjX0N6r jXlj1eaZFByroD1VdLq64y5R04yFLcrcXVcfnyNHpH4qmHpOCOKZx0n3CNqmdbHrSdjc hwH7g7wDBPr38E0nGx8kwYVebOjl8Jvmpa7mkPG+sFLo2HvJRLlb1cLdV2TKQXXDXhVm kNa6u2aLa/8oeVN8j4mlx/JlVi9/CqzCNIenTczUedKP7zDz4hRpPq2lTmucAS+IraGw boSMC0r44t8+PVx1kU2u2S7G8oJd51euvdAMMQXw2i2EUoUhd4fDuwuBU1P4BKSYWceG d+ow== X-Gm-Message-State: AOJu0Yzf5WQG2PAao72jZH41SupKSEb+4Fu/ZCXUojSFOP09zwNtxChJ VSYVVEN8PNTvBQrkMwM2G7cJQJm9vSj0Dnrkg52BUUY7XwGVu4/DlBMDTQd3VArDH1DhAyguOvA 4VpbnNHQjUM27lzf4vkGiwWHXMkm5/m/btOhJsKYQOc4XE8QWIud/G/Fr/87I25X1sH1mokfeWz qEd9LiDwcXT+rqUOPZazEK88lXH+1wSbMAIg== X-Gm-Gg: AZuq6aLWZzTgSYh4Pj0AeEQr6VNCxGWlcR2+0X1Uie58w9RTPSgyAlO2mCi41NnxOR1 1DDm6F3vJwyxcPoLwQ69TtZaJgeWGlQdwhe0DNwIylrBuSlvWM6VUM7mOXbjg4qWdMwxGWjrWZX 1QHZzYF1L47E+PWx4mzE/74qSagA5s88KsjxQFYWwqzPYYlM/eqq2bgWwNj+p/lk2coVI/BRtO+ uw729bkPX9+XZopZW/Q0O2HdvBFfhDLz4I/FWnnFr87EcFWUmeEeC40ra7ySUnMxKkdEEUQuRnu 5BANsjr3OvJxWsc6GGFQAs2p+O8tjkmcBA0EanZf7C8pfNduAJTsKXpz5K7Pk8T6bPQvTFEglfa 3GHb7GzFJCYFJUqXyXJO+IlLU+byfqApyuw== X-Received: by 2002:a05:6000:250a:b0:432:88c4:e180 with SMTP id ffacd0b85a97d-436209bfc2cmr593190f8f.15.1770231809004; Wed, 04 Feb 2026 11:03:29 -0800 (PST) X-Received: by 2002:a05:6000:250a:b0:432:88c4:e180 with SMTP id ffacd0b85a97d-436209bfc2cmr593133f8f.15.1770231808502; Wed, 04 Feb 2026 11:03:28 -0800 (PST) Date: Wed, 4 Feb 2026 14:03:26 -0500 From: "Michael S. Tsirkin" To: qemu-devel@nongnu.org Cc: Peter Maydell , CLEMENT MATHIEU--DRIF , Jason Wang , Yi Liu , Paolo Bonzini , Richard Henderson , Eduardo Habkost , Marcel Apfelbaum Subject: [PULL 16/51] intel_iommu: Handle insufficient permissions during translation requests Message-ID: <86c5072181002ea6160c716e0524105900c40dc2.1770231744.git.mst@redhat.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Mailer: git-send-email 2.27.0.106.g8ac3dc51b1 X-Mutt-Fcc: =sent Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=mst@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1770232140771154100 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: CLEMENT MATHIEU--DRIF ATS translations should not fail when the write permission is not set. Signed-off-by: Clement Mathieu--Drif Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Message-Id: <20251029105137.1097933-6-clement.mathieu--drif@eviden.com> --- hw/i386/intel_iommu.c | 14 ++++++++------ hw/i386/intel_iommu_internal.h | 3 ++- 2 files changed, 10 insertions(+), 7 deletions(-) diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c index 7e7c31cb55..6ba1c1676b 100644 --- a/hw/i386/intel_iommu.c +++ b/hw/i386/intel_iommu.c @@ -1998,7 +1998,7 @@ static int vtd_iova_to_fspte(IntelIOMMUState *s, VTDC= ontextEntry *ce, uint64_t iova, bool is_write, uint64_t *fsptep, uint32_t *fspte_level, bool *reads, bool *writes, uint8_t aw_bits, - uint32_t pasid) + uint32_t pasid, int iommu_idx) { dma_addr_t addr =3D vtd_get_iova_pgtbl_base(s, ce, pasid); uint32_t offset; @@ -2039,7 +2039,8 @@ static int vtd_iova_to_fspte(IntelIOMMUState *s, VTDC= ontextEntry *ce, =20 *reads =3D true; *writes =3D (*writes) && (fspte & VTD_FS_RW); - if (is_write && !(fspte & VTD_FS_RW)) { + /* ATS should not fail when the write permission is not set */ + if (is_write && !(fspte & VTD_FS_RW) && iommu_idx !=3D VTD_IDX_ATS= ) { return -VTD_FR_SM_WRITE; } if (vtd_fspte_nonzero_rsvd(fspte, *fspte_level)) { @@ -2098,7 +2099,7 @@ static void vtd_report_fault(IntelIOMMUState *s, */ static bool vtd_do_iommu_translate(VTDAddressSpace *vtd_as, PCIBus *bus, uint8_t devfn, hwaddr addr, bool is_wri= te, - IOMMUTLBEntry *entry) + IOMMUTLBEntry *entry, int iommu_idx) { IntelIOMMUState *s =3D vtd_as->iommu_state; VTDContextEntry ce; @@ -2204,7 +2205,8 @@ static bool vtd_do_iommu_translate(VTDAddressSpace *v= td_as, PCIBus *bus, =20 if (s->fsts && s->root_scalable) { ret_fr =3D vtd_iova_to_fspte(s, &ce, addr, is_write, &pte, &level, - &reads, &writes, s->aw_bits, pasid); + &reads, &writes, s->aw_bits, pasid, + iommu_idx); pgtt =3D VTD_SM_PASID_ENTRY_FST; } else { ret_fr =3D vtd_iova_to_sspte(s, &ce, addr, is_write, &pte, &level, @@ -4033,7 +4035,7 @@ static IOMMUTLBEntry vtd_iommu_translate(IOMMUMemoryR= egion *iommu, hwaddr addr, } } else { success =3D vtd_do_iommu_translate(vtd_as, vtd_as->bus, vtd_as= ->devfn, - addr, is_write, &iotlb); + addr, is_write, &iotlb, iommu_= idx); } } else { /* DMAR disabled, passthrough, use 4k-page*/ @@ -5196,7 +5198,7 @@ static IOMMUTLBEntry vtd_iommu_ats_do_translate(IOMMU= MemoryRegion *iommu, vtd_prepare_error_entry(&entry); entry.target_as =3D &address_space_memory; } else { - entry =3D vtd_iommu_translate(iommu, addr, flags, VTD_IDX_UNTRANSL= ATED); + entry =3D vtd_iommu_translate(iommu, addr, flags, VTD_IDX_ATS); } =20 return entry; diff --git a/hw/i386/intel_iommu_internal.h b/hw/i386/intel_iommu_internal.h index be757c290d..18d50191d2 100644 --- a/hw/i386/intel_iommu_internal.h +++ b/hw/i386/intel_iommu_internal.h @@ -692,7 +692,8 @@ typedef struct VTDPIOTLBInvInfo { typedef enum VTDIOMMUIndex { VTD_IDX_UNTRANSLATED =3D 0, /* Default */ VTD_IDX_TRANSLATED =3D 1, - VTD_IDX_COUNT =3D 2, /* Number of supported indexes */ + VTD_IDX_ATS =3D 2, + VTD_IDX_COUNT =3D 3, /* Number of supported indexes */ } VTDIOMMUIndex; =20 typedef struct VTDHostIOMMUDevice { --=20 MST