From nobody Mon Feb 9 09:34:02 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1526917271472156.74229732333356; Mon, 21 May 2018 08:41:11 -0700 (PDT) Received: from localhost ([::1]:51224 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fKmvu-00066z-OL for importer@patchew.org; Mon, 21 May 2018 11:41:10 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34556) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fKmrj-0001rK-0i for qemu-devel@nongnu.org; Mon, 21 May 2018 11:36:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fKmrg-0005KR-CF for qemu-devel@nongnu.org; Mon, 21 May 2018 11:36:51 -0400 Received: from zucker2.schokokeks.org ([178.63.68.90]:50069) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fKmrg-0005J9-5Q for qemu-devel@nongnu.org; Mon, 21 May 2018 11:36:48 -0400 Received: from blood-stain-child.lan.ruderich.org (localhost [::1]) (AUTH: PLAIN simon@ruderich.org, TLS: TLSv1/SSLv3, 128bits, ECDHE-RSA-AES128-GCM-SHA256) by zucker.schokokeks.org with ESMTPSA; Mon, 21 May 2018 17:37:07 +0200 id 00000000000000B4.000000005B02E7A3.00000915 From: Simon Ruderich To: qemu-devel@nongnu.org Date: Mon, 21 May 2018 17:36:44 +0200 Message-Id: <851d095cd457109e4a22a2e5ecd36ccbdacbf48b.1526916378.git.simon@ruderich.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: References: <0e59c79ddc01e195ddc59d77d9df2b95bf89b600.1523395243.git.simon@ruderich.org> In-Reply-To: References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 178.63.68.90 Subject: [Qemu-devel] [PATCH v3 5/5] qmp: add pmemload command X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Simon Ruderich Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Adapted patch from Baojun Wang [1] with the following commit message: I found this could be useful to have qemu-softmmu as a cross debugger (launch with -s -S command line option), then if we can have a command to load guest physical memory, we can use cross gdb to do some target debug which gdb cannot do directly. pmemload is necessary to directly write physical memory which is not possible with gdb alone as it uses only logical addresses. The QAPI for pmemload uses "val" as parameter name for the physical address. This name is not very descriptive but is consistent with the existing pmemsave. Changing the parameter name of pmemsave is not possible without breaking the existing API. [1]: https://lists.gnu.org/archive/html/qemu-trivial/2014-04/msg00074.html Based-on-patch-by: Baojun Wang Signed-off-by: Simon Ruderich --- cpus.c | 41 +++++++++++++++++++++++++++++++++++++++++ hmp-commands.hx | 14 ++++++++++++++ hmp.c | 12 ++++++++++++ hmp.h | 1 + qapi/misc.json | 20 ++++++++++++++++++++ 5 files changed, 88 insertions(+) diff --git a/cpus.c b/cpus.c index 49d4d44916..9b105336af 100644 --- a/cpus.c +++ b/cpus.c @@ -2367,6 +2367,47 @@ exit: qemu_close(fd); } =20 +void qmp_pmemload(int64_t addr, int64_t size, int64_t offset, + const char *filename, Error **errp) +{ + int fd; + size_t l; + ssize_t r; + uint8_t buf[1024]; + + fd =3D qemu_open(filename, O_RDONLY | O_BINARY); + if (fd < 0) { + error_setg_file_open(errp, errno, filename); + return; + } + if (offset > 0) { + if (lseek(fd, offset, SEEK_SET) !=3D offset) { + error_setg_errno(errp, errno, + "could not seek to offset %" PRIx64, offset); + goto exit; + } + } + + while (size !=3D 0) { + l =3D sizeof(buf); + if (l > size) { + l =3D size; + } + r =3D read(fd, buf, l); + if (r <=3D 0) { + error_setg(errp, QERR_IO_ERROR); + goto exit; + } + l =3D r; /* in case of short read */ + cpu_physical_memory_write(addr, buf, l); + addr +=3D l; + size -=3D l; + } + +exit: + qemu_close(fd); +} + void qmp_inject_nmi(Error **errp) { nmi_monitor_handle(monitor_get_cpu_index(), errp); diff --git a/hmp-commands.hx b/hmp-commands.hx index 0734fea931..84647c7c1d 100644 --- a/hmp-commands.hx +++ b/hmp-commands.hx @@ -822,6 +822,20 @@ STEXI @item pmemsave @var{addr} @var{size} @var{file} @findex pmemsave save to disk physical memory dump starting at @var{addr} of size @var{size= }. +ETEXI + + { + .name =3D "pmemload", + .args_type =3D "val:l,size:i,offset:i,filename:s", + .params =3D "addr size offset file", + .help =3D "load from disk physical memory dump starting at '= addr' of size 'size' at file offset 'offset'", + .cmd =3D hmp_pmemload, + }, + +STEXI +@item pmemload @var{addr} @var{size} @var{offset} @var{file} +@findex pmemload +load from disk physical memory dump starting at @var{addr} of size @var{si= ze} at file offset @var{offset}. ETEXI =20 { diff --git a/hmp.c b/hmp.c index a4d28913bb..b85c943b63 100644 --- a/hmp.c +++ b/hmp.c @@ -1105,6 +1105,18 @@ void hmp_pmemsave(Monitor *mon, const QDict *qdict) hmp_handle_error(mon, &err); } =20 +void hmp_pmemload(Monitor *mon, const QDict *qdict) +{ + uint64_t size =3D qdict_get_int(qdict, "size"); + uint64_t offset =3D qdict_get_int(qdict, "offset"); + const char *filename =3D qdict_get_str(qdict, "filename"); + uint64_t addr =3D qdict_get_int(qdict, "val"); + Error *err =3D NULL; + + qmp_pmemload(addr, size, offset, filename, &err); + hmp_handle_error(mon, &err); +} + void hmp_ringbuf_write(Monitor *mon, const QDict *qdict) { const char *chardev =3D qdict_get_str(qdict, "device"); diff --git a/hmp.h b/hmp.h index 20f27439d3..31767ea4a8 100644 --- a/hmp.h +++ b/hmp.h @@ -47,6 +47,7 @@ void hmp_system_powerdown(Monitor *mon, const QDict *qdic= t); void hmp_cpu(Monitor *mon, const QDict *qdict); void hmp_memsave(Monitor *mon, const QDict *qdict); void hmp_pmemsave(Monitor *mon, const QDict *qdict); +void hmp_pmemload(Monitor *mon, const QDict *qdict); void hmp_ringbuf_write(Monitor *mon, const QDict *qdict); void hmp_ringbuf_read(Monitor *mon, const QDict *qdict); void hmp_cont(Monitor *mon, const QDict *qdict); diff --git a/qapi/misc.json b/qapi/misc.json index f5988cc0b5..b4c0065b02 100644 --- a/qapi/misc.json +++ b/qapi/misc.json @@ -1219,6 +1219,26 @@ { 'command': 'pmemsave', 'data': {'val': 'int', 'size': 'int', 'filename': 'str'} } =20 +## +# @pmemload: +# +# Load a portion of guest physical memory from a file. +# +# @val: the physical address of the guest to start from +# +# @size: the size of memory region to load +# +# @offset: the offset in the file to start from +# +# @filename: the file to load the memory from as binary data +# +# Returns: Nothing on success +# +# Since: 2.13 +## +{ 'command': 'pmemload', + 'data': {'val': 'int', 'size': 'int', 'offset': 'int', 'filename': 'str'= } } + ## # @cont: # --=20 2.15.0