From nobody Mon Feb 9 12:03:58 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1590430669; cv=none; d=zohomail.com; s=zohoarc; b=RbZnZ0agihxsCEyuJjUVfRY/DN+QsgHpfN62NS1U73R8ZpW1VcAiSfGVaCOUAGgHRsU74Mqp63ZqOQWok2y6FD5gkeuo+wSGTSgUJ+Ol4ypHbf0xuhfBH7Sp70Ga5Zf3/2FHYYYa53uOF6ODg6YJUcftsRNYqShcejgVafvSVkM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1590430669; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=XBnN61YNWOhG+6+Gd0bCaslv74HTZpq5RBwS8AyYww8=; b=SwdsG90pIfk85Yk8XiVvUOEtOWoKOYivGvejMzUPu10qhjELB4ZfRijQMSZQfQxrIAzGHzobJNYWIkhwBhLBLGBeKzC/FAcqd+PNBvsLNnALZWdexJTi9kT6APfwUZI4BU+ifDSMVqGgMZo7ugRhwcmjx8158iOIlNWfur+NQ74= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1590430669535724.2589502803371; Mon, 25 May 2020 11:17:49 -0700 (PDT) Received: from localhost ([::1]:44734 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jdHfY-00007T-8H for importer@patchew.org; Mon, 25 May 2020 14:17:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45232) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jdHXt-0003z3-BZ; Mon, 25 May 2020 14:09:53 -0400 Received: from fanzine.igalia.com ([178.60.130.6]:51075) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jdHXq-0007py-2T; Mon, 25 May 2020 14:09:52 -0400 Received: from [81.0.38.199] (helo=perseus.local) by fanzine.igalia.com with esmtpsa (Cipher TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim) id 1jdHXP-00088i-JP; Mon, 25 May 2020 20:09:23 +0200 Received: from berto by perseus.local with local (Exim 4.92) (envelope-from ) id 1jdHXA-0002Nj-DL; Mon, 25 May 2020 20:09:08 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=XBnN61YNWOhG+6+Gd0bCaslv74HTZpq5RBwS8AyYww8=; b=Qz8C0p6ieID2DkvF7oYdObBNgP/HhCNDuoxCwpdvCwlJHui1KrrBTI+ABM2RB3/LuH05rlUur53zKTHE0osV5N2i4H/FWdue6mrRrq5jey9NHTwnQjMfAlhn2WNvLBTre/xtkm9ib8uXjODMupedHvVB7si/CPH4wC4nfmyFed0bmFmMHA+6f3LpY+S0Ha1uc+msFfz24Qd4LJHcA282YA/N5Vzllvf7DSsZu1YbIXN+YGp7MGhf/shGqU+JN2rpEkGT1SIJyvfkSWX4EBHgYStujeC0XQbw42qX43n7YOWfGYcPN7NIO6czheGbO2mWgeRrdFYYCqPOlW7dBc6rLw==; From: Alberto Garcia To: qemu-devel@nongnu.org Subject: [PATCH v7 29/32] qcow2: Add subcluster support to qcow2_measure() Date: Mon, 25 May 2020 20:08:54 +0200 Message-Id: <83811adb69792615e776e8259ab63139802f21f9.1590429901.git.berto@igalia.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=178.60.130.6; envelope-from=berto@igalia.com; helo=fanzine.igalia.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/25 14:09:23 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x (no timestamps) [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Vladimir Sementsov-Ogievskiy , Alberto Garcia , qemu-block@nongnu.org, Derek Su , Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Extended L2 entries are bigger than normal L2 entries so this has an impact on the amount of metadata needed for a qcow2 file. Signed-off-by: Alberto Garcia Reviewed-by: Max Reitz --- block/qcow2.c | 20 +++++++++++++------- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 40988fff55..bc7a4a1729 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -3233,28 +3233,31 @@ int64_t qcow2_refcount_metadata_size(int64_t cluste= rs, size_t cluster_size, * @total_size: virtual disk size in bytes * @cluster_size: cluster size in bytes * @refcount_order: refcount bits power-of-2 exponent + * @extended_l2: true if the image has extended L2 entries * * Returns: Total number of bytes required for the fully allocated image * (including metadata). */ static int64_t qcow2_calc_prealloc_size(int64_t total_size, size_t cluster_size, - int refcount_order) + int refcount_order, + bool extended_l2) { int64_t meta_size =3D 0; uint64_t nl1e, nl2e; int64_t aligned_total_size =3D ROUND_UP(total_size, cluster_size); + size_t l2e_size =3D extended_l2 ? L2E_SIZE_EXTENDED : L2E_SIZE_NORMAL; =20 /* header: 1 cluster */ meta_size +=3D cluster_size; =20 /* total size of L2 tables */ nl2e =3D aligned_total_size / cluster_size; - nl2e =3D ROUND_UP(nl2e, cluster_size / sizeof(uint64_t)); - meta_size +=3D nl2e * sizeof(uint64_t); + nl2e =3D ROUND_UP(nl2e, cluster_size / l2e_size); + meta_size +=3D nl2e * l2e_size; =20 /* total size of L1 tables */ - nl1e =3D nl2e * sizeof(uint64_t) / cluster_size; + nl1e =3D nl2e * l2e_size / cluster_size; nl1e =3D ROUND_UP(nl1e, cluster_size / sizeof(uint64_t)); meta_size +=3D nl1e * sizeof(uint64_t); =20 @@ -4834,6 +4837,8 @@ static BlockMeasureInfo *qcow2_measure(QemuOpts *opts= , BlockDriverState *in_bs, PreallocMode prealloc; bool has_backing_file; bool has_luks; + bool extended_l2 =3D false; /* Set to false until the option is added = */ + size_t l2e_size; =20 /* Parse image creation options */ cluster_size =3D qcow2_opt_get_cluster_size_del(opts, &local_err); @@ -4899,8 +4904,9 @@ static BlockMeasureInfo *qcow2_measure(QemuOpts *opts= , BlockDriverState *in_bs, virtual_size =3D ROUND_UP(virtual_size, cluster_size); =20 /* Check that virtual disk size is valid */ + l2e_size =3D extended_l2 ? L2E_SIZE_EXTENDED : L2E_SIZE_NORMAL; l2_tables =3D DIV_ROUND_UP(virtual_size / cluster_size, - cluster_size / sizeof(uint64_t)); + cluster_size / l2e_size); if (l2_tables * sizeof(uint64_t) > QCOW_MAX_L1_SIZE) { error_setg(&local_err, "The image size is too large " "(try using a larger cluster size)"); @@ -4963,9 +4969,9 @@ static BlockMeasureInfo *qcow2_measure(QemuOpts *opts= , BlockDriverState *in_bs, } =20 info =3D g_new(BlockMeasureInfo, 1); - info->fully_allocated =3D + info->fully_allocated =3D luks_payload_size + qcow2_calc_prealloc_size(virtual_size, cluster_size, - ctz32(refcount_bits)) + luks_payload_size; + ctz32(refcount_bits), extended_l2); =20 /* Remove data clusters that are not required. This overestimates the * required size because metadata needed for the fully allocated file = is --=20 2.20.1