From nobody Sun Feb 8 22:01:04 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1770232176; cv=none; d=zohomail.com; s=zohoarc; b=g6K9H0pXuFSz1DdiGWZk4L0jRDadAe+/pQN0nK2nef/VNGD2vOLsMp8WD640txiiMP4Thl2RTkYKl20K1GCOzf13Fw7tXzKqFluGvDodPI80d3B7xQZWINoS4Pn8QI3pK1bE35gT2Zk7nMgr20qHDOvsH+cTJ9SmhOQfDkCukfk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770232176; h=Content-Type:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=240llcH1KOsRD5XX9QQlOGkvt40lI+orhfBCWyP5XqQ=; b=juJwU0ny7vLmjrVCUkWQWG1bN7F/F0p1C0NRMuI6qw+JyvEReWCZN0McNLn7WD1N+WwoEupavVXu2UlcfMS+QbcOZZX04ZCSOTZgGijCiDu/gTfaUAHKS8r/tqiHds6aZT9Ed4xEwTbhcq5JtRA7qNhF2win5yzhNS/9wNPvvKQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770232176619794.5619651393199; Wed, 4 Feb 2026 11:09:36 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vniBc-0002yi-HO; Wed, 04 Feb 2026 14:05:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vniB0-0002s8-NS for qemu-devel@nongnu.org; Wed, 04 Feb 2026 14:04:34 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vniAz-0008AT-4N for qemu-devel@nongnu.org; Wed, 04 Feb 2026 14:04:34 -0500 Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-372-Y7LmGiV8NMSOJrF-6O5mwA-1; Wed, 04 Feb 2026 14:04:30 -0500 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-435ab907109so103593f8f.3 for ; Wed, 04 Feb 2026 11:04:29 -0800 (PST) Received: from redhat.com (IGLD-80-230-34-155.inter.net.il. [80.230.34.155]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43617e25683sm8191167f8f.6.2026.02.04.11.04.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Feb 2026 11:04:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770231872; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=240llcH1KOsRD5XX9QQlOGkvt40lI+orhfBCWyP5XqQ=; b=Et09Ypx49lgbnGVKhAfN0VqjI+O5Lq4NRohyT2OTd8KuLMoyFRdwnvlP09cYC2KFbIPmGi zSwjwoS67HqFaSMWWvzYD8YXJq2+0A0zm7CD8qe24IF5I/VfdC7/t/6DI9DhtaRRGdwAVm cR1iiD7NSw4Q38RofPEj4TRqdRw6PT8= X-MC-Unique: Y7LmGiV8NMSOJrF-6O5mwA-1 X-Mimecast-MFC-AGG-ID: Y7LmGiV8NMSOJrF-6O5mwA_1770231868 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1770231868; x=1770836668; darn=nongnu.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=240llcH1KOsRD5XX9QQlOGkvt40lI+orhfBCWyP5XqQ=; b=SRWbqZCEArh/qbqpjtgkShhjWckjHHZtnOT/1zmV1XEloQstlWttQBXLqKHWTrsWmp M6AvjuJpuwKgJ5ej2Ei4aLTq/fL9EezwiCrNLPdPOcuox4QSlTs3MKH8ZmSyQBDIChYL Ax+wJ27LjQuuvg6vdynxGiSDkSne25YQ9E2D9vHzPIbs6VvSKvdQttTDiAqznqpa+4fp 21ldPsJTLBBeSrBxwnT+L23zoRZqXPXzuqR82HlTrka9TtzWAKg+rROaOtpR5g83EBnf rE3YCqI380G60vq4mSe8ef4pQs6b2f9THUUueIPqT8YUad5VIYSbWTzWJmEZEtZEMGvy 0uQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770231868; x=1770836668; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=240llcH1KOsRD5XX9QQlOGkvt40lI+orhfBCWyP5XqQ=; b=d4pAI0RlJdraGey+dLvrFgAe4p26Jb2KccQjK0fJQYbsjHU7OdPYoAc3FDrZFeeamv YnqwOCdCNulNYtYSZxCqWE5n1uFpDvhkyUdQRK9EOwj+K61qbIFkQf8OPEbmoHzxgszy w5gsnsCa5iqWKYqmOliE+tDB31QyKEXISEz4rxxT5wUBUjC8KHZJ22nYofdl1JhDNnM2 P4ml04s+rNMVASvFLeY5EC1aspye2Iz6Xzr5s3sTG0DYTjCO6VQhGZlejA6vpU5/eB+Q lkcbIJYW/+64viuq5a3R4u6h6JdxDWOy+kKI3vCZZOwTjics282I+yLiFXT3ULCrWYaQ ux3A== X-Gm-Message-State: AOJu0Yz5XoUK/DSBUNDgfLKfmMxhAoP06TSztZ5KcZPrYOyGAGBf84Jv 2uCEWUcJuV5x+8tzi1vYi6pFXXLHxHBk/h0LuY+UfkezrtEcSvqeKPq1G2co+AYIWL5+pP9M07L YqaexMg4s/ideTQ479clKzk+9v6sapKZ/yF+is3ds6TRLL1ukUBrJ+z7eOYG6ceMwASUBq0C5+6 F2355LgD2NQ6tu5QATYMfLnqKEG+CY9Q6N5g== X-Gm-Gg: AZuq6aIvpM9+0pgseFox7pz0uYhB+XPNXWXbeykdAMYNFHPn+8c/1Z/HBELA32P8lPx dAv2vL0Ys9/AfIKlM75B1NvI4EZGC8ZDJow0vTtnPCO9PGgc6uZM12UTosxZIGz0tefaRRq/oj+ mhoFsTwyAk4gTKjfFzdlfRzA12fDHNhsfVU39ZCF6kwv4cKUiDYSn7BfZbcX1LDq80wOv1PM3S+ ncUfnHpVarczuvi5WVuVPUwTjv6OGXn+m8133r4kVhq9uwu0dNWDRN3+6sLnRBrjMTzd9BGIped ppZbJJJv6N14r223SpQoxifnpz4Gb00j7hpTu2cgK60a04QE5cYKgVS6cwspziROnEbN9S9TvWq hHB/gxzCc4ZAc2lgbIEnTA3XaLmNrrGmKQQ== X-Received: by 2002:a05:6000:240e:b0:432:8651:4071 with SMTP id ffacd0b85a97d-43617e3c672mr5591315f8f.18.1770231867695; Wed, 04 Feb 2026 11:04:27 -0800 (PST) X-Received: by 2002:a05:6000:240e:b0:432:8651:4071 with SMTP id ffacd0b85a97d-43617e3c672mr5591257f8f.18.1770231867191; Wed, 04 Feb 2026 11:04:27 -0800 (PST) Date: Wed, 4 Feb 2026 14:04:25 -0500 From: "Michael S. Tsirkin" To: qemu-devel@nongnu.org Cc: Peter Maydell , Li Chen , Li Chen Subject: [PULL 42/51] virtio-pmem: ignore empty queue notifications Message-ID: <7d3d3fa20b856b3a13b44c0d0824e3bf8bfd9219.1770231744.git.mst@redhat.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Mailer: git-send-email 2.27.0.106.g8ac3dc51b1 X-Mutt-Fcc: =sent Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=mst@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1770232178956154100 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Li Chen virtio_pmem_flush() treats a NULL return from virtqueue_pop() as a fatal error and calls virtio_error(), which puts the device into NEEDS_RESET. However, virtqueue handlers can be invoked when no element is available, so an empty queue should be handled as a benign no-op. With a Linux guest this avoids spurious NEEDS_RESET and the resulting -EIO propagation (e.g. EXT4 journal abort and remount-ro). Signed-off-by: Li Chen Acked-by: Michael S. Tsirkin Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Message-Id: <20260106083859.380338-1-me@linux.beauty> --- hw/virtio/virtio-pmem.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/virtio/virtio-pmem.c b/hw/virtio/virtio-pmem.c index 5381d59282..c3b3299c9c 100644 --- a/hw/virtio/virtio-pmem.c +++ b/hw/virtio/virtio-pmem.c @@ -73,7 +73,6 @@ static void virtio_pmem_flush(VirtIODevice *vdev, VirtQue= ue *vq) trace_virtio_pmem_flush_request(); req_data =3D virtqueue_pop(vq, sizeof(VirtIODeviceRequest)); if (!req_data) { - virtio_error(vdev, "virtio-pmem missing request data"); return; } =20 --=20 MST