From nobody Wed Nov 5 02:58:20 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail header.i=@wdc.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1531859814108452.96126486449054; Tue, 17 Jul 2018 13:36:54 -0700 (PDT) Received: from localhost ([::1]:33147 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ffWbX-0000dC-VL for importer@patchew.org; Tue, 17 Jul 2018 16:29:51 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49322) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ffWZq-0008Dk-8Y for qemu-devel@nongnu.org; Tue, 17 Jul 2018 16:28:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ffWZn-0005VV-31 for qemu-devel@nongnu.org; Tue, 17 Jul 2018 16:28:06 -0400 Received: from esa3.hgst.iphmx.com ([216.71.153.141]:30202) by eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71) (envelope-from ) id 1ffWZm-0005Ua-M0 for qemu-devel@nongnu.org; Tue, 17 Jul 2018 16:28:03 -0400 Received: from mail-sn1nam04lp0086.outbound.protection.outlook.com (HELO NAM04-SN1-obe.outbound.protection.outlook.com) ([216.32.180.86]) by ob1.hgst.iphmx.com with ESMTP; 18 Jul 2018 04:28:01 +0800 Received: from risc6-mainframe.int.fusionio.com (199.255.44.171) by DM5PR04MB0394.namprd04.prod.outlook.com (2603:10b6:3:9d::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.952.18; Tue, 17 Jul 2018 20:27:59 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1531859283; x=1563395283; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=3Hmi1bZjrsnxpK9XcYDC5g9rrP0pkPoWuqooHMb2t+k=; b=EX9+y/nJsnlCVDrP0/5GpiHLqoDjth9JFj6mWkQFxn8drYWVl3bPc26i lliVWwxA4WC76of7Qgoswkq8pWjYhP149MWIq/EakLw6AB0OTGw1MH+rk fRrSg8Uk53OSjHsUnVHr3YRv08+rZZUxOHcRC+7CVDQbVdlU4I/FJEOSG ZpZ/t5aaoIZbw84Vu0pvrbQlGZDX0JLceIUv04Zst6op5bAtuUR4pOllh nQ3p6+1twAOyysV1Eyz62SP3xqYtnY5BfPxqBfBpxqVTIQ3keBlAtVVeN 89Kh5UXzCiwzG4YKQtldLWMlektDAW41e19uAtbEHWVbJ6zzeG/ff099C g==; X-IronPort-AV: E=Sophos;i="5.51,366,1526313600"; d="scan'208";a="87467558" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector1-wdc-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SR/LrtcBLOo1Q1DC6zJeOTecOuWoi7wM4Vi3Q/UgGlA=; b=aM8oUwy6fO0lbYQOFJE8MCwLsARdv2nVCZISk2cAIIHm62SYlhIt2VgVGSIJicYdjLufq/I3g4B+y3nBMVJUVylyTBlhpudR/RiShx2hcRzEZvNqk/J3vvXeFmEhkUbSDUMOdMk/HmZrXyLPK+goQzZ/PKAxkbA8gKuLozCFzP0= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Alistair.Francis@wdc.com; From: Alistair Francis To: qemu-devel@nongnu.org Date: Tue, 17 Jul 2018 13:27:50 -0700 Message-Id: <7b4596fd90e5576e7caafc0f34ecb06c786c4a7c.1531859179.git.alistair.francis@wdc.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: MIME-Version: 1.0 X-Originating-IP: [199.255.44.171] X-ClientProxiedBy: CO1PR15CA0065.namprd15.prod.outlook.com (2603:10b6:101:1f::33) To DM5PR04MB0394.namprd04.prod.outlook.com (2603:10b6:3:9d::15) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bac28d5c-5105-4a1d-445f-08d5ec23c9d7 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600053)(711020)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(48565401081)(2017052603328)(7153060)(7193020); SRVR:DM5PR04MB0394; X-Microsoft-Exchange-Diagnostics: 1; DM5PR04MB0394; 3:YhrKGAKYrL2PLUOAElUer1bCyKco5Qhq60xlo7yr68lDCiVWzKg52MQn9YtWCdHB9MbdHUA4Xn0lAohvFKuV9LTo9d2U2FyHzt71kk4dXmdcaCDhTtqnjFjebJXSIbs1+9e7+voKKShGgarRmzvQagxLlAfKNTR5O6onZYMgN+GztY7u6pfTC4TT5aJ+t1hVhQ/L57tUFSjh/gApZsHCjLOG3NdrClhJ2z5iz3yTjiTQ0HNvemuIO6g0Go3f5sPf; 25:9q2NjW5KRp4y57jOMsaEWpudkE7q61ILpB3yjlvBJWJvcOy8V3DnXL3ldxqALPEPDv9IwMqNZkUrxvPUDBWP0AOav0x9j6JQa13W/Sga/gW0CzNhO0t5q0EF1Ksppp35NR3zAReRUO/vg5gS6aMhvvLoPDeQiYLLloboym+0M911TNPIjHqxvj8odH5ObS4bQgYJG+dC2cmtfUcvq65HCagA1kdhsEQ94qu3zoDqgR+kQQK4prAk9IAgwo+rdfI7HQEiMs84muBHAF58JKclqLcihb4LEe6BYhAd/OWUL4lV0q3Lsi9sZ2KW1m2sVtw/2AS4CprVBilskGwvHcOb3g==; 31:ZhPkFtaie1cF/KhcHSpucAmSA/9A1DxpUYDiRCV6+5bxEYd5eW6rphM40OmiVVlG/sKKCA5Im+QxsqSPbKVRY4SbbloL7o/9G/TCPQx27dL2Qp5+QaP6BObIg9cWCN3UwmkMufHR8797mxaxbOz79MsNGlUGoCSVc2Jy5btSdV4eUSoyK/Z1E4nvpsnJ8u8gN/Z3OndvqoFMKrO2gUnSQa+wsB6ZV0/3TIBMmUkseNU= X-MS-TrafficTypeDiagnostic: DM5PR04MB0394: WDCIPOUTBOUND: EOP-TRUE X-Microsoft-Exchange-Diagnostics: 1; DM5PR04MB0394; 20:B4nphwycI+Al9EE9QiHxsEs1iHIideT/TDfo+bpyESW0qLtTq+/TEIgFWq3VfNLwTmbcwrd2RVQZEPV89huA+31m+0ClRV7ZED7e5GoRdYCLHL13zDttpnGa+AQqmbYhokzNVRI8m9HmuHOdhjBYQoMjIe6ySPJnh/dLIMO2Iv5mX/px6V64HLwiweiHDa1jtpMWrjS11FutV92dX15ML36BQ9GIQNMdxYvIue3WvxoMiqjjGv7iaZazfoPJ0BDG12ZBYMu5FOatA7eBaSaRfENhIznKW7hdwegzSkSvYsOGKQpHwmjvJgVflFWxDp1ZdVNF4eyR9PVhorRu9qZ5GkZ3sNVdfCZkLo9ixQalbHmGZCelEaiAXKUJf1oqte4RbuEdLQ0eEGXWssWCGfH6w6Gp58NbileMjoWg1W1vdru0uu2NxFs3VM1tBPlgJ6wiAm2Oo9wJbTMZPLxP/fwPUDJxtt4la1uposzCkiuepSADbN2iq6WV9lEprp4OkcfQ; 4:iJN56A/1hb0oa+N9WXraLR5GI9QvY+u+59qKBsBPirCoLji2xAPw6Q/lsIHX02SudS4L0velzL6ytWZn40hIurwZyuq+QPOVLVh24tkBb0uSpaJnnz07sx7p/XFNNlMZ3rh8VJCg1MNUI079JqZhgiSJjSzjmljXQAs/S0GXgX5DqXRME7F7CUWXiHh4UlXfzufZmMzh9LaG9qgCoreKvGolH1x0eC1+1SeaI4vi5D+ltv1nyHJ/PFLAF6gXOn6rCVkWkZrqz1BleJwX8vLvUA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040522)(2401047)(5005006)(8121501046)(3002001)(3231311)(944501410)(52105095)(10201501046)(93006095)(93001095)(6055026)(149027)(150027)(6041310)(20161123558120)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123562045)(6072148)(201708071742011)(7699016); SRVR:DM5PR04MB0394; BCL:0; PCL:0; RULEID:; SRVR:DM5PR04MB0394; X-Forefront-PRVS: 073631BD3D X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(346002)(136003)(39860400002)(376002)(366004)(396003)(199004)(189003)(47776003)(66066001)(6116002)(186003)(97736004)(44832011)(53936002)(26005)(86362001)(3846002)(16526019)(4326008)(6916009)(76176011)(386003)(6506007)(446003)(486006)(476003)(2616005)(5660300001)(11346002)(956004)(51416003)(52116002)(7736002)(36756003)(8676002)(81166006)(105586002)(50226002)(81156014)(72206003)(16586007)(48376002)(8936002)(305945005)(118296001)(316002)(6666003)(2361001)(25786009)(2351001)(6512007)(50466002)(68736007)(106356001)(2906002)(6486002)(478600001); DIR:OUT; SFP:1102; SCL:1; SRVR:DM5PR04MB0394; H:risc6-mainframe.int.fusionio.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM5PR04MB0394; 23:VEgzxyzSfXxkJBps6Ul98/ADM29h2iZIE8uJ6rxpD?= =?us-ascii?Q?nxcE+ls7kdVgIohu6PB89nHsb5xc8/Pmym65r/Qc6ms2IdTeoygL95dxI7E8?= =?us-ascii?Q?gKZU9GidkWlhc09pWKm4q8JyRT22MpAI/+8DVd/v161xtuDeRgMS3O3DVAqc?= =?us-ascii?Q?rAE1nGB5EbujmHIllUcnlLCJSAuIlFg2uhzvbZsxaOH1MCyu5iJTdvr9VW1A?= =?us-ascii?Q?Il5WXOm/hoAymOLpjeNvMgCIDK53E9izP/HnWF4tPIKPfF+3MOwlC218fP0u?= =?us-ascii?Q?m8t42dcWHcoeru8RgJJ8dWlOcc9/jKGD4FlgpXE3ycLj/cN27Ubzs0qX9kYq?= =?us-ascii?Q?epU7g9CIGsMqdzGhnyp9WT+TIn0IE5jMqhQWdgqGyf/lpmKNt0Tc2y0zVl8c?= =?us-ascii?Q?kalUeIHOiXExlyiUCfL+oqkBSypuXnp1J7TPV0/Yiw27vE6CjoL6GBDnwPyo?= =?us-ascii?Q?AuGYdMQLb23BaHzZRBR+OkhKntfA3xuMVL1jCtcuiOvx9MOc1Mv9WeerNW/e?= =?us-ascii?Q?PzQxmxlBqJEu2+Xc+12pYbI7U2Cu7nGeO/cXvYfUzl9vAODZSsMWUtU6WQj5?= =?us-ascii?Q?wbMUCu7e5kNtyUgBaaRLqlj7dZ+cmG2GQbGvSG70htbPbKaYeK6idB7adqk8?= =?us-ascii?Q?3rk7upO3ERn+BWwPXNN87U+IjM4b9iseBxxE+EVJ1/sOFOBtUpODE6m6NBze?= =?us-ascii?Q?ipHO5j3DIzRVFLmgm+aEqY7pnzlsuPxN31Qr7M4SrbxuXtSg1c7G1w3ov4O8?= =?us-ascii?Q?4r4BfUTCmOkOaTrwgu3oXO+uQukHLcYSvCQzTlyfEzxEaCn9OqimBtdWAIOj?= =?us-ascii?Q?qR5qwADR2WVkppq5iHIHy1VLU3+PVxgpccc3CiiuHMgEawRLwOAXHoJgXI5x?= =?us-ascii?Q?Pzl5r40jKSuibCkx73oRZyBAZkaghDjTLd9LqCGdDEh1fEnteQPJBYSLQZvo?= =?us-ascii?Q?RwcNStvploqFPjcJA2lmJP0aqE+PkF24Pe9D3KwsybjMbw2CwwcYWAZyVT7u?= =?us-ascii?Q?j3PpXfs+dymmpuMok/Y+fs6hnqlie/Kh8Vo6JtSD4SgJ0qqJxOfEF5K21khe?= =?us-ascii?Q?4axX4sQFkSGeavWWh+Pex5RnRKynwUrXnVrkBfJ+ktszo+I+gskxy9SrQE3s?= =?us-ascii?Q?e6QxldbVQ/OUA3UwbqvV1x3eaelLro43IiNqYYudQAyPJHiypXHU8uXuRP2U?= =?us-ascii?Q?alKRDRjpvGObL2YCX11BvBSMz1RK+1fZOD+DoeaVwJq+120nX1FpBRlpesrj?= =?us-ascii?Q?LY6n6fMHV95cVRUZP6AmQq22jdPJ2kxaai1ysCa?= X-Microsoft-Antispam-Message-Info: yLLApMi/fgRGlVqg2akD/SXcNAp71H4nqqzE88V9VWDIfHM+2tOsSmbps+ikUkvU79l+xRm9ePzEuKKwYUtMg5/dqTSg2QXpi/+y+T69emcfCh6p1N6zuRRrY/64VUjJ0UreC2W9CJfXghyXyyLLKhMYGXYgpSnh9ipa33x3cjByEgO7wi+PVbZi0V6XSlcsJkxd2DH1yQpeG5aIjMazM3S27aaPKc9TbxU1GUlWHCaJWMOtX27RHWuBVaJGYqjXIopKiTzk8HOIlvL5q2iWKHHIh1jbmhkYyc8qKCcPob3pgBHojmktylB0wH0I6+NdsmgNeBDkjLkhferw8ambsULZ9rOkNHbKI2e99ddJO1Y= X-Microsoft-Exchange-Diagnostics: 1; DM5PR04MB0394; 6:s181Cn552ABZ461DfuePMa2jNQh4TEdhzLtEtkfjqfS2rvtYzXsWne6IXpZtel0evf4QHCGyk682D7RlstnEpK9+Y5vfN3FZTi4fykrdxfcPxOJgTT/B1fvHprrXR5h77gDu+FtYJQk90703A7k0H9UrFzDmsFP0oTndyK4SfZXVfw5ZiH9p3JfJzHkv1omYW5rZpw7gMZHn6Mvv1a3u5sMz/+Kl3tNOmG1bYKHQkFKCX34KPnkweFKq5kLKt94/5bLcHfho+q5IjYU9AdvhXyFMqiMGQdSxHPHKA2/39To+bnnIayeX/F9KUhRi3ftPYPoB/m/hZzspEstopXQMP4EIdhmzC5/r0iOp5+IJfAUbPuwGD9uhz0u5OHrabFG+l7TR8DpcmN1/8/7rGmJfat5GyKqhiRvFL0oImB6qTcrQQxm6WAE+S/yGrv2t4hLNeh0WlijOXHwHIf/5qNSZnw==; 5:CS5eVkRP4Pvfy/dRSnriatw8j/e3XN1igLzf0IBrh9GeL+TIbTK3APJzVVl9IQnY5+or1cbfzFaicqy7HJoNLivaPfB0WL9DeRiRLpwQbhmyQNfHQW04tAX27ta5Rb2i+qR10je7IBFIyKnAr8gTqRjmgEdxeOYBNNrenlZ269s=; 24:qalg6B2gu8o7qyVoYNcU6GaVSvJXoJvfOkb8a2B3Kp0G50y719JlDFVsMRIjwCGzCbUlJShhIU9ANV5+myt1LVnqRyh4BwmH4nuoHqu1S/w= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DM5PR04MB0394; 7:H+FXG9rrBcncY0P2gqQGUDrHLoJmrIvZZDW0wOVRKNZ26ouUHRuUve/NlhamAQj2Bh+NqOmRdxfV+uguPa7WPh+e4eM9GhCvGkfXUNleMjDkhfcJAGSzHOnHlVtQygiE8Pvs0DW6Uq2gm36ONcdw5jGgRt46omjp0xbLshrmqZBXrt1UncIvoIrqjWr/x2wmoaRdDITIXZTDEOlgVghyQySbQd94iNJBrL2jL1XfqgZ8lWuku6uw/K+GDzKO+HZK; 20:qhLcLwB33YRTWfhwR+5XJ2I/pfAEy4H7udWZrrk8PqjBGcPuF9EifXm6R+BwH4LeLCKfRgOSr+HYLM52xnQdWaX0vuhD+vyoGaq+qrq4mu6q8fJZHS8CRRCQpZm8RUwU0zdRqpwtgmCBa1Zzguk4MmG72kZqDDNPJAZvaPa3uj8= X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2018 20:27:59.3448 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bac28d5c-5105-4a1d-445f-08d5ec23c9d7 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR04MB0394 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 216.71.153.141 Subject: [Qemu-devel] [PATCH v1 1/5] sifive_e: Fix crash when introspecting the device X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: thuth@redhat.com, mjc@sifive.com, alistair.francis@wdc.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (found 2 invalid signatures) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use the new object_initialize_child() and sysbus_init_child_obj() to fix the issue. Signed-off-by: Alistair Francis Reviewed-by: Michael Clark --- hw/riscv/sifive_e.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/riscv/sifive_e.c b/hw/riscv/sifive_e.c index 8a8dbe1c00..4577d72037 100644 --- a/hw/riscv/sifive_e.c +++ b/hw/riscv/sifive_e.c @@ -105,9 +105,9 @@ static void riscv_sifive_e_init(MachineState *machine) int i; =20 /* Initialize SoC */ - object_initialize(&s->soc, sizeof(s->soc), TYPE_RISCV_E_SOC); - object_property_add_child(OBJECT(machine), "soc", OBJECT(&s->soc), - &error_abort); + object_initialize_child(OBJECT(machine), "soc", &s->soc, + sizeof(s->soc), TYPE_RISCV_E_SOC, + &error_abort, NULL); object_property_set_bool(OBJECT(&s->soc), true, "realized", &error_abort); =20 @@ -139,9 +139,9 @@ static void riscv_sifive_e_soc_init(Object *obj) { SiFiveESoCState *s =3D RISCV_E_SOC(obj); =20 - object_initialize(&s->cpus, sizeof(s->cpus), TYPE_RISCV_HART_ARRAY); - object_property_add_child(obj, "cpus", OBJECT(&s->cpus), - &error_abort); + object_initialize_child(obj, "cpus", &s->cpus, + sizeof(s->cpus), TYPE_RISCV_HART_ARRAY, + &error_abort, NULL); object_property_set_str(OBJECT(&s->cpus), SIFIVE_E_CPU, "cpu-type", &error_abort); object_property_set_int(OBJECT(&s->cpus), smp_cpus, "num-harts", --=20 2.17.1