From nobody Mon Feb 9 12:11:32 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=eik.bme.hu Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770254034488117.02815792000172; Wed, 4 Feb 2026 17:13:54 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnnw5-0002cJ-9a; Wed, 04 Feb 2026 20:13:33 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnnw0-0002bE-O1 for qemu-devel@nongnu.org; Wed, 04 Feb 2026 20:13:28 -0500 Received: from zero.eik.bme.hu ([152.66.115.2]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnnvy-0002ze-1V for qemu-devel@nongnu.org; Wed, 04 Feb 2026 20:13:28 -0500 Received: from localhost (localhost [127.0.0.1]) by zero.eik.bme.hu (Postfix) with ESMTP id 98D5D596ADE; Thu, 05 Feb 2026 02:13:21 +0100 (CET) Received: from zero.eik.bme.hu ([127.0.0.1]) by localhost (zero.eik.bme.hu [127.0.0.1]) (amavis, port 10028) with ESMTP id Jc7AANp5Wurr; Thu, 5 Feb 2026 02:13:19 +0100 (CET) Received: by zero.eik.bme.hu (Postfix, from userid 432) id 50DDC596A41; Thu, 05 Feb 2026 02:13:19 +0100 (CET) X-Virus-Scanned: amavis at eik.bme.hu Message-ID: <776271c85bacff22d7c02f7fa12b890dc66a7f3e.1770253186.git.balaton@eik.bme.hu> In-Reply-To: References: From: BALATON Zoltan Subject: [PATCH v4 1/8] hw/display/{cg3,tcx}: Do not use memory_region_init_rom_nomigrate() MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable To: qemu-devel@nongnu.org Cc: Peter Xu , Akihiko Odaki , Paolo Bonzini , Mark Cave-Ayland , Gerd Hoffmann , Max Filippov , Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Date: Thu, 05 Feb 2026 02:13:19 +0100 (CET) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=152.66.115.2; envelope-from=balaton@eik.bme.hu; helo=zero.eik.bme.hu X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZM-MESSAGEID: 1770254040293158500 Content-Type: text/plain; charset="utf-8" We could simply convert these to use memory_region_init_rom but that would be a migration compatibility break so preserve current behaviour for now. Signed-off-by: BALATON Zoltan Reviewed-by: Mark Cave-Ayland --- hw/display/cg3.c | 6 ++++-- hw/display/tcx.c | 6 ++++-- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/hw/display/cg3.c b/hw/display/cg3.c index 568d6048a6..44966e7586 100644 --- a/hw/display/cg3.c +++ b/hw/display/cg3.c @@ -282,8 +282,10 @@ static void cg3_initfn(Object *obj) SysBusDevice *sbd =3D SYS_BUS_DEVICE(obj); CG3State *s =3D CG3(obj); =20 - memory_region_init_rom_nomigrate(&s->rom, obj, "cg3.prom", - FCODE_MAX_ROM_SIZE, &error_fatal); + memory_region_init_ram_flags_nomigrate(&s->rom, obj, "cg3.prom", + FCODE_MAX_ROM_SIZE, 0, + &error_fatal); + memory_region_set_readonly(&s->rom, true); sysbus_init_mmio(sbd, &s->rom); =20 memory_region_init_io(&s->reg, obj, &cg3_reg_ops, s, "cg3.reg", diff --git a/hw/display/tcx.c b/hw/display/tcx.c index 36cad82abd..87fe7216ba 100644 --- a/hw/display/tcx.c +++ b/hw/display/tcx.c @@ -756,8 +756,10 @@ static void tcx_initfn(Object *obj) SysBusDevice *sbd =3D SYS_BUS_DEVICE(obj); TCXState *s =3D TCX(obj); =20 - memory_region_init_rom_nomigrate(&s->rom, obj, "tcx.prom", - FCODE_MAX_ROM_SIZE, &error_fatal); + memory_region_init_ram_flags_nomigrate(&s->rom, obj, "tcx.prom", + FCODE_MAX_ROM_SIZE, 0, + &error_fatal); + memory_region_set_readonly(&s->rom, true); sysbus_init_mmio(sbd, &s->rom); =20 /* 2/STIP : Stippler */ --=20 2.41.3