From nobody Sun Feb 8 23:26:05 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1710283282; cv=none; d=zohomail.com; s=zohoarc; b=Xoy8kStXQDCN8YRfzIlDVLY/UZm0x4q7BMOdvGD4mwJl4c2iIwwxJrVEBUX4VN5jSfQ1GcvmX+cxfwYBEVfSxgm8U00B1mOYdOyxwZfQ5Zf/2H1kqEPgcLLabssfEA2/3GM5cV5yL0ngN4GQqvN/gqCxcVMAERufKKaWdsPO53c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1710283282; h=Content-Type:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=GTX598p9HArzTLuFOxLRmny//KCE0d5V+ZWq2MLzXgc=; b=D3U1SOjXBo/cXdF6df3eOPHWvSqkobTHWF9+nMmg7mjhvuf3dCUIIYOOYsp4TVavpaRCjaFN/79x0hU2OYnQtbUKiV6JokXIVk82xumhLSDSKmm4rPt/Fk1wqEklJfekNp8uc7Wmsz21LEL/P0CdHXNxIi1HsMzjLWq0uc4Eno4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1710283282126203.5789007852194; Tue, 12 Mar 2024 15:41:22 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rkAbO-0000Wi-Eo; Tue, 12 Mar 2024 18:28:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rkAb3-000847-Ct for qemu-devel@nongnu.org; Tue, 12 Mar 2024 18:27:47 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rkAb1-0004Rs-1v for qemu-devel@nongnu.org; Tue, 12 Mar 2024 18:27:44 -0400 Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-640-hw04cfAjPsmqkqFyvvBt6w-1; Tue, 12 Mar 2024 18:27:41 -0400 Received: by mail-ed1-f69.google.com with SMTP id 4fb4d7f45d1cf-5684b85e0c9so296076a12.1 for ; Tue, 12 Mar 2024 15:27:41 -0700 (PDT) Received: from redhat.com ([2.52.134.16]) by smtp.gmail.com with ESMTPSA id m26-20020aa7c2da000000b005682d4f12b4sm4339184edp.45.2024.03.12.15.27.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Mar 2024 15:27:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710282462; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GTX598p9HArzTLuFOxLRmny//KCE0d5V+ZWq2MLzXgc=; b=QxS+FDY/zP7uIwQub2R6AkEb4Erxop61k1p+mJzWeC5I4LRsUGb8uv4NsAytCikPCaSgqG eqriYXGIhOxLyvKH6DFHY4m1M/JkaEgAXEUXqqY5f4Qjp6wREafjX8R1/1wU5pArKtmUhQ n4q8xl/ivfLobCii4rToRYO/lKM8GYs= X-MC-Unique: hw04cfAjPsmqkqFyvvBt6w-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710282459; x=1710887259; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GTX598p9HArzTLuFOxLRmny//KCE0d5V+ZWq2MLzXgc=; b=WD+9/4v42lRgC5qIck+mLZhMhBxPeWU4NmlViPBzi36V4aAeedoz9naPsvFoMdCIvu uJ6VPTNZWGV2N9wzF5+Dk/gtP5C/QuB+xo0qgoOj2jnp/pSuO+yD1a0J20JRxHzUK0WK or8W+JLShiP4vUOTQy1E/R8BrASV2838HymJYZwqyNlp/HgsvC2YESMD7lUNwU1nP2Mu /i/NZfvxml3ivkWZBtvGLreVived0gfauZJKwfs8+L05YXpKu2kZWoWF1y8lKNxtwRtz hGTdUXYtrQzk/yhgABnOTWLfPFf0mnNocTK2TjfRER/qitt+2hltDOpt2PnKYAt/0wjk yPPA== X-Gm-Message-State: AOJu0YyZVlD9OWyiK93sqlPkVzIgK8aJBlP6bAV7XaDu3sJ4PVKVq9bM Q1uy1dffXpHku2s0bc2zJOIz9tUKii+WhILBSzDBE4cmO2s5gyX2V/BGdPEQNweNmrZYqVWibwo qfm9dtNvbq+mGCsUA+i0ezrhu5Z13HRkDk7K/XZ1kFAxWC/JeruYCfzDwsfJPyJzlSd+w/Yj1m9 X7GTNSDmyzNHiLDQ3bPzB4/cS7XxZXejxW X-Received: by 2002:a50:cc89:0:b0:566:d083:df68 with SMTP id q9-20020a50cc89000000b00566d083df68mr707136edi.21.1710282459418; Tue, 12 Mar 2024 15:27:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGa5S5keexVi6Dkun5xvRgm/rGhpB0nN6qsiA5dFpVWMgHBQyZQ3SAvwwblUKBHQFX95crq8Q== X-Received: by 2002:a50:cc89:0:b0:566:d083:df68 with SMTP id q9-20020a50cc89000000b00566d083df68mr707095edi.21.1710282458418; Tue, 12 Mar 2024 15:27:38 -0700 (PDT) Date: Tue, 12 Mar 2024 18:27:35 -0400 From: "Michael S. Tsirkin" To: qemu-devel@nongnu.org Cc: Peter Maydell , Felix Wu , Nabih Estefan , Igor Mammedov , Ani Sinha Subject: [PULL 40/68] Implement base of SMBIOS type 9 descriptor. Message-ID: <735eee07d1f963635d3c3bf9f5e4bf1bc000870e.1710282274.git.mst@redhat.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Mailer: git-send-email 2.27.0.106.g8ac3dc51b1 X-Mutt-Fcc: =sent Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=mst@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.687, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1710283283890100011 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Felix Wu Version 2.1+. Signed-off-by: Felix Wu Signed-off-by: Nabih Estefan Message-Id: <20240221170027.1027325-2-nabihestefan@google.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/firmware/smbios.h | 13 +++++ hw/smbios/smbios.c | 99 ++++++++++++++++++++++++++++++++++++ qemu-options.hx | 3 ++ 3 files changed, 115 insertions(+) diff --git a/include/hw/firmware/smbios.h b/include/hw/firmware/smbios.h index 6e514982d4..9ab114aea2 100644 --- a/include/hw/firmware/smbios.h +++ b/include/hw/firmware/smbios.h @@ -211,6 +211,19 @@ struct smbios_type_8 { uint8_t port_type; } QEMU_PACKED; =20 +/* SMBIOS type 9 - System Slots (v2.1+) */ +struct smbios_type_9 { + struct smbios_structure_header header; + uint8_t slot_designation; + uint8_t slot_type; + uint8_t slot_data_bus_width; + uint8_t current_usage; + uint8_t slot_length; + uint16_t slot_id; + uint8_t slot_characteristics1; + uint8_t slot_characteristics2; +} QEMU_PACKED; + /* SMBIOS type 11 - OEM strings */ struct smbios_type_11 { struct smbios_structure_header header; diff --git a/hw/smbios/smbios.c b/hw/smbios/smbios.c index a3c4e52ce9..38b3ea172c 100644 --- a/hw/smbios/smbios.c +++ b/hw/smbios/smbios.c @@ -121,6 +121,16 @@ struct type8_instance { }; static QTAILQ_HEAD(, type8_instance) type8 =3D QTAILQ_HEAD_INITIALIZER(typ= e8); =20 +/* type 9 instance for parsing */ +struct type9_instance { + const char *slot_designation; + uint8_t slot_type, slot_data_bus_width, current_usage, slot_length, + slot_characteristics1, slot_characteristics2; + uint16_t slot_id; + QTAILQ_ENTRY(type9_instance) next; +}; +static QTAILQ_HEAD(, type9_instance) type9 =3D QTAILQ_HEAD_INITIALIZER(typ= e9); + static struct { size_t nvalues; char **values; @@ -380,6 +390,54 @@ static const QemuOptDesc qemu_smbios_type8_opts[] =3D { { /* end of list */ } }; =20 +static const QemuOptDesc qemu_smbios_type9_opts[] =3D { + { + .name =3D "type", + .type =3D QEMU_OPT_NUMBER, + .help =3D "SMBIOS element type", + }, + { + .name =3D "slot_designation", + .type =3D QEMU_OPT_STRING, + .help =3D "string number for reference designation", + }, + { + .name =3D "slot_type", + .type =3D QEMU_OPT_NUMBER, + .help =3D "connector type", + }, + { + .name =3D "slot_data_bus_width", + .type =3D QEMU_OPT_NUMBER, + .help =3D "port type", + }, + { + .name =3D "current_usage", + .type =3D QEMU_OPT_NUMBER, + .help =3D "current usage", + }, + { + .name =3D "slot_length", + .type =3D QEMU_OPT_NUMBER, + .help =3D "system slot length", + }, + { + .name =3D "slot_id", + .type =3D QEMU_OPT_NUMBER, + .help =3D "system slot id", + }, + { + .name =3D "slot_characteristics1", + .type =3D QEMU_OPT_NUMBER, + .help =3D "slot characteristics1, see the spec", + }, + { + .name =3D "slot_characteristics2", + .type =3D QEMU_OPT_NUMBER, + .help =3D "slot characteristics2, see the spec", + }, +}; + static const QemuOptDesc qemu_smbios_type11_opts[] =3D { { .name =3D "type", @@ -609,6 +667,7 @@ bool smbios_skip_table(uint8_t type, bool required_tabl= e) #define T2_BASE 0x200 #define T3_BASE 0x300 #define T4_BASE 0x400 +#define T9_BASE 0x900 #define T11_BASE 0xe00 =20 #define T16_BASE 0x1000 @@ -807,6 +866,28 @@ static void smbios_build_type_8_table(void) } } =20 +static void smbios_build_type_9_table(void) +{ + unsigned instance =3D 0; + struct type9_instance *t9; + + QTAILQ_FOREACH(t9, &type9, next) { + SMBIOS_BUILD_TABLE_PRE(9, T9_BASE + instance, true); + + SMBIOS_TABLE_SET_STR(9, slot_designation, t9->slot_designation); + t->slot_type =3D t9->slot_type; + t->slot_data_bus_width =3D t9->slot_data_bus_width; + t->current_usage =3D t9->current_usage; + t->slot_length =3D t9->slot_length; + t->slot_id =3D t9->slot_id; + t->slot_characteristics1 =3D t9->slot_characteristics1; + t->slot_characteristics2 =3D t9->slot_characteristics2; + + SMBIOS_BUILD_TABLE_POST; + instance++; + } +} + static void smbios_build_type_11_table(void) { char count_str[128]; @@ -1126,6 +1207,7 @@ void smbios_get_tables(MachineState *ms, } =20 smbios_build_type_8_table(); + smbios_build_type_9_table(); smbios_build_type_11_table(); =20 #define MAX_DIMM_SZ (16 * GiB) @@ -1460,6 +1542,23 @@ void smbios_entry_add(QemuOpts *opts, Error **errp) t8_i->port_type =3D qemu_opt_get_number(opts, "port_type", 0); QTAILQ_INSERT_TAIL(&type8, t8_i, next); return; + case 9: { + if (!qemu_opts_validate(opts, qemu_smbios_type9_opts, errp)) { + return; + } + struct type9_instance *t; + t =3D g_new0(struct type9_instance, 1); + save_opt(&t->slot_designation, opts, "slot_designation"); + t->slot_type =3D qemu_opt_get_number(opts, "slot_type", 0); + t->slot_data_bus_width =3D qemu_opt_get_number(opts, "slot_dat= a_bus_width", 0); + t->current_usage =3D qemu_opt_get_number(opts, "current_usage"= , 0); + t->slot_length =3D qemu_opt_get_number(opts, "slot_length", 0); + t->slot_id =3D qemu_opt_get_number(opts, "slot_id", 0); + t->slot_characteristics1 =3D qemu_opt_get_number(opts, "slot_c= haracteristics1", 0); + t->slot_characteristics2 =3D qemu_opt_get_number(opts, "slot_c= haracteristics2", 0); + QTAILQ_INSERT_TAIL(&type9, t, next); + return; + } case 11: if (!qemu_opts_validate(opts, qemu_smbios_type11_opts, errp)) { return; diff --git a/qemu-options.hx b/qemu-options.hx index ac4a30fa83..7da9235b08 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -2718,6 +2718,9 @@ SRST ``-smbios type=3D4[,sock_pfx=3Dstr][,manufacturer=3Dstr][,version=3Dstr][,= serial=3Dstr][,asset=3Dstr][,part=3Dstr][,processor-family=3D%d][,processor= -id=3D%d]`` Specify SMBIOS type 4 fields =20 +``-smbios type=3D9[,slot_designation=3Dstr][,slot_type=3D%d][,slot_data_bu= s_width=3D%d][,current_usage=3D%d][,slot_length=3D%d][,slot_id=3D%d][,slot_= characteristics1=3D%d][,slot_characteristics12=3D%d]`` + Specify SMBIOS type 9 fields + ``-smbios type=3D11[,value=3Dstr][,path=3Dfilename]`` Specify SMBIOS type 11 fields =20 --=20 MST