From nobody Wed Nov 5 02:58:20 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail header.i=@wdc.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1531859461739209.1170979759347; Tue, 17 Jul 2018 13:31:01 -0700 (PDT) Received: from localhost ([::1]:33152 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ffWcV-0001pv-6j for importer@patchew.org; Tue, 17 Jul 2018 16:30:51 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49463) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ffWaV-0000EX-W6 for qemu-devel@nongnu.org; Tue, 17 Jul 2018 16:28:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ffWaQ-0005l3-37 for qemu-devel@nongnu.org; Tue, 17 Jul 2018 16:28:46 -0400 Received: from esa1.hgst.iphmx.com ([68.232.141.245]:51356) by eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71) (envelope-from ) id 1ffWaP-0005kc-Lf for qemu-devel@nongnu.org; Tue, 17 Jul 2018 16:28:42 -0400 Received: from mail-by2nam03lp0049.outbound.protection.outlook.com (HELO NAM03-BY2-obe.outbound.protection.outlook.com) ([216.32.180.49]) by ob1.hgst.iphmx.com with ESMTP; 18 Jul 2018 04:28:39 +0800 Received: from risc6-mainframe.int.fusionio.com (199.255.44.250) by MWHPR04MB0401.namprd04.prod.outlook.com (2603:10b6:300:70::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.952.18; Tue, 17 Jul 2018 20:28:36 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1531859321; x=1563395321; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=OW7GsMaJB6yFpZ1sldwnHhyBeLJlBxlGvLILmf9CnD8=; b=iX3ba++Slg9ujPoEJ/TDlKyXI/lZkUUIY0/D96mwijFW0IUA2rmrPgEK 8uyOpb0rMeiyhfWldxxWQ+7UCtN6EjWGTW8THQueEI0F7OjyDzEi4zesV xdRQmYRXUWcSxV4Jgo6WXDTzT7qFo9IAEsLv3hwb1SktIhECkQ/MqnUyi qjwJjVusODoVTmO40GispklZipZNMi4Whvp+msPIAJe4oi3cT/u00KIn7 cm0UAsHGlpSXdY9HhDz30VooStdf6Wk5EDrJmqCi4i8RvZjZHPR2jFgYW NotGQx9+fxVx3zQPiWDtUNVuDIf63XSSK/HulCegPZcwbANj3MbApJ3p6 A==; X-IronPort-AV: E=Sophos;i="5.51,366,1526313600"; d="scan'208";a="187792148" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector1-wdc-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w3Jj27jptKthdvXHGV3XdDgiThigVPVpO7ZzCgmWsG8=; b=XVW/qQMVFMOENUMJpgYzO0K/13l+BXS6f5dAaqywhE2vDTlyc2GhErH1dmN4gYVgv5o2goh90P79KB4bQa+P+4BRnSG32M85KMuf6fT8mTOsgqMp5D3hz5mTkUFSg9WHcA0OaXM0+67c4j9FIBJPBaqXe4UhUql4b1D88pDNd0I= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Alistair.Francis@wdc.com; From: Alistair Francis To: qemu-devel@nongnu.org Date: Tue, 17 Jul 2018 13:28:28 -0700 Message-Id: <6c60f18b1b26088dbbb54538caeaa0121e94a52d.1531859179.git.alistair.francis@wdc.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: MIME-Version: 1.0 X-Originating-IP: [199.255.44.250] X-ClientProxiedBy: BYAPR04CA0027.namprd04.prod.outlook.com (2603:10b6:a03:40::40) To MWHPR04MB0401.namprd04.prod.outlook.com (2603:10b6:300:70::18) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ff0b3a86-4832-427d-128d-08d5ec23e003 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600053)(711020)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(48565401081)(2017052603328)(7153060)(7193020); SRVR:MWHPR04MB0401; X-Microsoft-Exchange-Diagnostics: 1; MWHPR04MB0401; 3:4sT6zMtssSCduH7eu9VwXYrd69BFgXYFfVu2qS6h/jAOGI3W6rO1405ZOtOES3JOdkGWEQSTrl1Yjd4YEOlkWoTa73zOugdgHQ0YABsLRBnYOoYKMevllMlS7zLaKprSDl2Se7iWP8da1mzBgvtlLDWV3QMh4Q1YQdYaYvSZL31Da7Laomni6SCozmqBHhdAnMX4U2v4mD/84eM/d7piL9x/E+tHbybIM2RV37QMUZujmUHS2dxor5J7YcRM1SUI; 25:EHJvDF7tLTqHsulYwC3geAvbSG+Q9Bj2pzbdea/mms9ujZX3q33VKiw7hDaVjIa3KXeYBWtahcCIKvOrwnYvbbDglyoPjPAT93tdqJWCewXgCw4ijT4OC5/+PXVNnE4H3FIABAFIGMC82MNMcVFfwyzaRBGn/zXUIutKSGjzdyfCDTS6Kb+U1DpkHKquqSTlK9nF8Z8wiBYT+D7eM6rh4RpuugSZygmZl2xRSsKw0Lgn8cT581L8R8FqtzMWIbZtPxcH+wP6kMpVE3ZnWcgKX3H3G2wgRI8h7DoIRNLxFX4RZimtWX661a6rXI61jAN9yJjQzpNY1wzbJzh3xP33cg==; 31:OZQGsCY1YXfyzeZWVVXsWT9HKtdbvQ7p7uw5WjYetEJdEJunMsEkxFTRWZywK8RUMw3ycdBNRj808jYDjebVgGEC5skrntaGvDv/W7V0cxMnxpgCs8/mU7pwF6qnrH2MAPDHKT8CjLUEuovoLEvESjnV/QlkT+OBi32meUVJ3og6YR39kHlYcB2lOQAItY0RVVlxzXxwjuBfUbZkteSpVjH077crwHhsDS4Y7qLtVXc= X-MS-TrafficTypeDiagnostic: MWHPR04MB0401: WDCIPOUTBOUND: EOP-TRUE X-Microsoft-Exchange-Diagnostics: 1; MWHPR04MB0401; 20:pvvHheGw3a75Kb2y/LdL53MuVBeuB15D1fHQLaMJxBhHb6OMzGpBmXj6JSJoUtZdHeGs273V3t1ub9cX+eq74S0wAvBRKDvjd7uEohxjfiz+iq696/WkjDISxYdnca1rqo/DwrowfRO4GetvQ6q6BPWI1G/Yj4zw8dOB0mN/aCgpQF/b/QSDMUUg744CfrXqEy1z/aDc6Uw2c+oyELGCfedHMxWdIcbkLqdIDCIRUklEzSMgMEY9UobF7imnhr1ghDsV8VIHc0qC6RVafyTVJrFaeH3ISlUC4pizOTQS1XSk4fuOLrzBrFvSGTkOrRgs8YbHxicgTJ4pTdmk9/gCayS34FIC7H89k04g42HHqTCv4y0nHV/Qnhd+uEVwX4ymMbMOZq5iZjBEsD6VurXOiHEfnlrVxY2mQFtPs31PAAU7yPsi/2VGinXoDmQjnDSY1TW74h+yS2DS/KKh4K76NSmKJyBji8onxJKCDsJW6uHRvYG3B0UYnNDnTxhwiF31; 4:0g8L2YDGmSYbcsWmKCVkgTKUJlIco1vUN/AzZ9cxGMUyrYpUE/pnUY1MoFLoafR+slXrdhj8G1AwSEsIAFtcVGY5iz1l3xT1A6bdHp00lx+TcKjghMIaVKa4+X+W7i2YiFRqUrujTuTyXkkB6jf9JWIoqHOEVL+6cmgR+v8NpMVqhHGt7plj5HtOWeRtf8Y5pQWROKdDm+FXSQYI2mOTLxS+HiGRbI0KiLo3qk7KQnXyVFfVCRRklwj80ZBHMKmImO6Ji0XqdTUiitAHx83N4A== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(3231311)(944501410)(52105095)(10201501046)(6055026)(149027)(150027)(6041310)(20161123564045)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:MWHPR04MB0401; BCL:0; PCL:0; RULEID:; SRVR:MWHPR04MB0401; X-Forefront-PRVS: 073631BD3D X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(136003)(346002)(376002)(39860400002)(396003)(366004)(189003)(199004)(118296001)(47776003)(2906002)(76176011)(3846002)(53936002)(26005)(6116002)(575784001)(97736004)(86362001)(16586007)(2351001)(316002)(8676002)(72206003)(476003)(2616005)(956004)(51416003)(305945005)(48376002)(16526019)(2361001)(6666003)(6916009)(4326008)(68736007)(66066001)(478600001)(50226002)(7736002)(186003)(25786009)(6506007)(386003)(36756003)(106356001)(44832011)(446003)(52116002)(5660300001)(6486002)(8936002)(81156014)(11346002)(105586002)(50466002)(6512007)(81166006)(486006); DIR:OUT; SFP:1102; SCL:1; SRVR:MWHPR04MB0401; H:risc6-mainframe.int.fusionio.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; MWHPR04MB0401; 23:7uXmB4iG0vjVqjo+hu+QCtPfCGgs8rwgrBBh7e6Y0?= =?us-ascii?Q?wfwTyVCVEsisHgpndduyq3V6Xgb+WDKLKHPg2XodHr65cSQg0OO/uphljKk1?= =?us-ascii?Q?/PHoDtX5Bn7EeyrQeO9s5EtqFc/qOmWl66fV9GdbGOZtZPyc/okHX9vyK/1n?= =?us-ascii?Q?dPSZMAl79B7/eKJb1srjxmlBCZWXU8XUK8xddwExM1ryRs+IMIDSQQYpqbB0?= =?us-ascii?Q?Vhdwyx7o1luNSujna/HFZUqUxF/rZwm77IOaNmF01fxnJmD8VEfqdJRtgub/?= =?us-ascii?Q?AAC68s30uUfzHdcpUeFiLKBUgRFixdYqB0/yloI4bfxDl6D43abv14ko/SYb?= =?us-ascii?Q?BHhdpbeppmY7c4NvKBW2ND6MY/sOPpNwZm/Zh0b8BfWziDggNFHnwywljDv1?= =?us-ascii?Q?VG3SHtgBwSaJo8uPd+cQYfe7SRfMgmGu+QW87qjaK1Qd0vwBHnyprroEud9x?= =?us-ascii?Q?jcTbdtL1l3SQsvChjbAwOXNn4vH3SG/Ftw6BtknWic1X7HSX1oGxfUTwiUx5?= =?us-ascii?Q?qxrtBGG4cOttDkd8jo6FVKRXAsa2xzn4/RjO7hGH81J1Y4XWVwYKAkyqF/hK?= =?us-ascii?Q?98IZZCZy3ajPWOLWzKinRmB0TQ25rSFebNF0DI9sVTIfrk89v8lX6Ros3d2S?= =?us-ascii?Q?E/HdcOex7u/FbBhKAjhceCtIa7aMDdZc1P0bNL80qZAiVLa1mYFMvk3q8qBe?= =?us-ascii?Q?HUpc0ei82N9lM1Q3lXvG2gjPF09yfr0t8M/gpT5gHmpM5jhO1TZ8MT+80qB4?= =?us-ascii?Q?q4H8MvlM8WTly1Jj5DM70sIG3Sl+nd0NitAsDn2oXrUAtqFadl/1KwpinWA8?= =?us-ascii?Q?XoVRizNIk+aERmmeJLD84qg4PdzFP2A6DgM/KYwfvuY5aWW6VRkTHij+K1RD?= =?us-ascii?Q?OIg85Y4PenIKsQAZkZM6VT65HHNzH6wcDjRELX1elIciSe+pTxL8frZFwk0y?= =?us-ascii?Q?vnVIVdQvnf75N4qApBUwV7Hh5yeiB59E+WBpI7gt2fxeXipXbzRKueBKJFrw?= =?us-ascii?Q?NXdHgdurIyBxwJW0uRJ0h5m003fYWlbeIpuqJC/1SzRD9z+oJJgMQ8rSBNWW?= =?us-ascii?Q?4V3UwW1eHILodsaJl4oAoOLW5LydK1/dr/BNLMdt8D/ywUsl4fhy5xm7Dbvu?= =?us-ascii?Q?FisNw803Hh/ZaGPnoHzgBiEUSk8UYBXxE4bzcGxK27nUb4tVfX14Vgv46kQ4?= =?us-ascii?Q?uBSaCJcZd+uKuhW8AfCTvWMBdTm4O+rN5/gRm8aOBYOm6nF50rNvLE0a9Jt/?= =?us-ascii?Q?ATl1i7Lp2+qOIEm19bkU/7WjtvVh6KgAHlmLB9zoyteNqqAKtT1D6oeac7FS?= =?us-ascii?B?UT09?= X-Microsoft-Antispam-Message-Info: GkzIpYqxXxalNb7cTH/blaMmOA0oUbbfoKfiwpxpFOvMAHv23XaTEdl9NUxz4+wYfdQdXVpd+P8X7GkNwWJypHbw58C8zGxXII1hLt6GN54h3Zsu4U7TOMUg65TC4HImVhSYTVQBsmEhwKdl7jG1bEywjCv8MQGYwt+1pOH8u7Fp2dpgnMneugSuFMgQTy/fIAFy8EV97zMA4yauQtrX1Q5sXt95uzOp7IYMBlrptw+qplw2PVsyIhkd15jEAMY+KIkXVuwlx4odye9s3f78ZcP7MA9X2sCS0mz0UWnt5DIuq/ttkGRIcM1bDSlT1RsL+SFgvS5Us60P22HPNKyJG71cnREw5ZU7DkzOK8Tj1ko= X-Microsoft-Exchange-Diagnostics: 1; MWHPR04MB0401; 6:47C5jYFam7YkPxsmAxYHexifFWZI7IHM62bRRvRPJBMkMbrm1usocHI2Ml3m1pPqnJep2aFTXtcF06HNmOdVYpkxv71T0kRHkSZiPiDefby+CUHRpI3ICT2qti28YEqxf7YqI1qfjeirZ8Guyx9xbQvUaNeorpmNUDT/PPTKGQaGXrhxnoMYED7SSkaAtZxr1uuWCapV/QDL5Xn5LdaP6FgsEu3lxHOfHxrPFCMe1STw024VjwLQpkqDNg158I5f5eFhI5SlIEZOBIwjXhB27t2ObiRsG4faUoXEylPCnjtfG4GAfoMz4T32n5ewElOVgeNi/EoiAr7dhtPjXGkc7iGyoZZKflcbnORtGqPYgHXZEyUMRtzZjztC1m1fJmfW1VDQHWz28Y0pRpDdfE5HcAheoXY57663ljcvuJdx0INQV+VeVBiTh12Y3Tu/d/5a2GO4SChNNADICdRut2iB0w==; 5:hpal2q4XC8mbwcGRxyizdxABd1CThUIziUdYIesOPoBuGc2g9UcDUHdZbxfWBphuS5t0amRPq1LLvBR88bVwvk5kTX/UzhrYJDnfEtCtE8p7FetA4JIeK7Mu6VCmimIbVwwp1/gXGqXWeLTBaFBTMh6ztDN4nvV/9qd9HU9JSZE=; 24:V1Bv7d+48w3myeMHxuWWiXFHzuBiiS6kP6l06pBPWX4o0w+U2vjW+UXTSNsDwZ2EoHMv7SigsuwVLuwLelkMmTM+StGp4uNXslL5E2zy7mw= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; MWHPR04MB0401; 7:m3nnGXcExBJTgALfqds73isLYOPgGS2gx1kRAlAOQ4MNFnXBMMejbc5vlWBtjP+L9eSCCD4g8HKMR5viGsA2PY/EZmS/McShcR4hO/Qz6NXu9+F+BYszjaVtDlHzwWLDh+1uR0Jp/WOjOwlS9CQjGdJrDD5PJkzuQyrZHyQOK6wqNp12WHXtqpcNU1BSghFV+KzN73noDfmqU35WrvJSylL6Zj5oOilZHqKiC3h75Wby16m35mcaGc7r5+6Ed9Ze; 20:LCfwItv5e/Ik20ZTJH+3kogHW1p438TuhDbCiejk3lXpUTCohnzj5JgQw98zMXsgRz44rPsDoBb405JrF7FNiiF9hyGWxfxP3V9k8GCkziaZSIUaNcENNAvdpqiIlMklipLBv41VRAJjNpuCtDaVrM06Um1E5/SqeAtEwtY51MI= X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2018 20:28:36.7339 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ff0b3a86-4832-427d-128d-08d5ec23e003 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR04MB0401 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 68.232.141.245 Subject: [Qemu-devel] [PATCH v1 4/5] riscv_hart: Fix crash when introspecting the device X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: thuth@redhat.com, mjc@sifive.com, alistair.francis@wdc.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (found 2 invalid signatures) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use the new object_initialize_child() and sysbus_init_child_obj() to fix the issue. Signed-off-by: Alistair Francis Reviewed-by: Michael Clark --- hw/riscv/riscv_hart.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/hw/riscv/riscv_hart.c b/hw/riscv/riscv_hart.c index 75ba7ed579..e34a26a0ef 100644 --- a/hw/riscv/riscv_hart.c +++ b/hw/riscv/riscv_hart.c @@ -45,11 +45,10 @@ static void riscv_harts_realize(DeviceState *dev, Error= **errp) s->harts =3D g_new0(RISCVCPU, s->num_harts); =20 for (n =3D 0; n < s->num_harts; n++) { - - object_initialize(&s->harts[n], sizeof(RISCVCPU), s->cpu_type); + object_initialize_child(OBJECT(s), "harts[*]", &s->harts[n], + sizeof(RISCVCPU), s->cpu_type, + &error_abort, NULL); s->harts[n].env.mhartid =3D n; - object_property_add_child(OBJECT(s), "harts[*]", OBJECT(&s->harts[= n]), - &error_abort); qemu_register_reset(riscv_harts_cpu_reset, &s->harts[n]); object_property_set_bool(OBJECT(&s->harts[n]), true, "realized", &err); --=20 2.17.1