From nobody Fri Dec 19 19:18:11 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail header.i=@wdc.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=wdc.com ARC-Seal: i=1; a=rsa-sha256; t=1575915758; cv=none; d=zohomail.com; s=zohoarc; b=PKcoH55vmm8s7ttXJh5yfz4r4Q2AxT5RRawjkJ+JBBkxIZs4OmxFrK/hmdxNUt66GyaODmms6FwhhBVij2T/PdECXh5NR8IzhBoeBMhr3Xg9J+wHeiJNB9p7h8k1ixywCKBr45QjCd1HSfJvDIHTTcCR5+eWII4ALIJKHyhgXVI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1575915758; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=GwmgEg/sVNiJHasDqylfv+JAwX52lpO1ok3PnJK0E80=; b=h7DIFWgBHA/YyI+7f9cBv2/RsMjEnHr01qj9qxvQaNNYi0/lE40hhnYNjyBOdy8Awu4vWWLE2eZkno0GWoV5Z2hbeJwwXcsfIFeXnrYi/Ay05PjYHUgJ2NFWFXpbBGnXbtjDuWUlAySQkbt1uY/HAYu0kCurHcz2bhxxb6igm7A= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail header.i=@wdc.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 157591575870014.318063245363533; Mon, 9 Dec 2019 10:22:38 -0800 (PST) Received: from localhost ([::1]:44352 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ieNg4-00067V-Ou for importer@patchew.org; Mon, 09 Dec 2019 13:22:36 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34371) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ieNa9-0006U8-Mw for qemu-devel@nongnu.org; Mon, 09 Dec 2019 13:16:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ieNa8-00074R-Mr for qemu-devel@nongnu.org; Mon, 09 Dec 2019 13:16:29 -0500 Received: from esa3.hgst.iphmx.com ([216.71.153.141]:57632) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ieNa8-00073h-Dk; Mon, 09 Dec 2019 13:16:28 -0500 Received: from uls-op-cesaip02.wdc.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 10 Dec 2019 02:16:27 +0800 Received: from uls-op-cesaip01.wdc.com ([10.248.3.36]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Dec 2019 10:10:43 -0800 Received: from risc6-mainframe.sdcorp.global.sandisk.com (HELO risc6-mainframe.int.fusionio.com) ([10.196.158.235]) by uls-op-cesaip01.wdc.com with ESMTP; 09 Dec 2019 10:16:28 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1575915388; x=1607451388; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Dys0PWzpucJXCLJWA35Bq97629MmvwsOaIFCuZq7/+E=; b=NMX+qKevn/KSjzpQXyhT4yyf3D6pLvGA3M2T3DaOZLd5wAwtiwU+DBAU uLAomQxrkki1ZjitNQYQgCaJhiI3K/3yXub22F8J9oKJanEgEvhFqqW1Q if+Vk457INnYMvjm/g/ttEwVGti4/XKXmgzGBMGIabC1tLciUUv3Yc7mX 3AxI7+o7bn4dJNK6nsWFrTPwEIbU+k8y/zH/N/MqGJSNwA+KWR94cyO8u 09q2tAqZkvB+m/8jusmRGDHW4ba7hci/wLgWmAAqfAh2DJReg/wwrU2gB 2OmcvZ6RGhOzV4cxYPwUjJ5THs8LF13X+CRoQmq3KSN+SkUkrHHUXqRoX w==; IronPort-SDR: lS4q1EtRCmAAX1q/1DjASAMcFYzQKhb6pHUF2OT3Zqb3TZjE/7Lt0cVH3E2MTqKFpAVHZXqTUK KHgkbcVf8HiOpA1wmdEt6EgI3mVzbO0tZ1KRZgyGh2xjttwo86vddrwTMJIaf+dqTtH1G8Cf/a VIpIepMdit14hN1WC7jj0FlUIseVU0XdUT36zMFwKcPFerK+wzmhLknWrhDZIc5WF7GwXxsy4l L7Tz5QmwWQvgB5le/+LpayCewFN7MukRHoMIZpsZ2GtiOKNfK9gTYOzzriYYGqUPcOcGRp0GrW jXk= X-IronPort-AV: E=Sophos;i="5.69,296,1571673600"; d="scan'208";a="129370403" IronPort-SDR: 6fNXwaX2de/01TFmzEzZmWBAKneFQxGPGCHXJZK1/fON937WN2nXaZX9NXQVNZcAEMqUAsJ1Ba 0AJR2+tjh4LTXZQBTXUfH5Q5Nv6l7yvddWMZKZ+kMtzKFZZ6PmYDJ4uDlNySUo0kRZYQBi6n01 o9l2I85FjJ/UUGXHXOp86spm7SZhzeb3MMzRwgrsH8F3F9HIH7ztJTnLyw0Dgjd3OdDN99m/+K vy58uuoRNdYpQwQVRVZKGEucVYaWH9bNKIIwmDvT3NoxEAqrQoG+wRjWa9uASJjQd6NRQRnPtf 2MYl4odTjUshgz4DidHRulBr IronPort-SDR: 4b6YO3UXNRUxpvvnxQGgMNqQaBHE/hb+43abs8WjXehAAvpL1fYfe9iqBGF7A+ZtQGf+9SK2xU 2y9iylsqLvexEI3TzK0XWdc24RJZIEOzt4WwSgJBpjg4DfeEapXoF8yAzZ2B68D5eDmAmNzDz1 vkaK24qBCPPcpxTvofsy9IDOHZRs7e7b13YPr7Yz+Wq2+phZDeTdMoF7JMJbI3cRLWQEod7RQU 2tf/vCR5kYX1CPaWzDiIUxTxjiEc+5Un62o4vm6S/fmcp0XsHwZRqWnbNARB3IWFGu8qLLYvYj 1PA= WDCIronportException: Internal From: Alistair Francis To: qemu-devel@nongnu.org, qemu-riscv@nongnu.org Subject: [PATCH v1 02/36] target/riscv: Don't set write permissions on dirty PTEs Date: Mon, 9 Dec 2019 10:10:45 -0800 Message-Id: <6a38e1a02e9a3d38fc311809772a152f0d99fd7a.1575914822.git.alistair.francis@wdc.com> X-Mailer: git-send-email 2.24.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x [fuzzy] X-Received-From: 216.71.153.141 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alistair.francis@wdc.com, palmer@dabbelt.com, alistair23@gmail.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Setting write permission on dirty PTEs results in userspace inside a Hypervisor guest (VU) becoming corrupted. This appears to be because it ends up with write permission in the second stage translation in cases where we aren't doing a store. Signed-off-by: Alistair Francis Reviewed-by: Bin Meng --- target/riscv/cpu_helper.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/target/riscv/cpu_helper.c b/target/riscv/cpu_helper.c index 767c8762ac..0de3a468eb 100644 --- a/target/riscv/cpu_helper.c +++ b/target/riscv/cpu_helper.c @@ -344,10 +344,8 @@ restart: if ((pte & PTE_X)) { *prot |=3D PAGE_EXEC; } - /* add write permission on stores or if the page is already di= rty, - so that we TLB miss on later writes to update the dirty bit= */ - if ((pte & PTE_W) && - (access_type =3D=3D MMU_DATA_STORE || (pte & PTE_D))) { + /* add write permission on stores */ + if ((pte & PTE_W) && (access_type =3D=3D MMU_DATA_STORE)) { *prot |=3D PAGE_WRITE; } return TRANSLATE_SUCCESS; --=20 2.24.0