From nobody Tue Apr 7 09:06:15 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1773579033; cv=none; d=zohomail.com; s=zohoarc; b=F7LhewtCxMG7sMMUKmauYnVo5IRiwrF+MPHecwM+PkY9raOZbQeKbOY8xmqAPiz1QUFKwjyvgR7zZo4b3PN1Uu0/IvauqB1cvAlBRRmQhnqj1EHfH2xIBb2u29m2dXzYyCRWaRS/djd3dnXHk27WT92UWeiL9G3L2GENiaS7eSg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773579033; h=Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=xLi4fHtc94ZOaV2+k4cXgPZo2Q77amdrgeIWUHhmgh4=; b=WAvFePpaMZjpk1vc+SviMk76F3eiOLpAiNqJE63FXoDpE4bimgpzQkIqkuwrdlkfsgPRD4ykKN3vCZgmp5XcMLcmMp5yNt3ndodQ0nLPA8V/ApFlMrojM+8i+ItoJFKmI6P5zSYnBgZsmlwH3JmJ6D2HaMAwg6ydWYLnVAs44Ww= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773579033282789.4861468663056; Sun, 15 Mar 2026 05:50:33 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w1kuj-0002qT-VG; Sun, 15 Mar 2026 08:49:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w1hN7-0008Q1-47 for qemu-devel@nongnu.org; Sun, 15 Mar 2026 05:02:53 -0400 Received: from mail-pf1-x434.google.com ([2607:f8b0:4864:20::434]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1w1hN5-0006Si-FI for qemu-devel@nongnu.org; Sun, 15 Mar 2026 05:02:52 -0400 Received: by mail-pf1-x434.google.com with SMTP id d2e1a72fcca58-823c56765fdso1987433b3a.1 for ; Sun, 15 Mar 2026 02:02:50 -0700 (PDT) Received: from Obsi.localdomain ([49.43.240.32]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82a0725bfd0sm12594101b3a.14.2026.03.15.02.02.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Mar 2026 02:02:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773565369; x=1774170169; darn=nongnu.org; h=cc:to:subject:date:from:message-id:from:to:cc:subject:date :message-id:reply-to; bh=xLi4fHtc94ZOaV2+k4cXgPZo2Q77amdrgeIWUHhmgh4=; b=K2oz8BZHde+7gDR9CN+HvSca7rLpRqT0m4cpxoCDuBtQV/8PFMQQ4V+mwz362wEXb5 Cmuf8grOLI2jNxpPM6YDzo/KSYwXNHyNUeHqp3l2D0zxURs65HF9HicT/2Qdf0uD/xvr PVgZk33/SZjp6yndGyxHanpjyx6zx9GL6JzQzHQ2D4+bsjuY515J+l71Nm9/xtQOV2XK Jhj5VIUvVK4WlKVxc3dvIJsZ5+ksVnEXpN+He7WHj8ozPdAJ5lJ2oMYWeO+90BzgtTco vYXUVhe1m1IPHShZz2bZ7YelTri/oisyJeQUlF/e2JWzNZROm7YgIAjw8+6k1Ub3HMID POAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773565369; x=1774170169; h=cc:to:subject:date:from:message-id:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=xLi4fHtc94ZOaV2+k4cXgPZo2Q77amdrgeIWUHhmgh4=; b=aJilIa7auRoKs48C0a+aV3CFlSdPFSaYXBEc5aX1OmaootHcDBR37f5o23t6ww+zG7 qD7uPgNJHjtdisUXOLzGKOrLAvNhModyf0QNd+lLP+rDpWZ409A1+Q/zjy9GVUUe0EAk tyRiweHL62u+7/qgLgSjfA5E2jLSqd5s917/UvYLo9OcK3e0CfuzBmMek5e071RtDpR2 LlI7fKnurz2diWxH6I66IiIIHkOEvKidfACTFjVP6r06BuYjH+mbEp/T/BRt4YYwhp4/ XaH6flBvZR8HGgnfWiAGib7Kth3sOvaCPr1FYhPuVVfuWLA3P8KZOsoawPm25S5PrOPp jbgg== X-Gm-Message-State: AOJu0Yx78H7bskIhwz/SWfroNLsIYawht4FMX9W7NeMZz58HmJtECUUg 4/MdId6sVfR6DYgSDu8/5gKpTrmQhn511QZHvWG8WRDSGf92rljtvbwn X-Gm-Gg: ATEYQzzZ7ZD7WAjpB6Urbmq1f+rQRBUilg9TK2L5Q9yCLHKeU6ZvNtovNINinig8Wl5 1FIvFhQdRgNFc0oKPQbPl2+4seGT7mj+aCSjbFfmZsptv8FreR0lT616IyevlYv2a2uspGxBrZi 8rVWyhytQvOwCvXpxX9n71yG9tj8bVvnjOCYrSoisQV082Wf46Ie7NLv9DA+f5xIjhQX+Z6X8iD mY9KxLANDmh6gigN3M7prSJDVO+/ll8yBcKol2IdZAzPRLrfYpBBHKZnweIq2mzPaja88Q5sDwy rvUf5ZOJwg+zPozvZqxIXOQ0GHgwH329Q9aNaAJU3pC5uEP3Xlsuox1FridWQJY55HjD0RoA6vR kP73k09y2XQqjJNhWdVKxpM92pH/acuikhPC9abvMHtbQ5/AbinOrjlUP4+YmviFiKvW9YOZC6H WE1MAKJqntp0sAoTqwrSPbLGdZRQc1zGZfg68sGgqYARmhe8kwi6ehC1wuCL6HVowoqEYjlEovm CLsVqdBz/fWdO9RpNO0rEPhsw== X-Received: by 2002:a05:6a00:3c92:b0:82a:13ef:5abf with SMTP id d2e1a72fcca58-82a1993a1f2mr8807276b3a.57.1773565369359; Sun, 15 Mar 2026 02:02:49 -0700 (PDT) Message-ID: <69b675b8.050a0220.3c467f.19ff@mx.google.com> From: Aadhya-R X-Google-Original-From: Aadhya-R Date: Sat, 14 Mar 2026 08:22:51 +0000 Subject: [PATCH v3] hw/audio/fmopl: Convert malloc/free to g_malloc/g_free To: kraxel@redhat.com Cc: qemu-devel@nongnu.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::434; envelope-from=raghavendraaadhya@gmail.com; helo=mail-pf1-x434.google.com X-Spam_score_int: -7 X-Spam_score: -0.8 X-Spam_bar: / X-Spam_report: (-0.8 / 5.0 requ) BAYES_00=-1.9, DATE_IN_PAST_24_48=1.34, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Sun, 15 Mar 2026 08:49:47 -0400 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1773579036092154100 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" As per the QEMU coding style guide, replace standard C malloc() and free() with GLib's g_malloc() and g_free(). Since g_malloc() safely aborts on out-of-memory errors, the redundant NULL checks and their associated error-handling paths have been removed. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1798 Signed-off-by: Aadhya-R --- hw/audio/fmopl.c | 41 ++++++++++++----------------------------- 1 file changed, 12 insertions(+), 29 deletions(-) diff --git a/hw/audio/fmopl.c b/hw/audio/fmopl.c index a63ad0f04d..79e43d5410 100644 --- a/hw/audio/fmopl.c +++ b/hw/audio/fmopl.c @@ -50,7 +50,6 @@ static int opl_dbg_maxchip,opl_dbg_chip; /* attack/decay rate time rate */ #define OPL_ARRATE 141280 /* RATE 4 =3D 2826.24ms @ 3.6MHz */ #define OPL_DRRATE 1956000 /* RATE 4 =3D 39280.64ms @ 3.6MHz */ - #define DELTAT_MIXING_LEVEL (1) /* DELTA-T ADPCM MIXING LEVEL */ =20 #define FREQ_BITS 24 /* frequency turn */ @@ -607,26 +606,10 @@ static int OPLOpenTable( void ) double pom; =20 /* allocate dynamic tables */ - if( (TL_TABLE =3D malloc(TL_MAX*2*sizeof(int32_t))) =3D=3D NULL) - return 0; - if( (SIN_TABLE =3D malloc(SIN_ENT*4 *sizeof(int32_t *))) =3D=3D NULL) - { - free(TL_TABLE); - return 0; - } - if( (AMS_TABLE =3D malloc(AMS_ENT*2 *sizeof(int32_t))) =3D=3D NULL) - { - free(TL_TABLE); - free(SIN_TABLE); - return 0; - } - if( (VIB_TABLE =3D malloc(VIB_ENT*2 *sizeof(int32_t))) =3D=3D NULL) - { - free(TL_TABLE); - free(SIN_TABLE); - free(AMS_TABLE); - return 0; - } + TL_TABLE =3D g_malloc(TL_MAX * 2 * sizeof(int32_t)); + SIN_TABLE =3D g_malloc(SIN_ENT * 4 * sizeof(int32_t *)); + AMS_TABLE =3D g_malloc(AMS_ENT * 2 * sizeof(int32_t)); + VIB_TABLE =3D g_malloc(VIB_ENT * 2 * sizeof(int32_t)); ENV_CURVE =3D g_new(int32_t, 2 * EG_ENT + 1); /* make total level table */ for (t =3D 0;t < EG_ENT-1 ;t++){ @@ -696,10 +679,10 @@ static int OPLOpenTable( void ) static void OPLCloseTable( void ) { g_free(ENV_CURVE); - free(TL_TABLE); - free(SIN_TABLE); - free(AMS_TABLE); - free(VIB_TABLE); + g_free(TL_TABLE); + g_free(SIN_TABLE); + g_free(AMS_TABLE); + g_free(VIB_TABLE); } =20 /* CSM Key Control */ @@ -1082,9 +1065,9 @@ FM_OPL *OPLCreate(int clock, int rate) state_size =3D sizeof(FM_OPL); state_size +=3D sizeof(OPL_CH)*max_ch; /* allocate memory block */ - ptr =3D malloc(state_size); - if(ptr=3D=3DNULL) return NULL; - /* clear */ + ptr =3D g_malloc(state_size); + + /* clear */ memset(ptr,0,state_size); OPL =3D (FM_OPL *)ptr; ptr+=3Dsizeof(FM_OPL); OPL->P_CH =3D (OPL_CH *)ptr; ptr+=3Dsizeof(OPL_CH)*max_ch; @@ -1128,7 +1111,7 @@ void OPLDestroy(FM_OPL *OPL) } #endif OPL_UnLockTable(); - free(OPL); + g_free(OPL); } =20 /* ---------- Option handlers ---------- */ --=20 2.43.0