From nobody Fri Dec 19 20:59:57 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=eik.bme.hu Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1635527539484134.37117274997058; Fri, 29 Oct 2021 10:12:19 -0700 (PDT) Received: from localhost ([::1]:34338 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mgVQQ-0000Tk-Do for importer@patchew.org; Fri, 29 Oct 2021 13:12:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49228) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mgUvr-0007C3-DM for qemu-devel@nongnu.org; Fri, 29 Oct 2021 12:40:43 -0400 Received: from zero.eik.bme.hu ([152.66.115.2]:51113) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mgUvo-00066g-GY for qemu-devel@nongnu.org; Fri, 29 Oct 2021 12:40:43 -0400 Received: from zero.eik.bme.hu (blah.eik.bme.hu [152.66.115.182]) by localhost (Postfix) with SMTP id 617827561EB; Fri, 29 Oct 2021 18:40:27 +0200 (CEST) Received: by zero.eik.bme.hu (Postfix, from userid 432) id A8BD17561A5; Fri, 29 Oct 2021 18:40:26 +0200 (CEST) Message-Id: <695476af8e88f12287645f4b1df38bc80fe38603.1635524617.git.balaton@eik.bme.hu> In-Reply-To: References: From: BALATON Zoltan Subject: [PATCH v5 15/25] hw/intc/sh_intc: Remove excessive parenthesis Date: Fri, 29 Oct 2021 18:23:36 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable To: qemu-devel@nongnu.org X-Spam-Probability: 8% Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=152.66.115.2; envelope-from=balaton@eik.bme.hu; helo=zero.eik.bme.hu X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Richard Henderson , Magnus Damm , Yoshinori Sato Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZM-MESSAGEID: 1635527540465100001 Drop unneded parenthesis and split up one complex expression to write it with less brackets so it's easier to follow. Signed-off-by: BALATON Zoltan Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/intc/sh_intc.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/hw/intc/sh_intc.c b/hw/intc/sh_intc.c index 54803bc2ca..537fc503d4 100644 --- a/hw/intc/sh_intc.c +++ b/hw/intc/sh_intc.c @@ -23,7 +23,7 @@ void sh_intc_toggle_source(struct intc_source *source, int pending_changed =3D 0; int old_pending; =20 - if ((source->enable_count =3D=3D source->enable_max) && (enable_adj = =3D=3D -1)) { + if (source->enable_count =3D=3D source->enable_max && enable_adj =3D= =3D -1) { enable_changed =3D -1; } source->enable_count +=3D enable_adj; @@ -68,7 +68,7 @@ void sh_intc_toggle_source(struct intc_source *source, static void sh_intc_set_irq(void *opaque, int n, int level) { struct intc_desc *desc =3D opaque; - struct intc_source *source =3D &(desc->sources[n]); + struct intc_source *source =3D &desc->sources[n]; =20 if (level && !source->asserted) { sh_intc_toggle_source(source, 0, 1); @@ -164,7 +164,7 @@ static void sh_intc_locate(struct intc_desc *desc, *modep =3D mode | INTC_MODE_IS_PRIO; *datap =3D &pr->value; *enums =3D pr->enum_ids; - *first =3D (pr->reg_width / pr->field_width) - 1; + *first =3D pr->reg_width / pr->field_width - 1; *width =3D pr->field_width; return; } @@ -245,7 +245,8 @@ static void sh_intc_write(void *opaque, hwaddr offset, } =20 for (k =3D 0; k <=3D first; k++) { - mask =3D ((1 << width) - 1) << ((first - k) * width); + mask =3D (1 << width) - 1; + mask <<=3D (first - k) * width; =20 if ((*valuep & mask) =3D=3D (value & mask)) { continue; --=20 2.21.4