From nobody Fri Nov 14 17:03:00 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1588701577; cv=none; d=zohomail.com; s=zohoarc; b=NJYhFsMfXzugJw6fww71LA7V0j0EQK7siy7Gu26OuDlxXB3yu4yl1s6hBt8TukvtM2vjuWkwPeviaPjs1eWGMvvAOrK5+YWT4x/M/JL6IuK9vX99DTBtpScSzk47dGmKQKChn0HujKvxQSTTSM7Jn8TftslbNYJ/xxu7KL3AQO0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1588701577; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=N/MW54lIt4epyPdq77tlopwi36sv0CYbrnTThMU6lNA=; b=MSfi5sshmlebclqSYh7wJvOoUoqCJCxV+owF1vmFXSp/voOACAOJn+1wppT26vNF7azKeMbRJXRMaJwZI0fGCnPLBDVNmuAk47O4SnkjfhtSzmN9/9donZCOzWZRT7CtHfhxiVpMjQrNQAkdBzCmWKadk1O8qWE9Aad4YSJRHyo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1588701577604908.2913805034907; Tue, 5 May 2020 10:59:37 -0700 (PDT) Received: from localhost ([::1]:50800 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jW1qy-0003xV-9a for importer@patchew.org; Tue, 05 May 2020 13:59:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44156) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jW1Xq-00074U-7l; Tue, 05 May 2020 13:39:50 -0400 Received: from fanzine.igalia.com ([178.60.130.6]:39069) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jW1Xd-0008Qz-Qq; Tue, 05 May 2020 13:39:49 -0400 Received: from static.160.43.0.81.ibercom.com ([81.0.43.160] helo=perseus.local) by fanzine.igalia.com with esmtpsa (Cipher TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim) id 1jW1Ws-00025Y-FR; Tue, 05 May 2020 19:38:50 +0200 Received: from berto by perseus.local with local (Exim 4.92) (envelope-from ) id 1jW1Wd-00044g-8B; Tue, 05 May 2020 19:38:35 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=N/MW54lIt4epyPdq77tlopwi36sv0CYbrnTThMU6lNA=; b=K7bnncuXJeAEXc2lKDLZ5DMieTvD2sEGOKEsoZoLJYh3qIKmoddRrEJl+XAkEQKIbJz7J8HHAtF5Sh3mN9gvbvofHdj2OFBCKnBX6kWZDE2o8Fj4Z9Ozl5FjEUnEgmTGF+/KRzRUZtbyU7g3h1lowt0zTar8jwY08kd7SItqZk2N8qZtf7AR2fbbFiJ1bT8hp7X0PDPZJpsdGG7EssvSPum9xlDwr1xC3JRKEcxT4/nOY2ukQ3QTMNzkqA0LB5S+zcygK1/QJ+LfHNF/RQSu/25D6lNlshwR0f1ykwWtFoNWgNho4jfbf9ZiDV/aEovn6662WqJL1yT1jIQlrlr8Nw==; From: Alberto Garcia To: qemu-devel@nongnu.org Subject: [PATCH v5 25/31] qcow2: Clear the L2 bitmap when allocating a compressed cluster Date: Tue, 5 May 2020 19:38:25 +0200 Message-Id: <688072bba0f7687063c8c7f7aaf5c958736cf255.1588699789.git.berto@igalia.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=178.60.130.6; envelope-from=berto@igalia.com; helo=fanzine.igalia.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/05 13:38:50 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x (no timestamps) [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Vladimir Sementsov-Ogievskiy , Alberto Garcia , qemu-block@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Compressed clusters always have the bitmap part of the extended L2 entry set to 0. Signed-off-by: Alberto Garcia Reviewed-by: Max Reitz --- block/qcow2-cluster.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c index 4544a40aa0..0a295076a3 100644 --- a/block/qcow2-cluster.c +++ b/block/qcow2-cluster.c @@ -800,6 +800,9 @@ int qcow2_alloc_compressed_cluster_offset(BlockDriverSt= ate *bs, BLKDBG_EVENT(bs->file, BLKDBG_L2_UPDATE_COMPRESSED); qcow2_cache_entry_mark_dirty(s->l2_table_cache, l2_slice); set_l2_entry(s, l2_slice, l2_index, cluster_offset); + if (has_subclusters(s)) { + set_l2_bitmap(s, l2_slice, l2_index, 0); + } qcow2_cache_put(s->l2_table_cache, (void **) &l2_slice); =20 *host_offset =3D cluster_offset & s->cluster_offset_mask; --=20 2.20.1