From nobody Mon Feb 9 17:40:40 2026 Delivered-To: importer@patchew.org Received-SPF: temperror (zoho.com: Error in retrieving data from DNS) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=temperror (zoho.com: Error in retrieving data from DNS) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1540491253539481.883523093103; Thu, 25 Oct 2018 11:14:13 -0700 (PDT) Received: from localhost ([::1]:56346 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gFk8s-0001dW-Rf for importer@patchew.org; Thu, 25 Oct 2018 14:13:58 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43684) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gFjT3-0006QY-9i for qemu-devel@nongnu.org; Thu, 25 Oct 2018 13:30:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gFjSz-0006Na-TE for qemu-devel@nongnu.org; Thu, 25 Oct 2018 13:30:45 -0400 Received: from pio-pvt-msa1.bahnhof.se ([79.136.2.40]:35993) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gFjSx-0006Ip-SZ for qemu-devel@nongnu.org; Thu, 25 Oct 2018 13:30:41 -0400 Received: from localhost (localhost [127.0.0.1]) by pio-pvt-msa1.bahnhof.se (Postfix) with ESMTP id B544E3F499; Thu, 25 Oct 2018 19:30:18 +0200 (CEST) Received: from pio-pvt-msa1.bahnhof.se ([127.0.0.1]) by localhost (pio-pvt-msa1.bahnhof.se [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XkY0ZoYXh_ky; Thu, 25 Oct 2018 19:30:12 +0200 (CEST) Received: from localhost (h-41-252.A163.priv.bahnhof.se [46.59.41.252]) (Authenticated sender: mb547485) by pio-pvt-msa1.bahnhof.se (Postfix) with ESMTPA id 2D53D3F421; Thu, 25 Oct 2018 19:30:11 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at bahnhof.se Date: Thu, 25 Oct 2018 19:30:11 +0200 From: Fredrik Noring To: Aleksandar Markovic , Aurelien Jarno , "Maciej W. Rozycki" , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Message-ID: <658cb95479c9b6debebe43ec06ff498ebf624653.1540487815.git.noring@nocrew.org> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 79.136.2.40 Subject: [Qemu-devel] [PATCH 01/11] target/mips: Rename ASE_MMI to ASE_TOSHIBA_MMI, with Toshiba namespace X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?Q?J=C3=BCrgen?= Urban , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Several vendors have multimedia instruction (MMI) sets and other extensions of various kinds. ASE vendor namespaces make it clear these are not generic architectural features and also avoid name clashes. Reported-by: Maciej W. Rozycki Signed-off-by: Fredrik Noring --- target/mips/mips-defs.h | 2 +- target/mips/translate.c | 3 ++- target/mips/translate_init.inc.c | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/target/mips/mips-defs.h b/target/mips/mips-defs.h index 5177618615..30b07e0bde 100644 --- a/target/mips/mips-defs.h +++ b/target/mips/mips-defs.h @@ -68,7 +68,7 @@ /* * bits 56-63: vendor-specific ASEs */ -#define ASE_MMI 0x0100000000000000ULL +#define ASE_TOSHIBA_MMI 0x0100000000000000ULL =20 /* MIPS CPU defines. */ #define CPU_MIPS1 (ISA_MIPS1) diff --git a/target/mips/translate.c b/target/mips/translate.c index c44a751be9..8547a6e6f6 100644 --- a/target/mips/translate.c +++ b/target/mips/translate.c @@ -26092,7 +26092,8 @@ static void decode_opc(CPUMIPSState *env, DisasCont= ext *ctx) decode_opc_special(env, ctx); break; case OPC_SPECIAL2: - if ((ctx->insn_flags & INSN_R5900) && (ctx->insn_flags & ASE_MMI))= { + if ((ctx->insn_flags & INSN_R5900) && + (ctx->insn_flags & ASE_TOSHIBA_MMI)) { decode_tx79_mmi(env, ctx); } else { decode_opc_special2_legacy(env, ctx); diff --git a/target/mips/translate_init.inc.c b/target/mips/translate_init.= inc.c index 85da4a269c..5cd968366b 100644 --- a/target/mips/translate_init.inc.c +++ b/target/mips/translate_init.inc.c @@ -466,7 +466,7 @@ const mips_def_t mips_defs[] =3D #endif /* !CONFIG_USER_ONLY */ .SEGBITS =3D 32, .PABITS =3D 32, - .insn_flags =3D CPU_R5900 | ASE_MMI, + .insn_flags =3D CPU_R5900 | ASE_TOSHIBA_MMI, .mmu_type =3D MMU_TYPE_R4000, }, { --=20 2.18.1