From nobody Mon Feb 9 10:53:39 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1579475641; cv=none; d=zohomail.com; s=zohoarc; b=kl0HVSlADwF+sT4Zl+Lqxy8cH7bVMlK5WQFhe9ZzOhqLqwmvKqg2F7xWzKofnly2QgQ4d0iSY20u6xyQUiToh1xMztLcI+T6uXZzymWWDJAoVkyIbLwZJI8GIy+yhoqpq5frOqiU+JGfGxybrzpuB2dwUySI59v02u7Utp4YXSM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1579475641; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=IALhyYGbPrqp6p0VmmthUVoqcHNIkV62h4kul31BlU0=; b=R1Bx50/JivftlUKQWy2UG76ausRQ4mmJc2oCzpCCrPYdO7VSJbrCuBmVd96+t1Xu9Q0FXwaHo4ODGMJbvH4pYGmdKxGVycMcJTFeq+EQEeNTA0DfB4Puv0j+FpQEXU8sEV14GyycKPdfqmBNZBgPivt17JCDif4HWiX2r3Ayl1Q= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1579475641475521.3408262466429; Sun, 19 Jan 2020 15:14:01 -0800 (PST) Received: from localhost ([::1]:54888 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1itJlY-00047C-9j for importer@patchew.org; Sun, 19 Jan 2020 18:14:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:55890) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1itJfi-00049V-7v for qemu-devel@nongnu.org; Sun, 19 Jan 2020 18:07:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1itJfg-0003lQ-Vg for qemu-devel@nongnu.org; Sun, 19 Jan 2020 18:07:58 -0500 Received: from kvm5.telegraphics.com.au ([98.124.60.144]:54734) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1itJfg-0003lA-Rh; Sun, 19 Jan 2020 18:07:56 -0500 Received: by kvm5.telegraphics.com.au (Postfix, from userid 502) id 36E7D2996F; Sun, 19 Jan 2020 18:07:55 -0500 (EST) To: Jason Wang , qemu-devel@nongnu.org Message-Id: <620ed4e86dd176b7382d9b115350a135d00687b5.1579474761.git.fthain@telegraphics.com.au> In-Reply-To: References: From: Finn Thain Subject: [PATCH v3 06/14] dp8393x: Clear RRRA command register bit only when appropriate MIME-Version: 1.0 Date: Mon, 20 Jan 2020 09:59:21 +1100 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 98.124.60.144 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Aleksandar Rikalo , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Laurent Vivier , qemu-stable@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" It doesn't make sense to clear the command register bit unless the command was actually issued. Signed-off-by: Finn Thain Reviewed-by: Philippe Mathieu-Daud=C3=A9 Tested-by: Laurent Vivier --- hw/net/dp8393x.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/hw/net/dp8393x.c b/hw/net/dp8393x.c index 249be403af..2e976781e2 100644 --- a/hw/net/dp8393x.c +++ b/hw/net/dp8393x.c @@ -352,9 +352,6 @@ static void dp8393x_do_read_rra(dp8393xState *s) s->regs[SONIC_ISR] |=3D SONIC_ISR_RBE; dp8393x_update_irq(s); } - - /* Done */ - s->regs[SONIC_CR] &=3D ~SONIC_CR_RRRA; } =20 static void dp8393x_do_software_reset(dp8393xState *s) @@ -563,8 +560,10 @@ static void dp8393x_do_command(dp8393xState *s, uint16= _t command) dp8393x_do_start_timer(s); if (command & SONIC_CR_RST) dp8393x_do_software_reset(s); - if (command & SONIC_CR_RRRA) + if (command & SONIC_CR_RRRA) { dp8393x_do_read_rra(s); + s->regs[SONIC_CR] &=3D ~SONIC_CR_RRRA; + } if (command & SONIC_CR_LCAM) dp8393x_do_load_cam(s); } --=20 2.24.1