From nobody Mon Feb 9 20:59:18 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@gnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 15067316327961017.6600456269356; Fri, 29 Sep 2017 17:33:52 -0700 (PDT) Received: from localhost ([::1]:37546 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dy5ir-0007RD-Pj for importer@patchew.org; Fri, 29 Sep 2017 20:33:37 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60299) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dy5Vg-0004LT-D3 for qemu-devel@nongnu.org; Fri, 29 Sep 2017 20:20:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dy5Vd-0005Ol-8d for qemu-devel@nongnu.org; Fri, 29 Sep 2017 20:20:00 -0400 Received: from mail-by2nam03on0079.outbound.protection.outlook.com ([104.47.42.79]:6855 helo=NAM03-BY2-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dy5Vc-0005Kc-UH for qemu-devel@nongnu.org; Fri, 29 Sep 2017 20:19:57 -0400 Received: from MWHPR02CA0056.namprd02.prod.outlook.com (10.164.133.45) by BLUPR0201MB1924.namprd02.prod.outlook.com (10.162.239.158) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Sat, 30 Sep 2017 00:19:54 +0000 Received: from BL2NAM02FT052.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e46::207) by MWHPR02CA0056.outlook.office365.com (2603:10b6:301:60::45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.56.11 via Frontend Transport; Sat, 30 Sep 2017 00:19:47 +0000 Received: from xsj-pvapsmtpgw01 (149.199.60.83) by BL2NAM02FT052.mail.protection.outlook.com (10.152.77.0) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.56.11 via Frontend Transport; Sat, 30 Sep 2017 00:19:46 +0000 Received: from unknown-38-66.xilinx.com ([149.199.38.66] helo=xsj-pvapsmtp01) by xsj-pvapsmtpgw01 with esmtp (Exim 4.63) (envelope-from ) id 1dy5VS-00082n-87; Fri, 29 Sep 2017 17:19:46 -0700 Received: from [127.0.0.1] (helo=localhost) by xsj-pvapsmtp01 with smtp (Exim 4.63) (envelope-from ) id 1dy5VS-00079M-3Y; Fri, 29 Sep 2017 17:19:46 -0700 Received: from xsj-pvapsmtp01 (mailhost.xilinx.com [149.199.38.66]) by xsj-smtp-dlp2.xlnx.xilinx.com (8.13.8/8.13.1) with ESMTP id v8U0JjKA000669; Fri, 29 Sep 2017 17:19:45 -0700 Received: from [172.19.2.220] (helo=localhost.localdomain) by xsj-pvapsmtp01 with esmtp (Exim 4.63) (envelope-from ) id 1dy5VQ-00079B-TM; Fri, 29 Sep 2017 17:19:44 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector1-xilinx-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=pqvHT/bA7tOW7E+CvkT01aZ9SjM6myD0Iq4JNfJkDLQ=; b=GFnitza1C/ndcfkc6S/ESn1yiLkYlyys5bifPqn7xXpmsv9sbuOrxz9Nt+YAcRui0UvgUJLUwsxIeWUfhmEakSCXbr5M5osjH+Dnr3m9GQ/RnfSE4ZcHl7hsDn+cPMS8Op2J/x08ua+w4YPVdUjq2Y0ndd5wI3rcpSj0a/Wp368= Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=xilinx.com; redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=bestguesspass action=none header.from=xilinx.com; Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@gnu.org; helo=lists.gnu.org; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.60.83 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.60.83; helo=xsj-pvapsmtpgw01; From: Alistair Francis To: Date: Fri, 29 Sep 2017 17:15:57 -0700 Message-ID: <5ff4b0fa8802bc338be8bb87274444d69f4eb2ba.1506730372.git.alistair.francis@xilinx.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: References: X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.1.0.1062-23358.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.83; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(39860400002)(376002)(346002)(2980300002)(438002)(199003)(189002)(81166006)(50226002)(316002)(77096006)(356003)(33646002)(36386004)(36756003)(81156014)(8676002)(16586007)(478600001)(47776003)(189998001)(106002)(5003940100001)(9786002)(54906003)(118296001)(50986999)(6666003)(2906002)(76176999)(305945005)(39060400002)(4326008)(106466001)(50466002)(2351001)(2950100002)(5660300001)(48376002)(63266004)(8936002)(6916009)(107986001); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0201MB1924; H:xsj-pvapsmtpgw01; FPR:; SPF:Pass; PTR:unknown-60-83.xilinx.com; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2NAM02FT052; 1:F0yHtaXvRAIaiPPEWhR1jmhCuA7e3z/WBLvPCR+7WBoPr/Jq2hCyFOfrxpocJwyNTsP4XVF0SrctPcwTqweQxOncO/XFChIdMH49/WsJy4NDlad5/Pv6WYLnO+d1aH7V MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2f411787-6af0-49a4-02b2-08d50798f511 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254152)(8251501002)(2017052603199)(201703131423075)(201703031133081)(201702281549075); SRVR:BLUPR0201MB1924; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0201MB1924; 3:0GNK9+mfSyNbtta5uKa3J3aBSC3yce1ZMt25yaTYLlixHt81ty9DezG7bo+/sNrv1nOZgouvUS48JV/moIhqG+2wYpi/8aVd1Zx9wOavZ4qvcSsK+AWgvvfG/02Jt3bp7SKehNlDHrbzuywZivWIAg2XMaFFLNEdbD0/ERoiIt6IMQliSoijDYeSNn54bDk3eNmCWab5a/vvnESgSt75IRHSy6oRgxN+nBuHYuSgcXOWkn9cSskPAUBxS4pdLh/bJlFTpXzd8TX3ZERirKwatpS/j86OyXKvY4EPINwMMCjlQ5ba5H+XYJAdR0eqU0ndWQR58Bpi9vePOxuJoWwDlvYxmJhcBCVJ3CHMwZGfW2g=; 25:lEAfubrvPUW/lMFk0HCWAQnhi6MEWVBtHOY08+QTbKyuudxbMFl38BKTOGed5/7whmU7ttCfAHIOBGWCRm0AnO1pFr5oHXm+3I3lJQcXMYDhtPSczPvGPSAeHFjabFxlsLfkNO7XX0zBc+gEtOvn77BU8XS0fypEaMPjBc3/fAHCduywy5DrMWSQD2aLvKTxf0CEuuDhmYVtmEe6BcQcmHpggq1iVUR3qZeuEjmzPksna4m3t/pxZ5US9oop7Ap5ozyIG6pQf5z8MSv3QwNJW4Xwh0Hoy2QYuq1Js22/88Zc/8KtJ/HzUhH+RHi05fnU8PPvCY0ogR3DOknynSOdBA== X-MS-TrafficTypeDiagnostic: BLUPR0201MB1924: X-Microsoft-Exchange-Diagnostics: 1; BLUPR0201MB1924; 31:rZI5scQ8TmtYwa87LBUhZCSv1fWZ+LAsaLKILFqytYbmd6KngD0vTG3majaDZCxrv9G0WoVr5cmbl+9l1pUVMX3wHVATmv1mVd8eUoe8bXNKZdTfiofnyhONFFpEY8yHLxVCo3J09Dg/Nj0OGpHX+vuNBZi9uFwiaHqaUd2sOQRL/lMNWloowNCdh9zV3OSSn8CYRBUCwZ0ZVrBbetUaXfsZJailZR7Xw+OklKWPG3U=; 20:kOMrOFXHCZBeVb9TlpEfrpE8K/Bex21+TmktUMjmNbW8+lbQ0UnzbcO+OX9P31Q9/5QjssnRBn8oN1tGnOER1xNS2P2QfFslbQjs0j8AvbZU/MYfY8A3CSrCO9I/ZtfIfSil+7cIMIXQ+ZkEAIXfrZapuR8RwOgqw0W/KTR4NaXeFSC/8lG8dHtYApdiy2t+FEndG3l0FRenRw6oJ+v7HbgPbYlAV4ingZ3Lgf5x16jGrNZfBis2WNvswIhfFOwG0+HoXX73rk2RFP5sU0ud+/iTQuQzhreB4H39c8VRHx+MTWSbHbR6fBtcuBCeJPwFR15UuoQvsBOkOedXx0dJPYJeZvkzNyAq+VVp0KWv4FbiCcsi5j9Vibyrll0olK14iPnS4rVizNDtkPPd7uHtP7Qtb0z966IpP6V6angSMk8hjKMfpIRnVQuEfBM5g1uswXcA19V7UQ6RInqh2c+I1vcUCxD30MW6GqWKSzsEjmykDkUVUnZ4wo1oPYqfA7/n X-Exchange-Antispam-Report-Test: UriScan:(788757137089)(192813158149592); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(3002001)(10201501046)(100000703101)(100105400095)(93006095)(93004095)(6055026)(6041248)(20161123558100)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123564025)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:BLUPR0201MB1924; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:BLUPR0201MB1924; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0201MB1924; 4:0cERpDgb7og9LQNv4/MmvC0aypzYxWfP831K6H9f9ZHtpOiO1DR50djUjqGv9AfuNrSGbtVWPopIpCjqBuodzD5Pr2AvnnmXhL41qbrqHcSxX/M6MB/BFnnaAQT5xM3gWd/b5IlQSVsLylhwoCmtJ2BHqF5oFLLbQcLFV8AYPSKgMawNGdWbxpHA3QP+uv4RYwBd5Nda7ppL71UTCQZH9WWk9Ku35HFumQjEaolftp71BPbV142e1B4Tw9ntwXCpU5PLIHorv0eG0bW1EKin3Uian+gSfxeTWrCYtHPByku/iN3Ka7U1D+lZR+0OxjtFZZCGsgxTIIz9hIncAV4SSg== X-Forefront-PRVS: 0446F0FCE1 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BLUPR0201MB1924; 23:TlOcrpAl40h76xINcQb4V718Pehy2sdKIiOODjo?= =?us-ascii?Q?FlOVVwhKKmtCBVHkrTZzdbhLx2WlFkwOplxL7UfaWgV7cDepdP+99Yhet39O?= =?us-ascii?Q?chJ67WTp69MnPCuAbv7eptlLy40cVKcqkQ37w9ZJyjx9pm3j3FwxfdHASSmw?= =?us-ascii?Q?lH81whA+xAhpKxxF7Ky4QMujx4VcltZYoisBE0zlzEjLb7VLh2kUYVWmI+em?= =?us-ascii?Q?9B49Yy04f4kfuPs49FH4YtRcb6Ew3AVTrVb+MiPZUeO5e0NkHBSyJVH0+2e3?= =?us-ascii?Q?QJNbd7Nj2wq9U5OPXIPehpMhaBivHuLU2AZS9gVJAYn8/aoKlYzxWuPw/Ltg?= =?us-ascii?Q?YDk91af7WrQiUWeg2VRQeNAOJVh7sdU4ZrNVgc+16eNfFSs3YITwoYtyekQP?= =?us-ascii?Q?goU5BhVhW8h+9wj4dBUNpiZBQ0pOxVrb3QZhNceFtmnbdGOyitmlsX0CMPv3?= =?us-ascii?Q?DS6QCDsh6RSGHLtmGF9zUTQG4vQ/PqUta9Lr/cTCjqV4lZJZDdEY3NMu23RM?= =?us-ascii?Q?21hA55Vi5JIEVshaliwcoqzPfTyVQu4eihB6CdSYCI1313ZJ4g4eQ4nWmi6z?= =?us-ascii?Q?eD7J9HsfGTEpnCrFvHVZbzw2cw39ai9st5OtsZPeLXMkDqUZ9I2LeZ7VSZ9j?= =?us-ascii?Q?CJGax8i7s9n39/dJzZTtUtU/cvwhFNUJB0RU6F1EWjxoPQnBHdNNFOtKoBOV?= =?us-ascii?Q?/BKdZAntCoP7vbS1EhIx6I3l+1gvT5v6HAwmXueenvP5PiO6HAJck1cZRfUG?= =?us-ascii?Q?wR2PWK4/e+sdWZVPymnzUhs1Y8VDWGjuain0rO3+G0X1YaA5tm2aWoCN5bjN?= =?us-ascii?Q?JoHz89jNDDAGJgETD5I6gKkJ1Ib8NKmCxppkxv57CqcT9uMdAxxh9pqUW0jX?= =?us-ascii?Q?aZllz7l5PZFtYZG8ENy4o3HZhtTQqQAvEALnFaTfgEFXN/2Df1QyiPgHFemb?= =?us-ascii?Q?YYhHt2DutNSKU/zYGOuUXpzvhmCURl+TvhamCxihm5GKxOvrw8r4kmy8b5As?= =?us-ascii?Q?N7SL6R+0HlibyKQmRG9Gt0jgjvkXi70RolQ+Mm4DRaS5b263528kWicLQi+l?= =?us-ascii?Q?cOxbSrNs=3D?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR0201MB1924; 6:o4EDogLnwO3zM9HNyhcN/pJugw4lrap5XcD2ykYzyDyoLzeRbVpS87axreQA9a9Xq1/jlbfCTz6oUd9RCq9DEaStRUXuv7wg6yRUW761RXWHMtcADu5708bLpmkUHiPsj/gVyjioqD3kSJycKYhEvNQQMiWuBeINQr79JS0FnzUr53yG5A7ZlPtvoIaXI1aUYoh1ebp8uvT7gKwevj7tcRCCLF8Z4cCFlvBMwoKuhX6DP/CMpw0eli2jH26ruki5JOG7Vv9jw3R0K6p6yOMvY7FWKGVnPKwqNESchK5fnWnm2ToYNlN2m5+inzbkaD+GUPt/gZMWAP+BPO6yeggZNg==; 5:Sz+KyQkfDT/SvrvGZly1aCAnGDtIl9TXveq8gtI/M0JNTulPryM44rZr4OgYPE/uaXsfviLkiNZoOpJ7X/B5r8hH938ISdeKvKU9nKSxxYUn8PZ99Zcy1xb0SwxusBuxHXPMF2nO6EYj48xKvw2KoazOnqgmS2wQunBcdUGQrKA=; 24:nsyjGHfZkVPT+GUhwwKfAxNGHSfoD4OmxwUYVYskzAd4pVAD8KsH3SlJoiHSRsQtAIF0zuYhCnemcDrZub7WJjFP8SUK5JuAnwuKrYccIso=; 7:Mg11GxHQgz6L0h3M1GG3harhdUaFwX9tYJWDKPi5+dXRJVEle+mOvZJGUXYqaRWL3IrPBORfgCPVmQhKDTfcrFKG3SiFVTigsSN2jWNJz9CwzBL37P5REMX4txSoxfnNQnr5slapsbLz3aL4NVTGmara6NXrCVKkZHMZ7HAsLEssEQ7XaMA7MBdgzgfFxKW4q3WFTQLmJ+hJpamJeccjzO8EfnG0KP8gOmUjG2ygO78= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2017 00:19:46.6999 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.60.83]; Helo=[xsj-pvapsmtpgw01] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0201MB1924 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 104.47.42.79 Subject: [Qemu-devel] [PATCH v2 19/47] hw/ipmi: Replace fprintf(stderr, "*\n" with error_report() X-BeenThere: qemu-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alistair23@gmail.com, armbru@redhat.com, alistair.francis@xilinx.com Errors-To: qemu-devel-bounces+importer=patchew.org@gnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_= report("\1"\2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_re= port("\1"\2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report= ("\1"\2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("= \1"\2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1= "\2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\= 2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2)= ;|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|= Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig= }' \ {} + find ./* -type f -exec sed -i \ 'N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}'= \ {} + find ./* -type f -exec sed -i \ 'N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \ {} + Some lines where then manually tweaked to pass checkpatch. Signed-off-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- V2: - Split hw patch into individual directories hw/ipmi/ipmi.c | 1 + hw/ipmi/ipmi_bmc_extern.c | 5 +++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/ipmi/ipmi.c b/hw/ipmi/ipmi.c index b27babd504..81c62920de 100644 --- a/hw/ipmi/ipmi.c +++ b/hw/ipmi/ipmi.c @@ -23,6 +23,7 @@ */ =20 #include "qemu/osdep.h" +#include "qemu/error-report.h" #include "hw/hw.h" #include "hw/ipmi/ipmi.h" #include "sysemu/sysemu.h" diff --git a/hw/ipmi/ipmi_bmc_extern.c b/hw/ipmi/ipmi_bmc_extern.c index abab3bba4f..8c0535d3dd 100644 --- a/hw/ipmi/ipmi_bmc_extern.c +++ b/hw/ipmi/ipmi_bmc_extern.c @@ -28,6 +28,7 @@ */ =20 #include "qemu/osdep.h" +#include "qemu/error-report.h" #include "qapi/error.h" #include "qemu/timer.h" #include "chardev/char-fe.h" @@ -194,8 +195,8 @@ static void ipmi_bmc_extern_handle_command(IPMIBmc *b, =20 if (ibe->outlen) { /* We already have a command queued. Shouldn't ever happen. */ - fprintf(stderr, "IPMI KCS: Got command when not finished with the" - " previous command\n"); + error_report("IPMI KCS: Got command when not finished with the" + " previous command"); abort(); } =20 --=20 2.11.0