From nobody Sat May 18 07:08:56 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1594563288; cv=none; d=zohomail.com; s=zohoarc; b=IGflJmDA6BkyBXJPYyJcQKgs4oqK/Yy1DF8YrAcIrwQjOJZFs7vdX2jMgJAFXx+NwJmtnqDbi81Do57hnACHohU6GSrSwg/LYodgDP6u08Wshet91VoWtjAcJyHcvriPFnmkSBxvSGsHAeD/xkHffiEU2XgYfK5pvh+1FVL/T7I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1594563288; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=+ffLDGOVfHqFo0Lsv8bvyZqZ5XPunBiBzv0m0/mgW6s=; b=fwTT4CZqYNF4SObCoNFw/6fg+TzWFQ38Atmx8Xohlgv4EOr3aPJ0EDo4rPdFeRuVVQLC8fuah1MLS8o9IVTzG8+KWwdknEqySeIJRJBSelkGpBG1OrWwGlAVBhiQEtf/oFA+cQWkv1xiaTOro6erah7nP7ydxVqR2JCsA5+N7go= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 15945632884751019.4432492136582; Sun, 12 Jul 2020 07:14:48 -0700 (PDT) Received: from localhost ([::1]:37540 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1juckg-0002nZ-Aw for importer@patchew.org; Sun, 12 Jul 2020 10:14:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55866) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1juaeU-00065d-Bt for qemu-devel@nongnu.org; Sun, 12 Jul 2020 08:00:15 -0400 Received: from vps.the-jedi.co.uk ([93.93.130.107]:33410) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1juaeS-0000k7-7Q for qemu-devel@nongnu.org; Sun, 12 Jul 2020 08:00:14 -0400 Received: by vps.the-jedi.co.uk (Postfix, from userid 111) id B1305429FD; Sun, 12 Jul 2020 13:00:09 +0100 (BST) Received: from [192.168.0.5] (host86-179-4-163.range86-179.btcentralplus.com [86.179.4.163]) by vps.the-jedi.co.uk (Postfix) with ESMTPSA id BA38D429F2; Sun, 12 Jul 2020 13:00:07 +0100 (BST) To: qemu-devel@nongnu.org From: Simon John Subject: [PATCH] Allow acpi-tmr size=2 Message-ID: <5f12377f-b640-c4c5-1bcd-858c622c6c31@the-jedi.co.uk> Date: Sun, 12 Jul 2020 13:00:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=93.93.130.107; envelope-from=github@the-jedi.co.uk; helo=vps.the-jedi.co.uk X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/12 08:00:09 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Sun, 12 Jul 2020 10:13:54 -0400 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: imammedo@redhat.com, mst@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8"; format="flowed" macos guests no longer boot after commit=20 5d971f9e672507210e77d020d89e0e89165c8fc9 acpi-tmr needs 2 byte memory accesses, so breaks as that commit only=20 allows 4 bytes. Fixes: 5d971f9e672507210e7 (memory: Revert "memory: accept mismatching=20 sizes in memory_region_access_valid") Buglink: https://bugs.launchpad.net/qemu/+bug/1886318 Signed-off-by: Simon John --- hw/acpi/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/acpi/core.c b/hw/acpi/core.c index f6d9ec4f13..05ff29b9d7 100644 --- a/hw/acpi/core.c +++ b/hw/acpi/core.c @@ -527,7 +527,7 @@ static void acpi_pm_tmr_write(void *opaque, hwaddr=20 addr, uint64_t val, static const MemoryRegionOps acpi_pm_tmr_ops =3D { .read =3D acpi_pm_tmr_read, .write =3D acpi_pm_tmr_write, - .valid.min_access_size =3D 4, + .valid.min_access_size =3D 1, .valid.max_access_size =3D 4, .endianness =3D DEVICE_LITTLE_ENDIAN, }; --=20 2.27.0