From nobody Tue Dec 16 07:41:28 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1650874985; cv=none; d=zohomail.com; s=zohoarc; b=Xp2DYGmbj++VwRUBTIwjIvqn5384znIBRat9QZTNeuavNgMnTAfVJKjgFHp58J923pvrs7U7Ae4A2BkTRNJFy8dq3TOIQREfl+GrScLnlviLyUrLvE7WeSSuQnIwBOBPIM6LvZCTXKixTI+NuitEUc1KPSksnM1oKmPUen48/c8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1650874985; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=s9HfXFFqm8XD3sd/B71lxNFxNbf5q88arJTDKzK7o3M=; b=j2QwqyE6YmtMqf5IN89ym7jOX/U75Sif6c/25J0Hf+46feGz848F287ZY24M7Qhl8rhcbsD2Yv64KeKHjWOOFVM6NPp2h5evAEDY2VxRJH90u7HpbxFqcNqtX0DeN74JK/U+f15KhCjfGDWdXiqdUe5lCxfZCQtDfzj1s7U/Tuw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 165087498562628.19531215991617; Mon, 25 Apr 2022 01:23:05 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-612-XwX8N38SNcqEmZug3lqFZA-1; Mon, 25 Apr 2022 04:22:26 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 22393805F63; Mon, 25 Apr 2022 08:22:18 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 047CF1468970; Mon, 25 Apr 2022 08:22:18 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id F29F4193F6E4; Mon, 25 Apr 2022 08:22:15 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id DBF631947BBE for ; Mon, 25 Apr 2022 08:22:10 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id CB4C840E80F7; Mon, 25 Apr 2022 08:22:10 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast09.extmail.prod.ext.rdu2.redhat.com [10.11.55.25]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C6DBD40E80E5 for ; Mon, 25 Apr 2022 08:22:10 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id AF970299E752 for ; Mon, 25 Apr 2022 08:22:10 +0000 (UTC) Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-448-7tH8xOmaNFGwjCq8sxn45Q-1; Mon, 25 Apr 2022 04:22:08 -0400 Received: by mail-wm1-f72.google.com with SMTP id p21-20020a1c5455000000b0038ff4f1014fso6449817wmi.7 for ; Mon, 25 Apr 2022 01:22:07 -0700 (PDT) Received: from wheatley.localdomain (nat-pool-brq-t.redhat.com. [213.175.37.10]) by smtp.gmail.com with ESMTPSA id d2-20020a056000186200b0020a7be3f1d2sm9949427wri.53.2022.04.25.01.22.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Apr 2022 01:22:05 -0700 (PDT) Received: from wheatley.redhat.com (wheatley.k8r.cz [127.0.0.1]) by wheatley.localdomain (Postfix) with ESMTP id 9C2A067B1B67; Mon, 25 Apr 2022 10:22:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1650874984; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=s9HfXFFqm8XD3sd/B71lxNFxNbf5q88arJTDKzK7o3M=; b=Tefdg8/btHbgAtBugxvZ8KQsu9bXfQJBvv6ZvOf2sVvLtV6Cq567UCyFzMet0OWnXxP2Ak er/53DcD+iDZRFTK23Sgkq7W4wdg9GKh633RyIzXCsFv6ofqb2nQuRLfU9yZ4qrrQVbhql Rh3xJpaeAyEPNg7MWJpMC7z8EtRnKXs= X-MC-Unique: XwX8N38SNcqEmZug3lqFZA-1 X-Original-To: libvir-list@listman.corp.redhat.com X-MC-Unique: 7tH8xOmaNFGwjCq8sxn45Q-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=s9HfXFFqm8XD3sd/B71lxNFxNbf5q88arJTDKzK7o3M=; b=yH38OfkDeRcAQbTDpGzwNoP/e7JuPm7/nZFPq9wFqLkw5yrWG1qWNpHj172FDrmqJE KbeupULBNAPr5M7sM3vocnBSjb9UZrx6rw9KTunfhVGePdtRb5GBbfo+WKTX7FtiGVWu o561x/Hd2MfDxQGCbx4qkPmKbg0dy5rpdatMAha6KwRn1l2VOVJ8TUUBnpzog7I0HdVn lesQfyGchI2SQiBS5CyaUXNYUOuf/AfJoWp2XtV2M/9p2QFkuy4WXgAtKNzlmraSzOVN 1aIWWzFRtIUFG2ws8bSCSfPWppHVWLEgcTF+CRkvW/vp05Kdzaz+g3/A7APFUs26uNAu hd9A== X-Gm-Message-State: AOAM530PGr0AUj6uhx964RDA2RSUcbWRXvQqoe0tnnVrhASCsBQObiqR Qh0ECGm013wHdnG0etYuvSVAqQ4VM+KAqTTLPVmj8IxXeoBL3ToJN+V5Q9yrbRS19G2PubYFU54 rKIbmZLFtU0r5bUKZXSE= X-Received: by 2002:a05:600c:500c:b0:392:b12f:40a with SMTP id n12-20020a05600c500c00b00392b12f040amr15318852wmr.122.1650874926859; Mon, 25 Apr 2022 01:22:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxLFvk5nzTaC2g1M8XY2wI8/zxlrWzXYrheN/6UUX0J7RkRiN+T145v3db5tf+iW6dHFnb7Eg== X-Received: by 2002:a05:600c:500c:b0:392:b12f:40a with SMTP id n12-20020a05600c500c00b00392b12f040amr15318821wmr.122.1650874926684; Mon, 25 Apr 2022 01:22:06 -0700 (PDT) From: Martin Kletzander To: qemu-devel@nongnu.org Subject: [PATCH 18/18] audio/spiceaudio: Fail initialisation when not using spice Date: Mon, 25 Apr 2022 10:22:01 +0200 Message-Id: <5db1fdef0330f20ed6ae306b5a71dad1b5e9b44c.1650874791.git.mkletzan@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Stefan Hajnoczi , libvir-list@redhat.com, Christian Schoenebeck , Yanan Wang , Gerd Hoffmann , "Edgar E. Iglesias" , Qiuhao Li , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Marcel Apfelbaum , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Laurent Vivier , Thomas Huth , Alistair Francis , Alexander Bulekov , Bandan Das , qemu-arm@nongnu.org, Jan Kiszka , Pavel Dovgalyuk , Eduardo Habkost , Darren Kenny , Thomas Huth , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-ppc@nongnu.org, Paolo Bonzini Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1650874986582100007 Content-Type: text/plain; charset="utf-8"; x-default="true" The caller would already fail, but this way the message can better express the reason for the failure. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=3D2043498 Signed-off-by: Martin Kletzander --- audio/spiceaudio.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/audio/spiceaudio.c b/audio/spiceaudio.c index a8d370fe6f31..fdbd7dc285ad 100644 --- a/audio/spiceaudio.c +++ b/audio/spiceaudio.c @@ -74,8 +74,9 @@ static const SpiceRecordInterface record_sif =3D { static void *spice_audio_init(Audiodev *dev) { if (!using_spice) { - return NULL; + error_setg(&error_fatal, "Cannot use spice audio without -spice"); } + return &spice_audio_init; } =20 --=20 2.35.1