From nobody Fri May 17 04:49:42 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1604396632; cv=none; d=zohomail.com; s=zohoarc; b=Xpe5leEPyHRCwmn94TFH0DvRRnseGmDzEZbub6yzl7E2s78qB/6kkZuCpD9T9Wdyhi5rBRyW+msTrVaivuKWJQcLzCTPgYnRmW+DAU49iXThmoKT2QkA5x6CheGyz3Y1iSJFOPIhNZEitvv5hh5lqVV5zFstCI8cTM4K7F81CxM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1604396632; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=PgWpVXWen81k99PdRxADxTliSvA/i+a3GIRddt0pCsU=; b=ns6JbV3Hy1Z+GZq+KJurMOIJ6kfDT5NLwYnYGQPObdprJpa/6rP2iiY68Q0PbvALyDir+ySSumDtigIEpKikfCHq/e+S5d9DI4TqD7o3rDbYFu7JHsLNkPm1q6AXYjNlV6Jqi2Jp+7i3r+w8EjszD/rmpMZqS6lem6o8XMAvwPM= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1604396632964960.8368967456673; Tue, 3 Nov 2020 01:43:52 -0800 (PST) Received: from localhost ([::1]:56634 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kZsr1-0004PZ-Eb for importer@patchew.org; Tue, 03 Nov 2020 04:43:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37754) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kZsqP-0003us-NT; Tue, 03 Nov 2020 04:43:13 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:2500) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kZsqN-0002FL-2Z; Tue, 03 Nov 2020 04:43:13 -0500 Received: from DGGEMS404-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4CQPwR3Rr4zhfdN; Tue, 3 Nov 2020 17:43:03 +0800 (CST) Received: from [10.174.187.138] (10.174.187.138) by DGGEMS404-HUB.china.huawei.com (10.3.19.204) with Microsoft SMTP Server id 14.3.487.0; Tue, 3 Nov 2020 17:42:56 +0800 Message-ID: <5FA12620.6030705@huawei.com> Date: Tue, 3 Nov 2020 17:42:56 +0800 From: AlexChen User-Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:17.0) Gecko/20130509 Thunderbird/17.0.6 MIME-Version: 1.0 To: Kevin Wolf , Subject: [PATCH V2] block/vvfat: Fix bad printf format specifiers Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.174.187.138] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.191; envelope-from=alex.chen@huawei.com; helo=szxga05-in.huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/02 20:52:53 X-ACL-Warn: Detected OS = Linux 3.1-3.10 [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: QEMU Trivial , QEMU , qemu-block@nongnu.org, zhang.zhanghailiang@huawei.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" We should use printf format specifier "%u" instead of "%d" for argument of type "unsigned int". In addition, fix two error format problems found by checkpatch.pl: ERROR: space required after that ',' (ctx:VxV) + fprintf(stderr,"%s attributes=3D0x%02x begin=3D%u size=3D%d\n", ^ ERROR: line over 90 characters + fprintf(stderr, "%d, %s (%u, %d)\n", i, commit->path ? commit->pat= h : "(null)", commit->param.rename.cluster, commit->action); Reported-by: Euler Robot Signed-off-by: Alex Chen --- block/vvfat.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/block/vvfat.c b/block/vvfat.c index 5abb90e7c7..54807f82ca 100644 --- a/block/vvfat.c +++ b/block/vvfat.c @@ -1437,7 +1437,7 @@ static void print_direntry(const direntry_t* direntry) for(i=3D0;i<11;i++) ADD_CHAR(direntry->name[i]); buffer[j] =3D 0; - fprintf(stderr,"%s attributes=3D0x%02x begin=3D%d size=3D%d\n", + fprintf(stderr, "%s attributes=3D0x%02x begin=3D%u size=3D%u\n", buffer, direntry->attributes, begin_of_direntry(direntry),le32_to_cpu(direntry->size)); @@ -1446,7 +1446,7 @@ static void print_direntry(const direntry_t* direntry) static void print_mapping(const mapping_t* mapping) { - fprintf(stderr, "mapping (%p): begin, end =3D %d, %d, dir_index =3D %d= , " + fprintf(stderr, "mapping (%p): begin, end =3D %u, %u, dir_index =3D %u= , " "first_mapping_index =3D %d, name =3D %s, mode =3D 0x%x, " , mapping, mapping->begin, mapping->end, mapping->dir_index, mapping->first_mapping_index, mapping->path, mapping->mode); @@ -1454,7 +1454,7 @@ static void print_mapping(const mapping_t* mapping) if (mapping->mode & MODE_DIRECTORY) fprintf(stderr, "parent_mapping_index =3D %d, first_dir_index =3D = %d\n", mapping->info.dir.parent_mapping_index, mapping->info.dir.first_dir_= index); else - fprintf(stderr, "offset =3D %d\n", mapping->info.file.offset); + fprintf(stderr, "offset =3D %u\n", mapping->info.file.offset); } #endif @@ -1588,7 +1588,7 @@ typedef struct commit_t { static void clear_commits(BDRVVVFATState* s) { int i; -DLOG(fprintf(stderr, "clear_commits (%d commits)\n", s->commits.next)); +DLOG(fprintf(stderr, "clear_commits (%u commits)\n", s->commits.next)); for (i =3D 0; i < s->commits.next; i++) { commit_t* commit =3D array_get(&(s->commits), i); assert(commit->path || commit->action =3D=3D ACTION_WRITEOUT); @@ -2648,7 +2648,9 @@ static int handle_renames_and_mkdirs(BDRVVVFATState* = s) fprintf(stderr, "handle_renames\n"); for (i =3D 0; i < s->commits.next; i++) { commit_t* commit =3D array_get(&(s->commits), i); - fprintf(stderr, "%d, %s (%d, %d)\n", i, commit->path ? commit->pat= h : "(null)", commit->param.rename.cluster, commit->action); + fprintf(stderr, "%d, %s (%u, %d)\n", i, + commit->path ? commit->path : "(null)", + commit->param.rename.cluster, commit->action); } #endif --=20 2.19.1