From nobody Sat Feb 7 18:51:55 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1604142414; cv=none; d=zohomail.com; s=zohoarc; b=D3UqiNZjCegS6FZENT1nuhBZwDp1jZnYyXip25z8I6XpnbvZGerclwrec8/5+kGOU+TFHjW52lKdiG+uhDuiPg8hkgm6lw/d2H4ivfgEpdJuRy8YyytxqvuKHDqlMIgSr5S+KSJtgfxXz4TUnnfNqKcA0PxYn291oOcF8Wn/UO8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1604142414; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=GoieXBY4W9G2NvvhdrDrugr/xfZMoQ2foLtT5mVXKzk=; b=PF6E3nEBTEr/603JKpji6z4Pxi9+dmptvqkq1ZyDYl4LdycxvBl2m09pju6sc/ManvE2Bp+2ooSzouQjlJKxNuk/PdN8o1bE0tLfZnf9GvDBU/kOseqsd6rxAvDH0XMfnp6JMYF4CUsm1gy1kSkCrn78ABIzBuiTmCpY+UAGg70= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1604142414561763.7369501814458; Sat, 31 Oct 2020 04:06:54 -0700 (PDT) Received: from localhost ([::1]:44162 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kYoii-0007Cc-Oh for importer@patchew.org; Sat, 31 Oct 2020 07:06:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55458) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kYog7-0005nq-7Z; Sat, 31 Oct 2020 07:04:11 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:2314) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kYog3-0001Uy-TA; Sat, 31 Oct 2020 07:04:10 -0400 Received: from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4CNbsB4czJzkbWD; Sat, 31 Oct 2020 19:03:58 +0800 (CST) Received: from [10.174.187.138] (10.174.187.138) by DGGEMS407-HUB.china.huawei.com (10.3.19.207) with Microsoft SMTP Server id 14.3.487.0; Sat, 31 Oct 2020 19:03:54 +0800 Message-ID: <5F9D449A.900@huawei.com> Date: Sat, 31 Oct 2020 19:03:54 +0800 From: AlexChen User-Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:17.0) Gecko/20130509 Thunderbird/17.0.6 MIME-Version: 1.0 To: Peter Maydell , Subject: [PATCH] util: Remove redundant checks in the openpty() Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.174.187.138] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.190; envelope-from=alex.chen@huawei.com; helo=szxga04-in.huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/31 07:04:00 X-ACL-Warn: Detected OS = Linux 3.1-3.10 [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: QEMU Trivial , QEMU Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" As we can see from the following function call stack, the amaster and the a= slave cannot be NULL: char_pty_open() -> qemu_openpty_raw() -> openpty(). In addition, the amaster and the aslave has been dereferenced at the beginn= ing of the openpty(). So the checks on amaster and aslave in the openpty() are = redundant. Reported-by: Euler Robot Signed-off-by: Alex Chen Reviewed-by: Peter Maydell --- util/qemu-openpty.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/util/qemu-openpty.c b/util/qemu-openpty.c index eb17f5b0bc..427f43a769 100644 --- a/util/qemu-openpty.c +++ b/util/qemu-openpty.c @@ -80,10 +80,9 @@ static int openpty(int *amaster, int *aslave, char *name, (termp !=3D NULL && tcgetattr(sfd, termp) < 0)) goto err; - if (amaster) - *amaster =3D mfd; - if (aslave) - *aslave =3D sfd; + *amaster =3D mfd; + *aslave =3D sfd; + if (winp) ioctl(sfd, TIOCSWINSZ, winp); --=20 2.19.1