From nobody Sat May 18 16:46:51 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1603951508; cv=none; d=zohomail.com; s=zohoarc; b=PgSm0G+wfTUJyUe4k25nJLvOk4f9VJb4+o7dHUEIzq1QFUjy1dlPyZX4Cd2QiJGMxJerqkZik+VXY5cXQrbE4papis8xfWiRYYuSN72CqGip+1QUtbtSf7aikFGB+YrMWhx8OuJnrFnu+t0m3ISNYLUj5w2HLe8yo3QzPQmNeFo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603951508; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=93Z1qFCoFEgihE+YFLY+pxgq6EHjq6oLYYnVQagTLzU=; b=RD3qCj2h4vsymlkhvmlgWTW/ZW8KlQt14Jl5CzHnamRjyCzgfMbieeaJg09LxMhV9WZJ8GKseobYvYNyjbMR21qAicxVC21IAACyshwGgBsDYlr4JKL0ZScJOS2XCslVGQcMIFNfdWQnOm3VfDKZrTj2iLsqtZbV2NcE19go7CE= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1603951508974986.570551756286; Wed, 28 Oct 2020 23:05:08 -0700 (PDT) Received: from localhost ([::1]:36982 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kY13b-0003FU-Ej for importer@patchew.org; Thu, 29 Oct 2020 02:05:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47810) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kY12W-0002fg-VH; Thu, 29 Oct 2020 02:04:01 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:2487) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kY12V-0006SI-0B; Thu, 29 Oct 2020 02:04:00 -0400 Received: from DGGEMS413-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4CMFHw3RF2zhYkF; Thu, 29 Oct 2020 14:03:56 +0800 (CST) Received: from [10.174.187.138] (10.174.187.138) by DGGEMS413-HUB.china.huawei.com (10.3.19.213) with Microsoft SMTP Server id 14.3.487.0; Thu, 29 Oct 2020 14:03:52 +0800 Message-ID: <5F9A5B48.9030509@huawei.com> Date: Thu, 29 Oct 2020 14:03:52 +0800 From: AlexChen User-Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:17.0) Gecko/20130509 Thunderbird/17.0.6 MIME-Version: 1.0 To: Raphael Norwitz , QEMU , Subject: [PATCH V2] vhost-user-blk/scsi: Fix broken error handling for socket call References: <5F997B84.9040900@huawei.com> In-Reply-To: <5F997B84.9040900@huawei.com> Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.174.187.138] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.191; envelope-from=alex.chen@huawei.com; helo=szxga05-in.huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/29 02:03:54 X-ACL-Warn: Detected OS = Linux 3.1-3.10 [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" When socket() fails, it returns -1, 0 is the normal return value and should= not return error. Reported-by: Euler Robot Signed-off-by: AlexChen Reviewed-by: Raphael Norwitz --- contrib/vhost-user-blk/vhost-user-blk.c | 2 +- contrib/vhost-user-scsi/vhost-user-scsi.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/contrib/vhost-user-blk/vhost-user-blk.c b/contrib/vhost-user-b= lk/vhost-user-blk.c index 25eccd02b5..40a2dfc544 100644 --- a/contrib/vhost-user-blk/vhost-user-blk.c +++ b/contrib/vhost-user-blk/vhost-user-blk.c @@ -474,7 +474,7 @@ static int unix_sock_new(char *unix_fn) assert(unix_fn); sock =3D socket(AF_UNIX, SOCK_STREAM, 0); - if (sock <=3D 0) { + if (sock < 0) { perror("socket"); return -1; } diff --git a/contrib/vhost-user-scsi/vhost-user-scsi.c b/contrib/vhost-user= -scsi/vhost-user-scsi.c index 3c912384e9..0f9ba4b2a2 100644 --- a/contrib/vhost-user-scsi/vhost-user-scsi.c +++ b/contrib/vhost-user-scsi/vhost-user-scsi.c @@ -320,7 +320,7 @@ static int unix_sock_new(char *unix_fn) assert(unix_fn); sock =3D socket(AF_UNIX, SOCK_STREAM, 0); - if (sock <=3D 0) { + if (sock < 0) { perror("socket"); return -1; } --=20 2.19.1