From nobody Sun May 19 05:00:06 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1598437017; cv=none; d=zohomail.com; s=zohoarc; b=dY0jzmeQ9zS/hfUfPbLYwwmoYkdcxVswI2OJoeeqWKX11h6OKK7uh5JzAInQnJHpM/Cmcdh5+hK5sLd3MLTAcMsEaXswGrCtokQ9Q99xOvl1oDNB/sgrhAagxtgU0Q8bLz8x0JBa9R70yhQex9r9x4RSKtuP9fvAQA4TeDk71Uo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1598437017; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=RW0um8U+eEn3AAKtGaUzPX6tc8fIzwxalW6Gf+kd3IE=; b=c0Usg9p03UKBgyVfc2dDsMxbfD77E3SGwr/9/EWIR2zDN3/aHf+gGL41WvlPPI2NjqorIZCws3nVA6ocfsgdgplU8gCHgT20WK85H6B2KkH3E4nlEOWJvA+E8jO1lZTXblb5QpfmRnHQIL9CUX6GngPqgL2XDSq7fDqZggHqHJk= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1598437017204372.0358046980308; Wed, 26 Aug 2020 03:16:57 -0700 (PDT) Received: from localhost ([::1]:41716 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kAsUB-00043u-Jx for importer@patchew.org; Wed, 26 Aug 2020 06:16:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34262) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kAsTN-0002uM-Uz for qemu-devel@nongnu.org; Wed, 26 Aug 2020 06:16:05 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:4269 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kAsTM-0004zk-9w for qemu-devel@nongnu.org; Wed, 26 Aug 2020 06:16:05 -0400 Received: from DGGEMS401-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 58686A781E1CE4EBD91A; Wed, 26 Aug 2020 18:16:00 +0800 (CST) Received: from [127.0.0.1] (10.174.187.160) by DGGEMS401-HUB.china.huawei.com (10.3.19.201) with Microsoft SMTP Server id 14.3.487.0; Wed, 26 Aug 2020 18:15:53 +0800 Message-ID: <5F463659.8080101@huawei.com> Date: Wed, 26 Aug 2020 18:15:53 +0800 From: AlexChen User-Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:17.0) Gecko/20130509 Thunderbird/17.0.6 MIME-Version: 1.0 To: Viktor Prutyanov Subject: elf2dmp: Fix memory leak on main() error paths Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.174.187.160] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.191; envelope-from=alex.chen@huawei.com; helo=huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/26 06:03:24 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: zhengchuan@huawei.com, qemu-devel@nongnu.org, zhang.zhanghailiang@huawei.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: AlexChen The 'kdgb' is allocating memory in get_kdbg(), but it is not freed in both fill_header() and fill_context() failed branches, fix it. Signed-off-by: AlexChen Reviewed-by: Li Qiang Reviewed-by: Thomas Huth Reviewed-by: Viktor Prutyanov --- contrib/elf2dmp/main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/contrib/elf2dmp/main.c b/contrib/elf2dmp/main.c index 9a2dbc2902..ac746e49e0 100644 --- a/contrib/elf2dmp/main.c +++ b/contrib/elf2dmp/main.c @@ -568,12 +568,12 @@ int main(int argc, char *argv[]) if (fill_header(&header, &ps, &vs, KdDebuggerDataBlock, kdbg, KdVersionBlock, qemu_elf.state_nr)) { err =3D 1; - goto out_pdb; + goto out_kdbg; } if (fill_context(kdbg, &vs, &qemu_elf)) { err =3D 1; - goto out_pdb; + goto out_kdbg; } if (write_dump(&ps, &header, argv[2])) { --=20 2.19.1