From nobody Sun Nov 16 06:29:39 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1592267999; cv=none; d=zohomail.com; s=zohoarc; b=UJM1PJqhfDBtzOvdF1dhspybaRxyAu7Dg1QOL2USy1D2ZeLKxXbU0rZ5doy8oKFl8O9REx1mvihOBkTEN8BkMayVN5aXJi09sOTWSzCcyX8W/nyByBXoxridi5uHZu9D8PG/dTW8HToXlFIZdT7ZTbeEv0aGDNUvm726HmM3a8Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1592267999; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=yzlKRcyoS6psVtm2OFtFezLSxz+IUZQ6h7GMxVWfrSk=; b=dElytrRNtQcPMh3djrHyyV9jWVcpvdRQ60CzEgjIdhakuMOQ0RI/uTaLTsw54BM9ybYjyo1WylH+MJUyXXg/heHS1rPR05q9WUJJHf2DQ+R7/lKhVv1r1EDtOD2RVIWNNM9U0EBLpTnUc3+yR6FseWG8JuUR4wwtJzVM8KkxGOA= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1592267999665466.2772007571682; Mon, 15 Jun 2020 17:39:59 -0700 (PDT) Received: from localhost ([::1]:44320 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jkzdu-0002If-Cj for importer@patchew.org; Mon, 15 Jun 2020 20:39:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43194) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jkzZu-0004fB-Fv for qemu-devel@nongnu.org; Mon, 15 Jun 2020 20:35:51 -0400 Received: from zero.eik.bme.hu ([2001:738:2001:2001::2001]:46225) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jkzZr-0003z1-J5 for qemu-devel@nongnu.org; Mon, 15 Jun 2020 20:35:50 -0400 Received: from zero.eik.bme.hu (blah.eik.bme.hu [152.66.115.182]) by localhost (Postfix) with SMTP id 051CA748DDF; Tue, 16 Jun 2020 02:35:41 +0200 (CEST) Received: by zero.eik.bme.hu (Postfix, from userid 432) id 7600C748DCF; Tue, 16 Jun 2020 02:35:40 +0200 (CEST) Message-Id: <59fd9656e72cd56e6dcd3c9ffc04ff91f8b3d907.1592266950.git.balaton@eik.bme.hu> In-Reply-To: References: From: BALATON Zoltan Subject: [PATCH v2 6/8] sm501: Use stn_he_p/ldn_he_p instead of switch/case Date: Tue, 16 Jun 2020 02:22:30 +0200 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable To: qemu-devel@nongnu.org X-Spam-Probability: 8% Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2001:738:2001:2001::2001; envelope-from=balaton@eik.bme.hu; helo=zero.eik.bme.hu X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Sebastian Bauer , Magnus Damm , Gerd Hoffmann , Aurelien Jarno Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Instead of open coding op with different sizes using a switch and type casting it can be written more compactly using stn_he_p/ldn_he_p. Suggested-by: Peter Maydell Signed-off-by: BALATON Zoltan Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/display/sm501.c | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/hw/display/sm501.c b/hw/display/sm501.c index b6356ea1ee..6e914d3162 100644 --- a/hw/display/sm501.c +++ b/hw/display/sm501.c @@ -766,17 +766,7 @@ static void sm501_2d_operation(SM501State *s) for (y =3D 0; y < height; y++) { i =3D (dst_x + (dst_y + y) * dst_pitch) * bypp; for (x =3D 0; x < width; x++, i +=3D bypp) { - switch (format) { - case 0: - d[i] =3D ~d[i]; - break; - case 1: - *(uint16_t *)&d[i] =3D ~*(uint16_t *)&d[i]; - break; - case 2: - *(uint32_t *)&d[i] =3D ~*(uint32_t *)&d[i]; - break; - } + stn_he_p(&d[i], bypp, ~ldn_he_p(&d[i], bypp)); } } } else { --=20 2.21.3