From nobody Mon Nov 10 12:49:23 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1556734944; cv=none; d=zoho.com; s=zohoarc; b=Wth4W1kuCqJQvwpeytw28/mPcnwCl9AS4S0sAheJnoi4k3Hnje6kKri2GSZ3XIFTe6dZwvtXUkoqCPj9NQspDEiHP2rcVY+RXFcG0aKjxsHNWW44CsoCZy77FJua1JeTSo2au1CeC4mtNuguEu1GEYm+2xqUpl+7DjuO0LmMDA0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1556734944; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=gu6vZ9BZd32QJ/IQ0z70dkM0F4vMe4X00civB0gcGbI=; b=oeAVwGH9d4u8ordwrCKMl2M6CJycdYgwjdbTuMa43P0wy6HnQCzZH4L92SB6KSufxnZpEtL4MMPI/oPLBd9u4QAjrOO2X2m/JzgqYmz89+0Jtyl8wfeEIZmnRjHVamDgDP8Z0AikGwVY+VIpy8RQD4pd8faMc3fug/seWFdm2bQ= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1556734944125697.7180747432149; Wed, 1 May 2019 11:22:24 -0700 (PDT) Received: from localhost ([127.0.0.1]:38099 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hLtrz-0003da-2W for importer@patchew.org; Wed, 01 May 2019 14:22:15 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45620) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hLtkc-0007NY-Hj for qemu-devel@nongnu.org; Wed, 01 May 2019 14:14:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hLtkb-0002cF-4S for qemu-devel@nongnu.org; Wed, 01 May 2019 14:14:38 -0400 Received: from fanzine.igalia.com ([91.117.99.155]:38856) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hLtka-0002RI-RG; Wed, 01 May 2019 14:14:37 -0400 Received: from 87-92-6-174.bb.dnainternet.fi ([87.92.6.174] helo=perseus.local) by fanzine.igalia.com with esmtpsa (Cipher TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim) id 1hLtkH-0002E8-5H; Wed, 01 May 2019 20:14:17 +0200 Received: from berto by perseus.local with local (Exim 4.89) (envelope-from ) id 1hLtk2-0002yN-Ke; Wed, 01 May 2019 21:14:02 +0300 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=References:In-Reply-To:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=gu6vZ9BZd32QJ/IQ0z70dkM0F4vMe4X00civB0gcGbI=; b=FPMOeqWjBEHefkfrav8r2YRsWmiqQoEpYuxJx1DG87ZPsjH1bqTd9IhanlPvk6FfspAGosvc8oMh1Nt6k78wkJkBiBxj90Ly/1pw+7AkFQi/VjF0lh5rcH2sGHOiyH4SQhXqsnIro5Bfkj90LIn7UQXNxYyg6I3NZu7F2PHsKFclyVmjPr5vyKwAdPalg+BzCzf7nV3szX19OzxtGXIAkp1z34VFvsHA9irZtJ7AZtH1LwBGAlC3kCXnBbdoHN3D3xndT+fhlbRvJXumkFM8IKZ62QOhG3U2CxxX3kNq8//OvorO6vbbYsztbVpe1uz1mwLZgblumSEgNBLb7BMFrw==; From: Alberto Garcia To: qemu-devel@nongnu.org Date: Wed, 1 May 2019 21:13:57 +0300 Message-Id: <524e211cb818a20f521d6e271e782ab62b8e5e80.1556732434.git.berto@igalia.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: References: In-Reply-To: References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] [fuzzy] X-Received-From: 91.117.99.155 Subject: [Qemu-devel] [PATCH v2 3/5] vvfat: Replace bdrv_{read, write}() with bdrv_{pread, pwrite}() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Alberto Garcia , qemu-block@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" There's only a couple of bdrv_read() and bdrv_write() calls left in the vvfat code, and they can be trivially replaced with the byte-based bdrv_pread() and bdrv_pwrite(). Signed-off-by: Alberto Garcia --- block/vvfat.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/block/vvfat.c b/block/vvfat.c index 5f66787890..253cc716dd 100644 --- a/block/vvfat.c +++ b/block/vvfat.c @@ -1494,8 +1494,8 @@ static int vvfat_read(BlockDriverState *bs, int64_t s= ector_num, DLOG(fprintf(stderr, "sectors %" PRId64 "+%" PRId64 " allocated\n", sector_num, n >> BDRV_SECTOR_BITS)); - if (bdrv_read(s->qcow, sector_num, buf + i * 0x200, - n >> BDRV_SECTOR_BITS)) { + if (bdrv_pread(s->qcow, sector_num * BDRV_SECTOR_SIZE, + buf + i * 0x200, n) < 0) { return -1; } i +=3D (n >> BDRV_SECTOR_BITS) - 1; @@ -1983,8 +1983,9 @@ static uint32_t get_cluster_count_for_direntry(BDRVVV= FATState* s, if (res) { return -1; } - res =3D bdrv_write(s->qcow, offset, s->cluster_buf= fer, 1); - if (res) { + res =3D bdrv_pwrite(s->qcow, offset * BDRV_SECTOR_= SIZE, + s->cluster_buffer, BDRV_SECTOR_S= IZE); + if (res < 0) { return -2; } } @@ -3050,7 +3051,8 @@ DLOG(checkpoint()); * Use qcow backend. Commit later. */ DLOG(fprintf(stderr, "Write to qcow backend: %d + %d\n", (int)sector_num, = nb_sectors)); - ret =3D bdrv_write(s->qcow, sector_num, buf, nb_sectors); + ret =3D bdrv_pwrite(s->qcow, sector_num * BDRV_SECTOR_SIZE, buf, + nb_sectors * BDRV_SECTOR_SIZE); if (ret < 0) { fprintf(stderr, "Error writing to qcow backend\n"); return ret; --=20 2.11.0