From nobody Sat May 10 02:34:48 2025
Delivered-To: importer@patchew.org
Authentication-Results: mx.zohomail.com;
dkim=fail header.i=@asus.com;
spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as
permitted sender)
smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org;
dmarc=pass(p=none dis=none) header.from=nongnu.org
ARC-Seal: i=1; a=rsa-sha256; t=1734083370; cv=none;
d=zohomail.com; s=zohoarc;
b=kE9jl4Qby//pef0rI9a1MaJn/lo7OhPhn30omKfNSS0eSgJgiHuoOJREUibeZ6jVBaTeloJhbI/IDbF7GqxsC4JByhDNa15o9rf2JX16ug+gMuqWQQ5qwMkM2pwqDDZ4ptFKt6d4BXKcFoUlUAq4QtZtjIhlPHb/k4E4hE15fbE=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com;
s=zohoarc;
t=1734083370;
h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id;
bh=ZBzLZSkUBRK8jeGbKSWmNvoq7xXyF5AQsM8nAn9lZPQ=;
b=cQmhhUIjHiSf5Cg/rnZiKZKKNpavwzJK2DwZ6DraDsZswjsGAirDOgPVjkSifVhXeBZLLGc8vSi+3d2+PEHJ0WDuqjQBe1B4ifQKyT1qho0T8SVEh4jQ0zzATOgyaVqpUVglIXD+1LIpuME1yvCUVmZTVCejWUJwYoQwTNFNWTo=
ARC-Authentication-Results: i=1; mx.zohomail.com;
dkim=fail header.i=@asus.com;
spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as
permitted sender)
smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org;
dmarc=pass header.from=<qemu-devel@nongnu.org> (p=none dis=none)
Return-Path: <qemu-devel-bounces+importer=patchew.org@nongnu.org>
Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by
mx.zohomail.com
with SMTPS id 1734083370620222.61495671038506;
Fri, 13 Dec 2024 01:49:30 -0800 (PST)
Received: from localhost ([::1] helo=lists1p.gnu.org)
by lists.gnu.org with esmtp (Exim 4.90_1)
(envelope-from <qemu-devel-bounces@nongnu.org>)
id 1tM2II-00025u-CO; Fri, 13 Dec 2024 04:49:10 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <prvs=070864293=kenneth_jia@asus.com>)
id 1tM2IF-000252-DV; Fri, 13 Dec 2024 04:49:07 -0500
Received: from ms.asus.com ([103.10.4.142])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <prvs=070864293=kenneth_jia@asus.com>)
id 1tM2ID-0007fL-7Z; Fri, 13 Dec 2024 04:49:07 -0500
Received: from unknown (HELO ACC-EX16-V01.acc.corpnet.asus) ([172.29.34.11])
by ms.asus.com with ESMTP; 13 Dec 2024 17:48:52 +0800
Received: from ACC-EX16-V03.acc.corpnet.asus (172.29.34.13) by
ACC-EX16-V01.acc.corpnet.asus (172.29.34.11) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.1.2507.43; Fri, 13 Dec 2024 17:48:48 +0800
Received: from ACC-EX16-V03.acc.corpnet.asus ([fe80::3dae:532a:2ef6:9654]) by
ACC-EX16-V03.acc.corpnet.asus ([fe80::3dae:532a:2ef6:9654%3]) with
mapi id 15.01.2507.043; Fri, 13 Dec 2024 17:48:48 +0800
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
d=asus.com; i=@asus.com; q=dns/txt; s=asuscom;
t=1734083345; x=1765619345;
h=from:to:cc:subject:date:message-id:references:
in-reply-to:content-transfer-encoding:mime-version;
bh=ZBzLZSkUBRK8jeGbKSWmNvoq7xXyF5AQsM8nAn9lZPQ=;
b=0IN8q/Uib47rE9iPTx8t59ku37dtJqVMgTVkphy4dBoshDWMdLS71YQD
0zoeL/XJRfwxbdOEXknfdkskT2XW21xu9ucbvvI+Z6PjSrNvFLj9kP00I
6SzqPFY9YHfJ8U6GoCjGSiNePCemK82a69te//HNp6jMnPUYwgaQzne6h g=;
IronPort-Data: A9a23:9lawd623skKmybnxkvbD5ftwkn2cJEfYwER7XKvMYLTBsI5bpzVSx
mFKWmqPOa6JNGH0ft9wYd+zp0IAuZCGzN9lHVQ6qSg9HnlHl5HIVI+TRqvSF3rJd5WcFiqLz
Cm8hv3odp1coqr0+0/F3oDJ9CU6j+fTLlbFILasEjhrQgN5QzsWhxtmmuoo6qZlmtHR7zml4
LsenuWEULOb828sWo4rw//bwP9flKyakC8VuFU4ecdKsDf2/5XCJMlHTU0ZByKQrrh8RoZWd
c6apF2K1jqxEyMWNz+Quu2Tnnvm4lLlFVPmZnJ+A8BOi/XZz8A4+v5T2PE0MS+7h9gV9jzYJ
RokWZGYEG8U0qPwdOs1aQVEOCxhF658pITIIl2mt8u39U/HfC65qxluJBle0Yww081cREx+r
KJdFmhUKBmIjKS9x6ijTORwwM04MdKD0IE34y46i2uIS616B8maK0nJzYYwMDMYhc1IG/vCZ
/0baDNHZQ/deFtEPVJ/5JcWxbv22yWjK2AwRFS9oJpu0XePyjZL+6XXGfPIWMOMYtt5txPNz
o7B1yGjav0AD/SUzTWt8XuriqnIhyyTcJsfEaD9/+RvqFuUwGMVFVsRT1TTifK9hWakVt5fI
lBS8S0rxYAq9E2vS9XVWxy+qWSD+BkGVLJ4EeQ/6Qe6zqvSyw+CHmUJQiJMY9xgv8gzLRQj0
FOTkszBDjtjvbaST2mB7KqfsXW5Pi1TJHJqTSAfTQIDy8PurIE6klTESdMLOLe4i8CwFTzuz
jSiqi84iLMOy8kR2M2GEUvv2m324MKYCFVpoFyONo640j5EiEeeT9TAwTDmATxodu51knHpU
KA4pvWj
IronPort-HdrOrdr: A9a23:BNb7v6h75ob+OYsA/5eJP9SNtHBQXk0ji2hC6mlwRA09TyXBrb
HIoBwavSWatN9jYgBHpTnmAtj0fZq8z+8G3WB/B8bAYOCLggaVxcRZnO/fKl7balnDH4xmpM
VdmsFFYbWaZ2SSz/yKhTVQeOxP/DDzysCVbJDlrkuFIzsHV0gq1XYBNu/SKDwPeOBpP+tDKH
LHi/A33QZJWhksH7mG7jlpZZm9mzWE+aiWHyLvSXQcmXqzZYHE0s+HLzGImgobWylChawv63
TBjmXCl9SemuD+1xvVzWOW8JhMgtvmzbJ4dbyxtvQ=
X-Talos-CUID: 9a23:mrXQ/mCpoMDocCn6ExN76GUZBeomSCHmw3T1Okm/LVxrSbLAHA==
X-Talos-MUID: 9a23:sV4y4QS5XCiMduvwRXTptGhQK5tu2Z6FFXokuIgkpM+jKwBZbmI=
To: =?utf-8?B?J0PDqWRyaWMgTGUgR29hdGVyJw==?= <clg@kaod.org>,
"'qemu-arm@nongnu.org'" <qemu-arm@nongnu.org>
CC: =?utf-8?B?J0PDqWRyaWMgTGUgR29hdGVyJw==?= <clg@redhat.com>,
=?utf-8?B?J1BoaWxpcHBlIE1hdGhpZXUtRGF1ZMOpJw==?= <philmd@linaro.org>, "'Jamin
Lin'" <jamin_lin@aspeedtech.com>, 'Andrew Jeffery'
<andrew@codeconstruct.com.au>, 'Gavin Shan' <gshan@redhat.com>, "'open
list:All patches CC here'" <qemu-devel@nongnu.org>
Subject:
=?utf-8?B?562U5aSNOiBbUEFUQ0hdIGh3L2FybS9hc3BlZWQ6IGZpeCBjb25uZWN0X3Nl?=
=?utf-8?B?cmlhbF9oZHNfdG9fdWFydHM=?=
Thread-Topic: [PATCH] hw/arm/aspeed: fix connect_serial_hds_to_uarts
Thread-Index: AQHbTS9dSL1vUYsQ8E2tdLoBmzCJz7Lj503A
Date: Fri, 13 Dec 2024 09:48:48 +0000
Message-ID: <4c9f90399854448497317465c1e4cedc@asus.com>
References: <5f9b0c53f1644922ba85522046e92f4c@asus.com>
<8af809d7-5fa2-471f-9fc9-eee482988894@kaod.org>
In-Reply-To: <8af809d7-5fa2-471f-9fc9-eee482988894@kaod.org>
Accept-Language: zh-CN, en-US
Content-Language: zh-CN
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.68.200.222]
x-tm-as-product-ver: SMEX-14.0.0.3223-9.1.2019-28826.004
x-tm-as-result: No-10--24.342000-8.000000
x-tmase-matchedrid: EF5z2ETDrAcfHU5fltg9RlY9XYa1m8xA1gfGMJv7tZK1GZp9GnkU8y67
ox+QMz1gAHg/HS2tqGjosUIDPdsTU2s7XhibDX9dUlO0zoIcpU6exJFd1f8r+3NxS8QcqzsbLqc
Doo8mZno2c+sa3AtBUqeeKmVKb44CvEQ3AnZS8ITipEa3UDsZRA2LmwHT7i+nX7YFvCOGcWk+ly
66+9jDJLAjxeuur58TI89VAyvsIp0yVLl90PKZQro2KXQsvVZSVPQ3cbOrxNL/GDyR80F454XVe
AzWzPHrEiKTmSPOUFcC+EBKhxaceufMaGeNZQ39WZxYhPYYrMlBqFX02wvtDw7PBVWyPtn/9NFK
rIIXgXw9NEjD7ulfbyQWr8B5J1Z+zEhV/IuzF6L6KF0S1zktZ+5zvRYCQLoV30z/E8e/OqLjEt1
EiGuYH9FETOOg+TX0tH3PC6sB1AhdXCl/d5Ej2xqsS/8jaA/K1c04BDYxKLaa4ymjlcrDbznxJq
un3snzhyRlPlpuvG6bCOivU2HrCzJJUfUG/qfc
x-tm-as-user-approved-sender: No
x-tm-as-user-blocked-sender: No
x-tmase-result: 10--24.342000-8.000000
x-tmase-version: SMEX-14.0.0.3223-9.1.2019-28826.004
x-tm-snts-smtp:
02D2D8B39B737C5B81FB6C2E50EA4C39DC9B2B62D3690B2A6EFE7FFFC0A270682000:9
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17
as permitted sender) client-ip=209.51.188.17;
envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org;
helo=lists.gnu.org;
Received-SPF: pass client-ip=103.10.4.142;
envelope-from=prvs=070864293=kenneth_jia@asus.com; helo=ms.asus.com
X-Spam_score_int: -25
X-Spam_score: -2.6
X-Spam_bar: --
X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.496,
DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,
SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-BeenThere: qemu-devel@nongnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <https://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Reply-to: =?utf-8?B?S2VubmV0aCBKaWEo6LS+57qq5LicX+WNjuehleS4iua1tyk=?=
<kenneth_jia@asus.com>
From: kenneth_jia--- via <qemu-devel@nongnu.org>
Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org
Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org
X-ZohoMail-DKIM: fail (Header signature does not verify)
X-ZM-MESSAGEID: 1734083373025116600
We plans to use a relatively large number of UART connections, and current=
ly test all UARTs that can be used.=20
When we use qumu for simulation, the problem was discovered.
The current code does not allocate char devices with index 5 (label serial=
5).
And even if there are more serial devices, the last one (UAR12) is not co=
nnected to serial.
Add debug information to watch:
diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c
index 556498f2a0..786df450ed 100644
Reviewed-by: C=C3=A9dric Le Goater <clg@redhat.com>
--- a/hw/arm/aspeed.c
+++ b/hw/arm/aspeed.c
@@ -369,6 +369,7 @@ static void connect_serial_hds_to_uarts(AspeedMachineSt=
ate *bmc)
continue;
}
aspeed_soc_uart_set_chr(s, uart, serial_hd(i));
+ printf("uart %d char index %d name %s\n", uart-sc->uarts_base, i, s=
erial_hd(i)?serial_hd(i)->filename:"null");
}
}
Test command
~/office_qemu/build/qemu-system-arm -m 1G -M ast2600-evb,fmc-model=
=3Dmx66l1g45g -nographic \
-drive file=3D./${evb}.bin,format=3Draw,if=3Dmtd,unit=3D0 \
-drive file=3D./emmc1.bin,format=3Draw,if=3Dsd,unit=3D2 \
-net nic -net nic -net nic -net nic \
-net user,hostfwd=3D::2443-:443,hostfwd=3D::2242-:22,hostfwd=3Dudp:=
:2623-:623 \
-serial pty \
-serial pty \
-serial pty \
-serial pty \
-serial pty \
-serial pty \
-serial pty \
-serial pty \
-serial pty \
-serial pty \
-serial pty \
-serial pty \
-serial pty \
-serial pty
Output Log:=20
QEMU 9.2.50 monitor - type 'help' for more information
char device redirected to /dev/pts/6 (label serial0)
char device redirected to /dev/pts/7 (label serial1)
char device redirected to /dev/pts/8 (label serial2)
char device redirected to /dev/pts/9 (label serial3)
char device redirected to /dev/pts/10 (label serial4)
char device redirected to /dev/pts/11 (label serial5)
char device redirected to /dev/pts/12 (label serial6)
char device redirected to /dev/pts/13 (label serial7)
char device redirected to /dev/pts/14 (label serial8)
char device redirected to /dev/pts/15 (label serial9)
char device redirected to /dev/pts/16 (label serial10)
char device redirected to /dev/pts/17 (label serial11)
char device redirected to /dev/pts/19 (label serial12)
char device redirected to /dev/pts/21 (label serial13)
char device redirected to /dev/pts/22 (label serial14)
uart 0 char index 1 name pty:/dev/pts/7
uart 1 char index 2 name pty:/dev/pts/8
uart 2 char index 3 name pty:/dev/pts/9
uart 3 char index 4 name pty:/dev/pts/10
uart 5 char index 6 name pty:/dev/pts/12
uart 6 char index 7 name pty:/dev/pts/13
uart 7 char index 8 name pty:/dev/pts/14
uart 8 char index 9 name pty:/dev/pts/15
uart 9 char index 10 name pty:/dev/pts/16
uart 10 char index 11 name pty:/dev/pts/17
uart 11 char index 12 name pty:/dev/pts/19
(qemu)
Issue:=20
/dev/pts/17 (label serial11) is not connected to a UART,
UART12 is not connect to a serial device.
-----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6-----
=E5=8F=91=E4=BB=B6=E4=BA=BA: C=C3=A9dric Le Goater <clg@kaod.org>=20
=E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2024=E5=B9=B412=E6=9C=8813=E6=97=A5 1=
5:19
=E6=94=B6=E4=BB=B6=E4=BA=BA: Kenneth Jia(=E8=B4=BE=E7=BA=AA=E4=B8=9C_=E5=8D=
=8E=E7=A1=95=E4=B8=8A=E6=B5=B7) <kenneth_jia@asus.com>; 'qemu-arm@nongnu.or=
g' <qemu-arm@nongnu.org>
=E6=8A=84=E9=80=81: 'C=C3=A9dric Le Goater' <clg@redhat.com>; 'Philippe Mat=
hieu-Daud=C3=A9' <philmd@linaro.o
>=20
> Subject: [PATCH]=C2=A0=C2=A0=C2=A0 hw/arm/aspeed: fix connect_serial_hds_=
to_uarts
>=20
> =C2=A0=C2=A0 In the loop, we need ignore the index increase when uart =
=3D=3D=20
> uart_chosen
>=20
> =C2=A0=C2=A0 We should increase the index only after we allocate a seria=
l.
>=20
> Signed-off-by: Kenneth Jia <kenneth_jia@asus.com>
Could you please tell us a bit on your test environment ? I am interested t=
o know how you found the issue.
Also, please use "git send-email" to send patches.
Anyhow,
Fixes: d2b3eaefb4d7 ("aspeed: Refactor UART init for multi-SoC machines")
Reviewed-by: C=C3=A9dric Le Goater <clg@redhat.com>
Thanks,
C.
>=20
> ---
>=20
> hw/arm/aspeed.c | 4 ++--
>=20
> 1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c
>=20
> index 556498f2a0..d8cb2d1429 100644
>=20
> --- a/hw/arm/aspeed.c
>=20
> +++ b/hw/arm/aspeed.c
>=20
> @@ -364,11 +364,11 @@ static void=20
> connect_serial_hds_to_uarts(AspeedMachineState *bmc)
>=20
> =C2=A0=C2=A0=C2=A0=C2=A0 int uart_chosen =3D bmc->uart_chosen ? bmc->uar=
t_chosen :=20
> amc->uart_default;
>=20
> =C2=A0=C2=A0=C2=A0=C2=A0 aspeed_soc_uart_set_chr(s, uart_chosen, serial_=
hd(0));
>=20
> -=C2=A0=C2=A0=C2=A0 for (int i =3D 1, uart =3D sc->uarts_base; i < sc->ua=
rts_num; i++,=20
> uart++) {
>=20
> +=C2=A0=C2=A0=C2=A0 for (int i =3D 1, uart =3D sc->uarts_base; i < sc->ua=
rts_num; uart++)=20
> +{
>=20
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (uart =3D=3D uart_ch=
osen) {
>=20
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
continue;
>=20
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 }
>=20
> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 aspeed_soc_uart_set_chr(s, ua=
rt, serial_hd(i));
>=20
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 aspeed_soc_uart_set_chr(s, ua=
rt, serial_hd(i++));
>=20
> =C2=A0=C2=A0=C2=A0=C2=A0 }
>=20
> }
>=20
> --
>=20
> 2.34.1
>=20
<p></p>