From nobody Wed Nov 27 19:28:34 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1697645336; cv=none; d=zohomail.com; s=zohoarc; b=WWtmCgNT68oy1nsvDNs24nBrDsrt0bK2jnutLMUkyHTi7TY/WORaK8MxHqSw1ja3XY+3+a5hzw9kRgGeCREe4OKF3Q7YHPZrah8wzb2Zbb0vwoq4Zd0Py4GsPZlUVztPEJ/Lm+Bx8G0tEQfmHz2KfaKJI76GAkHJOZ8cG+6veDk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1697645336; h=Content-Type:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=pK7tbuaeKJdZf3nB4jRfGMSAPSPT/dWMGPTuzqv6QUY=; b=DMAAO60uZfUW4/X31FwXBb2/t7zjNomaV3seykFHPw8ePlEqp5gHZmyjXvdpVR6dUqMPTUAj19MwLNr6NeLzGcQ0bxfTEDtO9dFJfVE1qAIy2ClmNOQQ6LcijtaWK22B8jDxFS4w1yZK2N59uXwZ1KhywUVyAWflxTXTbh9U4tk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1697645336257697.13261847545; Wed, 18 Oct 2023 09:08:56 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qt8vK-0005tP-0r; Wed, 18 Oct 2023 11:57:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qt8uE-0003uE-Jg for qemu-devel@nongnu.org; Wed, 18 Oct 2023 11:56:24 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qt8uC-0006zF-64 for qemu-devel@nongnu.org; Wed, 18 Oct 2023 11:56:21 -0400 Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-475-zOAIXCenMm6D0DcBPdpSoQ-1; Wed, 18 Oct 2023 11:56:17 -0400 Received: by mail-lj1-f197.google.com with SMTP id 38308e7fff4ca-2c50dcd377eso47365151fa.2 for ; Wed, 18 Oct 2023 08:56:17 -0700 (PDT) Received: from redhat.com ([2a02:14f:1f2:2037:f34:d61b:7da0:a7be]) by smtp.gmail.com with ESMTPSA id o30-20020a05600c511e00b004063cd8105csm2044729wms.22.2023.10.18.08.56.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Oct 2023 08:56:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1697644579; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pK7tbuaeKJdZf3nB4jRfGMSAPSPT/dWMGPTuzqv6QUY=; b=Iq6Np3WwX0/bQVD0UotOfk2n9VbccmLoIyRiJg4oQ7TWHu4dOq/6ywthGZcXCGaVJf/Y6k BCe/oSWqCaceRhktYFc2id10Q5ZNe3emI4vXzJKKuMVj1UKaYM9WsQ8aa0OP2kiONvWENY rFhgMNbBMmBcYa54vKoD+DeUBYg9JdA= X-MC-Unique: zOAIXCenMm6D0DcBPdpSoQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697644575; x=1698249375; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pK7tbuaeKJdZf3nB4jRfGMSAPSPT/dWMGPTuzqv6QUY=; b=BNARhEYgFbpV0TYU3GWHeAda5i/+0uf0900XfnxM0YNMktPChWCFPgWZFutCZHrkLP U3PhF1s1McJOfnyvaV5ZkOwlv1Nt75EQ3Ud2alnJLffU+uhgGBdCqy4RF6LjssfS53Aj nfj0VEoTZ6j/XpAAuCjI/CYRpvkEpA7ouulGmzjQrrEhL5fZt7DQ6nKdz2l5z8MtXL02 60YuOy1WlFXKYkOzAfI6O/qS8rC4/pfDJCJQAxhvwtPoTan1g5ACqglNYrjqVzKWGRtk uR2eg3jQVU2LjSsY7iT+nN7jUEHCbEyfPKIUUg92qZjqGPTorJusYWhnfJpvJ336QnUh k1VA== X-Gm-Message-State: AOJu0YyEVD6r3/R9loz+xfl9KSp+DtCuNyf+pY1pYi73NRkPfg2/SPb8 EenPrBxE21Jl/x+U/eJzbyA/YLu+BhUUFJZt0Belw61WNFIa9gM//lsNWbakJqwI19krqc2WmRx oYvxvI9I69hPmIhpFAHPg5CkP3+Q8Ju9p41EGBtT+AQW1ifroB7FLkoWRJoIlIlWaHGikfKs= X-Received: by 2002:a05:651c:1198:b0:2c4:fef7:c41e with SMTP id w24-20020a05651c119800b002c4fef7c41emr3768473ljo.0.1697644575808; Wed, 18 Oct 2023 08:56:15 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEHx+Q7d75V+zu5Xic4w1SZu941JfJgmRPwFNgSCI7Vh3lQ+OXIktkHNDyvxItal7Qc1pLv9A== X-Received: by 2002:a05:651c:1198:b0:2c4:fef7:c41e with SMTP id w24-20020a05651c119800b002c4fef7c41emr3768447ljo.0.1697644575508; Wed, 18 Oct 2023 08:56:15 -0700 (PDT) Date: Wed, 18 Oct 2023 11:56:11 -0400 From: "Michael S. Tsirkin" To: qemu-devel@nongnu.org Cc: Peter Maydell , Stefan Hajnoczi , Raphael Norwitz , Hanna Czenczek Subject: [PULL 38/83] vhost-backend: remove vhost_kernel_reset_device() Message-ID: <4c8cad564f032f9ecc0b726df9211df717629dab.1697644299.git.mst@redhat.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Mailer: git-send-email 2.27.0.106.g8ac3dc51b1 X-Mutt-Fcc: =sent Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=mst@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1697645337222100003 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Stefan Hajnoczi vhost_kernel_reset_device() invokes RESET_OWNER, which disassociates the owner process from the device. The device is left non-operational since SET_OWNER is only called once during startup in vhost_dev_init(). vhost_kernel_reset_device() is never called so this latent bug never appears. Get rid of vhost_kernel_reset_device() for now. If someone needs it in the future they'll need to implement it correctly. Signed-off-by: Stefan Hajnoczi Message-Id: <20231004014532.1228637-3-stefanha@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Raphael Norwitz Reviewed-by: Hanna Czenczek --- hw/virtio/vhost-backend.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/hw/virtio/vhost-backend.c b/hw/virtio/vhost-backend.c index 8e581575c9..17f3fc6a08 100644 --- a/hw/virtio/vhost-backend.c +++ b/hw/virtio/vhost-backend.c @@ -197,11 +197,6 @@ static int vhost_kernel_set_owner(struct vhost_dev *de= v) return vhost_kernel_call(dev, VHOST_SET_OWNER, NULL); } =20 -static int vhost_kernel_reset_device(struct vhost_dev *dev) -{ - return vhost_kernel_call(dev, VHOST_RESET_OWNER, NULL); -} - static int vhost_kernel_get_vq_index(struct vhost_dev *dev, int idx) { assert(idx >=3D dev->vq_index && idx < dev->vq_index + dev->nvqs); @@ -322,7 +317,6 @@ const VhostOps kernel_ops =3D { .vhost_get_features =3D vhost_kernel_get_features, .vhost_set_backend_cap =3D vhost_kernel_set_backend_cap, .vhost_set_owner =3D vhost_kernel_set_owner, - .vhost_reset_device =3D vhost_kernel_reset_device, .vhost_get_vq_index =3D vhost_kernel_get_vq_index, .vhost_vsock_set_guest_cid =3D vhost_kernel_vsock_set_guest_cid, .vhost_vsock_set_running =3D vhost_kernel_vsock_set_running, --=20 MST